mirror of
https://github.com/gravitational/teleport.git
synced 2026-09-24 16:17:11 +08:00
Fixed findings:
```
lib/sshutils/server_test.go:163:2: SA4006: this value of `clt` is never used (staticcheck)
clt, err := ssh.Dial("tcp", srv.Addr(), &cc)
^
lib/sshutils/server_test.go:91:3: SA5001: should check returned error before deferring ch.Close() (staticcheck)
defer ch.Close()
^
lib/shell/shell_test.go:33:2: SA4006: this value of `shell` is never used (staticcheck)
shell, err = GetLoginShell("non-existent-user")
^
lib/cgroup/cgroup_test.go:111:2: SA9003: empty branch (staticcheck)
if err != nil {
^
lib/cgroup/cgroup_test.go:119:2: SA5001: should check returned error before deferring service.Close() (staticcheck)
defer service.Close()
^
lib/client/keystore_test.go:138:2: SA4006: this value of `keyCopy` is never used (staticcheck)
keyCopy, err = s.store.GetKey("host.a", "bob")
^
lib/client/api.go:1604:3: SA4004: the surrounding loop is unconditionally terminated (staticcheck)
return makeProxyClient(sshClient, m), nil
^
lib/backend/test/suite.go:156:2: SA4006: this value of `err` is never used (staticcheck)
result, err = s.B.GetRange(ctx, prefix("/prefix/c/c1"), backend.RangeEnd(prefix("/prefix/c/cz")), backend.NoLimit)
^
lib/utils/timeout_test.go:84:2: SA1019: t.Dial is deprecated: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority. (staticcheck)
t.Dial = func(network string, addr string) (net.Conn, error) {
^
lib/utils/websocketwriter.go:83:3: SA4006: this value of `err` is never used (staticcheck)
utf8, err = w.encoder.String(string(data))
^
lib/utils/loadbalancer_test.go:134:2: SA4006: this value of `out` is never used (staticcheck)
out, err = Roundtrip(frontend.String())
^
lib/utils/loadbalancer_test.go:209:2: SA4006: this value of `out` is never used (staticcheck)
out, err = RoundtripWithConn(conn)
^
lib/srv/forward/sshserver.go:582:3: SA4004: the surrounding loop is unconditionally terminated (staticcheck)
return
^
lib/service/service.go:347:4: SA4006: this value of `err` is never used (staticcheck)
i, err = auth.GenerateIdentity(process.localAuth, id, principals, dnsNames)
^
lib/service/signals.go:60:3: SA1016: syscall.SIGKILL cannot be trapped (did you mean syscall.SIGTERM?) (staticcheck)
syscall.SIGKILL, // fast shutdown
^
lib/config/configuration_test.go:184:2: SA4006: this value of `conf` is never used (staticcheck)
conf, err = ReadFromFile(s.configFileBadContent)
^
lib/config/configuration.go:129:2: SA5001: should check returned error before deferring reader.Close() (staticcheck)
defer reader.Close()
^
lib/kube/kubeconfig/kubeconfig_test.go:227:2: SA4006: this value of `err` is never used (staticcheck)
tlsCert, err := ca.GenerateCertificate(tlsca.CertificateRequest{
^
lib/srv/sess.go:720:3: SA4006: this value of `err` is never used (staticcheck)
result, err := s.term.Wait()
^
lib/multiplexer/multiplexer_test.go:169:11: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
_, err = fmt.Fprintf(conn, proxyLine.String())
^
lib/multiplexer/multiplexer_test.go:221:11: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
_, err = fmt.Fprintf(conn, proxyLine.String())
^
```
104 lines
2.7 KiB
Go
104 lines
2.7 KiB
Go
/*
|
|
Copyright 2015 Gravitational, Inc.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
package utils
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"time"
|
|
|
|
"gopkg.in/check.v1"
|
|
)
|
|
|
|
// TimeoutSuite helps us to test ObeyTimeout mechanism. We use HTTP server/client
|
|
// machinery to test timeouts
|
|
type TimeoutSuite struct {
|
|
server *httptest.Server
|
|
}
|
|
|
|
var _ = check.Suite(&TimeoutSuite{})
|
|
|
|
func (s *TimeoutSuite) SetUpSuite(c *check.C) {
|
|
//
|
|
// set up an HTTP server which listens and responds to queries
|
|
s.server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
switch r.URL.Path {
|
|
// GET /slow?delay=10ms sleeps for a given delay, then returns word "slow"
|
|
case "/slow":
|
|
delay, err := time.ParseDuration(r.URL.Query().Get("delay"))
|
|
c.Assert(err, check.IsNil)
|
|
time.Sleep(delay)
|
|
fmt.Fprintf(w, "slow")
|
|
|
|
// GET /ping returns "pong"
|
|
case "/ping":
|
|
fmt.Fprintf(w, "pong")
|
|
}
|
|
}))
|
|
}
|
|
|
|
func (s *TimeoutSuite) TearDownSuite(c *check.C) {
|
|
s.server.Close()
|
|
}
|
|
|
|
func (s *TimeoutSuite) TestSlowOperation(c *check.C) {
|
|
client := newClient(time.Millisecond * 5)
|
|
resp, err := client.Get(s.server.URL + "/slow?delay=20ms")
|
|
if err == nil {
|
|
resp.Body.Close()
|
|
}
|
|
// must fail with I/O timeout
|
|
c.Assert(err, check.NotNil)
|
|
c.Assert(err.Error(), check.Matches, "^.*i/o timeout$")
|
|
}
|
|
|
|
func (s *TimeoutSuite) TestNormalOperation(c *check.C) {
|
|
client := newClient(time.Millisecond * 100)
|
|
resp, err := client.Get(s.server.URL + "/ping")
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(bodyText(resp), check.Equals, "pong")
|
|
}
|
|
|
|
// newClient helper returns HTTP client configured to use a connection
|
|
// which drops itself after N idle time
|
|
func newClient(timeout time.Duration) *http.Client {
|
|
var t http.Transport
|
|
t.DialContext = func(ctx context.Context, network string, addr string) (net.Conn, error) {
|
|
var d net.Dialer
|
|
conn, err := d.DialContext(ctx, network, addr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return ObeyIdleTimeout(conn, timeout, "test"), nil
|
|
}
|
|
return &http.Client{Transport: &t}
|
|
}
|
|
|
|
// bodyText helper returns a body string from an http response
|
|
func bodyText(resp *http.Response) string {
|
|
bytes, err := ioutil.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return ""
|
|
}
|
|
return string(bytes)
|
|
}
|