This is a pass on replacing modulestest.SetTestModules with supplying modules
where already possible. Some additional uses of modules.GetModules were also
replaced with localized modules injection to permit the removal of
modulestest.SetTestModules in tests. Most of the changes here are mechanical,
the one notable change is in TestSSHCommands. The test was not passing locally
because the shell (fish) builtin echo behaves differently. The easiest way
to produce expected output was to change the command invocation to use
/bin/echo to bypass any shell builtins for consistent behavior.
Inject modules into tool tests
Inject modules into integration tests
Inject modules into join server
Remove superflous enterprise modules in TestAuthenticationConfig_Parse_deviceTrustPB
Inject modules into signature algorithm config tests
Inject modules into TestGithubConnectorCRUDEventsEmitted
Inject modules into TestGetHierarchyForUser
Inject modules into kube proxy tests
Inject modules into controller tests
make fix-imports
add integration/app/fixture as test package
* Port `github` join method to new join service
This ports the `github` join method to the new join service, used to
join from GHA workflows.
* Add github to joinclient whitelist
* Test new joinclient
* Fix failing tests
- Resolves some TODOs
- Replaces `require.ErrorIs()` with `require.ErrorContains()` for
compatibility with networked error responses which don't preserve
the exact error chain.
- Adds missing bail on error for joinclient cases
* Fix lints and run checkAndSetDefaults()
* Fix batch of code review suggestions
* Fix additional review comments
rosstimothy