The Dependency Review action only supports the `pull_request` operation
currently. Running it on `push` operations throws an error, so remove for
now until the action supports that operation.
* RFD 0029 : Move GitHub review bot to shared-workflows repository
Apart from relocating the code to a different location and renaming the package, this
is a no-op change
Depends-on: gravitational/shared-workflows#12
* remove mentions of the GitHub review bot from Makefile targets
We're running CIFuzz and CodeQL in many cases where it doesn't make sense. We get
charged for GitHub Actions minutes used, so let's make sure to only run them when
absolutely necessary.
For CIFuzz, only run if a *.go file has been modified.
For CodeQL, only run if a path outside of docs/* and rfd/* has been modified.
Ref https://github.com/github/codeql/issues/9888
CodeQL was failing intermittently due to exceeding limits when
going through the Go extraction phase. Reduce the concurrent
extractions by half (32 --> 16) in an attempt to fix this.
This fixes a corner case where a docs review who submits a PR that
touches code or examples is treated as an external author instead
of an internal employee.
The backport workflow runs when any PR is merged to any banch.
Prior to this change, the workflow was a no-op if the target branch
was a release branch.
Update the workflow so that when it runs on merged backports
it deletes the auto-generated backport branch.
Also fixes#12412
This prevents an old approval from counting if the reviewer changes
their review state, and also ensures that multiple approvals from
the same author don't count as more than one approval.
Re-run the assign workflow whenever a review is submitted.
If the PR meets the required approvals and there are additional
reviewers still assigned, dismiss them.
This makes it easier on reviewers to filter PRs on
"awaiting review from me" as the list will not include PRs that
already have the required reviews.
Fixes#11855
Removed automatic creation of backport Pull Requests due to limitations
within GitHub Actions on recursive creation of workflows not allowing
the "Check" workflow to run upon automation creation of the Pull
Request.
As a temporary workaround, prepare the backport branch and provide a
link the user can click on to create the backport Pull Request.
* Add more lint coverage
golanglint-ci doesn't pick up subdirectories with their own go.mod
which left certain directories unlinted. To get around this we can
run golanglint-ci directly against those submodules.
The bot runs code from the `master` branch even for the stable branches
that still use vendored dependencies, so we should keep ignoring the
`vendor/` directory in the bot, or we might miscategorize PRs.
In a3d85ab removed reviewers from jobs that don't require it and did not
update parsing logic. Instead pass reviewers to all jobs as it is not a
secret and will be inlined into actions/bot soon.
Code reviewers are split into code owners and code reviewers. Each PR is
now randomly assigned a reviewers from the code owner and reviewer set.
Review checking makes sure that a reviewer from each set has approved
the PR.
This new feature in Go 1.17 automatically restores the environment
variable to its previous value when a test ends, making it simpler
to set up the environment for tests and less likely that we accidentally
leave behind global state.
Also convert some of the remaining uses of check to standard Go tests.
Reed Loden