From c53b95101616bbecbd1bbd75e9cdb74860576228 Mon Sep 17 00:00:00 2001 From: Zac Bergquist Date: Tue, 15 Aug 2023 15:22:30 -0600 Subject: [PATCH] pam: free conversation buffer on error (#30466) As per pam_conv(3): > On failure, the conversation function should release any resources > it has allocated, and return one of the predefined PAM error codes. Fixes gravitational/teleport-private#661 --- lib/pam/pam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/pam/pam.c b/lib/pam/pam.c index 4b8567c504f..84cf13ee7bc 100644 --- a/lib/pam/pam.c +++ b/lib/pam/pam.c @@ -111,6 +111,7 @@ int converse(int n, const struct pam_message **msg, struct pam_response **resp, } } memset(aresp, 0, n * sizeof *aresp); + free(aresp); *resp = NULL; return PAM_CONV_ERR; }