From b565095500eb7c8da7b64b54656f9e6a13526705 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Cie=C5=9Blak?= Date: Fri, 4 Apr 2025 17:36:12 +0200 Subject: [PATCH] Remove unnecessary node_gyp config option from .npmrc It's enough to have a specific version of node-gyp in package.json and that will cause node-pty to use that over the version shipped with pnpm. --- .npmrc | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.npmrc b/.npmrc index 98799a6a4c5..70ef8264dad 100644 --- a/.npmrc +++ b/.npmrc @@ -3,13 +3,3 @@ update-notifier=false # ESLint editor integrations expect ESLint's binary to be in the root node_modules. public-hoist-pattern[]=eslint -# pnpm v10.3.0+ ships with node-gyp@11.1.0. That version of node-gyp has a bug which prevents -# node-pty, one of Connect deps, from being built on Windows (https://github.com/nodejs/node-gyp/issues/3126). -# -# To work around this, we install node-gyp@11.0.0 as a dev dep and then tell node-pty through the below -# config option to use node-gyp from our node_modules rather than the one bundled with pnpm. -# -# During pnpm install, the script is executed from a directory such as -# /node_modules/.pnpm/node-pty@1.1.0-beta14/node_modules/node-pty -# so we escape five directories and then give a path to node-gyp.js. -node_gyp=../../../../../node_modules/node-gyp/bin/node-gyp.js