From afe814e72482b22808b2b5d4ad0cf06ea02600a4 Mon Sep 17 00:00:00 2001 From: Andrew Lytvynov Date: Wed, 8 Apr 2020 10:31:02 -0700 Subject: [PATCH] Ensure `make test` covers all packages Selectively listing package paths is error-prone. Use `go list` to get the complete list instead. Filter out integration tests since they are slower. Also, enable the race detector by default. Local `make test` runs should not skip it. --- Makefile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index ed0499d704a..f924836c5a4 100644 --- a/Makefile +++ b/Makefile @@ -193,12 +193,10 @@ run-docs: # tests everything: called by Jenkins # .PHONY: test -test: FLAGS ?= +test: FLAGS ?= '-race' +test: PACKAGES := $(shell go list ./... | grep -v integration) test: $(VERSRC) - go test -tags "$(PAM_TAG) $(FIPS_TAG) $(BPF_TAG)" ./tool/tsh/... \ - ./lib/... \ - ./tool/teleport... $(FLAGS) $(ADDFLAGS) - go vet ./tool/... ./lib/... + go test -tags "$(PAM_TAG) $(FIPS_TAG) $(BPF_TAG)" $(PACKAGES) $(FLAGS) $(ADDFLAGS) # # integration tests. need a TTY to work and not compatible with a race detector