mirror of
https://github.com/Wei-Shaw/sub2api.git
synced 2026-10-28 02:41:37 +08:00
visa2andClaude Opus 4.8
362f9e77bf
Three periodic background jobs ran on every instance with no cross-instance coordination, multiplying their cost (and side effects) by the replica count: - DashboardAggregationService.runScheduledAggregation: N× heavy GROUP BY aggregation queries every minute plus watermark write races. - PaymentOrderExpiryService.runOnce: N× upstream payment-provider reconcile/ expiry API calls per pending order. - SubscriptionExpiryService.sendExpiryReminders: N× full active-subscription scans every minute and potential duplicate reminder emails. Add a LeaderLockCache abstraction so only one instance runs each job per cycle: - The interface lives in the service layer; the Redis-backed implementation (SetNX + compare-and-delete release) lives in the repository layer, so the service package keeps its depguard "must not import redis" boundary intact. - tryAcquireSingletonLeaderLock prefers the cache and falls back to a Postgres advisory lock when Redis errors, mirroring the Ops background services. When neither backend is configured the job runs ungated, preserving single-instance and test behavior (no self-lockout: the lock is released every cycle). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
120 lines
3.2 KiB
Go
120 lines
3.2 KiB
Go
package service
|
||
|
||
import (
|
||
"context"
|
||
"database/sql"
|
||
"log/slog"
|
||
"sync"
|
||
"time"
|
||
|
||
"github.com/google/uuid"
|
||
)
|
||
|
||
const expiryCheckTimeout = 30 * time.Second
|
||
|
||
const (
|
||
// paymentOrderExpiryLeaderLockKey gates the periodic reconcile + expiry sweep so
|
||
// that only one instance issues the upstream payment-provider calls per cycle.
|
||
paymentOrderExpiryLeaderLockKey = "payment:order:expiry:leader"
|
||
// paymentOrderExpiryLeaderLockTTL must exceed the combined reconcile + expiry
|
||
// timeouts (2 * expiryCheckTimeout) so the lock never expires mid-run.
|
||
paymentOrderExpiryLeaderLockTTL = 3 * time.Minute
|
||
)
|
||
|
||
// PaymentOrderExpiryService periodically expires timed-out payment orders.
|
||
type PaymentOrderExpiryService struct {
|
||
paymentSvc *PaymentService
|
||
interval time.Duration
|
||
stopCh chan struct{}
|
||
stopOnce sync.Once
|
||
wg sync.WaitGroup
|
||
|
||
lockCache LeaderLockCache
|
||
db *sql.DB
|
||
instanceID string
|
||
}
|
||
|
||
func NewPaymentOrderExpiryService(paymentSvc *PaymentService, interval time.Duration) *PaymentOrderExpiryService {
|
||
return &PaymentOrderExpiryService{
|
||
paymentSvc: paymentSvc,
|
||
interval: interval,
|
||
stopCh: make(chan struct{}),
|
||
instanceID: uuid.NewString(),
|
||
}
|
||
}
|
||
|
||
// SetLeaderLock injects the leader-lock cache and DB used to elect a single
|
||
// instance for the periodic reconcile/expiry sweep. When both are nil the job
|
||
// runs ungated (single-instance / test behavior).
|
||
func (s *PaymentOrderExpiryService) SetLeaderLock(lockCache LeaderLockCache, db *sql.DB) {
|
||
if s == nil {
|
||
return
|
||
}
|
||
s.lockCache = lockCache
|
||
s.db = db
|
||
}
|
||
|
||
func (s *PaymentOrderExpiryService) Start() {
|
||
if s == nil || s.paymentSvc == nil || s.interval <= 0 {
|
||
return
|
||
}
|
||
s.wg.Add(1)
|
||
go func() {
|
||
defer s.wg.Done()
|
||
ticker := time.NewTicker(s.interval)
|
||
defer ticker.Stop()
|
||
|
||
s.runOnce()
|
||
for {
|
||
select {
|
||
case <-ticker.C:
|
||
s.runOnce()
|
||
case <-s.stopCh:
|
||
return
|
||
}
|
||
}
|
||
}()
|
||
}
|
||
|
||
func (s *PaymentOrderExpiryService) Stop() {
|
||
if s == nil {
|
||
return
|
||
}
|
||
s.stopOnce.Do(func() {
|
||
close(s.stopCh)
|
||
})
|
||
s.wg.Wait()
|
||
}
|
||
|
||
func (s *PaymentOrderExpiryService) runOnce() {
|
||
// Multi-instance guard: only the leader reconciles/expires orders per cycle,
|
||
// avoiding N× upstream payment-provider API calls and update races.
|
||
lockCtx, lockCancel := context.WithTimeout(context.Background(), 2*time.Second)
|
||
release, ok := tryAcquireSingletonLeaderLock(lockCtx, s.lockCache, s.db, paymentOrderExpiryLeaderLockKey, s.instanceID, paymentOrderExpiryLeaderLockTTL)
|
||
lockCancel()
|
||
if !ok {
|
||
return
|
||
}
|
||
defer release()
|
||
|
||
reconcileCtx, cancel := context.WithTimeout(context.Background(), expiryCheckTimeout)
|
||
recovered, err := s.paymentSvc.ReconcilePendingWxpayOrders(reconcileCtx)
|
||
cancel()
|
||
if err != nil {
|
||
slog.Warn("[PaymentOrderExpiry] failed to reconcile pending wxpay orders", "error", err)
|
||
} else if recovered > 0 {
|
||
slog.Info("[PaymentOrderExpiry] reconciled paid wxpay orders", "count", recovered)
|
||
}
|
||
|
||
expireCtx, cancel := context.WithTimeout(context.Background(), expiryCheckTimeout)
|
||
defer cancel()
|
||
expired, err := s.paymentSvc.ExpireTimedOutOrders(expireCtx)
|
||
if err != nil {
|
||
slog.Error("[PaymentOrderExpiry] failed to expire orders", "error", err)
|
||
return
|
||
}
|
||
if expired > 0 {
|
||
slog.Info("[PaymentOrderExpiry] expired timed-out orders", "count", expired)
|
||
}
|
||
}
|