mirror of
https://github.com/simstudioai/sim.git
synced 2026-09-24 15:45:35 +08:00
* fix(v2-api): stop leaking resolved secrets in logs and serving doc source Two regressions shipped with the v2 API (#5273) where v2 diverged from the v1 path it replaced, plus the hardening that fell out of auditing them. **v2 logs bypassed secret redaction.** `getPublicLog` and `listPublicLogs` called raw `materializeExecutionData`, while every other reader — v1 list and detail, CSV export, `fetch-log-detail`, both data-drain sources — calls `materializeExecutionDataForDisplay`, which applies the resolved-secret provenance projection. Both v2 routes then serialize `traceSpans` and `finalOutput` straight onto the wire, so unredacted secrets could reach the public API. Swapped to the display projection and threaded the principal's subject user into the read context. **v2 file download served generation source.** `GET /api/v2/files/{fileId}` streamed `file.key` raw. AI-generated docs store their generation source as the primary file, so a raw download yields source text under a `.pdf` name — a file the recipient cannot open. Generated docs now resolve to their compiled artifact; ordinary uploads still stream and are never materialized, gated on the recorded generation-source type rather than the extension. The resolve is capped at MAX_RENDERED_DOCUMENT_BYTES, and a still-compiling artifact returns a retryable 409 rather than a 500. Also in this change: - Reconcile the two v2 verbs that used PUT for PATCH semantics: `PUT /v2/knowledge/{id}` and `PUT /v2/tables/{tableId}/rows` are both all-optional partial updates. Breaking for API-key clients, but the surface is dark-launched behind the `v2-api` gate and no in-repo caller issues PUT. - Close the OpenAPI coverage blind spot that hid two routes: contract discovery was a non-recursive read of the flat `contracts/v2/` directory, so a contract in a subdirectory — or beside its non-v2 siblings, which is where the uploads contracts live — escaped the gate. The sweep is now recursive over the whole contracts tree, and the two upload data-plane routes are named in an explicit allowlist with reasons and staleness guards. - Extract `needsRenderedArtifact` so the "recorded type is authoritative, extension is fallback" rule has one home instead of being duplicated. - Extract `DocCompileUserError` into a leaf module so recognizing it no longer drags `app/api/**` and `next/server` into application modules. - Correct the stale pagination docstring in `contracts/v2/shared.ts` and pin the paged/full-set split in a test so it cannot drift again. * fix(v2-api): absolute imports for the extracted doc-compile error Review follow-up. - Use the `@/lib/...` alias for `doc-compile-error` in the three modules that imported it relatively. The repo requires absolute imports, and having all four consumers share one specifier also removes any chance of two module instances resolving apart and breaking `instanceof`. - Memoize the v2 list-pagination sweep. It re-imported the whole contracts tree once per test and timed out against the default 10s limit under load; it now sweeps once and declares an explicit timeout. Its failure message also still pointed at an enumeration in `v2/shared.ts` that this branch replaced with a pointer to the test itself. * fix(v2-api): correct three inaccurate claims found in verification None of these change behavior; each is a comment or test-config assertion that was not true as written. - The artifact resolver's TSDoc implied the byte cap prevents an oversized artifact being materialized. It does not: the artifact-store fetch is not streaming-bounded, so the bytes are resident before the ceiling rejects them. Say what it actually guarantees. - `v2/shared.ts` pointed at per-contract documentation for the two lists that still filter in memory. Neither contract documents it, so name the two lists and what they do inline instead of pointing at a page that does not exist. - The knowledge update contract said "every field of the body is optional"; `workspaceId` is required. Narrow the claim to mutable fields. - Scope the pagination sweep's extended timeout to the one test that pays for it, so a genuine hang in the other two surfaces in 10s rather than 60s.
790 lines
29 KiB
TypeScript
790 lines
29 KiB
TypeScript
#!/usr/bin/env bun
|
|
/**
|
|
* Validates the OpenAPI specs in `apps/docs/` against each other and against
|
|
* the runtime Zod contracts in `apps/sim/lib/api/contracts/`.
|
|
*
|
|
* Every document is code-first, carries `x-generated-by`, and is checked for
|
|
* staleness by `generate-openapi.ts --check` before this script runs.
|
|
*
|
|
* 1. Spec integrity (every file): all `$ref`s resolve, operationIds are
|
|
* present and unique, every operation documents a success response, no
|
|
* orphaned component schemas.
|
|
* 2. v2 conventions: every published operation is under `/api/v2/`, documents
|
|
* 401, 429, and 503, and resolves every documented 4xx/5xx response to the
|
|
* canonical error envelope `{ error: { code, message } }`.
|
|
* 3. Contract cross-check: every route contract anywhere under
|
|
* `lib/api/contracts/**` whose path is under `/api/v2/` must be documented
|
|
* (or listed in `UNDOCUMENTED_V2_ROUTES` with a reason), every documented
|
|
* `/api/v2/` operation must have a contract, and for each pair the query
|
|
* params, body fields, and response fields are diffed via
|
|
* `z.toJSONSchema`. The sweep is recursive and rooted at the whole
|
|
* contracts tree, not the flat `v2/` directory — a contract in a
|
|
* subdirectory, or one that lives beside its non-v2 siblings, must never
|
|
* be able to escape coverage by virtue of where its file sits.
|
|
* 4. Examples: documented request/response examples are parsed with the
|
|
* matching contract's actual Zod schemas — a doc example that the runtime
|
|
* would reject fails the build.
|
|
*/
|
|
|
|
import { readdirSync, readFileSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import Ajv2020 from 'ajv/dist/2020'
|
|
import { z } from 'zod'
|
|
import { OPENAPI_SPEC_FILES } from '../apps/docs/lib/openapi-specs'
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..')
|
|
const DOCS_DIR = path.join(ROOT, 'apps/docs')
|
|
const CONTRACTS_DIR = path.join(ROOT, 'apps/sim/lib/api/contracts')
|
|
|
|
const SPEC_FILES = OPENAPI_SPEC_FILES
|
|
|
|
/**
|
|
* `/api/v2/` routes that are deliberately absent from the public OpenAPI
|
|
* specs, each with the reason it is not public API surface. Anything not
|
|
* listed here fails the build, so an undocumented v2 route is always a
|
|
* conscious, reviewed decision rather than an accident of file layout.
|
|
*
|
|
* A stale entry — one whose contract no longer exists, or which has since
|
|
* been documented — also fails, so the list cannot rot into a blanket
|
|
* exemption.
|
|
*/
|
|
const UNDOCUMENTED_V2_ROUTES: Readonly<Record<string, string>> = {
|
|
'PUT /api/v2/uploads/{uploadId}':
|
|
'Local-storage data plane for a signed whole-object upload. Authenticated by the short-lived upload-token minted by the documented session-create operation, not by an API key; carries no v2 feature gate and returns bare error bodies rather than the canonical v2 envelope. The URL is handed to the client by the session response and is never constructed from docs.',
|
|
'PUT /api/v2/uploads/{uploadId}/parts/{partNumber}':
|
|
'Local-storage data plane for a signed multipart part upload. Authenticated by a per-part signed `token` query param minted by the documented part-URL operation, not by an API key; same non-canonical envelope and self-describing URL as the whole-object PUT above.',
|
|
}
|
|
|
|
/**
|
|
* Every operation removed with the unversioned core specification has a
|
|
* public v2 replacement. Keeping this mapping executable prevents a future
|
|
* docs edit from accidentally dropping a migrated execution, HITL, or usage
|
|
* capability.
|
|
*/
|
|
const LEGACY_CORE_REPLACEMENTS = {
|
|
executeWorkflow: 'POST /api/v2/workflows/{id}/execute',
|
|
getWorkflowExecution: 'GET /api/v2/workflows/{id}/runs/{runId}',
|
|
cancelExecution: 'POST /api/v2/workflows/{id}/runs/{runId}/cancel',
|
|
getJobStatus: 'GET /api/v2/workflows/{id}/runs/{runId}',
|
|
listPausedExecutions: 'GET /api/v2/workflows/{id}/runs',
|
|
getPausedExecution: 'GET /api/v2/workflows/{id}/runs/{runId}',
|
|
getPausedExecutionByResumePath: 'GET /api/v2/workflows/{id}/runs/{runId}',
|
|
getPauseContext: 'GET /api/v2/workflows/{id}/runs/{runId}',
|
|
resumeExecution: 'POST /api/v2/workflows/{id}/runs/{runId}/resume',
|
|
getUsageLimits: 'GET /api/v2/billing/status',
|
|
} as const
|
|
|
|
const API_REFERENCE_LOCALES = ['de', 'en', 'es', 'fr', 'ja', 'zh'] as const
|
|
const REQUIRED_API_REFERENCE_GROUPS = [
|
|
'(generated)/workflows',
|
|
'(generated)/workflow-runs',
|
|
'(generated)/logs',
|
|
'(generated)/audit-logs',
|
|
'(generated)/billing',
|
|
'(generated)/tables',
|
|
'(generated)/files',
|
|
'(generated)/knowledge-bases',
|
|
'(generated)/workspaces',
|
|
'(generated)/mcp-servers',
|
|
'(generated)/skills',
|
|
'(generated)/custom-tools',
|
|
'(generated)/credentials',
|
|
'(generated)/secrets',
|
|
] as const
|
|
const REMOVED_API_REFERENCE_GROUPS = [
|
|
'(generated)/execution',
|
|
'(generated)/human-in-the-loop',
|
|
'(generated)/usage',
|
|
] as const
|
|
|
|
type Json = Record<string, unknown>
|
|
const HTTP_METHODS = new Set(['get', 'post', 'put', 'patch', 'delete'])
|
|
|
|
const errors: string[] = []
|
|
const fail = (spec: string, msg: string) => errors.push(`${spec}: ${msg}`)
|
|
|
|
interface ContractLike {
|
|
method: string
|
|
path: string
|
|
params?: z.ZodType
|
|
query?: z.ZodType
|
|
body?: z.ZodType
|
|
response?: {
|
|
mode: string
|
|
schema?: z.ZodType
|
|
status?: number | readonly number[]
|
|
statusSchemas?: Readonly<Record<number, z.ZodType>>
|
|
}
|
|
}
|
|
|
|
function isContract(value: unknown): value is ContractLike {
|
|
return (
|
|
!!value &&
|
|
typeof value === 'object' &&
|
|
typeof (value as ContractLike).method === 'string' &&
|
|
typeof (value as ContractLike).path === 'string' &&
|
|
typeof (value as ContractLike).response === 'object'
|
|
)
|
|
}
|
|
|
|
/** `[tableId]` (contract) → `{tableId}` (OpenAPI). */
|
|
const contractKey = (c: ContractLike) =>
|
|
`${c.method.toUpperCase()} ${c.path.replace(/\[([^\]]+)\]/g, '{$1}')}`
|
|
|
|
/** Every non-test `.ts` file under `dir`, recursively, in stable order. */
|
|
function listContractFiles(dir: string): string[] {
|
|
const files: string[] = []
|
|
for (const entry of readdirSync(dir, { withFileTypes: true }).sort((a, b) =>
|
|
a.name.localeCompare(b.name)
|
|
)) {
|
|
const full = path.join(dir, entry.name)
|
|
if (entry.isDirectory()) {
|
|
if (entry.name === '__tests__') continue
|
|
files.push(...listContractFiles(full))
|
|
} else if (entry.name.endsWith('.ts') && !entry.name.endsWith('.test.ts')) {
|
|
files.push(full)
|
|
}
|
|
}
|
|
return files
|
|
}
|
|
|
|
/** Every `/api/v2/` route contract exported anywhere in the contracts tree. */
|
|
async function loadContracts(): Promise<Map<string, { name: string; contract: ContractLike }>> {
|
|
const registry = new Map<string, { name: string; contract: ContractLike }>()
|
|
for (const file of listContractFiles(CONTRACTS_DIR)) {
|
|
const mod = (await import(file)) as Record<string, unknown>
|
|
for (const [name, value] of Object.entries(mod)) {
|
|
if (!isContract(value)) continue
|
|
if (!value.path.startsWith('/api/v2/')) continue
|
|
const key = contractKey(value)
|
|
const existing = registry.get(key)
|
|
if (existing) {
|
|
// A route may expose narrowing variants of one operation (e.g. the
|
|
// batch-create alias) — keep the first, they share the wire.
|
|
continue
|
|
}
|
|
registry.set(key, { name, contract: value })
|
|
}
|
|
}
|
|
return registry
|
|
}
|
|
|
|
function resolveRef(ref: string, spec: Json): unknown {
|
|
let current: unknown = spec
|
|
for (const part of ref.replace('#/', '').split('/')) {
|
|
if (!current || typeof current !== 'object') return undefined
|
|
current = (current as Json)[part]
|
|
}
|
|
return current
|
|
}
|
|
|
|
/** Follow at most one level of `$ref` chains until a concrete node. */
|
|
function deref(node: unknown, spec: Json): unknown {
|
|
let current = node
|
|
for (let i = 0; i < 8; i++) {
|
|
if (current && typeof current === 'object' && typeof (current as Json).$ref === 'string') {
|
|
current = resolveRef((current as Json).$ref as string, spec)
|
|
} else {
|
|
return current
|
|
}
|
|
}
|
|
return current
|
|
}
|
|
|
|
function walkRefs(node: unknown, visit: (ref: string) => void): void {
|
|
if (Array.isArray(node)) {
|
|
for (const item of node) walkRefs(item, visit)
|
|
} else if (node && typeof node === 'object') {
|
|
for (const [key, value] of Object.entries(node)) {
|
|
if (key === '$ref' && typeof value === 'string') visit(value)
|
|
else walkRefs(value, visit)
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Top-level property names of a documented JSON schema, unioning `oneOf` /
|
|
* `anyOf` / `allOf` variants. Returns `null` when the schema is opaque
|
|
* (no `properties` anywhere), in which case comparison is skipped.
|
|
*/
|
|
function docPropertyNames(schema: unknown, spec: Json): Set<string> | null {
|
|
const node = deref(schema, spec)
|
|
if (!node || typeof node !== 'object') return null
|
|
const record = node as Json
|
|
const variants = (record.oneOf ?? record.anyOf ?? record.allOf) as unknown[] | undefined
|
|
if (variants) {
|
|
const names = new Set<string>()
|
|
let sawAny = false
|
|
for (const variant of variants) {
|
|
const sub = docPropertyNames(variant, spec)
|
|
if (sub) {
|
|
sawAny = true
|
|
for (const n of sub) names.add(n)
|
|
}
|
|
}
|
|
return sawAny ? names : null
|
|
}
|
|
if (record.properties && typeof record.properties === 'object') {
|
|
return new Set(Object.keys(record.properties as Json))
|
|
}
|
|
return null
|
|
}
|
|
|
|
function toJsonSchema(schema: z.ZodType, io: 'input' | 'output'): Json {
|
|
return z.toJSONSchema(schema, {
|
|
io,
|
|
target: 'draft-2020-12',
|
|
unrepresentable: 'any',
|
|
cycles: 'ref',
|
|
}) as Json
|
|
}
|
|
|
|
const outputExampleValidator = new Ajv2020({
|
|
strict: false,
|
|
allErrors: true,
|
|
validateFormats: false,
|
|
})
|
|
|
|
function stripLegacySchemaIds(value: unknown): unknown {
|
|
if (Array.isArray(value)) return value.map(stripLegacySchemaIds)
|
|
if (!value || typeof value !== 'object') return value
|
|
return Object.fromEntries(
|
|
Object.entries(value)
|
|
.filter(([key, entry]) => key !== 'id' || typeof entry !== 'string')
|
|
.map(([key, entry]) => [key, stripLegacySchemaIds(entry)])
|
|
)
|
|
}
|
|
|
|
function outputExampleError(schema: z.ZodType, value: unknown): string | null {
|
|
const validate = outputExampleValidator.compile(
|
|
stripLegacySchemaIds(toJsonSchema(schema, 'output'))
|
|
)
|
|
if (validate(value)) return null
|
|
return outputExampleValidator.errorsText(validate.errors)
|
|
}
|
|
|
|
interface Operation {
|
|
specFile: string
|
|
path: string
|
|
method: string
|
|
op: Json
|
|
spec: Json
|
|
}
|
|
|
|
function collectOperations(specFile: string, spec: Json): Operation[] {
|
|
const ops: Operation[] = []
|
|
for (const [p, methods] of Object.entries((spec.paths as Json) ?? {})) {
|
|
if (!methods || typeof methods !== 'object') continue
|
|
for (const [method, op] of Object.entries(methods as Json)) {
|
|
if (!HTTP_METHODS.has(method)) continue
|
|
ops.push({ specFile, path: p, method, op: op as Json, spec })
|
|
}
|
|
}
|
|
return ops
|
|
}
|
|
|
|
function isSuccessStatus(code: string): boolean {
|
|
const status = Number(code)
|
|
return Number.isInteger(status) && status >= 200 && status < 400
|
|
}
|
|
|
|
function checkIntegrity(specFile: string, spec: Json, ops: Operation[]): void {
|
|
walkRefs(spec, (ref) => {
|
|
if (resolveRef(ref, spec) === undefined) fail(specFile, `unresolved $ref ${ref}`)
|
|
})
|
|
|
|
const seenIds = new Set<string>()
|
|
for (const { path: p, method, op } of ops) {
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
const id = op.operationId
|
|
if (typeof id !== 'string' || !id) {
|
|
fail(specFile, `${label}: missing operationId`)
|
|
} else if (seenIds.has(id)) {
|
|
fail(specFile, `${label}: duplicate operationId "${id}"`)
|
|
} else {
|
|
seenIds.add(id)
|
|
}
|
|
const responses = (op.responses as Json) ?? {}
|
|
if (!Object.keys(responses).some(isSuccessStatus)) {
|
|
fail(specFile, `${label}: no documented success response`)
|
|
}
|
|
|
|
const requestBody = deref(op.requestBody, spec) as Json | undefined
|
|
if (requestBody) {
|
|
const content = requestBody.content as Json | undefined
|
|
if (!content || Object.keys(content).length === 0) {
|
|
fail(specFile, `${label}: request body has no content types`)
|
|
} else {
|
|
for (const [contentType, media] of Object.entries(content)) {
|
|
if (!(media as Json)?.schema) {
|
|
fail(specFile, `${label}: ${contentType} request body has no schema`)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
for (const [status, response] of Object.entries(responses)) {
|
|
if (!isSuccessStatus(status)) continue
|
|
const resolved = deref(response, spec) as Json | undefined
|
|
const content = resolved?.content as Json | undefined
|
|
if (!content) continue
|
|
if (Object.keys(content).length === 0) {
|
|
fail(specFile, `${label}: ${status} response has an empty content map`)
|
|
continue
|
|
}
|
|
for (const [contentType, media] of Object.entries(content)) {
|
|
if (!(media as Json)?.schema) {
|
|
fail(specFile, `${label}: ${status} ${contentType} response has no schema`)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
const schemas = ((spec.components as Json)?.schemas as Json) ?? {}
|
|
const blobWithout = (name: string) =>
|
|
JSON.stringify({
|
|
...spec,
|
|
components: { ...(spec.components as Json), schemas: { ...schemas, [name]: null } },
|
|
})
|
|
for (const name of Object.keys(schemas)) {
|
|
if (!blobWithout(name).includes(`"#/components/schemas/${name}"`)) {
|
|
fail(specFile, `orphaned component schema "${name}" (unreferenced)`)
|
|
}
|
|
}
|
|
}
|
|
|
|
function checkV2Conventions(operation: Operation): void {
|
|
const { specFile, path: p, method, op, spec } = operation
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
const responses = (op.responses as Json) ?? {}
|
|
|
|
for (const code of ['401', '429', '503']) {
|
|
if (!(code in responses)) fail(specFile, `${label}: v2 operation missing ${code} response`)
|
|
}
|
|
|
|
for (const [code, response] of Object.entries(responses)) {
|
|
if (!/^[45]/.test(code)) continue
|
|
const resolved = deref(response, spec) as Json | undefined
|
|
const schema = deref(
|
|
((resolved?.content as Json)?.['application/json'] as Json)?.schema,
|
|
spec
|
|
) as Json | undefined
|
|
// A bodyless error (e.g. a bare 413) documents intent without a schema.
|
|
if (!schema) continue
|
|
const errorProp = deref((schema.properties as Json)?.error, spec) as Json | undefined
|
|
const inner = errorProp?.properties as Json | undefined
|
|
if (!inner || !('code' in inner) || !('message' in inner)) {
|
|
fail(
|
|
specFile,
|
|
`${label}: ${code} response is not the canonical v2 error envelope { error: { code, message } }`
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
function checkQueryParams(operation: Operation, contract: ContractLike, name: string): void {
|
|
const { specFile, path: p, method, op, spec } = operation
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
if (!contract.query) return
|
|
const zodSchema = toJsonSchema(contract.query, 'input')
|
|
if (!zodSchema?.properties) return
|
|
|
|
const docParams = new Map<string, Json>()
|
|
for (const raw of (op.parameters as unknown[]) ?? []) {
|
|
const param = deref(raw, spec) as Json | undefined
|
|
if (param?.in === 'query' && typeof param.name === 'string') docParams.set(param.name, param)
|
|
}
|
|
|
|
const zodProps = Object.keys(zodSchema.properties as Json)
|
|
const zodRequired = new Set((zodSchema.required as string[]) ?? [])
|
|
for (const prop of zodProps) {
|
|
const doc = docParams.get(prop)
|
|
if (!doc) {
|
|
fail(specFile, `${label}: query param "${prop}" (${name}) is not documented`)
|
|
} else if (Boolean(doc.required) !== zodRequired.has(prop)) {
|
|
fail(
|
|
specFile,
|
|
`${label}: query param "${prop}" required mismatch (contract ${zodRequired.has(prop) ? 'required' : 'optional'}, docs ${doc.required ? 'required' : 'optional'})`
|
|
)
|
|
}
|
|
}
|
|
for (const docName of docParams.keys()) {
|
|
if (!zodProps.includes(docName)) {
|
|
fail(specFile, `${label}: documented query param "${docName}" does not exist on ${name}`)
|
|
}
|
|
}
|
|
}
|
|
|
|
function checkSuccessStatuses(operation: Operation, contract: ContractLike): void {
|
|
const { specFile, path: p, method, op } = operation
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
const configured = contract.response?.status
|
|
const expected = (
|
|
configured === undefined
|
|
? [200]
|
|
: typeof configured === 'number'
|
|
? [configured]
|
|
: [...configured]
|
|
).sort((a, b) => a - b)
|
|
const documented = Object.keys((op.responses as Json) ?? {})
|
|
.filter(isSuccessStatus)
|
|
.map(Number)
|
|
.sort((a, b) => a - b)
|
|
|
|
if (JSON.stringify(documented) !== JSON.stringify(expected)) {
|
|
fail(
|
|
specFile,
|
|
`${label}: documented success statuses [${documented.join(', ')}] do not match contract statuses [${expected.join(', ')}]`
|
|
)
|
|
}
|
|
}
|
|
|
|
/** Property subschema lookup, searching `oneOf`/`anyOf`/`allOf` variants. */
|
|
function propertyNode(schema: unknown, root: Json, prop: string): unknown {
|
|
const node = deref(schema, root)
|
|
if (!node || typeof node !== 'object') return undefined
|
|
const record = node as Json
|
|
const variants = (record.oneOf ?? record.anyOf ?? record.allOf) as unknown[] | undefined
|
|
if (variants) {
|
|
for (const variant of variants) {
|
|
const found = propertyNode(variant, root, prop)
|
|
if (found !== undefined) return found
|
|
}
|
|
return undefined
|
|
}
|
|
return (record.properties as Json | undefined)?.[prop]
|
|
}
|
|
|
|
/** Deref + step through array wrappers so item objects compare directly. */
|
|
function unwrapArrays(node: unknown, root: Json): unknown {
|
|
let current = deref(node, root)
|
|
for (let i = 0; i < 3; i++) {
|
|
const record = current as Json | null
|
|
if (record && typeof record === 'object' && record.type === 'array' && record.items) {
|
|
current = deref(record.items, root)
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
return current
|
|
}
|
|
|
|
interface DiffContext {
|
|
specFile: string
|
|
label: string
|
|
name: string
|
|
where: 'body' | 'response'
|
|
}
|
|
|
|
/**
|
|
* Recursively diffs property-name sets between the Zod-derived JSON schema and
|
|
* the documented one, descending through matching object properties and array
|
|
* items. Comparison happens only where BOTH sides expose a property set — an
|
|
* opaque side (records, `additionalProperties`, prose-only docs) ends the
|
|
* descent instead of producing false positives. The Zod root doubles as the
|
|
* `$defs` resolution context for recursive schemas.
|
|
*/
|
|
function diffSchemaFields(
|
|
zodNode: unknown,
|
|
zodRoot: Json,
|
|
docNode: unknown,
|
|
docRoot: Json,
|
|
ctx: DiffContext,
|
|
prefix: string,
|
|
depth: number
|
|
): void {
|
|
if (depth > 4) return
|
|
const zodObj = unwrapArrays(zodNode, zodRoot)
|
|
const docObj = unwrapArrays(docNode, docRoot)
|
|
const zodNames = docPropertyNames(zodObj, zodRoot)
|
|
const docNames = docPropertyNames(docObj, docRoot)
|
|
if (!zodNames || !docNames) return
|
|
const fieldPath = (n: string) => (prefix ? `${prefix}.${n}` : n)
|
|
/**
|
|
* A `.passthrough()` contract deliberately under-declares its fields, so the
|
|
* docs are allowed to document more than the Zod side names.
|
|
*/
|
|
const extra = (zodObj as Json).additionalProperties
|
|
const zodIsPassthrough =
|
|
extra === true || (!!extra && typeof extra === 'object' && Object.keys(extra).length === 0)
|
|
for (const n of zodNames) {
|
|
if (!docNames.has(n)) {
|
|
fail(
|
|
ctx.specFile,
|
|
`${ctx.label}: ${ctx.where} field "${fieldPath(n)}" (${ctx.name}) not documented`
|
|
)
|
|
}
|
|
}
|
|
for (const n of docNames) {
|
|
if (!zodNames.has(n) && !zodIsPassthrough) {
|
|
fail(
|
|
ctx.specFile,
|
|
`${ctx.label}: documented ${ctx.where} field "${fieldPath(n)}" does not exist on ${ctx.name}`
|
|
)
|
|
}
|
|
}
|
|
for (const n of zodNames) {
|
|
if (!docNames.has(n)) continue
|
|
diffSchemaFields(
|
|
propertyNode(zodObj, zodRoot, n),
|
|
zodRoot,
|
|
propertyNode(docObj, docRoot, n),
|
|
docRoot,
|
|
ctx,
|
|
fieldPath(n),
|
|
depth + 1
|
|
)
|
|
}
|
|
}
|
|
|
|
function checkBodyAndResponse(operation: Operation, contract: ContractLike, name: string): void {
|
|
const { specFile, path: p, method, op, spec } = operation
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
|
|
const docBodyContent = ((deref(op.requestBody, spec) as Json)?.content as Json) ?? {}
|
|
if (contract.body) {
|
|
const zodRoot = toJsonSchema(contract.body, 'input')
|
|
if (zodRoot) {
|
|
for (const media of Object.values(docBodyContent)) {
|
|
const docSchema = (media as Json)?.schema
|
|
if (!docSchema) continue
|
|
diffSchemaFields(
|
|
zodRoot,
|
|
zodRoot,
|
|
docSchema,
|
|
spec,
|
|
{ specFile, label, name, where: 'body' },
|
|
'',
|
|
0
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
if (contract.response?.mode === 'json' && contract.response.schema) {
|
|
const responses = (op.responses as Json) ?? {}
|
|
for (const [status, response] of Object.entries(responses)) {
|
|
if (!isSuccessStatus(status)) continue
|
|
const docResponse = deref(response, spec) as Json | undefined
|
|
const docSchema = ((docResponse?.content as Json)?.['application/json'] as Json)?.schema
|
|
if (docSchema) {
|
|
const responseSchema =
|
|
contract.response.statusSchemas?.[Number(status)] ?? contract.response.schema
|
|
const zodRoot = toJsonSchema(responseSchema, 'output')
|
|
diffSchemaFields(
|
|
zodRoot,
|
|
zodRoot,
|
|
docSchema,
|
|
spec,
|
|
{ specFile, label, name, where: 'response' },
|
|
'',
|
|
0
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
function documentedExamples(media: Json, spec: Json): Array<[string, unknown]> {
|
|
const candidates: Array<[string, unknown]> = []
|
|
if (media.example !== undefined) candidates.push(['example', media.example])
|
|
for (const [name, rawExample] of Object.entries((media.examples as Json) ?? {})) {
|
|
const example = deref(rawExample, spec) as Json | undefined
|
|
if (example?.value !== undefined) candidates.push([name, example.value])
|
|
}
|
|
|
|
const schema = deref(media.schema, spec) as Json | undefined
|
|
if (schema?.example !== undefined) candidates.push(['schema.example', schema.example])
|
|
if (Array.isArray(schema?.examples)) {
|
|
for (const [index, example] of schema.examples.entries()) {
|
|
candidates.push([`schema.examples[${index}]`, example])
|
|
}
|
|
}
|
|
return candidates
|
|
}
|
|
|
|
function checkExamples(operation: Operation, contract: ContractLike, name: string): void {
|
|
const { specFile, path: p, method, op, spec } = operation
|
|
const label = `${method.toUpperCase()} ${p}`
|
|
|
|
const bodyContent = ((deref(op.requestBody, spec) as Json)?.content as Json) ?? {}
|
|
if (contract.body) {
|
|
for (const [contentType, rawMedia] of Object.entries(bodyContent)) {
|
|
for (const [exampleName, value] of documentedExamples(rawMedia as Json, spec)) {
|
|
const parsed = contract.body.safeParse(value)
|
|
if (!parsed.success) {
|
|
fail(
|
|
specFile,
|
|
`${label}: ${contentType} request example "${exampleName}" rejected by ${name}: ${parsed.error.issues[0]?.message}`
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (contract.response?.mode === 'json' && contract.response.schema) {
|
|
const responses = (op.responses as Json) ?? {}
|
|
for (const [status, rawResponse] of Object.entries(responses)) {
|
|
if (!isSuccessStatus(status)) continue
|
|
const response = deref(rawResponse, spec) as Json | undefined
|
|
const content = (response?.content as Json)?.['application/json'] as Json | undefined
|
|
if (!content) continue
|
|
for (const [exampleName, value] of documentedExamples(content, spec)) {
|
|
const responseSchema =
|
|
contract.response.statusSchemas?.[Number(status)] ?? contract.response.schema
|
|
const validationError = outputExampleError(responseSchema, value)
|
|
if (validationError) {
|
|
fail(
|
|
specFile,
|
|
`${label}: ${status} response example "${exampleName}" rejected by ${name}: ${validationError}`
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
const registry = await loadContracts()
|
|
const documentedKeys = new Set<string>()
|
|
const globalOperationIds = new Map<string, string>()
|
|
const globalOperationTags = new Map<string, readonly string[]>()
|
|
|
|
for (const specFile of SPEC_FILES) {
|
|
const spec = JSON.parse(readFileSync(path.join(DOCS_DIR, specFile), 'utf8')) as Json
|
|
if (spec['x-generated-by'] !== 'scripts/generate-openapi.ts') {
|
|
fail(specFile, 'generated spec is missing its x-generated-by marker')
|
|
}
|
|
const ops = collectOperations(specFile, spec)
|
|
checkIntegrity(specFile, spec, ops)
|
|
|
|
for (const operation of ops) {
|
|
const key = `${operation.method.toUpperCase()} ${operation.path}`
|
|
if (documentedKeys.has(key)) {
|
|
fail(specFile, `${key}: operation is documented by more than one spec`)
|
|
}
|
|
documentedKeys.add(key)
|
|
const operationId = operation.op.operationId
|
|
if (typeof operationId === 'string') {
|
|
const previous = globalOperationIds.get(operationId)
|
|
if (previous)
|
|
fail(specFile, `duplicate global operationId "${operationId}" (also in ${previous})`)
|
|
else {
|
|
globalOperationIds.set(operationId, specFile)
|
|
globalOperationTags.set(
|
|
operationId,
|
|
Array.isArray(operation.op.tags)
|
|
? operation.op.tags.filter((tag): tag is string => typeof tag === 'string')
|
|
: []
|
|
)
|
|
}
|
|
}
|
|
if (!operation.path.startsWith('/api/v2/')) {
|
|
fail(specFile, `${key}: public OpenAPI operations must use the /api/v2/ namespace`)
|
|
continue
|
|
}
|
|
checkV2Conventions(operation)
|
|
|
|
const entry = registry.get(key)
|
|
if (!entry) {
|
|
fail(specFile, `${key}: documented but no contract exports this route`)
|
|
continue
|
|
}
|
|
checkSuccessStatuses(operation, entry.contract)
|
|
checkQueryParams(operation, entry.contract, entry.name)
|
|
checkBodyAndResponse(operation, entry.contract, entry.name)
|
|
checkExamples(operation, entry.contract, entry.name)
|
|
}
|
|
}
|
|
|
|
for (const [key, { name }] of registry) {
|
|
if (documentedKeys.has(key) || key in UNDOCUMENTED_V2_ROUTES) continue
|
|
errors.push(`registry: ${name} (${key}) is not documented in any OpenAPI spec`)
|
|
}
|
|
|
|
for (const [key, reason] of Object.entries(UNDOCUMENTED_V2_ROUTES)) {
|
|
if (!reason.trim()) {
|
|
errors.push(`undocumented v2 allowlist: ${key} needs a reason explaining why it is not public`)
|
|
}
|
|
if (!registry.has(key)) {
|
|
errors.push(`undocumented v2 allowlist: ${key} matches no contract — remove the stale entry`)
|
|
} else if (documentedKeys.has(key)) {
|
|
errors.push(
|
|
`undocumented v2 allowlist: ${key} is documented after all — remove it from the allowlist`
|
|
)
|
|
}
|
|
}
|
|
|
|
for (const [legacyOperationId, replacement] of Object.entries(LEGACY_CORE_REPLACEMENTS)) {
|
|
if (!documentedKeys.has(replacement)) {
|
|
errors.push(
|
|
`legacy coverage: ${legacyOperationId} is missing its documented v2 replacement (${replacement})`
|
|
)
|
|
}
|
|
}
|
|
|
|
const workflowMetaGroups = [
|
|
{
|
|
tag: 'Workflows',
|
|
file: 'content/docs/en/api-reference/(generated)/workflows/meta.json',
|
|
},
|
|
{
|
|
tag: 'Workflow Runs',
|
|
file: 'content/docs/en/api-reference/(generated)/workflow-runs/meta.json',
|
|
},
|
|
] as const
|
|
const visibleWorkflowOperationIds = new Set<string>()
|
|
for (const group of workflowMetaGroups) {
|
|
const meta = JSON.parse(readFileSync(path.join(DOCS_DIR, group.file), 'utf8')) as Json
|
|
if (!Array.isArray(meta.pages) || !meta.pages.every((page) => typeof page === 'string')) {
|
|
fail(group.file, 'pages must be an array of operationIds')
|
|
continue
|
|
}
|
|
for (const operationId of meta.pages as string[]) {
|
|
if (visibleWorkflowOperationIds.has(operationId)) {
|
|
fail(group.file, `${operationId} is listed in more than one workflow group`)
|
|
continue
|
|
}
|
|
visibleWorkflowOperationIds.add(operationId)
|
|
if (globalOperationIds.get(operationId) !== 'openapi-v2-workflows.json') {
|
|
fail(group.file, `${operationId} is not an operation in openapi-v2-workflows.json`)
|
|
continue
|
|
}
|
|
if (!globalOperationTags.get(operationId)?.includes(group.tag)) {
|
|
fail(group.file, `${operationId} is not tagged ${group.tag}`)
|
|
}
|
|
}
|
|
}
|
|
for (const [operationId, specFile] of globalOperationIds) {
|
|
if (specFile === 'openapi-v2-workflows.json' && !visibleWorkflowOperationIds.has(operationId)) {
|
|
errors.push(`${operationId} is documented but hidden from the workflow API reference groups`)
|
|
}
|
|
}
|
|
|
|
for (const locale of API_REFERENCE_LOCALES) {
|
|
const metaFile = `content/docs/${locale}/api-reference/meta.json`
|
|
const meta = JSON.parse(readFileSync(path.join(DOCS_DIR, metaFile), 'utf8')) as Json
|
|
if (!Array.isArray(meta.pages) || !meta.pages.every((page) => typeof page === 'string')) {
|
|
fail(metaFile, 'pages must be an array of page identifiers')
|
|
continue
|
|
}
|
|
const pages = new Set(meta.pages as string[])
|
|
for (const group of REQUIRED_API_REFERENCE_GROUPS) {
|
|
if (!pages.has(group)) fail(metaFile, `missing public v2 group ${group}`)
|
|
}
|
|
for (const group of REMOVED_API_REFERENCE_GROUPS) {
|
|
if (pages.has(group)) fail(metaFile, `obsolete legacy group ${group} must not be published`)
|
|
}
|
|
}
|
|
|
|
if (errors.length > 0) {
|
|
console.error(
|
|
`OpenAPI spec validation failed (${errors.length} issue${errors.length === 1 ? '' : 's'}):`
|
|
)
|
|
for (const message of errors) console.error(` - ${message}`)
|
|
process.exit(1)
|
|
}
|
|
const exemptCount = Object.keys(UNDOCUMENTED_V2_ROUTES).length
|
|
console.log(
|
|
`OpenAPI spec validation passed: ${SPEC_FILES.length} specs, ${documentedKeys.size} operations, ${registry.size} contracts cross-checked (${exemptCount} explicitly undocumented).`
|
|
)
|