mirror of
https://github.com/simstudioai/sim.git
synced 2026-10-30 19:32:46 +08:00
Waleed
011f26d9f3
* refactor: remove dead code, orphan modules, and two unused dependencies Every symbol below was classified per reference hit as: own declaration / barrel re-export line / vi.mock stub / real production caller. Only symbols with zero real callers are removed. Orphan modules (nothing imports them): - scheduled-tasks/components/schedule-calendar/ — 11 files. Zero references repo-wide, not even a barrel line. - terminal/components/filter-popover/ — re-exported through a barrel, consumed by nothing. - 6 iso-marks primitives (IsoCubeGrid, IsoCubeRow, IsoFourBox, IsoGridPlane, IsoStackedPlanes, IsoStar). mothership.tsx imports only the four Iso*Illustrations, which do not use these. - 4 copilot user-input hooks (useMentionKeyboard, useTextareaAutoResize, useMentionInsertHandlers, useCaretViewport) — barrel line only. Their six siblings in that directory are live and stay. - lib/workflows/application/duplicate-workflow.ts — an orphaned authorized use case. Live duplication goes through lib/workflows/persistence/duplicate.ts, which exports a same-named duplicateWorkflow; the 23 apparent references are all to that one. Nothing imports the application path. Dead exports: - lib/compare/data/feature-catalog.ts (SIM_FEATURES, 939 lines) plus the SimFeature type, FeatureCategory union, and featuresByCategory/featuresByTag helpers that only it used — one unshipped feature-comparison catalog. - createExecutionCallbacks (execution-events.ts) — declaration only, zero other hits repo-wide. Stale vi.mock targets — mocks whose module no longer exists, so they are silent no-ops that make a test look protected when it is not: - @/background/logs-webhook-delivery and @/app/api/webhooks/utils in the webhook trigger route test (its generateRequestHashMock and validateSlackSignatureMock hoisted vars went with it) - @/lib/workflows/subblocks/options in blocks/blocks/logs.test.ts - @/lib/uploads/setup in the S3 client test - @/lib/uploads/setup.server in the files delete and parse route tests — parse/route.test.ts mocks the real @/lib/uploads/core/setup.server on the very next line Dependencies: three and @types/three. Zero imports anywhere, and absent from every config, script, workflow, Dockerfile and chart. Both arrived with the speech-to-speech voice mode, which has since been removed. Deliberately kept: build-chat-animation/ reads as an orphan but build-callout.tsx documents it as parked unwired for reuse. * chore: update lockfile for the three/@types/three removal CI runs bun install --frozen-lockfile, so dropping the two dependencies from apps/sim/package.json without regenerating bun.lock fails the install step. The diff is the two entries plus three's transitives (@dimforge/rapier3d-compat, @tweenjs/tween.js, @types/stats.js, @types/webxr, @webgpu/types, meshoptimizer). One change deserves a note: top-level fflate moves 0.8.3 -> 0.4.8. It was hoisted to 0.8.3 only because @types/three required ~0.8.2; with that gone the remaining top-level consumer is posthog-js, which asks for ^0.4.8. Every other consumer keeps its own pinned nested entry (@shuding/opentype.js 0.7.4, @smithy/middleware-compression 0.8.1), and no source file imports fflate directly, so no resolution changes for anything that was already installed.