From d081ab283e5f3e036bfbb6c4941a77afe08486a3 Mon Sep 17 00:00:00 2001
From: Waleed <walif6@gmail.com>
Date: Thu, 7 May 2026 12:54:42 -0700
Subject: [PATCH] fix(logs): relax fileSchema so execution logs with files
 render again (#4495)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix(logs): relax fileSchema so execution logs with files render again

* improvement(logs): align fileSchema with shared UserFile type

- contracts/logs.ts: replace local fileSchema with mediaUserFileSchema (the established UserFile boundary schema with .passthrough())
- file-download.tsx: drop local FileData interface, use UserFile from @/executor/types

* improvement(contracts): promote userFileSchema to primitives

Move the canonical UserFile boundary schema out of tools/media/shared.ts
(where it didn't belong — logs aren't media tools) into primitives.ts as
userFileSchema. Update logs, stt, and video contracts to import from the
shared primitive.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
---
 .../file-download/file-download.tsx           | 23 +++++--------------
 apps/sim/lib/api/contracts/logs.ts            | 16 ++-----------
 apps/sim/lib/api/contracts/primitives.ts      | 20 ++++++++++++++++
 .../lib/api/contracts/tools/media/shared.ts   | 13 -----------
 apps/sim/lib/api/contracts/tools/media/stt.ts |  5 ++--
 .../lib/api/contracts/tools/media/video.ts    |  5 ++--
 6 files changed, 34 insertions(+), 48 deletions(-)

diff --git a/apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/file-download/file-download.tsx b/apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/file-download/file-download.tsx
index 23670cf2c0..9a2e09ce47 100644
--- a/apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/file-download/file-download.tsx
+++ b/apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/file-download/file-download.tsx
@@ -5,31 +5,20 @@ import { createLogger } from '@sim/logger'
 import { ArrowDown } from 'lucide-react'
 import { useRouter } from 'next/navigation'
 import { Button, Loader } from '@/components/emcn'
+import { cn } from '@/lib/core/utils/cn'
 import { extractWorkspaceIdFromExecutionKey, getViewerUrl } from '@/lib/uploads/utils/file-utils'
+import type { UserFile } from '@/executor/types'
 
 const logger = createLogger('FileCards')
 
-interface FileData {
-  id?: string
-  name: string
-  size: number
-  type: string
-  key: string
-  url: string
-  uploadedAt: string
-  expiresAt: string
-  storageProvider?: 's3' | 'blob' | 'local'
-  bucketName?: string
-}
-
 interface FileCardsProps {
-  files: FileData[]
+  files: UserFile[]
   isExecutionFile?: boolean
   workspaceId?: string
 }
 
 interface FileCardProps {
-  file: FileData
+  file: UserFile
   isExecutionFile?: boolean
   workspaceId?: string
 }
@@ -157,7 +146,7 @@ export function FileDownload({
   className,
   workspaceId,
 }: {
-  file: FileData
+  file: UserFile
   isExecutionFile?: boolean
   className?: string
   workspaceId?: string
@@ -220,7 +209,7 @@ export function FileDownload({
   return (
     <Button
       variant='ghost'
-      className={`h-7 px-2 text-xs ${className}`}
+      className={cn('h-7 px-2 text-xs', className)}
       onClick={handleDownload}
       disabled={isDownloading}
     >
diff --git a/apps/sim/lib/api/contracts/logs.ts b/apps/sim/lib/api/contracts/logs.ts
index 6e94720f91..088d6044a4 100644
--- a/apps/sim/lib/api/contracts/logs.ts
+++ b/apps/sim/lib/api/contracts/logs.ts
@@ -1,4 +1,5 @@
 import { z } from 'zod'
+import { userFileSchema } from '@/lib/api/contracts/primitives'
 import { defineRouteContract } from '@/lib/api/contracts/types'
 
 const comparisonOperatorSchema = z.enum(['=', '>', '<', '>=', '<=', '!='])
@@ -66,19 +67,6 @@ const workflowSummarySchema = z
   })
   .partial()
 
-const fileSchema = z.object({
-  id: z.string(),
-  name: z.string(),
-  size: z.number(),
-  type: z.string(),
-  url: z.string(),
-  key: z.string(),
-  uploadedAt: z.string(),
-  expiresAt: z.string(),
-  storageProvider: z.enum(['s3', 'blob', 'local']).optional(),
-  bucketName: z.string().optional(),
-})
-
 const tokenBreakdownSchema = z
   .object({
     total: z.number().optional(),
@@ -237,7 +225,7 @@ export const workflowLogSummarySchema = z.object({
 
 export const workflowLogDetailSchema = workflowLogSummarySchema.extend({
   executionData: executionDataDetailSchema,
-  files: z.array(fileSchema).nullable(),
+  files: z.array(userFileSchema).nullable(),
 })
 
 export type WorkflowLogSummary = z.output<typeof workflowLogSummarySchema>
diff --git a/apps/sim/lib/api/contracts/primitives.ts b/apps/sim/lib/api/contracts/primitives.ts
index a223c92683..c7faa0b0d2 100644
--- a/apps/sim/lib/api/contracts/primitives.ts
+++ b/apps/sim/lib/api/contracts/primitives.ts
@@ -59,6 +59,26 @@ export const workflowIdSchema = z.string().min(1, 'Workflow ID is required')
  * Use `.optional()` / `.default(...)` at the call site, not here, so each
  * query field controls its own omission/default semantics.
  */
+/**
+ * Canonical boundary schema for `UserFile` (`apps/sim/executor/types.ts`) — the
+ * shape produced by the executor and persisted in `workflowExecutionLogs.files`,
+ * forwarded through tool inputs, and rendered in the logs UI. `.passthrough()`
+ * tolerates legacy/extra fields on stored rows (e.g. `uploadedAt`, `expiresAt`,
+ * `storageProvider`) without rejecting the whole payload.
+ */
+export const userFileSchema = z
+  .object({
+    id: z.string().optional().default(''),
+    name: z.string().min(1),
+    url: z.string().optional().default(''),
+    size: z.coerce.number().nonnegative(),
+    type: z.string().optional().default('application/octet-stream'),
+    key: z.string().min(1),
+    context: z.string().optional(),
+    base64: z.string().optional(),
+  })
+  .passthrough()
+
 export const booleanQueryFlagSchema = z.preprocess(
   (value) => {
     if (typeof value === 'boolean') return value
diff --git a/apps/sim/lib/api/contracts/tools/media/shared.ts b/apps/sim/lib/api/contracts/tools/media/shared.ts
index 36315d6936..30f2122ce0 100644
--- a/apps/sim/lib/api/contracts/tools/media/shared.ts
+++ b/apps/sim/lib/api/contracts/tools/media/shared.ts
@@ -3,19 +3,6 @@ import { z } from 'zod'
 export const AWS_REGION_PATTERN =
   /^(eu-isoe|us-isob|us-iso|us-gov|af|ap|ca|cn|eu|il|me|mx|sa|us)-(central|north|northeast|northwest|south|southeast|southwest|east|west)-\d{1,2}$/
 
-export const mediaUserFileSchema = z
-  .object({
-    id: z.string().optional().default(''),
-    name: z.string().min(1),
-    url: z.string().optional().default(''),
-    size: z.coerce.number().nonnegative(),
-    type: z.string().optional().default('application/octet-stream'),
-    key: z.string().min(1),
-    context: z.string().optional(),
-    base64: z.string().optional(),
-  })
-  .passthrough()
-
 export const toolJsonResponseSchema = z
   .object({
     success: z.boolean().optional(),
diff --git a/apps/sim/lib/api/contracts/tools/media/stt.ts b/apps/sim/lib/api/contracts/tools/media/stt.ts
index b7d7ad4ac3..015e3eaf4e 100644
--- a/apps/sim/lib/api/contracts/tools/media/stt.ts
+++ b/apps/sim/lib/api/contracts/tools/media/stt.ts
@@ -1,11 +1,12 @@
 import { z } from 'zod'
-import { mediaUserFileSchema, toolJsonResponseSchema } from '@/lib/api/contracts/tools/media/shared'
+import { userFileSchema } from '@/lib/api/contracts/primitives'
+import { toolJsonResponseSchema } from '@/lib/api/contracts/tools/media/shared'
 import { defineRouteContract } from '@/lib/api/contracts/types'
 
 export const sttProviders = ['whisper', 'deepgram', 'elevenlabs', 'assemblyai', 'gemini'] as const
 const MISSING_STT_FIELDS_ERROR = 'Missing required fields: provider and apiKey'
 
-export const sttUserFileSchema = mediaUserFileSchema.extend({
+export const sttUserFileSchema = userFileSchema.extend({
   type: z.string().optional().default(''),
 })
 
diff --git a/apps/sim/lib/api/contracts/tools/media/video.ts b/apps/sim/lib/api/contracts/tools/media/video.ts
index d823285a28..edeb44e128 100644
--- a/apps/sim/lib/api/contracts/tools/media/video.ts
+++ b/apps/sim/lib/api/contracts/tools/media/video.ts
@@ -1,5 +1,6 @@
 import { z } from 'zod'
-import { mediaUserFileSchema, toolJsonResponseSchema } from '@/lib/api/contracts/tools/media/shared'
+import { userFileSchema } from '@/lib/api/contracts/primitives'
+import { toolJsonResponseSchema } from '@/lib/api/contracts/tools/media/shared'
 import { defineRouteContract } from '@/lib/api/contracts/types'
 
 export const videoProviders = ['runway', 'veo', 'luma', 'minimax', 'falai'] as const
@@ -19,7 +20,7 @@ export const videoToolBodySchema = z
     duration: z.coerce.number().optional(),
     aspectRatio: z.string().optional(),
     resolution: z.string().optional(),
-    visualReference: mediaUserFileSchema.optional(),
+    visualReference: userFileSchema.optional(),
     cameraControl: z.unknown().optional(),
     endpoint: z.string().optional(),
     promptOptimizer: z.boolean().optional(),