mirror of
https://github.com/simstudioai/sim.git
synced 2026-09-24 15:45:35 +08:00
fix(docker): use full bun.lock + bump deprecated GHA actions (#4323)
* fix(docker): use full bun.lock and copy it into builder
The staging build for app.Dockerfile (commit dc2022995, PR #4322) is
failing in two ways after switching to turbo prune:
1. turbo 2.9.6's pruned bun.lock is malformed for bun 1.3.x:
error: Failed to resolve prod dependency 'wrap-ansi' for package
'log-update' at bun.lock:2688:5
Bun ignores it and falls back to a fresh resolve (~7m install).
2. Next.js 16.1.6's Turbopack production build can't infer the workspace
root because /app/bun.lock doesn't exist in the builder stage:
Error: We couldn't find the Next.js package (next/package.json)
from the project directory: /app/apps/sim
This blocks the build entirely.
Fix:
- deps stage: use the full bun.lock from /app/bun.lock (the original
lockfile after `COPY . .` in pruner) instead of the broken
/app/out/bun.lock that turbo prune emits.
- builder stage: also copy the full bun.lock to /app/bun.lock so
Turbopack and turborepo can detect the workspace root.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* chore(ci): bump deprecated Node.js 20 actions to Node.js 24 versions
GitHub Actions runners emit deprecation warnings for actions still on the
Node.js 20 runtime. Node.js 20 will be force-upgraded by GitHub on
2026-06-02 and removed on 2026-09-16.
Bumps to the latest stable major versions, all of which use Node.js 24:
- actions/cache: v4 -> v5
- actions/setup-node: v4 -> v6
- aws-actions/configure-aws-credentials: v4 -> v6
- docker/login-action: v3 -> v4
All require GHA runner v2.327.1+ which Blacksmith already runs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
6a7d5ae828
commit
ceb7d20aed
+13
-3
@@ -29,10 +29,14 @@ RUN turbo prune sim --docker
|
||||
FROM base AS deps
|
||||
WORKDIR /app
|
||||
|
||||
# Pruned manifests + lockfile from the pruner stage. This layer only invalidates
|
||||
# when package.json/bun.lock content changes — not on source edits.
|
||||
# Pruned manifests from the pruner stage. This layer only invalidates when
|
||||
# package.json/bun.lock content changes — not on source edits.
|
||||
COPY --from=pruner /app/out/json/ ./
|
||||
COPY --from=pruner /app/out/bun.lock ./bun.lock
|
||||
# Use the full bun.lock (not the pruned out/bun.lock). turbo prune emits a
|
||||
# bun.lock that bun 1.3.x rejects with "Failed to resolve prod dependency",
|
||||
# forcing a slow fresh resolve. The full lockfile parses cleanly and bun
|
||||
# only installs what the pruned package.jsons reference.
|
||||
COPY --from=pruner /app/bun.lock ./bun.lock
|
||||
|
||||
# Install all dependencies (including devDependencies — tailwindcss/postcss are
|
||||
# devDeps but required at build time). Then rebuild isolated-vm against Node.js.
|
||||
@@ -55,6 +59,12 @@ COPY --from=deps /app/node_modules ./node_modules
|
||||
# Copy pruned source tree (apps/sim + workspace packages it depends on)
|
||||
COPY --from=pruner /app/out/full/ ./
|
||||
|
||||
# Next.js 16 / Turbopack workspace-root detection looks for a lockfile next to
|
||||
# the workspace package.json. Without it, `next build` fails with
|
||||
# "couldn't find next/package.json from /app/apps/sim". turbo also warns
|
||||
# "Lockfile not found at /app/bun.lock" without it.
|
||||
COPY --from=pruner /app/bun.lock ./bun.lock
|
||||
|
||||
ENV NEXT_TELEMETRY_DISABLED=1 \
|
||||
VERCEL_TELEMETRY_DISABLED=1 \
|
||||
DOCKER_BUILD=1
|
||||
|
||||
Reference in New Issue
Block a user