From 9ef3a11d758d2f398acee544137ad978f6a1eb45 Mon Sep 17 00:00:00 2001 From: Waleed Latif Date: Wed, 6 May 2026 19:25:22 -0700 Subject: [PATCH] fix(sap-concur): final live-API alignment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Verified against live SAP Concur docs (concur/developer.concur.com preview branch): - Revert Cash Advance paths to /cashadvance/v4/ (v4.1 endpoints do not exist; live spec is v4) - Travel Profile v2 summary has no Active/Status query param — drop the filter from tool, types, and block - Report Comments v4 contextType is TRAVELER or PROXY only (NOT MANAGER) — move create_report_comment + list_report_comments into the TRAVELER/PROXY context group - Trip v1.1 query keys: userid_type / userid_value / ItemsPerPage / Page (snake/Pascal per docs) — already correct, kept Co-Authored-By: Claude Opus 4.7 --- apps/docs/content/docs/en/tools/sap_concur.mdx | 6 +++--- apps/sim/app/(landing)/integrations/data/integrations.json | 6 +++--- apps/sim/tools/sap_concur/create_cash_advance.ts | 4 ++-- apps/sim/tools/sap_concur/get_cash_advance.ts | 4 ++-- apps/sim/tools/sap_concur/issue_cash_advance.ts | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/apps/docs/content/docs/en/tools/sap_concur.mdx b/apps/docs/content/docs/en/tools/sap_concur.mdx index 9abd089187..d8a819c4e6 100644 --- a/apps/docs/content/docs/en/tools/sap_concur.mdx +++ b/apps/docs/content/docs/en/tools/sap_concur.mdx @@ -96,7 +96,7 @@ Associate attendees with an expense (POST /expensereports/v4/users/\{userId\}/co ### `sap_concur_create_cash_advance` -Create a cash advance (POST /cashadvance/v4.1/cashadvances). +Create a cash advance (POST /cashadvance/v4/cashadvances). #### Input @@ -686,7 +686,7 @@ Get a budget item header by ID (GET /budget/v4/budgetItemHeader/\{id\}). ### `sap_concur_get_cash_advance` -Get a cash advance (GET /cashadvance/v4.1/cashadvances/\{cashAdvanceId\}). +Get a cash advance (GET /cashadvance/v4/cashadvances/\{cashAdvanceId\}). #### Input @@ -1426,7 +1426,7 @@ Get a single user by UUID (GET /profile/identity/v4.1/Users/\{id\}). ### `sap_concur_issue_cash_advance` -Issue a cash advance (POST /cashadvance/v4.1/cashadvances/\{cashAdvanceId\}/issue). +Issue a cash advance (POST /cashadvance/v4/cashadvances/\{cashAdvanceId\}/issue). #### Input diff --git a/apps/sim/app/(landing)/integrations/data/integrations.json b/apps/sim/app/(landing)/integrations/data/integrations.json index 9a1513dc6f..8f5fea2387 100644 --- a/apps/sim/app/(landing)/integrations/data/integrations.json +++ b/apps/sim/app/(landing)/integrations/data/integrations.json @@ -11666,15 +11666,15 @@ }, { "name": "Create Cash Advance", - "description": "Create a cash advance (POST /cashadvance/v4.1/cashadvances)." + "description": "Create a cash advance (POST /cashadvance/v4/cashadvances)." }, { "name": "Get Cash Advance", - "description": "Get a cash advance (GET /cashadvance/v4.1/cashadvances/{cashAdvanceId})." + "description": "Get a cash advance (GET /cashadvance/v4/cashadvances/{cashAdvanceId})." }, { "name": "Issue Cash Advance", - "description": "Issue a cash advance (POST /cashadvance/v4.1/cashadvances/{cashAdvanceId}/issue)." + "description": "Issue a cash advance (POST /cashadvance/v4/cashadvances/{cashAdvanceId}/issue)." }, { "name": "List Itineraries (Trips)", diff --git a/apps/sim/tools/sap_concur/create_cash_advance.ts b/apps/sim/tools/sap_concur/create_cash_advance.ts index 7297eb214c..6d507c2ee0 100644 --- a/apps/sim/tools/sap_concur/create_cash_advance.ts +++ b/apps/sim/tools/sap_concur/create_cash_advance.ts @@ -9,7 +9,7 @@ import type { ToolConfig } from '@/tools/types' export const createCashAdvanceTool: ToolConfig = { id: 'sap_concur_create_cash_advance', name: 'SAP Concur Create Cash Advance', - description: 'Create a cash advance (POST /cashadvance/v4.1/cashadvances).', + description: 'Create a cash advance (POST /cashadvance/v4/cashadvances).', version: '1.0.0', params: { datacenter: { @@ -67,7 +67,7 @@ export const createCashAdvanceTool: ToolConfig ({ 'Content-Type': 'application/json' }), body: (params) => ({ ...baseProxyBody(params), - path: `/cashadvance/v4.1/cashadvances`, + path: `/cashadvance/v4/cashadvances`, method: 'POST', body: params.body, }), diff --git a/apps/sim/tools/sap_concur/get_cash_advance.ts b/apps/sim/tools/sap_concur/get_cash_advance.ts index ace1a6315f..3e6ea57add 100644 --- a/apps/sim/tools/sap_concur/get_cash_advance.ts +++ b/apps/sim/tools/sap_concur/get_cash_advance.ts @@ -10,7 +10,7 @@ import type { ToolConfig } from '@/tools/types' export const getCashAdvanceTool: ToolConfig = { id: 'sap_concur_get_cash_advance', name: 'SAP Concur Get Cash Advance', - description: 'Get a cash advance (GET /cashadvance/v4.1/cashadvances/{cashAdvanceId}).', + description: 'Get a cash advance (GET /cashadvance/v4/cashadvances/{cashAdvanceId}).', version: '1.0.0', params: { datacenter: { @@ -70,7 +70,7 @@ export const getCashAdvanceTool: ToolConfig = { id: 'sap_concur_issue_cash_advance', name: 'SAP Concur Issue Cash Advance', - description: 'Issue a cash advance (POST /cashadvance/v4.1/cashadvances/{cashAdvanceId}/issue).', + description: 'Issue a cash advance (POST /cashadvance/v4/cashadvances/{cashAdvanceId}/issue).', version: '1.0.0', params: { datacenter: { @@ -76,7 +76,7 @@ export const issueCashAdvanceTool: ToolConfig