From 2fcd91210f5e3f9f53eda1bd108eba6b53e7b012 Mon Sep 17 00:00:00 2001 From: fengxsong Date: Sun, 9 Oct 2022 10:06:44 +0800 Subject: [PATCH] fix: return error if any error occured (#1844) Signed-off-by: fengxsong Signed-off-by: fengxsong --- pkg/registry/save.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/registry/save.go b/pkg/registry/save.go index 9e986011b..f2831d977 100644 --- a/pkg/registry/save.go +++ b/pkg/registry/save.go @@ -23,11 +23,10 @@ import ( "strings" "sync" + "github.com/labring/sealos/pkg/passwd" "github.com/labring/sealos/pkg/utils/http" "github.com/labring/sealos/pkg/utils/logger" - "github.com/labring/sealos/pkg/passwd" - distribution "github.com/distribution/distribution/v3" "github.com/distribution/distribution/v3/configuration" "github.com/distribution/distribution/v3/reference" @@ -40,6 +39,7 @@ import ( "github.com/docker/docker/pkg/streamformatter" "github.com/opencontainers/go-digest" v1 "github.com/opencontainers/image-spec/specs-go/v1" + "github.com/pkg/errors" "golang.org/x/sync/errgroup" "github.com/labring/sealos/pkg/registry/distributionpkg/proxy" @@ -108,8 +108,7 @@ func (is *DefaultImageSaver) SaveImages(images []string, dir string, platform v1 err = is.save(tmpnameds, platform, registry) if err != nil { - logger.Warn("save domain %s image %s error: %v", tmpnameds[0].domain, tmpnameds[0].FullName(), err) - return nil + return errors.WithMessagef(err, "save domain %s image %s", tmpnameds[0].domain, tmpnameds[0].FullName()) } outImages = append(outImages, tmpnameds[0].FullName()) return nil