From e760d44e659af58ee126e18f0ecc044a55460f7d Mon Sep 17 00:00:00 2001 From: Zhengchao An Date: Thu, 27 Aug 2026 10:24:03 +0800 Subject: [PATCH] chore(rustfs): remove stale manual-test-runners feature and README (#6715) --- rustfs/Cargo.toml | 1 - rustfs/src/config/info.rs | 17 +++++------------ rustfs/tests/manual/README.md | 19 ------------------- 3 files changed, 5 insertions(+), 32 deletions(-) delete mode 100644 rustfs/tests/manual/README.md diff --git a/rustfs/Cargo.toml b/rustfs/Cargo.toml index 391acde11..529fc4b73 100644 --- a/rustfs/Cargo.toml +++ b/rustfs/Cargo.toml @@ -67,7 +67,6 @@ license = [] io-scheduler-debug = [] # Enable debug information in I/O scheduler tracing-chunk-debug = [] # Enable per-chunk tracing in data plane (high noise, for debugging only) full = ["metrics-gpu", "ftps", "swift", "webdav", "sftp", "pyroscope"] -manual-test-runners = [] e2e-test-hooks = [] # Shortens Connect credentials only in debug E2E builds. connect-e2e-short-credentials = [] diff --git a/rustfs/src/config/info.rs b/rustfs/src/config/info.rs index 95289581c..1c8649116 100644 --- a/rustfs/src/config/info.rs +++ b/rustfs/src/config/info.rs @@ -591,7 +591,7 @@ struct FeatureSpec { default_enabled: bool, } -fn feature_specs() -> [FeatureSpec; 8] { +fn feature_specs() -> [FeatureSpec; 7] { [ FeatureSpec { name: "metrics-gpu", @@ -635,13 +635,6 @@ fn feature_specs() -> [FeatureSpec; 8] { dependencies: "(none)", default_enabled: false, }, - FeatureSpec { - name: "manual-test-runners", - enabled: cfg!(feature = "manual-test-runners"), - description: "Enable manual test binaries", - dependencies: "(none)", - default_enabled: false, - }, FeatureSpec { name: "full", enabled: cfg!(feature = "full"), @@ -1008,11 +1001,11 @@ mod tests { let info = collect_deps_info_json(); let feature_names: Vec<_> = info.features.iter().map(|feature| feature.name).collect(); - assert_eq!(info.total_count, 8); - assert_eq!(info.features.len(), 8); + assert_eq!(info.total_count, 7); + assert_eq!(info.features.len(), 7); assert!(feature_names.contains(&"metrics-gpu")); assert!(feature_names.contains(&"io-scheduler-debug")); - assert!(feature_names.contains(&"manual-test-runners")); + assert!(!feature_names.contains(&"manual-test-runners")); assert!(!feature_names.contains(&"metrics")); assert!(!feature_names.contains(&"direct-io")); } @@ -1023,7 +1016,7 @@ mod tests { assert!(output.contains("| metrics-gpu |")); assert!(output.contains("| io-scheduler-debug |")); - assert!(output.contains("| manual-test-runners |")); + assert!(!output.contains("| manual-test-runners |")); assert!(output.contains("| ftps | enabled by default |")); assert!(output.contains("| webdav | enabled by default |")); assert!(output.contains("| full | metrics-gpu + ftps + swift + webdav |")); diff --git a/rustfs/tests/manual/README.md b/rustfs/tests/manual/README.md deleted file mode 100644 index 6755e73a4..000000000 --- a/rustfs/tests/manual/README.md +++ /dev/null @@ -1,19 +0,0 @@ -# Manual test runners - -Files in this directory are for manual execution only. -They are not auto-discovered as integration tests by `cargo test`. - -## Dial9 runner - -Build: - -```bash -cargo build -p rustfs --features manual-test-runners --bin manual-test-dial9 -``` - -Run: - -```bash -cargo run -p rustfs --features manual-test-runners --bin manual-test-dial9 -``` -