From fef690c06d0c3719ba7c9a2215145dfbec80fc6e Mon Sep 17 00:00:00 2001 From: yx9o Date: Wed, 24 Dec 2025 09:31:19 +0800 Subject: [PATCH] [ISSUE #9943] Remove redundant containsKey check in checkBrokerConfig (#9944) --- .../main/java/org/apache/rocketmq/client/Validators.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/client/src/main/java/org/apache/rocketmq/client/Validators.java b/client/src/main/java/org/apache/rocketmq/client/Validators.java index 7f588d56ea..170af8b106 100644 --- a/client/src/main/java/org/apache/rocketmq/client/Validators.java +++ b/client/src/main/java/org/apache/rocketmq/client/Validators.java @@ -131,11 +131,10 @@ public class Validators { } public static void checkBrokerConfig(final Properties brokerConfig) throws MQClientException { - // TODO: use MixAll.isPropertyValid() when jdk upgrade to 1.8 - if (brokerConfig.containsKey("brokerPermission") - && !PermName.isValid(brokerConfig.getProperty("brokerPermission"))) { + String brokerPermission = brokerConfig.getProperty("brokerPermission"); + if (brokerPermission != null && !PermName.isValid(brokerPermission)) { throw new MQClientException(ResponseCode.NO_PERMISSION, - String.format("brokerPermission value: %s is invalid.", brokerConfig.getProperty("brokerPermission"))); + String.format("brokerPermission value: %s is invalid.", brokerPermission)); } } }