opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-09-19 02:23:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE #5507] Improve the speed of AttributeParser#parseToMap parsing (#5508)

Browse Source
This commit is contained in:
mxsm
2023-01-12 10:41:25 +08:00
committed by GitHub
parent 07ce0be339
commit fa22a78387
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java
+18 -12
View File
@@ -16,15 +16,22 @@
*/
package org.apache.rocketmq.common.attribute;
import com.google.common.base.Joiner;
import com.google.common.base.Strings;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
public class AttributeParser {
public static final String ATTR_ARRAY_SEPARATOR_COMMA = ",";
public static final String ATTR_KEY_VALUE_EQUAL_SIGN = "=";
public static final String ATTR_ADD_PLUS_SIGN = "+";
private static final String ATTR_DELETE_MINUS_SIGN = "-";
public static Map<String, String> parseToMap(String attributesModification) {
if (Strings.isNullOrEmpty(attributesModification)) {
return new HashMap<>();
@@ -32,22 +39,21 @@ public class AttributeParser {
// format: +key1=value1,+key2=value2,-key3,+key4=value4
Map<String, String> attributes = new HashMap<>();
String arraySeparator = ",";
String kvSeparator = "=";
String[] kvs = attributesModification.split(arraySeparator);
String[] kvs = attributesModification.split(ATTR_ARRAY_SEPARATOR_COMMA);
for (String kv : kvs) {
String key;
String value;
if (kv.contains(kvSeparator)) {
key = kv.split(kvSeparator)[0];
value = kv.split(kvSeparator)[1];
if (!key.contains("+")) {
if (kv.contains(ATTR_KEY_VALUE_EQUAL_SIGN)) {
String[] splits = kv.split(ATTR_KEY_VALUE_EQUAL_SIGN);
key = splits[0];
value = splits[1];
if (!key.contains(ATTR_ADD_PLUS_SIGN)) {
throw new RuntimeException("add/alter attribute format is wrong: " + key);
}
} else {
key = kv;
value = "";
if (!key.contains("-")) {
if (!key.contains(ATTR_DELETE_MINUS_SIGN)) {
throw new RuntimeException("delete attribute format is wrong: " + key);
}
}
@@ -71,9 +77,9 @@ public class AttributeParser {
if (Strings.isNullOrEmpty(value)) {
kvs.add(entry.getKey());
} else {
kvs.add(entry.getKey() + "=" + entry.getValue());
kvs.add(entry.getKey() + ATTR_KEY_VALUE_EQUAL_SIGN + entry.getValue());
}
}
return Joiner.on(",").join(kvs);
return String.join(ATTR_ARRAY_SEPARATOR_COMMA, kvs);
}
}