diff --git a/acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java b/acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java index d4452a3f21..294db4f069 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java @@ -55,7 +55,7 @@ public class AclClientRPCHook implements RPCHook { request.makeCustomHeaderToNet(); Map extFields = request.getExtFields(); // Sort property - return new TreeMap(extFields); + return new TreeMap<>(extFields); } public SessionCredentials getSessionCredentials() { diff --git a/acl/src/main/java/org/apache/rocketmq/acl/common/Permission.java b/acl/src/main/java/org/apache/rocketmq/acl/common/Permission.java index 7213cf72d8..b04937cabd 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/common/Permission.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/common/Permission.java @@ -30,7 +30,7 @@ public class Permission { public static final byte PUB = 1 << 2; public static final byte SUB = 1 << 3; - public static final Set ADMIN_CODE = new HashSet(); + public static final Set ADMIN_CODE = new HashSet<>(); static { // UPDATE_AND_CREATE_TOPIC diff --git a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java index 794c163000..305643e7a1 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java @@ -174,7 +174,7 @@ public class PlainAccessResource implements AccessResource { } // Content - SortedMap map = new TreeMap(); + SortedMap map = new TreeMap<>(); for (Map.Entry entry : request.getExtFields().entrySet()) { if (!SessionCredentials.SIGNATURE.equals(entry.getKey()) && !MixAll.UNIQUE_MSG_QUERY_FLAG.equals(entry.getKey())) { diff --git a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java index 509d549024..dc0b9175ec 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java @@ -290,8 +290,8 @@ public class PlainPermissionManager { } } dataVersion.nextVersion(); - List> versionElement = new ArrayList>(); - Map accountsMap = new LinkedHashMap(); + List> versionElement = new ArrayList<>(); + Map accountsMap = new LinkedHashMap<>(); accountsMap.put(AclConstants.CONFIG_COUNTER, dataVersion.getCounter().longValue()); accountsMap.put(AclConstants.CONFIG_TIME_STAMP, dataVersion.getTimestamp()); @@ -339,7 +339,7 @@ public class PlainPermissionManager { } Map accountMap = aclPlainAccessResourceMap.get(aclFileName); if (accountMap == null) { - accountMap = new HashMap(1); + accountMap = new HashMap<>(1); accountMap.put(plainAccessConfig.getAccessKey(), buildPlainAccessResource(plainAccessConfig)); } else if (accountMap.size() == 0) { accountMap.put(plainAccessConfig.getAccessKey(), buildPlainAccessResource(plainAccessConfig)); @@ -398,7 +398,7 @@ public class PlainPermissionManager { Map newAccountsMap = null; if (existedAccountMap == null) { - newAccountsMap = new LinkedHashMap(); + newAccountsMap = new LinkedHashMap<>(); } else { newAccountsMap = existedAccountMap; } diff --git a/acl/src/test/java/org/apache/rocketmq/acl/common/AclClientRPCHookTest.java b/acl/src/test/java/org/apache/rocketmq/acl/common/AclClientRPCHookTest.java index 1dd94d8a11..dbb80f06f6 100644 --- a/acl/src/test/java/org/apache/rocketmq/acl/common/AclClientRPCHookTest.java +++ b/acl/src/test/java/org/apache/rocketmq/acl/common/AclClientRPCHookTest.java @@ -35,7 +35,7 @@ import static org.assertj.core.api.Assertions.assertThat; public class AclClientRPCHookTest { protected ConcurrentHashMap, Field[]> fieldCache = - new ConcurrentHashMap, Field[]>(); + new ConcurrentHashMap<>(); private AclClientRPCHook aclClientRPCHook = new AclClientRPCHook(null); @Test @@ -81,7 +81,7 @@ public class AclClientRPCHookTest { private SortedMap oldVersionParseRequestContent(RemotingCommand request, String ak, String securityToken) { CommandCustomHeader header = request.readCustomHeader(); // Sort property - SortedMap map = new TreeMap(); + SortedMap map = new TreeMap<>(); map.put(ACCESS_KEY, ak); if (securityToken != null) { map.put(SECURITY_TOKEN, securityToken); diff --git a/acl/src/test/java/org/apache/rocketmq/acl/common/AclUtilsTest.java b/acl/src/test/java/org/apache/rocketmq/acl/common/AclUtilsTest.java index 2956df9c1e..395d9b9bf3 100644 --- a/acl/src/test/java/org/apache/rocketmq/acl/common/AclUtilsTest.java +++ b/acl/src/test/java/org/apache/rocketmq/acl/common/AclUtilsTest.java @@ -227,16 +227,16 @@ public class AclUtilsTest { Assert.assertTrue(transport.createNewFile()); transport.deleteOnExit(); - Map aclYamlMap = new HashMap(); + Map aclYamlMap = new HashMap<>(); // For globalWhiteRemoteAddrs element in acl yaml config file - List globalWhiteRemoteAddrs = new ArrayList(); + List globalWhiteRemoteAddrs = new ArrayList<>(); globalWhiteRemoteAddrs.add("10.10.103.*"); globalWhiteRemoteAddrs.add("192.168.0.*"); aclYamlMap.put("globalWhiteRemoteAddrs", globalWhiteRemoteAddrs); // For accounts element in acl yaml config file - List> accounts = new ArrayList>(); + List> accounts = new ArrayList<>(); Map accountsMap = new LinkedHashMap() { { put("accessKey", "RocketMQ"); @@ -257,10 +257,10 @@ public class AclUtilsTest { Assert.assertTrue(transport.createNewFile()); transport.deleteOnExit(); - Map aclYamlMap = new HashMap(); + Map aclYamlMap = new HashMap<>(); // For globalWhiteRemoteAddrs element in acl yaml config file - List globalWhiteRemoteAddrs = new ArrayList(); + List globalWhiteRemoteAddrs = new ArrayList<>(); globalWhiteRemoteAddrs.add("10.10.103.*"); globalWhiteRemoteAddrs.add("192.168.0.*"); aclYamlMap.put("globalWhiteRemoteAddrs", globalWhiteRemoteAddrs); diff --git a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessValidatorTest.java b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessValidatorTest.java index 3cca20b227..d4f0d400d6 100644 --- a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessValidatorTest.java +++ b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessValidatorTest.java @@ -493,11 +493,11 @@ public class PlainAccessValidatorTest { plainAccessConfig.setWhiteRemoteAddress("192.168.0.*"); plainAccessConfig.setDefaultGroupPerm("PUB"); plainAccessConfig.setDefaultTopicPerm("SUB"); - List topicPerms = new ArrayList(); + List topicPerms = new ArrayList<>(); topicPerms.add("topicC=PUB|SUB"); topicPerms.add("topicB=PUB"); plainAccessConfig.setTopicPerms(topicPerms); - List groupPerms = new ArrayList(); + List groupPerms = new ArrayList<>(); groupPerms.add("groupB=PUB|SUB"); groupPerms.add("groupC=DENY"); plainAccessConfig.setGroupPerms(groupPerms); @@ -578,11 +578,11 @@ public class PlainAccessValidatorTest { plainAccessConfig.setWhiteRemoteAddress("192.168.0.*"); plainAccessConfig.setDefaultGroupPerm("PUB"); plainAccessConfig.setDefaultTopicPerm("SUB"); - List topicPerms = new ArrayList(); + List topicPerms = new ArrayList<>(); topicPerms.add("topicC=PUB|SUB"); topicPerms.add("topicB=PUB"); plainAccessConfig.setTopicPerms(topicPerms); - List groupPerms = new ArrayList(); + List groupPerms = new ArrayList<>(); groupPerms.add("groupB=PUB|SUB"); groupPerms.add("groupC=DENY"); plainAccessConfig.setGroupPerms(groupPerms); @@ -598,11 +598,11 @@ public class PlainAccessValidatorTest { plainAccessConfig1.setWhiteRemoteAddress("192.168.0.*"); plainAccessConfig1.setDefaultGroupPerm("PUB"); plainAccessConfig1.setDefaultTopicPerm("SUB"); - List topicPerms1 = new ArrayList(); + List topicPerms1 = new ArrayList<>(); topicPerms1.add("topicC=PUB|SUB"); topicPerms1.add("topicB=PUB"); plainAccessConfig1.setTopicPerms(topicPerms1); - List groupPerms1 = new ArrayList(); + List groupPerms1 = new ArrayList<>(); groupPerms1.add("groupB=PUB|SUB"); groupPerms1.add("groupC=DENY"); plainAccessConfig1.setGroupPerms(groupPerms1); @@ -658,11 +658,11 @@ public class PlainAccessValidatorTest { plainAccessConfig.setWhiteRemoteAddress("192.168.0.*"); plainAccessConfig.setDefaultGroupPerm("PUB"); plainAccessConfig.setDefaultTopicPerm("SUB"); - List topicPerms = new ArrayList(); + List topicPerms = new ArrayList<>(); topicPerms.add("topicC=PUB|SUB"); topicPerms.add("topicB=PUB"); plainAccessConfig.setTopicPerms(topicPerms); - List groupPerms = new ArrayList(); + List groupPerms = new ArrayList<>(); groupPerms.add("groupB=PUB|SUB"); groupPerms.add("groupC=DENY"); plainAccessConfig.setGroupPerms(groupPerms); @@ -1078,11 +1078,11 @@ public class PlainAccessValidatorTest { Map backUpAclConfigMap2 = AclUtils.getYamlDataObject(targetFileName2, Map.class); PlainAccessValidator plainAccessValidator = new PlainAccessValidator(); - List globalWhiteAddrsList1 = new ArrayList(); + List globalWhiteAddrsList1 = new ArrayList<>(); globalWhiteAddrsList1.add("10.10.154.1"); - List globalWhiteAddrsList2 = new ArrayList(); + List globalWhiteAddrsList2 = new ArrayList<>(); globalWhiteAddrsList2.add("10.10.154.2"); - List globalWhiteAddrsList3 = new ArrayList(); + List globalWhiteAddrsList3 = new ArrayList<>(); globalWhiteAddrsList3.add("10.10.154.3"); //Test parameter p is null diff --git a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionManagerTest.java b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionManagerTest.java index f30b6f57d3..2fc0912031 100644 --- a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionManagerTest.java +++ b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionManagerTest.java @@ -119,7 +119,7 @@ public class PlainPermissionManagerTest { plainAccessResource = plainPermissionManager.buildPlainAccessResource(plainAccess); Assert.assertEquals(plainAccessResource.isAdmin(), true); - List groups = new ArrayList(); + List groups = new ArrayList<>(); groups.add("groupA=DENY"); groups.add("groupB=PUB|SUB"); groups.add("groupC=PUB"); @@ -132,7 +132,7 @@ public class PlainPermissionManagerTest { Assert.assertEquals(resourcePermMap.get(PlainAccessResource.getRetryTopic("groupB")).byteValue(), Permission.PUB | Permission.SUB); Assert.assertEquals(resourcePermMap.get(PlainAccessResource.getRetryTopic("groupC")).byteValue(), Permission.PUB); - List topics = new ArrayList(); + List topics = new ArrayList<>(); topics.add("topicA=DENY"); topics.add("topicB=PUB|SUB"); topics.add("topicC=PUB"); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java index 5676dbd0a0..61098a178d 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java @@ -211,8 +211,8 @@ public class BrokerController { protected final BlockingQueue loadBalanceThreadPoolQueue; protected final FilterServerManager filterServerManager; protected final BrokerStatsManager brokerStatsManager; - protected final List sendMessageHookList = new ArrayList(); - protected final List consumeMessageHookList = new ArrayList(); + protected final List sendMessageHookList = new ArrayList<>(); + protected final List consumeMessageHookList = new ArrayList<>(); protected MessageStore messageStore; protected RemotingServer remotingServer; protected CountDownLatch remotingServerStartLatch; @@ -244,7 +244,7 @@ public class BrokerController { protected TransactionalMessageCheckService transactionalMessageCheckService; protected TransactionalMessageService transactionalMessageService; protected AbstractTransactionalMessageCheckListener transactionalMessageCheckListener; - protected Map accessValidatorMap = new HashMap(); + protected Map accessValidatorMap = new HashMap<>(); protected volatile boolean shutdown = false; protected ShutdownHook shutdownHook; private volatile boolean isScheduleServiceStart = false; @@ -327,20 +327,20 @@ public class BrokerController { this.slaveSynchronize = new SlaveSynchronize(this); this.endTransactionProcessor = new EndTransactionProcessor(this); - this.sendThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getSendThreadPoolQueueCapacity()); - this.putThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getPutThreadPoolQueueCapacity()); - this.pullThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getPullThreadPoolQueueCapacity()); - this.litePullThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getLitePullThreadPoolQueueCapacity()); + this.sendThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getSendThreadPoolQueueCapacity()); + this.putThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getPutThreadPoolQueueCapacity()); + this.pullThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getPullThreadPoolQueueCapacity()); + this.litePullThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getLitePullThreadPoolQueueCapacity()); - this.ackThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getAckThreadPoolQueueCapacity()); - this.replyThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getReplyThreadPoolQueueCapacity()); - this.queryThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getQueryThreadPoolQueueCapacity()); - this.clientManagerThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getClientManagerThreadPoolQueueCapacity()); - this.consumerManagerThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getConsumerManagerThreadPoolQueueCapacity()); - this.heartbeatThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getHeartbeatThreadPoolQueueCapacity()); - this.endTransactionThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getEndTransactionPoolQueueCapacity()); - this.adminBrokerThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getAdminBrokerThreadPoolQueueCapacity()); - this.loadBalanceThreadPoolQueue = new LinkedBlockingQueue(this.brokerConfig.getLoadBalanceThreadPoolQueueCapacity()); + this.ackThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getAckThreadPoolQueueCapacity()); + this.replyThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getReplyThreadPoolQueueCapacity()); + this.queryThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getQueryThreadPoolQueueCapacity()); + this.clientManagerThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getClientManagerThreadPoolQueueCapacity()); + this.consumerManagerThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getConsumerManagerThreadPoolQueueCapacity()); + this.heartbeatThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getHeartbeatThreadPoolQueueCapacity()); + this.endTransactionThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getEndTransactionPoolQueueCapacity()); + this.adminBrokerThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getAdminBrokerThreadPoolQueueCapacity()); + this.loadBalanceThreadPoolQueue = new LinkedBlockingQueue<>(this.brokerConfig.getLoadBalanceThreadPoolQueueCapacity()); this.brokerFastFailure = new BrokerFastFailure(this); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupInfo.java b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupInfo.java index 638c522feb..7ac01a3adf 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupInfo.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupInfo.java @@ -36,9 +36,9 @@ public class ConsumerGroupInfo { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME); private final String groupName; private final ConcurrentMap subscriptionTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private final ConcurrentMap channelInfoTable = - new ConcurrentHashMap(16); + new ConcurrentHashMap<>(16); private volatile ConsumeType consumeType; private volatile MessageModel messageModel; private volatile ConsumeFromWhere consumeFromWhere; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java index 6b41714691..ee11329e40 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java @@ -42,7 +42,7 @@ public class ConsumerManager { private static final InternalLogger LOGGER = InternalLoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME); private static final long CHANNEL_EXPIRED_TIMEOUT = 1000 * 120; private final ConcurrentMap consumerTable = - new ConcurrentHashMap(1024); + new ConcurrentHashMap<>(1024); private final List consumerIdsChangeListenerList = new CopyOnWriteArrayList<>(); protected final BrokerStatsManager brokerStatsManager; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java b/broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java index 2589ca1938..ee6644349e 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java @@ -82,12 +82,12 @@ public class ProducerManager { clientChannelInfo.getLastUpdateTimestamp() )); } else { - map.put(group, new ArrayList(Collections.singleton(new ProducerInfo( - clientChannelInfo.getClientId(), - clientChannelInfo.getChannel().remoteAddress().toString(), - clientChannelInfo.getLanguage(), - clientChannelInfo.getVersion(), - clientChannelInfo.getLastUpdateTimestamp() + map.put(group, new ArrayList<>(Collections.singleton(new ProducerInfo( + clientChannelInfo.getClientId(), + clientChannelInfo.getChannel().remoteAddress().toString(), + clientChannelInfo.getLanguage(), + clientChannelInfo.getVersion(), + clientChannelInfo.getLastUpdateTimestamp() )))); } } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java b/broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java index b78129c6c5..a64b2daa9c 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java @@ -118,7 +118,7 @@ public class Broker2Client { return response; } - Map offsetTable = new HashMap(); + Map offsetTable = new HashMap<>(); for (int i = 0; i < topicConfig.getWriteQueueNums(); i++) { MessageQueue mq = new MessageQueue(); @@ -238,7 +238,7 @@ public class Broker2Client { RemotingCommand.createRequestCommand(RequestCode.GET_CONSUMER_STATUS_FROM_CLIENT, requestHeader); - Map> consumerStatusTable = new HashMap>(); + Map> consumerStatusTable = new HashMap<>(); ConcurrentMap channelInfoTable = this.brokerController.getConsumerManager().getConsumerGroupInfo(group).getChannelInfoTable(); if (null == channelInfoTable || channelInfoTable.isEmpty()) { diff --git a/broker/src/main/java/org/apache/rocketmq/broker/client/rebalance/RebalanceLockManager.java b/broker/src/main/java/org/apache/rocketmq/broker/client/rebalance/RebalanceLockManager.java index a0abd70f88..b4942e8279 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/client/rebalance/RebalanceLockManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/client/rebalance/RebalanceLockManager.java @@ -34,7 +34,7 @@ public class RebalanceLockManager { "rocketmq.broker.rebalance.lockMaxLiveTime", "60000")); private final Lock lock = new ReentrantLock(); private final ConcurrentMap> mqLockTable = - new ConcurrentHashMap>(1024); + new ConcurrentHashMap<>(1024); public boolean isLockAllExpired(final String group) { final ConcurrentHashMap lockEntryMap = mqLockTable.get(group); @@ -124,8 +124,8 @@ public class RebalanceLockManager { public Set tryLockBatch(final String group, final Set mqs, final String clientId) { - Set lockedMqs = new HashSet(mqs.size()); - Set notLockedMqs = new HashSet(mqs.size()); + Set lockedMqs = new HashSet<>(mqs.size()); + Set notLockedMqs = new HashSet<>(mqs.size()); for (MessageQueue mq : mqs) { if (this.isLocked(group, mq, clientId)) { diff --git a/broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterManager.java b/broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterManager.java index 5f3b7eb7a6..749af7c664 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterManager.java @@ -48,7 +48,7 @@ public class ConsumerFilterManager extends ConfigManager { private static final long MS_24_HOUR = 24 * 3600 * 1000; private ConcurrentMap - filterDataByTopic = new ConcurrentHashMap(256); + filterDataByTopic = new ConcurrentHashMap<>(256); private transient BrokerController brokerController; private transient BloomFilter bloomFilter; @@ -176,7 +176,7 @@ public class ConsumerFilterManager extends ConfigManager { } public Collection getByGroup(final String consumerGroup) { - Collection ret = new HashSet(); + Collection ret = new HashSet<>(); Iterator topicIterator = this.filterDataByTopic.values().iterator(); while (topicIterator.hasNext()) { @@ -324,7 +324,7 @@ public class ConsumerFilterManager extends ConfigManager { public static class FilterDataMapByTopic { private ConcurrentMap - groupFilterData = new ConcurrentHashMap(); + groupFilterData = new ConcurrentHashMap<>(); private String topic; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/filter/MessageEvaluationContext.java b/broker/src/main/java/org/apache/rocketmq/broker/filter/MessageEvaluationContext.java index 84921f0d65..980b738dda 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/filter/MessageEvaluationContext.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/filter/MessageEvaluationContext.java @@ -48,7 +48,7 @@ public class MessageEvaluationContext implements EvaluationContext { return null; } - Map copy = new HashMap(properties.size(), 1); + Map copy = new HashMap<>(properties.size(), 1); for (Entry entry : properties.entrySet()) { copy.put(entry.getKey(), entry.getValue()); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerManager.java b/broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerManager.java index 8dd781e48f..10075f6bbd 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerManager.java @@ -41,7 +41,7 @@ public class FilterServerManager { public static final long FILTER_SERVER_MAX_IDLE_TIME_MILLS = 30000; private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME); private final ConcurrentMap filterServerTable = - new ConcurrentHashMap(16); + new ConcurrentHashMap<>(16); private final BrokerController brokerController; private ScheduledExecutorService scheduledExecutorService = Executors diff --git a/broker/src/main/java/org/apache/rocketmq/broker/latency/BrokerFixedThreadPoolExecutor.java b/broker/src/main/java/org/apache/rocketmq/broker/latency/BrokerFixedThreadPoolExecutor.java index 8060fd00c7..d2d1143a34 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/latency/BrokerFixedThreadPoolExecutor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/latency/BrokerFixedThreadPoolExecutor.java @@ -52,6 +52,6 @@ public class BrokerFixedThreadPoolExecutor extends ThreadPoolExecutor { @Override protected RunnableFuture newTaskFor(final Runnable runnable, final T value) { - return new FutureTaskExt(runnable, value); + return new FutureTaskExt<>(runnable, value); } } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/loadbalance/MessageRequestModeManager.java b/broker/src/main/java/org/apache/rocketmq/broker/loadbalance/MessageRequestModeManager.java index f3d382a886..cfd7d8379b 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/loadbalance/MessageRequestModeManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/loadbalance/MessageRequestModeManager.java @@ -28,7 +28,7 @@ public class MessageRequestModeManager extends ConfigManager { private transient BrokerController brokerController; private ConcurrentHashMap> - messageRequestModeMap = new ConcurrentHashMap>(); + messageRequestModeMap = new ConcurrentHashMap<>(); public MessageRequestModeManager() { // empty construct for decode @@ -41,7 +41,7 @@ public class MessageRequestModeManager extends ConfigManager { public void setMessageRequestMode(String topic, String consumerGroup, SetMessageRequestModeRequestBody requestBody) { ConcurrentHashMap consumerGroup2ModeMap = messageRequestModeMap.get(topic); if (consumerGroup2ModeMap == null) { - consumerGroup2ModeMap = new ConcurrentHashMap(); + consumerGroup2ModeMap = new ConcurrentHashMap<>(); ConcurrentHashMap pre = messageRequestModeMap.putIfAbsent(topic, consumerGroup2ModeMap); if (pre != null) { diff --git a/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java b/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java index bf3f66866f..f3cfc11e33 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java @@ -36,7 +36,7 @@ public class PullRequestHoldService extends ServiceThread { protected final BrokerController brokerController; private final SystemClock systemClock = new SystemClock(); protected ConcurrentMap pullRequestTable = - new ConcurrentHashMap(1024); + new ConcurrentHashMap<>(1024); public PullRequestHoldService(final BrokerController brokerController) { this.brokerController = brokerController; @@ -126,7 +126,7 @@ public class PullRequestHoldService extends ServiceThread { if (mpr != null) { List requestList = mpr.cloneListAndClear(); if (requestList != null) { - List replayList = new ArrayList(); + List replayList = new ArrayList<>(); for (PullRequest request : requestList) { long newestOffset = maxOffset; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManager.java b/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManager.java index 4eadaa8d05..02509f60df 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManager.java @@ -42,7 +42,7 @@ public class ConsumerOffsetManager extends ConfigManager { private DataVersion dataVersion = new DataVersion(); protected ConcurrentMap> offsetTable = - new ConcurrentHashMap>(512); + new ConcurrentHashMap<>(512); protected transient BrokerController brokerController; @@ -119,7 +119,7 @@ public class ConsumerOffsetManager extends ConfigManager { } public Set whichTopicByConsumer(final String group) { - Set topics = new HashSet(); + Set topics = new HashSet<>(); Iterator>> it = this.offsetTable.entrySet().iterator(); while (it.hasNext()) { @@ -137,7 +137,7 @@ public class ConsumerOffsetManager extends ConfigManager { } public Set whichGroupByTopic(final String topic) { - Set groups = new HashSet(); + Set groups = new HashSet<>(); Iterator>> it = this.offsetTable.entrySet().iterator(); while (it.hasNext()) { @@ -155,7 +155,7 @@ public class ConsumerOffsetManager extends ConfigManager { } public Map> getGroupTopicMap() { - Map> retMap = new HashMap>(128); + Map> retMap = new HashMap<>(128); for (String key : this.offsetTable.keySet()) { String[] arr = key.split(TOPIC_GROUP_SEPARATOR); @@ -165,7 +165,7 @@ public class ConsumerOffsetManager extends ConfigManager { Set topics = retMap.get(group); if (topics == null) { - topics = new HashSet(8); + topics = new HashSet<>(8); retMap.put(group, topics); } @@ -186,7 +186,7 @@ public class ConsumerOffsetManager extends ConfigManager { private void commitOffset(final String clientHost, final String key, final int queueId, final long offset) { ConcurrentMap map = this.offsetTable.get(key); if (null == map) { - map = new ConcurrentHashMap(32); + map = new ConcurrentHashMap<>(32); map.put(queueId, offset); this.offsetTable.put(key, map); } else { @@ -250,7 +250,7 @@ public class ConsumerOffsetManager extends ConfigManager { public Map queryMinOffsetInAllGroup(final String topic, final String filterGroups) { - Map queueMinOffset = new HashMap(); + Map queueMinOffset = new HashMap<>(); Set topicGroups = this.offsetTable.keySet(); if (!UtilAll.isBlank(filterGroups)) { for (String group : filterGroups.split(",")) { @@ -293,7 +293,7 @@ public class ConsumerOffsetManager extends ConfigManager { public void cloneOffset(final String srcGroup, final String destGroup, final String topic) { ConcurrentMap offsets = this.offsetTable.get(topic + TOPIC_GROUP_SEPARATOR + srcGroup); if (offsets != null) { - this.offsetTable.put(topic + TOPIC_GROUP_SEPARATOR + destGroup, new ConcurrentHashMap(offsets)); + this.offsetTable.put(topic + TOPIC_GROUP_SEPARATOR + destGroup, new ConcurrentHashMap<>(offsets)); } } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java b/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java index a91accb920..6438c8e26b 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java @@ -204,7 +204,7 @@ public class BrokerOuterAPI { public void updateNameServerAddressList(final String addrs) { String[] addrArray = addrs.split(";"); - List lst = new ArrayList(Arrays.asList(addrArray)); + List lst = new ArrayList<>(Arrays.asList(addrArray)); this.remotingClient.updateNameServerAddressList(lst); } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java index 7369e296c0..b7ee62c9b6 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java @@ -1462,7 +1462,7 @@ public class AdminBrokerProcessor implements NettyRequestProcessor { ConsumeStats consumeStats = new ConsumeStats(); - Set topics = new HashSet(); + Set topics = new HashSet<>(); if (UtilAll.isBlank(requestHeader.getTopic())) { topics = this.brokerController.getConsumerOffsetManager().whichTopicByConsumer(requestHeader.getConsumerGroup()); } else { @@ -1751,7 +1751,7 @@ public class AdminBrokerProcessor implements NettyRequestProcessor { return response; } - List timeSpanSet = new ArrayList(); + List timeSpanSet = new ArrayList<>(); for (int i = 0; i < topicConfig.getWriteQueueNums(); i++) { QueueTimeSpan timeSpan = new QueueTimeSpan(); MessageQueue mq = new MessageQueue(); @@ -1923,7 +1923,7 @@ public class AdminBrokerProcessor implements NettyRequestProcessor { if (UtilAll.isBlank(requestHeader.getTopic())) { topics = this.brokerController.getConsumerOffsetManager().whichTopicByConsumer(requestHeader.getSrcGroup()); } else { - topics = new HashSet(); + topics = new HashSet<>(); topics.add(requestHeader.getTopic()); } @@ -2015,14 +2015,14 @@ public class AdminBrokerProcessor implements NettyRequestProcessor { brokerController.getSubscriptionGroupManager().getSubscriptionGroupTable(); List>> brokerConsumeStatsList = - new ArrayList>>(); + new ArrayList<>(); long totalDiff = 0L; for (String group : subscriptionGroups.keySet()) { - Map> subscripTopicConsumeMap = new HashMap>(); + Map> subscripTopicConsumeMap = new HashMap<>(); Set topics = this.brokerController.getConsumerOffsetManager().whichTopicByConsumer(group); - List consumeStatsList = new ArrayList(); + List consumeStatsList = new ArrayList<>(); for (String topic : topics) { ConsumeStats consumeStats = new ConsumeStats(); TopicConfig topicConfig = this.brokerController.getTopicConfigManager().selectTopicConfig(topic); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java index 7eefe58767..68dece0090 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java @@ -94,7 +94,7 @@ public class PopReviveService extends ServiceThread { if (messageExt.getTags() != null) { msgInner.setTags(messageExt.getTags()); } else { - MessageAccessor.setProperties(msgInner, new HashMap()); + MessageAccessor.setProperties(msgInner, new HashMap<>()); } msgInner.setBornTimestamp(messageExt.getBornTimestamp()); msgInner.setBornHost(brokerController.getStoreHost()); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/QueryAssignmentProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/QueryAssignmentProcessor.java index 01fcc773fe..8d350c00b7 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/QueryAssignmentProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/QueryAssignmentProcessor.java @@ -55,7 +55,7 @@ public class QueryAssignmentProcessor implements NettyRequestProcessor { private final BrokerController brokerController; - private final ConcurrentHashMap name2LoadStrategy = new ConcurrentHashMap(); + private final ConcurrentHashMap name2LoadStrategy = new ConcurrentHashMap<>(); private MessageRequestModeManager messageRequestModeManager; @@ -130,7 +130,7 @@ public class QueryAssignmentProcessor implements NettyRequestProcessor { Set assignments = null; if (messageQueues != null) { - assignments = new HashSet(); + assignments = new HashSet<>(); for (MessageQueue messageQueue : messageQueues) { MessageQueueAssignment messageQueueAssignment = new MessageQueueAssignment(); messageQueueAssignment.setMessageQueue(messageQueue); @@ -196,7 +196,7 @@ public class QueryAssignmentProcessor implements NettyRequestProcessor { return null; } - List mqAll = new ArrayList(); + List mqAll = new ArrayList<>(); mqAll.addAll(mqSet); Collections.sort(mqAll); Collections.sort(cidAll); @@ -221,7 +221,7 @@ public class QueryAssignmentProcessor implements NettyRequestProcessor { return null; } - assignedQueueSet = new HashSet(); + assignedQueueSet = new HashSet<>(); if (allocateResult != null) { assignedQueueSet.addAll(allocateResult); } @@ -282,7 +282,7 @@ public class QueryAssignmentProcessor implements NettyRequestProcessor { throw new IllegalArgumentException("cidAll is null or cidAll empty"); } - List result = new ArrayList(); + List result = new ArrayList<>(); if (!cidAll.contains(currentCID)) { log.info("[BUG] ConsumerGroup: {} The consumerId: {} not in cidAll: {}", consumerGroup, diff --git a/broker/src/main/java/org/apache/rocketmq/broker/schedule/DelayOffsetSerializeWrapper.java b/broker/src/main/java/org/apache/rocketmq/broker/schedule/DelayOffsetSerializeWrapper.java index e867b62db9..751026b9b6 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/schedule/DelayOffsetSerializeWrapper.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/schedule/DelayOffsetSerializeWrapper.java @@ -23,7 +23,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class DelayOffsetSerializeWrapper extends RemotingSerializable { private ConcurrentMap offsetTable = - new ConcurrentHashMap(32); + new ConcurrentHashMap<>(32); private DataVersion dataVersion; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java index d9f419071a..a7dfbd1e92 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java @@ -67,10 +67,10 @@ public class ScheduleMessageService extends ConfigManager { private static final long DELAY_FOR_A_SLEEP = 10L; private final ConcurrentMap delayLevelTable = - new ConcurrentHashMap(32); + new ConcurrentHashMap<>(32); private final ConcurrentMap offsetTable = - new ConcurrentHashMap(32); + new ConcurrentHashMap<>(32); private final AtomicBoolean started = new AtomicBoolean(false); private ScheduledExecutorService deliverExecutorService; private int maxDelayLevel; @@ -305,7 +305,7 @@ public class ScheduleMessageService extends ConfigManager { } public boolean parseDelayLevel() { - HashMap timeUnitTable = new HashMap(); + HashMap timeUnitTable = new HashMap<>(); timeUnitTable.put("s", 1000L); timeUnitTable.put("m", 1000L * 60); timeUnitTable.put("h", 1000L * 60 * 60); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java index 17c3120808..b43579fae4 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java @@ -35,10 +35,10 @@ public class SubscriptionGroupManager extends ConfigManager { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME); private final ConcurrentMap subscriptionGroupTable = - new ConcurrentHashMap(1024); + new ConcurrentHashMap<>(1024); private final ConcurrentMap> forbiddenTable = - new ConcurrentHashMap>(4); + new ConcurrentHashMap<>(4); private final DataVersion dataVersion = new DataVersion(); private transient BrokerController brokerController; @@ -182,7 +182,7 @@ public class SubscriptionGroupManager extends ConfigManager { ConcurrentMap topicsPermMap = this.forbiddenTable.get(group); if (topicsPermMap == null) { - this.forbiddenTable.putIfAbsent(group, new ConcurrentHashMap()); + this.forbiddenTable.putIfAbsent(group, new ConcurrentHashMap<>()); topicsPermMap = this.forbiddenTable.get(group); } Integer old = topicsPermMap.put(topic, forbidden); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java b/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java index 2a2e3f3735..7028ba88bf 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java @@ -59,7 +59,7 @@ public class TopicConfigManager extends ConfigManager { private transient final Lock topicConfigTableLock = new ReentrantLock(); private final ConcurrentMap topicConfigTable = - new ConcurrentHashMap(1024); + new ConcurrentHashMap<>(1024); private final DataVersion dataVersion = new DataVersion(); private transient BrokerController brokerController; diff --git a/broker/src/main/java/org/apache/rocketmq/broker/transaction/AbstractTransactionalMessageCheckListener.java b/broker/src/main/java/org/apache/rocketmq/broker/transaction/AbstractTransactionalMessageCheckListener.java index 2ed0d9d1cd..beda6504c6 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/transaction/AbstractTransactionalMessageCheckListener.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/transaction/AbstractTransactionalMessageCheckListener.java @@ -97,7 +97,7 @@ public abstract class AbstractTransactionalMessageCheckListener { public synchronized void initExecutorService() { if (executorService == null) { - executorService = new ThreadPoolExecutor(2, 5, 100, TimeUnit.SECONDS, new ArrayBlockingQueue(2000), + executorService = new ThreadPoolExecutor(2, 5, 100, TimeUnit.SECONDS, new ArrayBlockingQueue<>(2000), new ThreadFactoryImpl("Transaction-msg-check-thread", brokerController.getBrokerIdentity()), new CallerRunsPolicy()); } } diff --git a/broker/src/test/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMapTest.java b/broker/src/test/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMapTest.java index 8f28832c0c..af1d06ea28 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMapTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMapTest.java @@ -55,7 +55,7 @@ public class CommitLogDispatcherCalcBitMapTest { filterManager); for (int i = 0; i < 1; i++) { - Map properties = new HashMap(4); + Map properties = new HashMap<>(4); properties.put("a", String.valueOf(i * 10 + 5)); String topic = "topic" + i; @@ -99,7 +99,7 @@ public class CommitLogDispatcherCalcBitMapTest { filterManager); for (int i = 0; i < 10; i++) { - Map properties = new HashMap(4); + Map properties = new HashMap<>(4); properties.put("a", String.valueOf(i * 10 + 5)); String topic = "topic" + i; @@ -136,7 +136,7 @@ public class CommitLogDispatcherCalcBitMapTest { filterManager); for (int i = 0; i < 10; i++) { - Map properties = new HashMap(4); + Map properties = new HashMap<>(4); properties.put("a", String.valueOf(i * 10 + 5)); String topic = "topic" + i; diff --git a/broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java b/broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java index 8c49581242..b5eebf0c6e 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java @@ -180,7 +180,7 @@ public class MessageStoreWithFilterTest { protected List putMsg(DefaultMessageStore master, int topicCount, int msgCountPerTopic) throws Exception { - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); for (int i = 0; i < topicCount; i++) { String realTopic = TOPIC + i; for (int j = 0; j < msgCountPerTopic; j++) { @@ -201,7 +201,7 @@ public class MessageStoreWithFilterTest { } protected List filtered(List msgs, ConsumerFilterData filterData) { - List filteredMsgs = new ArrayList(); + List filteredMsgs = new ArrayList<>(); for (MessageExtBrokerInner messageExtBrokerInner : msgs) { diff --git a/broker/src/test/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManagerTest.java b/broker/src/test/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManagerTest.java index 1df1adb1f9..4374164daf 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManagerTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManagerTest.java @@ -33,7 +33,7 @@ public class ConsumerOffsetManagerTest { @Before public void init() { consumerOffsetManager = new ConsumerOffsetManager(); - ConcurrentHashMap> offsetTable = new ConcurrentHashMap>(512); + ConcurrentHashMap> offsetTable = new ConcurrentHashMap<>(512); offsetTable.put(KEY,new ConcurrentHashMap() {{ put(1,2L); put(2,3L); diff --git a/broker/src/test/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessorTest.java b/broker/src/test/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessorTest.java index a60ba7715d..e604b63365 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessorTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessorTest.java @@ -121,7 +121,7 @@ public class ReplyMessageProcessorTest { requestHeader.setBornTimestamp(System.currentTimeMillis()); requestHeader.setFlag(124); requestHeader.setReconsumeTimes(0); - Map map = new HashMap(); + Map map = new HashMap<>(); map.put(MessageConst.PROPERTY_MESSAGE_REPLY_TO_CLIENT, "127.0.0.1"); requestHeader.setProperties(MessageDecoder.messageProperties2String(map)); return requestHeader; diff --git a/broker/src/test/java/org/apache/rocketmq/broker/schedule/ScheduleMessageServiceTest.java b/broker/src/test/java/org/apache/rocketmq/broker/schedule/ScheduleMessageServiceTest.java index 1e3ee5cc1b..d3f6753d23 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/schedule/ScheduleMessageServiceTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/schedule/ScheduleMessageServiceTest.java @@ -219,7 +219,7 @@ public class ScheduleMessageServiceTest { // timer run maybe delay, then consumer message again // and wait offsetTable TimeUnit.SECONDS.sleep(15); - scheduleMessageService.buildRunningStats(new HashMap()); + scheduleMessageService.buildRunningStats(new HashMap<>()); messageResult = getMessage(realQueueId, offset); // now,found the message diff --git a/broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java b/broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java index edac5c2396..bf00ea7991 100644 --- a/broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java +++ b/broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java @@ -73,7 +73,7 @@ public class TopicQueueMappingManagerTest { public void testEncodeDecode() throws Exception { Map mappingDetailMap = new HashMap<>(); TopicQueueMappingManager topicQueueMappingManager = null; - Set brokers = new HashSet(); + Set brokers = new HashSet<>(); brokers.add(BROKER1_NAME); { for (int i = 0; i < 10; i++) { diff --git a/client/src/main/java/org/apache/rocketmq/client/ClientConfig.java b/client/src/main/java/org/apache/rocketmq/client/ClientConfig.java index bebe6b1027..30b9955351 100644 --- a/client/src/main/java/org/apache/rocketmq/client/ClientConfig.java +++ b/client/src/main/java/org/apache/rocketmq/client/ClientConfig.java @@ -125,7 +125,7 @@ public class ClientConfig { } public Set withNamespace(Set resourceSet) { - Set resourceWithNamespace = new HashSet(); + Set resourceWithNamespace = new HashSet<>(); for (String resource : resourceSet) { resourceWithNamespace.add(withNamespace(resource)); } @@ -137,7 +137,7 @@ public class ClientConfig { } public Set withoutNamespace(Set resourceSet) { - Set resourceWithoutNamespace = new HashSet(); + Set resourceWithoutNamespace = new HashSet<>(); for (String resource : resourceSet) { resourceWithoutNamespace.add(withoutNamespace(resource)); } diff --git a/client/src/main/java/org/apache/rocketmq/client/MQHelper.java b/client/src/main/java/org/apache/rocketmq/client/MQHelper.java index cfd0b7ee1c..08ab172b60 100644 --- a/client/src/main/java/org/apache/rocketmq/client/MQHelper.java +++ b/client/src/main/java/org/apache/rocketmq/client/MQHelper.java @@ -60,7 +60,7 @@ public class MQHelper { try { mqs = consumer.fetchSubscribeMessageQueues(topic); if (mqs != null && !mqs.isEmpty()) { - TreeSet mqsNew = new TreeSet(mqs); + TreeSet mqsNew = new TreeSet<>(mqs); for (MessageQueue mq : mqsNew) { long offset = consumer.searchOffset(mq, timestamp); if (offset >= 0) { diff --git a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java index c345a266b8..5fd41c8178 100644 --- a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java +++ b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java @@ -20,7 +20,7 @@ package org.apache.rocketmq.client.common; import java.util.Random; public class ThreadLocalIndex { - private final ThreadLocal threadLocalIndex = new ThreadLocal(); + private final ThreadLocal threadLocalIndex = new ThreadLocal<>(); private final Random random = new Random(); private final static int POSITIVE_MASK = 0x7FFFFFFF; diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumer.java b/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumer.java index 2747fabbba..c0c592a1c2 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumer.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumer.java @@ -76,7 +76,7 @@ public class DefaultMQPullConsumer extends ClientConfig implements MQPullConsume /** * Topic set you want to register */ - private Set registerTopics = new HashSet(); + private Set registerTopics = new HashSet<>(); /** * Queue allocation algorithm */ diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java b/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java index a2a857f574..9f18730a1d 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java @@ -142,7 +142,7 @@ public class DefaultMQPushConsumer extends ClientConfig implements MQPushConsume /** * Subscription relationship */ - private Map subscription = new HashMap(); + private Map subscription = new HashMap<>(); /** * Message listener @@ -670,7 +670,7 @@ public class DefaultMQPushConsumer extends ClientConfig implements MQPushConsume */ @Deprecated public void setSubscription(Map subscription) { - Map subscriptionWithNamespace = new HashMap(subscription.size(), 1); + Map subscriptionWithNamespace = new HashMap<>(subscription.size(), 1); for (Entry topicEntry : subscription.entrySet()) { subscriptionWithNamespace.put(withNamespace(topicEntry.getKey()), topicEntry.getValue()); } diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumerScheduleService.java b/client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumerScheduleService.java index 6a5e714fbb..d03aa0f76e 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumerScheduleService.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumerScheduleService.java @@ -41,11 +41,11 @@ public class MQPullConsumerScheduleService { private final InternalLogger log = ClientLogger.getLog(); private final MessageQueueListener messageQueueListener = new MessageQueueListenerImpl(); private final ConcurrentMap taskTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private DefaultMQPullConsumer defaultMQPullConsumer; private int pullThreadNums = 20; private ConcurrentMap callbackTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private ScheduledThreadPoolExecutor scheduledThreadPoolExecutor; public MQPullConsumerScheduleService(final String consumerGroup) { diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearby.java b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearby.java index 415a5fa510..08e95dc588 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearby.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearby.java @@ -56,18 +56,18 @@ public class AllocateMachineRoomNearby extends AbstractAllocateMessageQueueStrat public List allocate(String consumerGroup, String currentCID, List mqAll, List cidAll) { - List result = new ArrayList(); + List result = new ArrayList<>(); if (!check(consumerGroup, currentCID, mqAll, cidAll)) { return result; } //group mq by machine room - Map> mr2Mq = new TreeMap>(); + Map> mr2Mq = new TreeMap<>(); for (MessageQueue mq : mqAll) { String brokerMachineRoom = machineRoomResolver.brokerDeployIn(mq); if (StringUtils.isNoneEmpty(brokerMachineRoom)) { if (mr2Mq.get(brokerMachineRoom) == null) { - mr2Mq.put(brokerMachineRoom, new ArrayList()); + mr2Mq.put(brokerMachineRoom, new ArrayList<>()); } mr2Mq.get(brokerMachineRoom).add(mq); } else { @@ -76,12 +76,12 @@ public class AllocateMachineRoomNearby extends AbstractAllocateMessageQueueStrat } //group consumer by machine room - Map> mr2c = new TreeMap>(); + Map> mr2c = new TreeMap<>(); for (String cid : cidAll) { String consumerMachineRoom = machineRoomResolver.consumerDeployIn(cid); if (StringUtils.isNoneEmpty(consumerMachineRoom)) { if (mr2c.get(consumerMachineRoom) == null) { - mr2c.put(consumerMachineRoom, new ArrayList()); + mr2c.put(consumerMachineRoom, new ArrayList<>()); } mr2c.get(consumerMachineRoom).add(cid); } else { @@ -89,7 +89,7 @@ public class AllocateMachineRoomNearby extends AbstractAllocateMessageQueueStrat } } - List allocateResults = new ArrayList(); + List allocateResults = new ArrayList<>(); //1.allocate the mq that deploy in the same machine room with the current consumer String currentMachineRoom = machineRoomResolver.consumerDeployIn(currentCID); diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java index f420fb2556..c3d3dbcd4a 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java @@ -39,7 +39,7 @@ public class AllocateMessageQueueAveragely extends AbstractAllocateMessageQueueS public List allocate(String consumerGroup, String currentCID, List mqAll, List cidAll) { - List result = new ArrayList(); + List result = new ArrayList<>(); if (!check(consumerGroup, currentCID, mqAll, cidAll)) { return result; } diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircle.java b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircle.java index 744c2ac12d..10f8c9de18 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircle.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircle.java @@ -39,7 +39,7 @@ public class AllocateMessageQueueAveragelyByCircle extends AbstractAllocateMessa public List allocate(String consumerGroup, String currentCID, List mqAll, List cidAll) { - List result = new ArrayList(); + List result = new ArrayList<>(); if (!check(consumerGroup, currentCID, mqAll, cidAll)) { return result; } diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoom.java b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoom.java index 289242f8d8..4a2ba888a9 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoom.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoom.java @@ -31,7 +31,7 @@ public class AllocateMessageQueueByMachineRoom extends AbstractAllocateMessageQu public List allocate(String consumerGroup, String currentCID, List mqAll, List cidAll) { - List result = new ArrayList(); + List result = new ArrayList<>(); if (!check(consumerGroup, currentCID, mqAll, cidAll)) { return result; } @@ -39,7 +39,7 @@ public class AllocateMessageQueueByMachineRoom extends AbstractAllocateMessageQu if (currentIndex < 0) { return result; } - List premqAll = new ArrayList(); + List premqAll = new ArrayList<>(); for (MessageQueue mq : mqAll) { String[] temp = mq.getBrokerName().split("@"); if (temp.length == 2 && consumeridcs.contains(temp[0])) { diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsistentHash.java b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsistentHash.java index 7dededa764..eea19ed7fe 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsistentHash.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsistentHash.java @@ -52,24 +52,24 @@ public class AllocateMessageQueueConsistentHash extends AbstractAllocateMessageQ public List allocate(String consumerGroup, String currentCID, List mqAll, List cidAll) { - List result = new ArrayList(); + List result = new ArrayList<>(); if (!check(consumerGroup, currentCID, mqAll, cidAll)) { return result; } - Collection cidNodes = new ArrayList(); + Collection cidNodes = new ArrayList<>(); for (String cid : cidAll) { cidNodes.add(new ClientNode(cid)); } final ConsistentHashRouter router; //for building hash ring if (customHashFunction != null) { - router = new ConsistentHashRouter(cidNodes, virtualNodeCnt, customHashFunction); + router = new ConsistentHashRouter<>(cidNodes, virtualNodeCnt, customHashFunction); } else { - router = new ConsistentHashRouter(cidNodes, virtualNodeCnt); + router = new ConsistentHashRouter<>(cidNodes, virtualNodeCnt); } - List results = new ArrayList(); + List results = new ArrayList<>(); for (MessageQueue mq : mqAll) { ClientNode clientNode = router.routeNode(mq.toString()); if (clientNode != null && currentCID.equals(clientNode.getKey())) { diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java b/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java index f949b75a81..108130d515 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java @@ -48,7 +48,7 @@ public class LocalFileOffsetStore implements OffsetStore { private final String groupName; private final String storePath; private ConcurrentMap offsetTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); public LocalFileOffsetStore(MQClientInstance mQClientFactory, String groupName) { this.mQClientFactory = mQClientFactory; @@ -169,7 +169,7 @@ public class LocalFileOffsetStore implements OffsetStore { @Override public Map cloneOffsetTable(String topic) { - Map cloneOffsetTable = new HashMap(this.offsetTable.size(), 1); + Map cloneOffsetTable = new HashMap<>(this.offsetTable.size(), 1); for (Map.Entry entry : this.offsetTable.entrySet()) { MessageQueue mq = entry.getKey(); if (!UtilAll.isBlank(topic) && !topic.equals(mq.getTopic())) { diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/store/OffsetSerializeWrapper.java b/client/src/main/java/org/apache/rocketmq/client/consumer/store/OffsetSerializeWrapper.java index 7dfd97af6a..85fe0d4398 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/store/OffsetSerializeWrapper.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/store/OffsetSerializeWrapper.java @@ -27,7 +27,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; */ public class OffsetSerializeWrapper extends RemotingSerializable { private ConcurrentMap offsetTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); public ConcurrentMap getOffsetTable() { return offsetTable; diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java b/client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java index 6c393cade9..74d931338a 100644 --- a/client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java +++ b/client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java @@ -46,7 +46,7 @@ public class RemoteBrokerOffsetStore implements OffsetStore { private final MQClientInstance mQClientFactory; private final String groupName; private ConcurrentMap offsetTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); public RemoteBrokerOffsetStore(MQClientInstance mQClientFactory, String groupName) { this.mQClientFactory = mQClientFactory; @@ -118,7 +118,7 @@ public class RemoteBrokerOffsetStore implements OffsetStore { if (null == mqs || mqs.isEmpty()) return; - final HashSet unusedMQ = new HashSet(); + final HashSet unusedMQ = new HashSet<>(); for (Map.Entry entry : this.offsetTable.entrySet()) { MessageQueue mq = entry.getKey(); @@ -176,7 +176,7 @@ public class RemoteBrokerOffsetStore implements OffsetStore { @Override public Map cloneOffsetTable(String topic) { - Map cloneOffsetTable = new HashMap(this.offsetTable.size(), 1); + Map cloneOffsetTable = new HashMap<>(this.offsetTable.size(), 1); for (Map.Entry entry : this.offsetTable.entrySet()) { MessageQueue mq = entry.getKey(); if (!UtilAll.isBlank(topic) && !topic.equals(mq.getTopic())) { diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java index 6b9e6b38e1..d0ac6401ef 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java @@ -153,7 +153,7 @@ public class ClientRemotingProcessor implements NettyRequestProcessor { log.info("invoke reset offset operation from broker. brokerAddr={}, topic={}, group={}, timestamp={}", RemotingHelper.parseChannelRemoteAddr(ctx.channel()), requestHeader.getTopic(), requestHeader.getGroup(), requestHeader.getTimestamp()); - Map offsetTable = new HashMap(); + Map offsetTable = new HashMap<>(); if (request.getBody() != null) { ResetOffsetBody body = ResetOffsetBody.decode(request.getBody(), ResetOffsetBody.class); offsetTable = body.getOffsetTable(); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java index 44e5b7204d..6aaadd88ae 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java @@ -155,7 +155,7 @@ public class MQAdminImpl { } public List parsePublishMessageQueues(List messageQueueList) { - List resultQueues = new ArrayList(); + List resultQueues = new ArrayList<>(); for (MessageQueue queue : messageQueueList) { String userTopic = NamespaceUtil.withoutNamespace(queue.getTopic(), this.mQClientFactory.getClientConfig().getNamespace()); resultQueues.add(new MessageQueue(userTopic, queue.getBrokerName(), queue.getQueueId())); @@ -321,7 +321,7 @@ public class MQAdminImpl { } if (topicRouteData != null) { - List brokerAddrs = new LinkedList(); + List brokerAddrs = new LinkedList<>(); for (BrokerData brokerData : topicRouteData.getBrokerDatas()) { if (clusterName != null && !clusterName.isEmpty() && !clusterName.equals(brokerData.getCluster())) { @@ -335,7 +335,7 @@ public class MQAdminImpl { if (!brokerAddrs.isEmpty()) { final CountDownLatch countDownLatch = new CountDownLatch(brokerAddrs.size()); - final List queryResultList = new LinkedList(); + final List queryResultList = new LinkedList<>(); final ReadWriteLock lock = new ReentrantReadWriteLock(false); for (String addr : brokerAddrs) { @@ -402,7 +402,7 @@ public class MQAdminImpl { } long indexLastUpdateTimestamp = 0; - List messageList = new LinkedList(); + List messageList = new LinkedList<>(); for (QueryResult qr : queryResultList) { if (qr.getIndexLastUpdateTimestamp() > indexLastUpdateTimestamp) { indexLastUpdateTimestamp = qr.getIndexLastUpdateTimestamp(); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java index aa22805913..145a44d634 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java @@ -492,7 +492,7 @@ public class MQClientAPIImpl implements NameServerUpdateCallback { clusterAclVersionInfo.setBrokerAddr(responseHeader.getBrokerAddr()); clusterAclVersionInfo.setAclConfigDataVersion(DataVersion.fromJson(responseHeader.getVersion(), DataVersion.class)); HashMap dataVersionMap = JSON.parseObject(responseHeader.getAllAclFileVersion(), HashMap.class); - Map allAclConfigDataVersion = new HashMap(dataVersionMap.size(), 1); + Map allAclConfigDataVersion = new HashMap<>(dataVersionMap.size(), 1); for (Map.Entry entry : dataVersionMap.entrySet()) { allAclConfigDataVersion.put(entry.getKey(), DataVersion.fromJson(JSON.toJSONString(entry.getValue()), DataVersion.class)); } @@ -1079,15 +1079,15 @@ public class MQClientAPIImpl implements NameServerUpdateCallback { msgOffsetInfo = ExtraInfoUtil.parseMsgOffsetInfo(responseHeader.getMsgOffsetInfo()); orderCountInfo = ExtraInfoUtil.parseOrderCountInfo(responseHeader.getOrderCountInfo()); } - Map/*msg queueOffset*/> sortMap = new HashMap>(16); + Map/*msg queueOffset*/> sortMap = new HashMap<>(16); for (MessageExt messageExt : msgFoundList) { String key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(), messageExt.getQueueId()); if (!sortMap.containsKey(key)) { - sortMap.put(key, new ArrayList(4)); + sortMap.put(key, new ArrayList<>(4)); } sortMap.get(key).add(messageExt.getQueueOffset()); } - Map map = new HashMap(5); + Map map = new HashMap<>(5); for (MessageExt messageExt : msgFoundList) { if (requestHeader instanceof PopMessageRequestHeader) { if (startOffsetInfo == null) { @@ -2706,7 +2706,7 @@ public class MQClientAPIImpl implements NameServerUpdateCallback { RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.GET_NAMESRV_CONFIG, null); - Map configMap = new HashMap(4); + Map configMap = new HashMap<>(4); for (String nameServer : invokeNameServers) { RemotingCommand response = this.remotingClient.invokeSync(nameServer, request, timeoutMillis); @@ -2989,7 +2989,7 @@ public class MQClientAPIImpl implements NameServerUpdateCallback { RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.GET_CONTROLLER_CONFIG, null); - Map configMap = new HashMap(4); + Map configMap = new HashMap<>(4); for (String controller : invokeControllerServers) { RemotingCommand response = this.remotingClient.invokeSync(controller, request, timeoutMillis); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java index 053c049c9c..3f4bda7cc6 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java @@ -30,7 +30,7 @@ public class MQClientManager { private static MQClientManager instance = new MQClientManager(); private AtomicInteger factoryIndexGenerator = new AtomicInteger(); private ConcurrentMap factoryTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private MQClientManager() { diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java index 4d18a9be1b..5f89c3c6cd 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java @@ -30,7 +30,7 @@ public class AssignedMessageQueue { private RebalanceImpl rebalanceImpl; public AssignedMessageQueue() { - assignedMessageQueueState = new ConcurrentHashMap(); + assignedMessageQueueState = new ConcurrentHashMap<>(); } public void setRebalanceImpl(RebalanceImpl rebalanceImpl) { diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java index 18bd8b3e48..0fbdc5cedd 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java @@ -67,7 +67,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService this.defaultMQPushConsumer = this.defaultMQPushConsumerImpl.getDefaultMQPushConsumer(); this.consumerGroup = this.defaultMQPushConsumer.getConsumerGroup(); - this.consumeRequestQueue = new LinkedBlockingQueue(); + this.consumeRequestQueue = new LinkedBlockingQueue<>(); String consumeThreadPrefix = null; if (consumerGroup.length() > 100) { @@ -139,7 +139,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService result.setAutoCommit(true); msg.setBrokerName(brokerName); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); msgs.add(msg); MessageQueue mq = new MessageQueue(); mq.setBrokerName(brokerName); @@ -204,7 +204,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService } } else { for (int total = 0; total < msgs.size(); ) { - List msgThis = new ArrayList(consumeBatchSize); + List msgThis = new ArrayList<>(consumeBatchSize); for (int i = 0; i < consumeBatchSize; i++, total++) { if (total < msgs.size()) { msgThis.add(msgs.get(total)); @@ -281,7 +281,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService } break; case CLUSTERING: - List msgBackFailed = new ArrayList(consumeRequest.getMsgs().size()); + List msgBackFailed = new ArrayList<>(consumeRequest.getMsgs().size()); for (int i = ackIndex + 1; i < consumeRequest.getMsgs().size(); i++) { MessageExt msg = consumeRequest.getMsgs().get(i); boolean result = this.sendMessageBack(msg, context); @@ -390,7 +390,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService consumeMessageContext = new ConsumeMessageContext(); consumeMessageContext.setNamespace(defaultMQPushConsumer.getNamespace()); consumeMessageContext.setConsumerGroup(defaultMQPushConsumer.getConsumerGroup()); - consumeMessageContext.setProps(new HashMap()); + consumeMessageContext.setProps(new HashMap<>()); consumeMessageContext.setMq(messageQueue); consumeMessageContext.setMsgList(msgs); consumeMessageContext.setSuccess(false); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java index 4f4f98c98a..46baee9180 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java @@ -72,7 +72,7 @@ public class ConsumeMessageOrderlyService implements ConsumeMessageService { this.defaultMQPushConsumer = this.defaultMQPushConsumerImpl.getDefaultMQPushConsumer(); this.consumerGroup = this.defaultMQPushConsumer.getConsumerGroup(); - this.consumeRequestQueue = new LinkedBlockingQueue(); + this.consumeRequestQueue = new LinkedBlockingQueue<>(); String consumeThreadPrefix = null; if (consumerGroup.length() > 100) { @@ -146,7 +146,7 @@ public class ConsumeMessageOrderlyService implements ConsumeMessageService { ConsumeMessageDirectlyResult result = new ConsumeMessageDirectlyResult(); result.setOrder(true); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); msgs.add(msg); MessageQueue mq = new MessageQueue(); mq.setBrokerName(brokerName); @@ -486,7 +486,7 @@ public class ConsumeMessageOrderlyService implements ConsumeMessageService { consumeMessageContext.setMsgList(msgs); consumeMessageContext.setSuccess(false); // init the consume context type - consumeMessageContext.setProps(new HashMap()); + consumeMessageContext.setProps(new HashMap<>()); ConsumeMessageOrderlyService.this.defaultMQPushConsumerImpl.executeHookBefore(consumeMessageContext); } diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopConcurrentlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopConcurrentlyService.java index 5f5c422aae..dd246126e3 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopConcurrentlyService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopConcurrentlyService.java @@ -68,7 +68,7 @@ public class ConsumeMessagePopConcurrentlyService implements ConsumeMessageServi this.defaultMQPushConsumer = this.defaultMQPushConsumerImpl.getDefaultMQPushConsumer(); this.consumerGroup = this.defaultMQPushConsumer.getConsumerGroup(); - this.consumeRequestQueue = new LinkedBlockingQueue(); + this.consumeRequestQueue = new LinkedBlockingQueue<>(); this.consumeExecutor = new ThreadPoolExecutor( this.defaultMQPushConsumer.getConsumeThreadMin(), @@ -118,7 +118,7 @@ public class ConsumeMessagePopConcurrentlyService implements ConsumeMessageServi result.setOrder(false); result.setAutoCommit(true); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); msgs.add(msg); MessageQueue mq = new MessageQueue(); mq.setBrokerName(brokerName); @@ -188,7 +188,7 @@ public class ConsumeMessagePopConcurrentlyService implements ConsumeMessageServi } } else { for (int total = 0; total < msgs.size(); ) { - List msgThis = new ArrayList(consumeBatchSize); + List msgThis = new ArrayList<>(consumeBatchSize); for (int i = 0; i < consumeBatchSize; i++, total++) { if (total < msgs.size()) { msgThis.add(msgs.get(total)); @@ -405,7 +405,7 @@ public class ConsumeMessagePopConcurrentlyService implements ConsumeMessageServi consumeMessageContext = new ConsumeMessageContext(); consumeMessageContext.setNamespace(defaultMQPushConsumer.getNamespace()); consumeMessageContext.setConsumerGroup(defaultMQPushConsumer.getConsumerGroup()); - consumeMessageContext.setProps(new HashMap()); + consumeMessageContext.setProps(new HashMap<>()); consumeMessageContext.setMq(messageQueue); consumeMessageContext.setMsgList(msgs); consumeMessageContext.setSuccess(false); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopOrderlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopOrderlyService.java index a5e760de82..4e0bf02ae3 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopOrderlyService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessagePopOrderlyService.java @@ -54,7 +54,7 @@ public class ConsumeMessagePopOrderlyService implements ConsumeMessageService { private final DefaultMQPushConsumer defaultMQPushConsumer; private final MessageListenerOrderly messageListener; private final BlockingQueue consumeRequestQueue; - private final ConcurrentSet consumeRequestSet = new ConcurrentSet(); + private final ConcurrentSet consumeRequestSet = new ConcurrentSet<>(); private final ThreadPoolExecutor consumeExecutor; private final String consumerGroup; private final MessageQueueLock messageQueueLock = new MessageQueueLock(); @@ -69,7 +69,7 @@ public class ConsumeMessagePopOrderlyService implements ConsumeMessageService { this.defaultMQPushConsumer = this.defaultMQPushConsumerImpl.getDefaultMQPushConsumer(); this.consumerGroup = this.defaultMQPushConsumer.getConsumerGroup(); - this.consumeRequestQueue = new LinkedBlockingQueue(); + this.consumeRequestQueue = new LinkedBlockingQueue<>(); this.consumeExecutor = new ThreadPoolExecutor( this.defaultMQPushConsumer.getConsumeThreadMin(), @@ -135,7 +135,7 @@ public class ConsumeMessagePopOrderlyService implements ConsumeMessageService { ConsumeMessageDirectlyResult result = new ConsumeMessageDirectlyResult(); result.setOrder(true); - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); msgs.add(msg); MessageQueue mq = new MessageQueue(); mq.setBrokerName(brokerName); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java index 1e40ddaf63..90dc9b3b92 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java @@ -84,7 +84,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { private final RPCHook rpcHook; - private final ArrayList filterMessageHookList = new ArrayList(); + private final ArrayList filterMessageHookList = new ArrayList<>(); private volatile ServiceState serviceState = ServiceState.CREATE_JUST; @@ -127,19 +127,19 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { private DefaultLitePullConsumer defaultLitePullConsumer; private final ConcurrentMap taskTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private AssignedMessageQueue assignedMessageQueue = new AssignedMessageQueue(); - private final BlockingQueue consumeRequestCache = new LinkedBlockingQueue(); + private final BlockingQueue consumeRequestCache = new LinkedBlockingQueue<>(); private ScheduledThreadPoolExecutor scheduledThreadPoolExecutor; private final ScheduledExecutorService scheduledExecutorService; - private Map topicMessageQueueChangeListenerMap = new HashMap(); + private Map topicMessageQueueChangeListenerMap = new HashMap<>(); - private Map> messageQueuesForTopic = new HashMap>(); + private Map> messageQueuesForTopic = new HashMap<>(); private long consumeRequestFlowControlTimes = 0L; @@ -151,7 +151,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { private final MessageQueueLock messageQueueLock = new MessageQueueLock(); - private final ArrayList consumeMessageHookList = new ArrayList(); + private final ArrayList consumeMessageHookList = new ArrayList<>(); // only for test purpose, will be modified by reflection in unit test. @SuppressWarnings("FieldMayBeFinal") private static boolean doNotUpdateTopicSubscribeInfoWhenSubscriptionChanged = false; @@ -1096,7 +1096,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { @Override public Set subscriptions() { - Set subSet = new HashSet(); + Set subSet = new HashSet<>(); subSet.addAll(this.rebalanceImpl.getSubscriptionInner().values()); @@ -1114,7 +1114,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { public void persistConsumerOffset() { try { checkServiceState(); - Set mqs = new HashSet(); + Set mqs = new HashSet<>(); if (this.subscriptionType == SubscriptionType.SUBSCRIBE) { Set allocateMq = this.rebalanceImpl.getProcessQueueTable().keySet(); mqs.addAll(allocateMq); @@ -1242,7 +1242,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner { } private Set parseMessageQueues(Set queueSet) { - Set resultQueues = new HashSet(); + Set resultQueues = new HashSet<>(); for (MessageQueue messageQueue : queueSet) { String userTopic = NamespaceUtil.withoutNamespace(messageQueue.getTopic(), this.defaultLitePullConsumer.getNamespace()); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java index 77c9134050..66f3578fe0 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java @@ -76,8 +76,8 @@ public class DefaultMQPullConsumerImpl implements MQConsumerInner { private final DefaultMQPullConsumer defaultMQPullConsumer; private final long consumerStartTimestamp = System.currentTimeMillis(); private final RPCHook rpcHook; - private final ArrayList consumeMessageHookList = new ArrayList(); - private final ArrayList filterMessageHookList = new ArrayList(); + private final ArrayList consumeMessageHookList = new ArrayList<>(); + private final ArrayList filterMessageHookList = new ArrayList<>(); private volatile ServiceState serviceState = ServiceState.CREATE_JUST; protected MQClientInstance mQClientFactory; private PullAPIWrapper pullAPIWrapper; @@ -124,7 +124,7 @@ public class DefaultMQPullConsumerImpl implements MQConsumerInner { } ConcurrentMap mqTable = this.rebalanceImpl.getProcessQueueTable(); - Set mqResult = new HashSet(); + Set mqResult = new HashSet<>(); for (MessageQueue mq : mqTable.keySet()) { if (mq.getTopic().equals(topic)) { mqResult.add(mq); @@ -151,7 +151,7 @@ public class DefaultMQPullConsumerImpl implements MQConsumerInner { } public Set parseSubscribeMessageQueues(Set queueSet) { - Set resultQueues = new HashSet(); + Set resultQueues = new HashSet<>(); for (MessageQueue messageQueue : queueSet) { String userTopic = NamespaceUtil.withoutNamespace(messageQueue.getTopic(), this.defaultMQPullConsumer.getNamespace()); @@ -355,7 +355,7 @@ public class DefaultMQPullConsumerImpl implements MQConsumerInner { @Override public Set subscriptions() { - Set result = new HashSet(); + Set result = new HashSet<>(); Set topics = this.defaultMQPullConsumer.getRegisterTopics(); if (topics != null) { @@ -389,7 +389,7 @@ public class DefaultMQPullConsumerImpl implements MQConsumerInner { public void persistConsumerOffset() { try { this.isRunning(); - Set mqs = new HashSet(); + Set mqs = new HashSet<>(); Set allocateMq = this.rebalanceImpl.getProcessQueueTable().keySet(); mqs.addAll(allocateMq); this.offsetStore.persistAll(mqs); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java index 789852a6cf..7dc212dd14 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java @@ -113,9 +113,9 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { private final InternalLogger log = ClientLogger.getLog(); private final DefaultMQPushConsumer defaultMQPushConsumer; private final RebalanceImpl rebalanceImpl = new RebalancePushImpl(this); - private final ArrayList filterMessageHookList = new ArrayList(); + private final ArrayList filterMessageHookList = new ArrayList<>(); private final long consumerStartTimestamp = System.currentTimeMillis(); - private final ArrayList consumeMessageHookList = new ArrayList(); + private final ArrayList consumeMessageHookList = new ArrayList<>(); private final RPCHook rpcHook; private volatile ServiceState serviceState = ServiceState.CREATE_JUST; private MQClientInstance mQClientFactory; @@ -204,7 +204,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { } public Set parseSubscribeMessageQueues(Set messageQueueList) { - Set resultQueues = new HashSet(); + Set resultQueues = new HashSet<>(); for (MessageQueue queue : messageQueueList) { String userTopic = NamespaceUtil.withoutNamespace(queue.getTopic(), this.defaultMQPushConsumer.getNamespace()); resultQueues.add(new MessageQueue(userTopic, queue.getBrokerName(), queue.getQueueId())); @@ -605,7 +605,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { List msgListFilterAgain = msgFoundList; if (!subscriptionData.getTagsSet().isEmpty() && !subscriptionData.isClassFilterMode() && popResult.getMsgFoundList().size() > 0) { - msgListFilterAgain = new ArrayList(popResult.getMsgFoundList().size()); + msgListFilterAgain = new ArrayList<>(popResult.getMsgFoundList().size()); for (MessageExt msg : popResult.getMsgFoundList()) { if (msg.getTags() != null) { if (subscriptionData.getTagsSet().contains(msg.getTags())) { @@ -1297,7 +1297,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { for (String topic : rebalanceImpl.getSubscriptionInner().keySet()) { Set mqs = rebalanceImpl.getTopicSubscribeInfoTable().get(topic); if (CollectionUtils.isNotEmpty(mqs)) { - Map offsetTable = new HashMap(mqs.size(), 1); + Map offsetTable = new HashMap<>(mqs.size(), 1); for (MessageQueue mq : mqs) { long offset = searchOffset(mq, timeStamp); offsetTable.put(mq, offset); @@ -1333,7 +1333,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { @Override public Set subscriptions() { - return new HashSet(this.rebalanceImpl.getSubscriptionInner().values()); + return new HashSet<>(this.rebalanceImpl.getSubscriptionInner().values()); } @Override @@ -1347,7 +1347,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { public void persistConsumerOffset() { try { this.makeSureStateOK(); - Set mqs = new HashSet(); + Set mqs = new HashSet<>(); Set allocateMq = this.rebalanceImpl.getProcessQueueTable().keySet(); mqs.addAll(allocateMq); @@ -1480,7 +1480,7 @@ public class DefaultMQPushConsumerImpl implements MQConsumerInner { public List queryConsumeTimeSpan(final String topic) throws RemotingException, MQClientException, InterruptedException, MQBrokerException { - List queueTimeSpan = new ArrayList(); + List queueTimeSpan = new ArrayList<>(); TopicRouteData routeData = this.mQClientFactory.getMQClientAPIImpl().getTopicRouteInfoFromNameServer(topic, 3000); for (BrokerData brokerData : routeData.getBrokerDatas()) { String addr = brokerData.selectBrokerAddr(); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/MessageQueueLock.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/MessageQueueLock.java index 73453b0ed6..0fc9c93b44 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/MessageQueueLock.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/MessageQueueLock.java @@ -25,7 +25,7 @@ import org.apache.rocketmq.common.message.MessageQueue; */ public class MessageQueueLock { private ConcurrentMap> mqLockTable = - new ConcurrentHashMap>(32); + new ConcurrentHashMap<>(32); public Object fetchLockObject(final MessageQueue mq) { return fetchLockObject(mq, -1); @@ -34,7 +34,7 @@ public class MessageQueueLock { public Object fetchLockObject(final MessageQueue mq, final int shardingKeyIndex) { ConcurrentMap objMap = this.mqLockTable.get(mq); if (null == objMap) { - objMap = new ConcurrentHashMap(32); + objMap = new ConcurrentHashMap<>(32); ConcurrentMap prevObjMap = this.mqLockTable.putIfAbsent(mq, objMap); if (prevObjMap != null) { objMap = prevObjMap; diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java index ba00aaef99..9ffab3cba4 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java @@ -47,14 +47,14 @@ public class ProcessQueue { private final static long PULL_MAX_IDLE_TIME = Long.parseLong(System.getProperty("rocketmq.client.pull.pullMaxIdleTime", "120000")); private final InternalLogger log = ClientLogger.getLog(); private final ReadWriteLock treeMapLock = new ReentrantReadWriteLock(); - private final TreeMap msgTreeMap = new TreeMap(); + private final TreeMap msgTreeMap = new TreeMap<>(); private final AtomicLong msgCount = new AtomicLong(); private final AtomicLong msgSize = new AtomicLong(); private final Lock consumeLock = new ReentrantLock(); /** * A subset of msgTreeMap, will only be used when orderly consume */ - private final TreeMap consumingMsgOrderlyTreeMap = new TreeMap(); + private final TreeMap consumingMsgOrderlyTreeMap = new TreeMap<>(); private final AtomicLong tryUnlockTimes = new AtomicLong(0); private volatile long queueOffsetMax = 0L; private volatile boolean dropped = false; @@ -303,7 +303,7 @@ public class ProcessQueue { } public List takeMessages(final int batchSize) { - List result = new ArrayList(batchSize); + List result = new ArrayList<>(batchSize); final long now = System.currentTimeMillis(); try { this.treeMapLock.writeLock().lockInterruptibly(); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java index abf4a1322b..92dded34df 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java @@ -59,11 +59,11 @@ public class PullAPIWrapper { private final String consumerGroup; private final boolean unitMode; private ConcurrentMap pullFromWhichNodeTable = - new ConcurrentHashMap(32); + new ConcurrentHashMap<>(32); private volatile boolean connectBrokerByUser = false; private volatile long defaultBrokerId = MixAll.MASTER_ID; private Random random = new Random(System.nanoTime()); - private ArrayList filterMessageHookList = new ArrayList(); + private ArrayList filterMessageHookList = new ArrayList<>(); public PullAPIWrapper(MQClientInstance mQClientFactory, String consumerGroup, boolean unitMode) { this.mQClientFactory = mQClientFactory; @@ -94,7 +94,7 @@ public class PullAPIWrapper { } } if (needDecodeInnerMessage) { - List innerMsgList = new ArrayList(); + List innerMsgList = new ArrayList<>(); try { for (MessageExt messageExt: msgList) { if (MessageSysFlag.check(messageExt.getSysFlag(), MessageSysFlag.INNER_BATCH_FLAG) @@ -112,7 +112,7 @@ public class PullAPIWrapper { List msgListFilterAgain = msgList; if (!subscriptionData.getTagsSet().isEmpty() && !subscriptionData.isClassFilterMode()) { - msgListFilterAgain = new ArrayList(msgList.size()); + msgListFilterAgain = new ArrayList<>(msgList.size()); for (MessageExt msg : msgList) { if (msg.getTags() != null) { if (subscriptionData.getTagsSet().contains(msg.getTags())) { diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullMessageService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullMessageService.java index 9665c6d22a..a5f3379f92 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullMessageService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullMessageService.java @@ -30,7 +30,7 @@ import org.apache.rocketmq.logging.InternalLogger; public class PullMessageService extends ServiceThread { private final InternalLogger log = ClientLogger.getLog(); - private final LinkedBlockingQueue messageRequestQueue = new LinkedBlockingQueue(); + private final LinkedBlockingQueue messageRequestQueue = new LinkedBlockingQueue<>(); private final MQClientInstance mQClientFactory; private final ScheduledExecutorService scheduledExecutorService = Executors diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java index 3b72816069..b1c0f5ef65 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java @@ -49,13 +49,13 @@ import org.apache.rocketmq.remoting.exception.RemotingTimeoutException; public abstract class RebalanceImpl { protected static final InternalLogger log = ClientLogger.getLog(); - protected final ConcurrentMap processQueueTable = new ConcurrentHashMap(64); - protected final ConcurrentMap popProcessQueueTable = new ConcurrentHashMap(64); + protected final ConcurrentMap processQueueTable = new ConcurrentHashMap<>(64); + protected final ConcurrentMap popProcessQueueTable = new ConcurrentHashMap<>(64); protected final ConcurrentMap> topicSubscribeInfoTable = - new ConcurrentHashMap>(); + new ConcurrentHashMap<>(); protected final ConcurrentMap subscriptionInner = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); protected String consumerGroup; protected MessageModel messageModel; protected AllocateMessageQueueStrategy allocateMessageQueueStrategy; @@ -63,8 +63,8 @@ public abstract class RebalanceImpl { private static final int TIMEOUT_CHECK_TIMES = 3; private static final int QUERY_ASSIGNMENT_TIMEOUT = 3000; - private Map topicBrokerRebalance = new ConcurrentHashMap(); - private Map topicClientRebalance = new ConcurrentHashMap(); + private Map topicBrokerRebalance = new ConcurrentHashMap<>(); + private Map topicClientRebalance = new ConcurrentHashMap<>(); public RebalanceImpl(String consumerGroup, MessageModel messageModel, AllocateMessageQueueStrategy allocateMessageQueueStrategy, @@ -131,7 +131,7 @@ public abstract class RebalanceImpl { } private HashMap> buildProcessQueueTableByBrokerName() { - HashMap> result = new HashMap>(); + HashMap> result = new HashMap<>(); for (Map.Entry entry : this.processQueueTable.entrySet()) { MessageQueue mq = entry.getKey(); @@ -144,7 +144,7 @@ public abstract class RebalanceImpl { String destBrokerName = this.mQClientFactory.getBrokerNameFromMessageQueue(mq); Set mqs = result.get(destBrokerName); if (null == mqs) { - mqs = new HashSet(); + mqs = new HashSet<>(); result.put(mq.getBrokerName(), mqs); } @@ -330,7 +330,7 @@ public abstract class RebalanceImpl { } if (mqSet != null && cidAll != null) { - List mqAll = new ArrayList(); + List mqAll = new ArrayList<>(); mqAll.addAll(mqSet); Collections.sort(mqAll); @@ -350,7 +350,7 @@ public abstract class RebalanceImpl { return false; } - Set allocateResultSet = new HashSet(); + Set allocateResultSet = new HashSet<>(); if (allocateResult != null) { allocateResultSet.addAll(allocateResult); } @@ -390,7 +390,7 @@ public abstract class RebalanceImpl { if (messageQueueAssignments == null) { return false; } - Set mqSet = new HashSet(); + Set mqSet = new HashSet<>(); for (MessageQueueAssignment messageQueueAssignment : messageQueueAssignments) { if (messageQueueAssignment.getMessageQueue() != null) { mqSet.add(messageQueueAssignment.getMessageQueue()); @@ -408,7 +408,7 @@ public abstract class RebalanceImpl { } private Set getWorkingMessageQueue(String topic) { - Set queueSet = new HashSet(); + Set queueSet = new HashSet<>(); for (Entry entry : this.processQueueTable.entrySet()) { MessageQueue mq = entry.getKey(); ProcessQueue pq = entry.getValue(); @@ -475,7 +475,7 @@ public abstract class RebalanceImpl { boolean changed = false; // drop process queues no longer belong me - HashMap removeQueueMap = new HashMap(this.processQueueTable.size()); + HashMap removeQueueMap = new HashMap<>(this.processQueueTable.size()); Iterator> it = this.processQueueTable.entrySet().iterator(); while (it.hasNext()) { Entry next = it.next(); @@ -509,7 +509,7 @@ public abstract class RebalanceImpl { // add new message queue boolean allMQLocked = true; - List pullRequestList = new ArrayList(); + List pullRequestList = new ArrayList<>(); for (MessageQueue mq : mqSet) { if (!this.processQueueTable.containsKey(mq)) { if (isOrder && !this.lock(mq)) { @@ -556,8 +556,8 @@ public abstract class RebalanceImpl { final boolean isOrder) { boolean changed = false; - Map mq2PushAssignment = new HashMap(); - Map mq2PopAssignment = new HashMap(); + Map mq2PushAssignment = new HashMap<>(); + Map mq2PopAssignment = new HashMap<>(); for (MessageQueueAssignment assignment : assignments) { MessageQueue messageQueue = assignment.getMessageQueue(); if (messageQueue == null) { @@ -595,7 +595,7 @@ public abstract class RebalanceImpl { { // drop process queues no longer belong me - HashMap removeQueueMap = new HashMap(this.processQueueTable.size()); + HashMap removeQueueMap = new HashMap<>(this.processQueueTable.size()); Iterator> it = this.processQueueTable.entrySet().iterator(); while (it.hasNext()) { Entry next = it.next(); @@ -628,7 +628,7 @@ public abstract class RebalanceImpl { } { - HashMap removeQueueMap = new HashMap(this.popProcessQueueTable.size()); + HashMap removeQueueMap = new HashMap<>(this.popProcessQueueTable.size()); Iterator> it = this.popProcessQueueTable.entrySet().iterator(); while (it.hasNext()) { Entry next = it.next(); @@ -664,7 +664,7 @@ public abstract class RebalanceImpl { { // add new message queue boolean allMQLocked = true; - List pullRequestList = new ArrayList(); + List pullRequestList = new ArrayList<>(); for (MessageQueue mq : mq2PushAssignment.keySet()) { if (!this.processQueueTable.containsKey(mq)) { if (isOrder && !this.lock(mq)) { @@ -712,7 +712,7 @@ public abstract class RebalanceImpl { { // add new message queue - List popRequestList = new ArrayList(); + List popRequestList = new ArrayList<>(); for (MessageQueue mq : mq2PopAssignment.keySet()) { if (!this.popProcessQueueTable.containsKey(mq)) { PopProcessQueue pq = createPopProcessQueue(); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java index ab0d21d77f..d972663190 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java @@ -102,9 +102,9 @@ public class DefaultMQProducerImpl implements MQProducerInner { private final Random random = new Random(); private final DefaultMQProducer defaultMQProducer; private final ConcurrentMap topicPublishInfoTable = - new ConcurrentHashMap(); - private final ArrayList sendMessageHookList = new ArrayList(); - private final ArrayList endTransactionHookList = new ArrayList(); + new ConcurrentHashMap<>(); + private final ArrayList sendMessageHookList = new ArrayList<>(); + private final ArrayList endTransactionHookList = new ArrayList<>(); private final RPCHook rpcHook; private final BlockingQueue asyncSenderThreadPoolQueue; private final ExecutorService defaultAsyncSenderExecutor; @@ -112,7 +112,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { protected ExecutorService checkExecutor; private ServiceState serviceState = ServiceState.CREATE_JUST; private MQClientInstance mQClientFactory; - private ArrayList checkForbiddenHookList = new ArrayList(); + private ArrayList checkForbiddenHookList = new ArrayList<>(); private MQFaultStrategy mqFaultStrategy = new MQFaultStrategy(); private ExecutorService asyncSenderExecutor; @@ -133,7 +133,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.defaultMQProducer = defaultMQProducer; this.rpcHook = rpcHook; - this.asyncSenderThreadPoolQueue = new LinkedBlockingQueue(50000); + this.asyncSenderThreadPoolQueue = new LinkedBlockingQueue<>(50000); this.defaultAsyncSenderExecutor = new ThreadPoolExecutor( Runtime.getRuntime().availableProcessors(), Runtime.getRuntime().availableProcessors(), @@ -182,7 +182,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { if (producer.getExecutorService() != null) { this.checkExecutor = producer.getExecutorService(); } else { - this.checkRequestQueue = new LinkedBlockingQueue(producer.getCheckRequestHoldMax()); + this.checkRequestQueue = new LinkedBlockingQueue<>(producer.getCheckRequestHoldMax()); this.checkExecutor = new ThreadPoolExecutor( producer.getCheckThreadPoolMinSize(), producer.getCheckThreadPoolMaxSize(), @@ -296,7 +296,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { @Override public Set getPublishTopicList() { - return new HashSet(this.topicPublishInfoTable.keySet()); + return new HashSet<>(this.topicPublishInfoTable.keySet()); } @Override @@ -657,14 +657,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { default: break; } - } catch (RemotingException e) { - endTimestamp = System.currentTimeMillis(); - this.updateFaultItem(mq.getBrokerName(), endTimestamp - beginTimestampPrev, true); - log.warn(String.format("sendKernelImpl exception, resend at once, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - beginTimestampPrev, mq), e); - log.warn(msg.toString()); - exception = e; - continue; - } catch (MQClientException e) { + } catch (RemotingException | MQClientException e) { endTimestamp = System.currentTimeMillis(); this.updateFaultItem(mq.getBrokerName(), endTimestamp - beginTimestampPrev, true); log.warn(String.format("sendKernelImpl exception, resend at once, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - beginTimestampPrev, mq), e); @@ -923,19 +916,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { } return sendResult; - } catch (RemotingException e) { - if (this.hasSendMessageHook()) { - context.setException(e); - this.executeSendMessageHookAfter(context); - } - throw e; - } catch (MQBrokerException e) { - if (this.hasSendMessageHook()) { - context.setException(e); - this.executeSendMessageHookAfter(context); - } - throw e; - } catch (InterruptedException e) { + } catch (RemotingException | InterruptedException | MQBrokerException e) { if (this.hasSendMessageHook()) { context.setException(e); this.executeSendMessageHookAfter(context); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java index 079cee848e..e3bb9a041c 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java @@ -26,7 +26,7 @@ import org.apache.rocketmq.common.protocol.route.TopicRouteData; public class TopicPublishInfo { private boolean orderTopic = false; private boolean haveTopicRouterInfo = false; - private List messageQueueList = new ArrayList(); + private List messageQueueList = new ArrayList<>(); private volatile ThreadLocalIndex sendWhichQueue = new ThreadLocalIndex(); private TopicRouteData topicRouteData; diff --git a/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java b/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java index 750759f3d8..b61ed7b3de 100644 --- a/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java @@ -25,7 +25,7 @@ import java.util.concurrent.ConcurrentHashMap; import org.apache.rocketmq.client.common.ThreadLocalIndex; public class LatencyFaultToleranceImpl implements LatencyFaultTolerance { - private final ConcurrentHashMap faultItemTable = new ConcurrentHashMap(16); + private final ConcurrentHashMap faultItemTable = new ConcurrentHashMap<>(16); private final ThreadLocalIndex whichItemWorst = new ThreadLocalIndex(); @@ -65,7 +65,7 @@ public class LatencyFaultToleranceImpl implements LatencyFaultTolerance @Override public String pickOneAtLeast() { final Enumeration elements = this.faultItemTable.elements(); - List tmpList = new LinkedList(); + List tmpList = new LinkedList<>(); while (elements.hasMoreElements()) { final FaultItem faultItem = elements.nextElement(); tmpList.add(faultItem); diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java b/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java index 15e1da22ab..3e268f6b7d 100644 --- a/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java +++ b/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java @@ -66,13 +66,13 @@ public class DefaultMQProducer extends ClientConfig implements MQProducer { */ protected final transient DefaultMQProducerImpl defaultMQProducerImpl; private final InternalLogger log = ClientLogger.getLog(); - private final Set retryResponseCodes = new CopyOnWriteArraySet(Arrays.asList( - ResponseCode.TOPIC_NOT_EXIST, - ResponseCode.SERVICE_NOT_AVAILABLE, - ResponseCode.SYSTEM_ERROR, - ResponseCode.NO_PERMISSION, - ResponseCode.NO_BUYER_ID, - ResponseCode.NOT_IN_CURRENT_UNIT + private final Set retryResponseCodes = new CopyOnWriteArraySet<>(Arrays.asList( + ResponseCode.TOPIC_NOT_EXIST, + ResponseCode.SERVICE_NOT_AVAILABLE, + ResponseCode.SYSTEM_ERROR, + ResponseCode.NO_PERMISSION, + ResponseCode.NO_BUYER_ID, + ResponseCode.NOT_IN_CURRENT_UNIT )); /** diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java b/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java index df0706f1f8..100890d872 100644 --- a/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java +++ b/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java @@ -38,8 +38,8 @@ import org.apache.rocketmq.logging.InternalLogger; public class RequestFutureHolder { private static InternalLogger log = ClientLogger.getLog(); private static final RequestFutureHolder INSTANCE = new RequestFutureHolder(); - private ConcurrentHashMap requestFutureTable = new ConcurrentHashMap(); - private final Set producerSet = new HashSet(); + private ConcurrentHashMap requestFutureTable = new ConcurrentHashMap<>(); + private final Set producerSet = new HashSet<>(); private ScheduledExecutorService scheduledExecutorService = null; public ConcurrentHashMap getRequestFutureTable() { @@ -47,7 +47,7 @@ public class RequestFutureHolder { } private void scanExpiredRequest() { - final List rfList = new LinkedList(); + final List rfList = new LinkedList<>(); Iterator> it = requestFutureTable.entrySet().iterator(); while (it.hasNext()) { Map.Entry next = it.next(); diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java b/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java index 439253f32c..e7ca728175 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java @@ -88,12 +88,12 @@ public class AsyncTraceDispatcher implements TraceDispatcher { this.pollingTimeMil = 100; this.waitTimeThresholdMil = 500; this.discardCount = new AtomicLong(0L); - this.traceContextQueue = new ArrayBlockingQueue(1024); + this.traceContextQueue = new ArrayBlockingQueue<>(1024); this.taskQueueByTopic = new HashMap(); this.group = group; this.type = type; - this.appenderQueue = new ArrayBlockingQueue(queueSize); + this.appenderQueue = new ArrayBlockingQueue<>(queueSize); if (!UtilAll.isBlank(traceTopicName)) { this.traceTopicName = traceTopicName; } else { @@ -379,7 +379,7 @@ public class AsyncTraceDispatcher implements TraceDispatcher { @Override public void run() { StringBuilder buffer = new StringBuilder(1024); - Set keySet = new HashSet(); + Set keySet = new HashSet<>(); for (TraceTransferBean bean : traceTransferBeanList) { keySet.addAll(bean.getTransKey()); buffer.append(bean.getTransData()); @@ -419,7 +419,7 @@ public class AsyncTraceDispatcher implements TraceDispatcher { @Override public MessageQueue select(List mqs, Message msg, Object arg) { Set brokerSet = (Set) arg; - List filterMqs = new ArrayList(); + List filterMqs = new ArrayList<>(); for (MessageQueue queue : mqs) { if (brokerSet.contains(queue.getBrokerName())) { filterMqs.add(queue); @@ -438,7 +438,7 @@ public class AsyncTraceDispatcher implements TraceDispatcher { } private Set tryGetMessageQueueBrokerSet(DefaultMQProducerImpl producer, String topic) { - Set brokerSet = new HashSet(); + Set brokerSet = new HashSet<>(); TopicPublishInfo topicPublishInfo = producer.getTopicPublishInfoTable().get(topic); if (null == topicPublishInfo || !topicPublishInfo.ok()) { producer.getTopicPublishInfoTable().putIfAbsent(topic, new TopicPublishInfo()); diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java b/client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java index 9d8669e5d4..9184222642 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java @@ -36,7 +36,7 @@ public class TraceDataEncoder { * @return */ public static List decoderFromTraceDataString(String traceData) { - List resList = new ArrayList(); + List resList = new ArrayList<>(); if (traceData == null || traceData.length() <= 0) { return resList; } @@ -73,7 +73,7 @@ public class TraceDataEncoder { bean.setClientHost(line[14]); } - pubContext.setTraceBeans(new ArrayList(1)); + pubContext.setTraceBeans(new ArrayList<>(1)); pubContext.getTraceBeans().add(bean); resList.add(pubContext); } else if (line[0].equals(TraceType.SubBefore.name())) { @@ -87,7 +87,7 @@ public class TraceDataEncoder { bean.setMsgId(line[5]); bean.setRetryTimes(Integer.parseInt(line[6])); bean.setKeys(line[7]); - subBeforeContext.setTraceBeans(new ArrayList(1)); + subBeforeContext.setTraceBeans(new ArrayList<>(1)); subBeforeContext.getTraceBeans().add(bean); resList.add(subBeforeContext); } else if (line[0].equals(TraceType.SubAfter.name())) { @@ -97,7 +97,7 @@ public class TraceDataEncoder { TraceBean bean = new TraceBean(); bean.setMsgId(line[2]); bean.setKeys(line[5]); - subAfterContext.setTraceBeans(new ArrayList(1)); + subAfterContext.setTraceBeans(new ArrayList<>(1)); subAfterContext.getTraceBeans().add(bean); subAfterContext.setCostTime(Integer.parseInt(line[3])); subAfterContext.setSuccess(Boolean.parseBoolean(line[4])); @@ -128,7 +128,7 @@ public class TraceDataEncoder { bean.setTransactionState(LocalTransactionState.valueOf(line[11])); bean.setFromTransactionCheck(Boolean.parseBoolean(line[12])); - endTransactionContext.setTraceBeans(new ArrayList(1)); + endTransactionContext.setTraceBeans(new ArrayList<>(1)); endTransactionContext.getTraceBeans().add(bean); resList.add(endTransactionContext); } diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/TraceTransferBean.java b/client/src/main/java/org/apache/rocketmq/client/trace/TraceTransferBean.java index 78be33fe84..482a782e51 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/TraceTransferBean.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/TraceTransferBean.java @@ -24,7 +24,7 @@ import java.util.Set; */ public class TraceTransferBean { private String transData; - private Set transKey = new HashSet(); + private Set transKey = new HashSet<>(); public String getTransData() { return transData; diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/TraceView.java b/client/src/main/java/org/apache/rocketmq/client/trace/TraceView.java index 7601221cde..01ce56699d 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/TraceView.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/TraceView.java @@ -39,7 +39,7 @@ public class TraceView { private String status; public static List decodeFromTraceTransData(String key, MessageExt messageExt) { - List messageTraceViewList = new ArrayList(); + List messageTraceViewList = new ArrayList<>(); String messageBody = new String(messageExt.getBody(), StandardCharsets.UTF_8); if (messageBody == null || messageBody.length() <= 0) { return messageTraceViewList; diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageOpenTracingHookImpl.java b/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageOpenTracingHookImpl.java index fe97c77394..28fccae06f 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageOpenTracingHookImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageOpenTracingHookImpl.java @@ -51,7 +51,7 @@ public class ConsumeMessageOpenTracingHookImpl implements ConsumeMessageHook { if (context == null || context.getMsgList() == null || context.getMsgList().isEmpty()) { return; } - List spanList = new ArrayList(); + List spanList = new ArrayList<>(); for (MessageExt msg : context.getMsgList()) { if (msg == null) { continue; diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageTraceHookImpl.java b/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageTraceHookImpl.java index bce613987f..b0654db441 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageTraceHookImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/hook/ConsumeMessageTraceHookImpl.java @@ -54,7 +54,7 @@ public class ConsumeMessageTraceHookImpl implements ConsumeMessageHook { context.setMqTraceContext(traceContext); traceContext.setTraceType(TraceType.SubBefore);// traceContext.setGroupName(NamespaceUtil.withoutNamespace(context.getConsumerGroup()));// - List beans = new ArrayList(); + List beans = new ArrayList<>(); for (MessageExt msg : context.getMsgList()) { if (msg == null) { continue; diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionTraceHookImpl.java b/client/src/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionTraceHookImpl.java index 8172d0459d..0261c400c3 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionTraceHookImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionTraceHookImpl.java @@ -53,7 +53,7 @@ public class EndTransactionTraceHookImpl implements EndTransactionHook { Message msg = context.getMessage(); //build the context content of TuxeTraceContext TraceContext tuxeContext = new TraceContext(); - tuxeContext.setTraceBeans(new ArrayList(1)); + tuxeContext.setTraceBeans(new ArrayList<>(1)); tuxeContext.setTraceType(TraceType.EndTransaction); tuxeContext.setGroupName(NamespaceUtil.withoutNamespace(context.getProducerGroup())); //build the data bean object of message trace diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java b/client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java index 21e2bd9220..1581f7a228 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java @@ -48,7 +48,7 @@ public class SendMessageTraceHookImpl implements SendMessageHook { } //build the context content of TraceContext TraceContext traceContext = new TraceContext(); - traceContext.setTraceBeans(new ArrayList(1)); + traceContext.setTraceBeans(new ArrayList<>(1)); context.setMqTraceContext(traceContext); traceContext.setTraceType(TraceType.Pub); traceContext.setGroupName(NamespaceUtil.withoutNamespace(context.getProducerGroup())); diff --git a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java index ce7ec1beee..94f02abaae 100644 --- a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java @@ -41,7 +41,7 @@ public class ThreadLocalIndexTest { public void testIncrementAndGet3() throws Exception { ThreadLocalIndex localIndex = new ThreadLocalIndex(); Field threadLocalIndexField = ThreadLocalIndex.class.getDeclaredField("threadLocalIndex"); - ThreadLocal mockThreadLocal = new ThreadLocal(); + ThreadLocal mockThreadLocal = new ThreadLocal<>(); mockThreadLocal.set(Integer.MAX_VALUE); threadLocalIndexField.setAccessible(true); diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java index 35c2602589..41825381fc 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java @@ -139,7 +139,7 @@ public class DefaultLitePullConsumerTest { public void testSubscribeWithListener_PollMessageSuccess() throws Exception { DefaultLitePullConsumer litePullConsumer = createSubscribeLitePullConsumerWithListener(); try { - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createMessageQueue()); litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); litePullConsumer.setPollTimeoutMillis(20 * 1000); @@ -184,7 +184,7 @@ public class DefaultLitePullConsumerTest { offsetStore.set(litePullConsumerImpl, store); MessageQueue messageQueue = createMessageQueue(); - HashSet set = new HashSet(); + HashSet set = new HashSet<>(); set.add(messageQueue); //mock assign and reset offset @@ -204,7 +204,7 @@ public class DefaultLitePullConsumerTest { public void testSubscribe_PollMessageSuccess() throws Exception { DefaultLitePullConsumer litePullConsumer = createSubscribeLitePullConsumer(); try { - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createMessageQueue()); litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); litePullConsumer.setPollTimeoutMillis(20 * 1000); @@ -220,7 +220,7 @@ public class DefaultLitePullConsumerTest { public void testSubscribe_BroadcastPollMessageSuccess() throws Exception { DefaultLitePullConsumer litePullConsumer = createBroadcastLitePullConsumer(); try { - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createMessageQueue()); litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); litePullConsumer.setPollTimeoutMillis(20 * 1000); @@ -460,7 +460,7 @@ public class DefaultLitePullConsumerTest { flag = true; } }); - Set set = new HashSet(); + Set set = new HashSet<>(); set.add(createMessageQueue()); doReturn(set).when(mQAdminImpl).fetchSubscribeMessageQueues(anyString()); Thread.sleep(11 * 1000); @@ -633,7 +633,7 @@ public class DefaultLitePullConsumerTest { offsetStore.set(litePullConsumerImpl, store); MessageQueue messageQueue = createMessageQueue(); - HashSet set = new HashSet(); + HashSet set = new HashSet<>(); set.add(messageQueue); //mock assign and reset offset diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumerTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumerTest.java index 7afaf2bea0..0e5062cfff 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumerTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumerTest.java @@ -106,7 +106,7 @@ public class DefaultMQPullConsumerTest { assertThat(pullResult.getNextBeginOffset()).isEqualTo(1024 + 1); assertThat(pullResult.getMinOffset()).isEqualTo(123); assertThat(pullResult.getMaxOffset()).isEqualTo(2048); - assertThat(pullResult.getMsgFoundList()).isEqualTo(new ArrayList()); + assertThat(pullResult.getMsgFoundList()).isEqualTo(new ArrayList<>()); } @Test @@ -115,7 +115,7 @@ public class DefaultMQPullConsumerTest { @Override public Object answer(InvocationOnMock mock) throws Throwable { PullMessageRequestHeader requestHeader = mock.getArgument(1); - return createPullResult(requestHeader, PullStatus.NO_NEW_MSG, new ArrayList()); + return createPullResult(requestHeader, PullStatus.NO_NEW_MSG, new ArrayList<>()); } }).when(mQClientAPIImpl).pullMessage(anyString(), any(PullMessageRequestHeader.class), anyLong(), any(CommunicationMode.class), nullable(PullCallback.class)); @@ -147,7 +147,7 @@ public class DefaultMQPullConsumerTest { assertThat(pullResult.getNextBeginOffset()).isEqualTo(1024 + 1); assertThat(pullResult.getMinOffset()).isEqualTo(123); assertThat(pullResult.getMaxOffset()).isEqualTo(2048); - assertThat(pullResult.getMsgFoundList()).isEqualTo(new ArrayList()); + assertThat(pullResult.getMsgFoundList()).isEqualTo(new ArrayList<>()); } @Override diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java index cd8d1aa87d..50fcd6e63b 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java @@ -163,7 +163,7 @@ public class DefaultMQPushConsumerTest { field.setAccessible(true); field.set(null, true); - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createPullRequest().getMessageQueue()); pushConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); @@ -212,7 +212,7 @@ public class DefaultMQPushConsumerTest { @Test public void testPullMessage_Success() throws InterruptedException, RemotingException, MQBrokerException { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference messageAtomic = new AtomicReference(); + final AtomicReference messageAtomic = new AtomicReference<>(); pushConsumer.getDefaultMQPushConsumerImpl().setConsumeMessageService(new ConsumeMessageConcurrentlyService(pushConsumer.getDefaultMQPushConsumerImpl(), new MessageListenerConcurrently() { @Override public ConsumeConcurrentlyStatus consumeMessage(List msgs, @@ -235,7 +235,7 @@ public class DefaultMQPushConsumerTest { @Test(timeout = 20000) public void testPullMessage_SuccessWithOrderlyService() throws Exception { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference messageAtomic = new AtomicReference(); + final AtomicReference messageAtomic = new AtomicReference<>(); MessageListenerOrderly listenerOrderly = new MessageListenerOrderly() { @Override diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearByTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearByTest.java index 14e8ae3a53..6650f84a5d 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearByTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMachineRoomNearByTest.java @@ -104,7 +104,7 @@ public class AllocateMachineRoomNearByTest { public void testWhenIDCSizeEquals(int idcSize, int queueSize, int consumerSize) { List cidAll = prepareConsumer(idcSize, consumerSize); List mqAll = prepareMQ(idcSize, queueSize); - List resAll = new ArrayList(); + List resAll = new ArrayList<>(); for (String currentID : cidAll) { List res = allocateMessageQueueStrategy.allocate("Test-C-G",currentID,mqAll,cidAll); for (MessageQueue mq : res) { @@ -116,14 +116,14 @@ public class AllocateMachineRoomNearByTest { } public void testWhenConsumerIDCIsMore(int brokerIDCSize, int consumerMore, int queueSize, int consumerSize, boolean print) { - Set brokerIDCWithConsumer = new TreeSet(); + Set brokerIDCWithConsumer = new TreeSet<>(); List cidAll = prepareConsumer(brokerIDCSize + consumerMore, consumerSize); List mqAll = prepareMQ(brokerIDCSize, queueSize); for (MessageQueue mq : mqAll) { brokerIDCWithConsumer.add(machineRoomResolver.brokerDeployIn(mq)); } - List resAll = new ArrayList(); + List resAll = new ArrayList<>(); for (String currentID : cidAll) { List res = allocateMessageQueueStrategy.allocate("Test-C-G",currentID,mqAll,cidAll); for (MessageQueue mq : res) { @@ -138,20 +138,20 @@ public class AllocateMachineRoomNearByTest { } public void testWhenConsumerIDCIsLess(int brokerIDCSize, int consumerIDCLess, int queueSize, int consumerSize, boolean print) { - Set healthyIDC = new TreeSet(); + Set healthyIDC = new TreeSet<>(); List cidAll = prepareConsumer(brokerIDCSize - consumerIDCLess, consumerSize); List mqAll = prepareMQ(brokerIDCSize, queueSize); for (String cid : cidAll) { healthyIDC.add(machineRoomResolver.consumerDeployIn(cid)); } - List resAll = new ArrayList(); - Map> idc2Res = new TreeMap>(); + List resAll = new ArrayList<>(); + Map> idc2Res = new TreeMap<>(); for (String currentID : cidAll) { String currentIDC = machineRoomResolver.consumerDeployIn(currentID); List res = allocateMessageQueueStrategy.allocate("Test-C-G",currentID,mqAll,cidAll); if (!idc2Res.containsKey(currentIDC)) { - idc2Res.put(currentIDC, new ArrayList()); + idc2Res.put(currentIDC, new ArrayList<>()); } idc2Res.get(currentIDC).addAll(res); resAll.addAll(res); @@ -176,7 +176,7 @@ public class AllocateMachineRoomNearByTest { private List createConsumerIdList(String machineRoom, int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add(machineRoom + "-" + CID_PREFIX + String.valueOf(i)); } @@ -184,7 +184,7 @@ public class AllocateMachineRoomNearByTest { } private List createMessageQueueList(String machineRoom, int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq = new MessageQueue(topic, machineRoom + "-brokerName", i); messageQueueList.add(mq); @@ -193,7 +193,7 @@ public class AllocateMachineRoomNearByTest { } private List prepareMQ(int brokerIDCSize, int queueSize) { - List mqAll = new ArrayList(); + List mqAll = new ArrayList<>(); for (int i = 1; i <= brokerIDCSize; i++) { mqAll.addAll(createMessageQueueList("IDC" + i, queueSize)); } @@ -202,7 +202,7 @@ public class AllocateMachineRoomNearByTest { } private List prepareConsumer(int idcSize, int consumerSize) { - List cidAll = new ArrayList(); + List cidAll = new ArrayList<>(); for (int i = 1; i <= idcSize; i++) { cidAll.addAll(createConsumerIdList("IDC" + i, consumerSize)); } diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircleTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircleTest.java index 497766d9a6..ee314bc684 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircleTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyByCircleTest.java @@ -33,7 +33,7 @@ public class AllocateMessageQueueAveragelyByCircleTest extends TestCase { List allocateQueues = new AllocateMessageQueueAveragelyByCircle().allocate("", "CID_PREFIX", messageQueueList, consumerIdList); Assert.assertEquals(0, allocateQueues.size()); - Map consumerAllocateQueue = new HashMap(consumerIdList.size()); + Map consumerAllocateQueue = new HashMap<>(consumerIdList.size()); for (String consumerId : consumerIdList) { List queues = new AllocateMessageQueueAveragelyByCircle().allocate("", consumerId, messageQueueList, consumerIdList); int[] queueIds = new int[queues.size()]; @@ -49,7 +49,7 @@ public class AllocateMessageQueueAveragelyByCircleTest extends TestCase { } private List createConsumerIdList(int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add("CID_PREFIX" + i); } @@ -57,7 +57,7 @@ public class AllocateMessageQueueAveragelyByCircleTest extends TestCase { } private List createMessageQueueList(int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq = new MessageQueue("topic", "brokerName", i); messageQueueList.add(mq); diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyTest.java index b486106783..498d9e240b 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragelyTest.java @@ -37,7 +37,7 @@ public class AllocateMessageQueueAveragelyTest extends TestCase { } private List createConsumerIdList(int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add("CID_PREFIX" + i); } @@ -45,7 +45,7 @@ public class AllocateMessageQueueAveragelyTest extends TestCase { } private List createMessageQueueList(int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq = new MessageQueue("topic", "brokerName", i); messageQueueList.add(mq); diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByConfigTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByConfigTest.java index a1c925c3ae..baae104e21 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByConfigTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByConfigTest.java @@ -32,7 +32,7 @@ public class AllocateMessageQueueByConfigTest extends TestCase { AllocateMessageQueueByConfig allocateStrategy = new AllocateMessageQueueByConfig(); allocateStrategy.setMessageQueueList(messageQueueList); - Map consumerAllocateQueue = new HashMap(consumerIdList.size()); + Map consumerAllocateQueue = new HashMap<>(consumerIdList.size()); for (String consumerId : consumerIdList) { List queues = allocateStrategy.allocate("", consumerId, messageQueueList, consumerIdList); int[] queueIds = new int[queues.size()]; @@ -46,7 +46,7 @@ public class AllocateMessageQueueByConfigTest extends TestCase { } private List createConsumerIdList(int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add("CID_PREFIX" + i); } @@ -54,7 +54,7 @@ public class AllocateMessageQueueByConfigTest extends TestCase { } private List createMessageQueueList(int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq = new MessageQueue("topic", "brokerName", i); messageQueueList.add(mq); diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoomTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoomTest.java index 7b6dc6d7d8..62a7775972 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoomTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoomTest.java @@ -31,20 +31,20 @@ public class AllocateMessageQueueByMachineRoomTest extends TestCase { public void testAllocateMessageQueueByMachineRoom() { List consumerIdList = createConsumerIdList(2); List messageQueueList = createMessageQueueList(10); - Set consumeridcs = new HashSet(); + Set consumeridcs = new HashSet<>(); consumeridcs.add("room1"); AllocateMessageQueueByMachineRoom allocateStrategy = new AllocateMessageQueueByMachineRoom(); allocateStrategy.setConsumeridcs(consumeridcs); // mqAll is null or mqAll empty try { - allocateStrategy.allocate("", consumerIdList.get(0), new ArrayList(), consumerIdList); + allocateStrategy.allocate("", consumerIdList.get(0), new ArrayList<>(), consumerIdList); } catch (Exception e) { assert e instanceof IllegalArgumentException; Assert.assertEquals("mqAll is null or mqAll empty", e.getMessage()); } - Map consumerAllocateQueue = new HashMap(consumerIdList.size()); + Map consumerAllocateQueue = new HashMap<>(consumerIdList.size()); for (String consumerId : consumerIdList) { List queues = allocateStrategy.allocate("", consumerId, messageQueueList, consumerIdList); int[] queueIds = new int[queues.size()]; @@ -58,7 +58,7 @@ public class AllocateMessageQueueByMachineRoomTest extends TestCase { } private List createConsumerIdList(int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add("CID_PREFIX" + i); } @@ -66,7 +66,7 @@ public class AllocateMessageQueueByMachineRoomTest extends TestCase { } private List createMessageQueueList(int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq; if (i < size / 2) { diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java index e8784a3c5c..261d6d65a6 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java @@ -97,13 +97,13 @@ public class AllocateMessageQueueConsitentHashTest { List mqAll = createMessageQueueList(queueSize); List cidAll = createConsumerIdList(consumerSize); - List allocatedResAll = new ArrayList(); + List allocatedResAll = new ArrayList<>(); - Map allocateToAllOrigin = new TreeMap(); + Map allocateToAllOrigin = new TreeMap<>(); //test allocate all { - List cidBegin = new ArrayList(cidAll); + List cidBegin = new ArrayList<>(cidAll); for (String cid : cidBegin) { List rs = allocateMessageQueueConsistentHash.allocate("testConsumerGroup", cid, mqAll, cidBegin); @@ -117,12 +117,12 @@ public class AllocateMessageQueueConsitentHashTest { verifyAllocateAll(cidBegin, mqAll, allocatedResAll)); } - Map allocateToAllAfterRemoveOne = new TreeMap(); - List cidAfterRemoveOne = new ArrayList(cidAll); + Map allocateToAllAfterRemoveOne = new TreeMap<>(); + List cidAfterRemoveOne = new ArrayList<>(cidAll); //test allocate remove one cid { String removeCID = cidAfterRemoveOne.remove(0); - List mqShouldOnlyChanged = new ArrayList(); + List mqShouldOnlyChanged = new ArrayList<>(); Iterator> it = allocateToAllOrigin.entrySet().iterator(); while (it.hasNext()) { Map.Entry entry = it.next(); @@ -131,7 +131,7 @@ public class AllocateMessageQueueConsitentHashTest { } } - List allocatedResAllAfterRemove = new ArrayList(); + List allocatedResAllAfterRemove = new ArrayList<>(); for (String cid : cidAfterRemoveOne) { List rs = allocateMessageQueueConsistentHash.allocate("testConsumerGroup", cid, mqAll, cidAfterRemoveOne); allocatedResAllAfterRemove.addAll(rs); @@ -145,14 +145,14 @@ public class AllocateMessageQueueConsitentHashTest { verifyAfterRemove(allocateToAllOrigin, allocateToAllAfterRemoveOne, removeCID); } - List cidAfterAdd = new ArrayList(cidAfterRemoveOne); + List cidAfterAdd = new ArrayList<>(cidAfterRemoveOne); //test allocate add one more cid { String newCid = CID_PREFIX + "NEW"; cidAfterAdd.add(newCid); - List mqShouldOnlyChanged = new ArrayList(); - List allocatedResAllAfterAdd = new ArrayList(); - Map allocateToAll3 = new TreeMap(); + List mqShouldOnlyChanged = new ArrayList<>(); + List allocatedResAllAfterAdd = new ArrayList<>(); + Map allocateToAll3 = new TreeMap<>(); for (String cid : cidAfterAdd) { List rs = allocateMessageQueueConsistentHash.allocate("testConsumerGroup", cid, mqAll, cidAfterAdd); allocatedResAllAfterAdd.addAll(rs); @@ -204,7 +204,7 @@ public class AllocateMessageQueueConsitentHashTest { } private List createConsumerIdList(int size) { - List consumerIdList = new ArrayList(size); + List consumerIdList = new ArrayList<>(size); for (int i = 0; i < size; i++) { consumerIdList.add(CID_PREFIX + String.valueOf(i)); } @@ -212,7 +212,7 @@ public class AllocateMessageQueueConsitentHashTest { } private List createMessageQueueList(int size) { - List messageQueueList = new ArrayList(size); + List messageQueueList = new ArrayList<>(size); for (int i = 0; i < size; i++) { MessageQueue mq = new MessageQueue(topic, "brokerName", i); messageQueueList.add(mq); diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java index a705b30fc3..c31c708dbb 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java @@ -71,7 +71,7 @@ public class LocalFileOffsetStoreTest { offsetStore.updateOffset(messageQueue, 1024, false); assertThat(offsetStore.readOffset(messageQueue, ReadOffsetType.READ_FROM_STORE)).isEqualTo(-1); - offsetStore.persistAll(new HashSet(Collections.singletonList(messageQueue))); + offsetStore.persistAll(new HashSet<>(Collections.singletonList(messageQueue))); assertThat(offsetStore.readOffset(messageQueue, ReadOffsetType.READ_FROM_STORE)).isEqualTo(1024); } diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStoreTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStoreTest.java index c303f2d8e5..2032b7a61c 100644 --- a/client/src/test/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStoreTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStoreTest.java @@ -129,7 +129,7 @@ public class RemoteBrokerOffsetStoreTest { assertThat(offsetStore.readOffset(messageQueue, ReadOffsetType.READ_FROM_STORE)).isEqualTo(1023); offsetStore.updateOffset(messageQueue, 1025, false); - offsetStore.persistAll(new HashSet(Collections.singletonList(messageQueue))); + offsetStore.persistAll(new HashSet<>(Collections.singletonList(messageQueue))); assertThat(offsetStore.readOffset(messageQueue, ReadOffsetType.READ_FROM_STORE)).isEqualTo(1025); } diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyServiceTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyServiceTest.java index e0282d6093..3da59cd9c1 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyServiceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyServiceTest.java @@ -155,7 +155,7 @@ public class ConsumeMessageConcurrentlyServiceTest { doReturn(new FindBrokerResult("127.0.0.1:10912", false)).when(mQClientFactory).findBrokerAddressInSubscribe(anyString(), anyLong(), anyBoolean()); doReturn(false).when(mQClientFactory).updateTopicRouteInfoFromNameServer(anyString()); - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createPullRequest().getMessageQueue()); pushConsumer.getDefaultMQPushConsumerImpl().updateTopicSubscribeInfo(topic, messageQueueSet); pushConsumer.start(); @@ -164,7 +164,7 @@ public class ConsumeMessageConcurrentlyServiceTest { @Test public void testPullMessage_ConsumeSuccess() throws InterruptedException, RemotingException, MQBrokerException, NoSuchFieldException,Exception { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference messageAtomic = new AtomicReference(); + final AtomicReference messageAtomic = new AtomicReference<>(); ConsumeMessageConcurrentlyService normalServie = new ConsumeMessageConcurrentlyService(pushConsumer.getDefaultMQPushConsumerImpl(), new MessageListenerConcurrently() { @Override @@ -235,7 +235,7 @@ public class ConsumeMessageConcurrentlyServiceTest { @Test public void testConsumeThreadName() throws Exception { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference consumeThreadName = new AtomicReference(); + final AtomicReference consumeThreadName = new AtomicReference<>(); StringBuilder consumeGroup2 = new StringBuilder(); for (int i = 0; i < 101; i++) { diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyServiceTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyServiceTest.java index 384d14f3b2..d1614b8f29 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyServiceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyServiceTest.java @@ -152,7 +152,7 @@ public class ConsumeMessageOrderlyServiceTest { doReturn(new FindBrokerResult("127.0.0.1:10912", false)).when(mQClientFactory).findBrokerAddressInSubscribe(anyString(), anyLong(), anyBoolean()); doReturn(false).when(mQClientFactory).updateTopicRouteInfoFromNameServer(anyString()); - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createPullRequest().getMessageQueue()); pushConsumer.getDefaultMQPushConsumerImpl().updateTopicSubscribeInfo(topic, messageQueueSet); pushConsumer.start(); @@ -202,7 +202,7 @@ public class ConsumeMessageOrderlyServiceTest { @Test public void testConsumeThreadName() throws Exception { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference consumeThreadName = new AtomicReference(); + final AtomicReference consumeThreadName = new AtomicReference<>(); StringBuilder consumeGroup2 = new StringBuilder(); for (int i = 0; i < 101; i++) { diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java index 16e4a0d901..a31c5fb25d 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java @@ -95,7 +95,7 @@ public class ProcessQueueTest { } private List createMessageList(int count) { - List messageExtList = new ArrayList(); + List messageExtList = new ArrayList<>(); for (int i = 0; i < count; i++) { MessageExt messageExt = new MessageExt(); messageExt.setQueueOffset(i); diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImplTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImplTest.java index b722365819..5aa19470b9 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImplTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImplTest.java @@ -78,7 +78,7 @@ public class RebalancePushImplTest { // Just set pullThresholdForQueue defaultMQPushConsumer.getDefaultMQPushConsumer().setPullThresholdForQueue(1024); - Set allocateResultSet = new HashSet(); + Set allocateResultSet = new HashSet<>(); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 0)); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 1)); doRebalanceForcibly(rebalancePush, allocateResultSet); @@ -119,7 +119,7 @@ public class RebalancePushImplTest { // Just set pullThresholdSizeForQueue defaultMQPushConsumer.getDefaultMQPushConsumer().setPullThresholdSizeForQueue(1024); - Set allocateResultSet = new HashSet(); + Set allocateResultSet = new HashSet<>(); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 0)); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 1)); doRebalanceForcibly(rebalancePush, allocateResultSet); @@ -144,7 +144,7 @@ public class RebalancePushImplTest { defaultMQPushConsumer.getDefaultMQPushConsumer().setPullThresholdSizeForQueue(1024); defaultMQPushConsumer.getDefaultMQPushConsumer().setPullThresholdForQueue(1024); - Set allocateResultSet = new HashSet(); + Set allocateResultSet = new HashSet<>(); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 0)); allocateResultSet.add(new MessageQueue(topic, "BrokerA", 1)); doRebalanceForcibly(rebalancePush, allocateResultSet); diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/factory/MQClientInstanceTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/factory/MQClientInstanceTest.java index abc9f93ffd..3c95f98abb 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/factory/MQClientInstanceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/factory/MQClientInstanceTest.java @@ -51,7 +51,7 @@ public class MQClientInstanceTest { private MQClientInstance mqClientInstance = MQClientManager.getInstance().getOrCreateMQClientInstance(new ClientConfig()); private String topic = "FooBar"; private String group = "FooBarGroup"; - private ConcurrentMap> brokerAddrTable = new ConcurrentHashMap>(); + private ConcurrentMap> brokerAddrTable = new ConcurrentHashMap<>(); @Before public void init() throws Exception { @@ -62,18 +62,18 @@ public class MQClientInstanceTest { public void testTopicRouteData2TopicPublishInfo() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); @@ -93,7 +93,7 @@ public class MQClientInstanceTest { public void testFindBrokerAddressInSubscribe() { // dledger normal case String brokerName = "BrokerA"; - HashMap addrMap = new HashMap(); + HashMap addrMap = new HashMap<>(); addrMap.put(0L, "127.0.0.1:10911"); addrMap.put(1L, "127.0.0.1:10912"); addrMap.put(2L, "127.0.0.1:10913"); @@ -106,7 +106,7 @@ public class MQClientInstanceTest { // dledger case, when node n0 was voted as the leader brokerName = "BrokerB"; - HashMap addrMapNew = new HashMap(); + HashMap addrMapNew = new HashMap<>(); addrMapNew.put(0L, "127.0.0.1:10911"); addrMapNew.put(2L, "127.0.0.1:10912"); addrMapNew.put(3L, "127.0.0.1:10913"); diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java index ebfa8b2a5c..14c3a1c51e 100644 --- a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java @@ -129,7 +129,7 @@ public class DefaultMQProducerTest { @Test public void testSendMessage_NoNameSrv() throws RemotingException, InterruptedException, MQBrokerException { - when(mQClientAPIImpl.getNameServerAddressList()).thenReturn(new ArrayList()); + when(mQClientAPIImpl.getNameServerAddressList()).thenReturn(new ArrayList<>()); try { producer.send(message); failBecauseExceptionWasNotThrown(MQClientException.class); @@ -507,18 +507,18 @@ public class DefaultMQProducerTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByHashTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByHashTest.java index 8f286ee429..8d5a24b313 100644 --- a/client/src/test/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByHashTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByHashTest.java @@ -34,7 +34,7 @@ public class SelectMessageQueueByHashTest { Message message = new Message(topic, new byte[] {}); - List messageQueues = new ArrayList(); + List messageQueues = new ArrayList<>(); for (int i = 0; i < 10; i++) { MessageQueue messageQueue = new MessageQueue(topic, "DefaultBroker", i); messageQueues.add(messageQueue); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithOpenTracingTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithOpenTracingTest.java index 0de8db558a..1f57522dc5 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithOpenTracingTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithOpenTracingTest.java @@ -160,7 +160,7 @@ public class DefaultMQConsumerWithOpenTracingTest { doReturn(new FindBrokerResult("127.0.0.1:10911", false)).when(mQClientFactory).findBrokerAddressInSubscribe(anyString(), anyLong(), anyBoolean()); - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createPullRequest().getMessageQueue()); pushConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); @@ -176,7 +176,7 @@ public class DefaultMQConsumerWithOpenTracingTest { @Test public void testPullMessage_WithTrace_Success() throws InterruptedException, RemotingException, MQBrokerException, MQClientException { final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference messageAtomic = new AtomicReference(); + final AtomicReference messageAtomic = new AtomicReference<>(); pushConsumer.getDefaultMQPushConsumerImpl().setConsumeMessageService(new ConsumeMessageConcurrentlyService(pushConsumer.getDefaultMQPushConsumerImpl(), new MessageListenerConcurrently() { @Override public ConsumeConcurrentlyStatus consumeMessage(List msgs, diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java index ee94b90df2..ff82610246 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java @@ -205,7 +205,7 @@ public class DefaultMQConsumerWithTraceTest { }); doReturn(new FindBrokerResult("127.0.0.1:10911", false)).when(mQClientFactory).findBrokerAddressInSubscribe(anyString(), anyLong(), anyBoolean()); - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createPullRequest().getMessageQueue()); pushConsumer.getDefaultMQPushConsumerImpl().updateTopicSubscribeInfo(topic, messageQueueSet); } @@ -220,7 +220,7 @@ public class DefaultMQConsumerWithTraceTest { traceProducer.getDefaultMQProducerImpl().getMqClientFactory().registerProducer(producerGroupTraceTemp, traceProducer.getDefaultMQProducerImpl()); final CountDownLatch countDownLatch = new CountDownLatch(1); - final AtomicReference messageAtomic = new AtomicReference(); + final AtomicReference messageAtomic = new AtomicReference<>(); pushConsumer.getDefaultMQPushConsumerImpl().setConsumeMessageService(new ConsumeMessageConcurrentlyService(pushConsumer.getDefaultMQPushConsumerImpl(), new MessageListenerConcurrently() { @Override public ConsumeConcurrentlyStatus consumeMessage(List msgs, @@ -278,18 +278,18 @@ public class DefaultMQConsumerWithTraceTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); @@ -314,18 +314,18 @@ public class DefaultMQConsumerWithTraceTest { public static TopicRouteData createTraceTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("broker-trace"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10912"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("broker-trace"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQLitePullConsumerWithTraceTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQLitePullConsumerWithTraceTest.java index 231f0d04e0..f367f0e593 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQLitePullConsumerWithTraceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQLitePullConsumerWithTraceTest.java @@ -124,7 +124,7 @@ public class DefaultMQLitePullConsumerWithTraceTest { public void testSubscribe_PollMessageSuccess_WithDefaultTraceTopic() throws Exception { DefaultLitePullConsumer litePullConsumer = createLitePullConsumerWithDefaultTraceTopic(); try { - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createMessageQueue()); litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); litePullConsumer.setPollTimeoutMillis(20 * 1000); @@ -140,7 +140,7 @@ public class DefaultMQLitePullConsumerWithTraceTest { public void testSubscribe_PollMessageSuccess_WithCustomizedTraceTopic() throws Exception { DefaultLitePullConsumer litePullConsumer = createLitePullConsumerWithCustomizedTraceTopic(); try { - Set messageQueueSet = new HashSet(); + Set messageQueueSet = new HashSet<>(); messageQueueSet.add(createMessageQueue()); litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet); litePullConsumer.setPollTimeoutMillis(20 * 1000); @@ -273,18 +273,18 @@ public class DefaultMQLitePullConsumerWithTraceTest { private TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java index cc57a03164..0cdd64f7f1 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java @@ -134,18 +134,18 @@ public class DefaultMQProducerWithOpenTracingTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithTraceTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithTraceTest.java index 34e43799cf..acadda2162 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithTraceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithTraceTest.java @@ -165,18 +165,18 @@ public class DefaultMQProducerWithTraceTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); @@ -201,18 +201,18 @@ public class DefaultMQProducerWithTraceTest { public static TopicRouteData createTraceTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("broker-trace"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10912"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("broker-trace"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/TraceDataEncoderTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/TraceDataEncoderTest.java index fed8c4ef76..763de9f3b3 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/TraceDataEncoderTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/TraceDataEncoderTest.java @@ -82,7 +82,7 @@ public class TraceDataEncoderTest { traceBean.setStoreTime(time); traceBean.setMsgType(MessageType.Normal_Msg); traceBean.setBodyLength(26); - List traceBeans = new ArrayList(); + List traceBeans = new ArrayList<>(); traceBeans.add(traceBean); context.setTraceBeans(traceBeans); TraceTransferBean traceTransferBean = TraceDataEncoder.encoderFromContextBean(context); @@ -108,7 +108,7 @@ public class TraceDataEncoderTest { traceBean.setTransactionId("transactionId"); traceBean.setTransactionState(LocalTransactionState.COMMIT_MESSAGE); traceBean.setFromTransactionCheck(false); - List traceBeans = new ArrayList(); + List traceBeans = new ArrayList<>(); traceBeans.add(traceBean); context.setTraceBeans(traceBeans); TraceTransferBean traceTransferBean = TraceDataEncoder.encoderFromContextBean(context); @@ -151,7 +151,7 @@ public class TraceDataEncoderTest { bean.setBodyLength(100); bean.setMsgType(MessageType.Normal_Msg); bean.setOffsetMsgId("AC1415116D1418B4AAC217FE1B4E0000"); - pubContext.setTraceBeans(new ArrayList(1)); + pubContext.setTraceBeans(new ArrayList<>(1)); pubContext.getTraceBeans().add(bean); TraceTransferBean traceTransferBean = TraceDataEncoder.encoderFromContextBean(pubContext); @@ -174,7 +174,7 @@ public class TraceDataEncoderTest { bean.setMsgId("AC1415116D1418B4AAC217FE1B4E0000"); bean.setRetryTimes(0); bean.setKeys("keys"); - subBeforeContext.setTraceBeans(new ArrayList(1)); + subBeforeContext.setTraceBeans(new ArrayList<>(1)); subBeforeContext.getTraceBeans().add(bean); TraceTransferBean traceTransferBean = TraceDataEncoder.encoderFromContextBean(subBeforeContext); @@ -198,7 +198,7 @@ public class TraceDataEncoderTest { TraceBean bean = new TraceBean(); bean.setMsgId("AC1415116D1418B4AAC217FE1B4E0000"); bean.setKeys("keys"); - subAfterContext.setTraceBeans(new ArrayList(1)); + subAfterContext.setTraceBeans(new ArrayList<>(1)); subAfterContext.getTraceBeans().add(bean); TraceTransferBean traceTransferBean = TraceDataEncoder.encoderFromContextBean(subAfterContext); @@ -226,7 +226,7 @@ public class TraceDataEncoderTest { endTrxTraceBean.setTransactionId("transactionId"); endTrxTraceBean.setTransactionState(LocalTransactionState.COMMIT_MESSAGE); endTrxTraceBean.setFromTransactionCheck(false); - List traceBeans = new ArrayList(); + List traceBeans = new ArrayList<>(); traceBeans.add(endTrxTraceBean); endTrxContext.setTraceBeans(traceBeans); @@ -255,7 +255,7 @@ public class TraceDataEncoderTest { endTrxTraceBean.setTransactionId("transactionId"); endTrxTraceBean.setTransactionState(LocalTransactionState.COMMIT_MESSAGE); endTrxTraceBean.setFromTransactionCheck(false); - List traceBeans = new ArrayList(); + List traceBeans = new ArrayList<>(); traceBeans.add(endTrxTraceBean); endTrxContext.setTraceBeans(traceBeans); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithOpenTracingTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithOpenTracingTest.java index 5de15f451e..0e58b82ed8 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithOpenTracingTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithOpenTracingTest.java @@ -152,18 +152,18 @@ public class TransactionMQProducerWithOpenTracingTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); diff --git a/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithTraceTest.java b/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithTraceTest.java index 7b9e003c2f..32e6861034 100644 --- a/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithTraceTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/trace/TransactionMQProducerWithTraceTest.java @@ -132,7 +132,7 @@ public class TransactionMQProducerWithTraceTest { Field fieldHooks = DefaultMQProducerImpl.class.getDeclaredField("endTransactionHookList"); fieldHooks.setAccessible(true); - List hooks = new ArrayList(); + List hooks = new ArrayList<>(); hooks.add(endTransactionHook); fieldHooks.set(producer.getDefaultMQProducerImpl(), hooks); @@ -148,7 +148,7 @@ public class TransactionMQProducerWithTraceTest { public void testSendMessageSync_WithTrace_Success() throws RemotingException, InterruptedException, MQBrokerException, MQClientException { traceProducer.getDefaultMQProducerImpl().getMqClientFactory().registerProducer(producerGroupTraceTemp, traceProducer.getDefaultMQProducerImpl()); when(mQClientAPIImpl.getTopicRouteInfoFromNameServer(anyString(), anyLong())).thenReturn(createTopicRoute()); - final AtomicReference context = new AtomicReference(); + final AtomicReference context = new AtomicReference<>(); doAnswer(new Answer() { @Override public Object answer(InvocationOnMock mock) throws Throwable { @@ -175,18 +175,18 @@ public class TransactionMQProducerWithTraceTest { public static TopicRouteData createTopicRoute() { TopicRouteData topicRouteData = new TopicRouteData(); - topicRouteData.setFilterServerTable(new HashMap>()); - List brokerDataList = new ArrayList(); + topicRouteData.setFilterServerTable(new HashMap<>()); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); brokerData.setBrokerName("BrokerA"); brokerData.setCluster("DefaultCluster"); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "127.0.0.1:10911"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); QueueData queueData = new QueueData(); queueData.setBrokerName("BrokerA"); queueData.setPerm(6); diff --git a/common/src/main/java/org/apache/rocketmq/common/Configuration.java b/common/src/main/java/org/apache/rocketmq/common/Configuration.java index e441b9d3c5..b87453987a 100644 --- a/common/src/main/java/org/apache/rocketmq/common/Configuration.java +++ b/common/src/main/java/org/apache/rocketmq/common/Configuration.java @@ -33,7 +33,7 @@ public class Configuration { private final InternalLogger log; - private List configObjectList = new ArrayList(4); + private List configObjectList = new ArrayList<>(4); private String storePath; private boolean storePathFromConfig = false; private Object storePathObject; diff --git a/common/src/main/java/org/apache/rocketmq/common/MixAll.java b/common/src/main/java/org/apache/rocketmq/common/MixAll.java index d3a6888884..9c27d41daa 100644 --- a/common/src/main/java/org/apache/rocketmq/common/MixAll.java +++ b/common/src/main/java/org/apache/rocketmq/common/MixAll.java @@ -372,7 +372,7 @@ public class MixAll { } public static List getLocalInetAddress() { - List inetAddressList = new ArrayList(); + List inetAddressList = new ArrayList<>(); try { Enumeration enumeration = NetworkInterface.getNetworkInterfaces(); while (enumeration.hasMoreElements()) { @@ -407,7 +407,7 @@ public class MixAll { //Reverse logic comparing to RemotingUtil method, consider refactor in RocketMQ 5.0 public static String getLocalhostByNetworkInterface() throws SocketException { - List candidatesHost = new ArrayList(); + List candidatesHost = new ArrayList<>(); Enumeration enumeration = NetworkInterface.getNetworkInterfaces(); while (enumeration.hasMoreElements()) { diff --git a/common/src/main/java/org/apache/rocketmq/common/admin/ConsumeStats.java b/common/src/main/java/org/apache/rocketmq/common/admin/ConsumeStats.java index ae7e18dd2f..a963e854b0 100644 --- a/common/src/main/java/org/apache/rocketmq/common/admin/ConsumeStats.java +++ b/common/src/main/java/org/apache/rocketmq/common/admin/ConsumeStats.java @@ -25,7 +25,7 @@ import org.apache.rocketmq.common.message.MessageQueue; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ConsumeStats extends RemotingSerializable { - private Map offsetTable = new ConcurrentHashMap(); + private Map offsetTable = new ConcurrentHashMap<>(); private double consumeTps = 0; public long computeTotalDiff() { diff --git a/common/src/main/java/org/apache/rocketmq/common/admin/TopicStatsTable.java b/common/src/main/java/org/apache/rocketmq/common/admin/TopicStatsTable.java index 42a8872dcb..a15baae12b 100644 --- a/common/src/main/java/org/apache/rocketmq/common/admin/TopicStatsTable.java +++ b/common/src/main/java/org/apache/rocketmq/common/admin/TopicStatsTable.java @@ -23,7 +23,7 @@ import org.apache.rocketmq.common.message.MessageQueue; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class TopicStatsTable extends RemotingSerializable { - private Map offsetTable = new ConcurrentHashMap(); + private Map offsetTable = new ConcurrentHashMap<>(); public Map getOffsetTable() { return offsetTable; diff --git a/common/src/main/java/org/apache/rocketmq/common/consistenthash/ConsistentHashRouter.java b/common/src/main/java/org/apache/rocketmq/common/consistenthash/ConsistentHashRouter.java index 33fae11cd9..08a58856fb 100644 --- a/common/src/main/java/org/apache/rocketmq/common/consistenthash/ConsistentHashRouter.java +++ b/common/src/main/java/org/apache/rocketmq/common/consistenthash/ConsistentHashRouter.java @@ -30,7 +30,7 @@ import java.util.TreeMap; * algorithm */ public class ConsistentHashRouter { - private final SortedMap> ring = new TreeMap>(); + private final SortedMap> ring = new TreeMap<>(); private final HashFunction hashFunction; public ConsistentHashRouter(Collection pNodes, int vNodeCount) { @@ -65,7 +65,7 @@ public class ConsistentHashRouter { throw new IllegalArgumentException("illegal virtual node counts :" + vNodeCount); int existingReplicas = getExistingReplicas(pNode); for (int i = 0; i < vNodeCount; i++) { - VirtualNode vNode = new VirtualNode(pNode, i + existingReplicas); + VirtualNode vNode = new VirtualNode<>(pNode, i + existingReplicas); ring.put(hashFunction.hash(vNode.getKey()), vNode); } } diff --git a/common/src/main/java/org/apache/rocketmq/common/filter/impl/PolishExpr.java b/common/src/main/java/org/apache/rocketmq/common/filter/impl/PolishExpr.java index 388d095def..e80073f5d4 100644 --- a/common/src/main/java/org/apache/rocketmq/common/filter/impl/PolishExpr.java +++ b/common/src/main/java/org/apache/rocketmq/common/filter/impl/PolishExpr.java @@ -38,8 +38,8 @@ public class PolishExpr { * @return the compute result of Shunting-yard algorithm */ public static List reversePolish(List tokens) { - List segments = new ArrayList(); - Stack operatorStack = new Stack(); + List segments = new ArrayList<>(); + Stack operatorStack = new Stack<>(); for (int i = 0; i < tokens.size(); i++) { Op token = tokens.get(i); @@ -87,7 +87,7 @@ public class PolishExpr { * @throws Exception */ private static List participle(String expression) { - List segments = new ArrayList(); + List segments = new ArrayList<>(); int size = expression.length(); int wordStartIndex = -1; diff --git a/common/src/main/java/org/apache/rocketmq/common/message/Message.java b/common/src/main/java/org/apache/rocketmq/common/message/Message.java index 6e8cad0c38..e02b526a18 100644 --- a/common/src/main/java/org/apache/rocketmq/common/message/Message.java +++ b/common/src/main/java/org/apache/rocketmq/common/message/Message.java @@ -68,7 +68,7 @@ public class Message implements Serializable { void putProperty(final String name, final String value) { if (null == this.properties) { - this.properties = new HashMap(); + this.properties = new HashMap<>(); } this.properties.put(name, value); @@ -102,7 +102,7 @@ public class Message implements Serializable { public String getProperty(final String name) { if (null == this.properties) { - this.properties = new HashMap(); + this.properties = new HashMap<>(); } return this.properties.get(name); diff --git a/common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java b/common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java index e3104f1656..a423048c5c 100644 --- a/common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java +++ b/common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java @@ -42,7 +42,7 @@ public class MessageBatch extends Message implements Iterable { public static MessageBatch generateFromList(Collection messages) { assert messages != null; assert messages.size() > 0; - List messageList = new ArrayList(messages.size()); + List messageList = new ArrayList<>(messages.size()); Message first = null; for (Message message : messages) { if (message.getDelayTimeLevel() > 0) { diff --git a/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java b/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java index 602802c932..9b20593e5b 100644 --- a/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java +++ b/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java @@ -538,7 +538,7 @@ public class MessageDecoder { final boolean readBody, final boolean decompressBody, final boolean isClient) { - List msgExts = new ArrayList(); + List msgExts = new ArrayList<>(); while (byteBuffer.hasRemaining()) { MessageExt msgExt = decode(byteBuffer, readBody, decompressBody, isClient); if (null != msgExt) { @@ -551,7 +551,7 @@ public class MessageDecoder { } public static List decodes(ByteBuffer byteBuffer, final boolean readBody) { - List msgExts = new ArrayList(); + List msgExts = new ArrayList<>(); while (byteBuffer.hasRemaining()) { MessageExt msgExt = clientDecode(byteBuffer, readBody); if (null != msgExt) { @@ -600,7 +600,7 @@ public class MessageDecoder { } public static Map string2messageProperties(final String properties) { - Map map = new HashMap(); + Map map = new HashMap<>(); if (properties != null) { int len = properties.length(); int index = 0; @@ -697,7 +697,7 @@ public class MessageDecoder { public static byte[] encodeMessages(List messages) { //TO DO refactor, accumulate in one buffer, avoid copies - List encodedMessages = new ArrayList(messages.size()); + List encodedMessages = new ArrayList<>(messages.size()); int allSize = 0; for (Message message : messages) { byte[] tmp = encodeMessage(message); @@ -715,7 +715,7 @@ public class MessageDecoder { public static List decodeMessages(ByteBuffer byteBuffer) throws Exception { //TO DO add a callback for processing, avoid creating lists - List msgs = new ArrayList(); + List msgs = new ArrayList<>(); while (byteBuffer.hasRemaining()) { Message msg = decodeMessage(byteBuffer); msgs.add(msg); diff --git a/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java b/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java index f7da77764a..be7e78c7ea 100644 --- a/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java +++ b/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java @@ -76,7 +76,7 @@ public class DefaultTopAddressing implements TopAddressing { private List loadCustomTopAddressing() { ServiceLoader serviceLoader = ServiceLoader.load(TopAddressing.class); Iterator iterator = serviceLoader.iterator(); - List topAddressingList = new ArrayList(); + List topAddressingList = new ArrayList<>(); if (iterator.hasNext()) { topAddressingList.add(iterator.next()); } diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/BrokerMemberGroup.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/BrokerMemberGroup.java index 7e24da3640..855d5a7e46 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/BrokerMemberGroup.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/BrokerMemberGroup.java @@ -30,13 +30,13 @@ public class BrokerMemberGroup extends RemotingSerializable { // Provide default constructor for serializer public BrokerMemberGroup() { - this.brokerAddrs = new HashMap(); + this.brokerAddrs = new HashMap<>(); } public BrokerMemberGroup(final String cluster, final String brokerName) { this.cluster = cluster; this.brokerName = brokerName; - this.brokerAddrs = new HashMap(); + this.brokerAddrs = new HashMap<>(); } public long minimumBrokerId() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ClusterInfo.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ClusterInfo.java index e6dee69166..1664f88f38 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ClusterInfo.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ClusterInfo.java @@ -46,7 +46,7 @@ public class ClusterInfo extends RemotingSerializable { } public String[] retrieveAllAddrByCluster(String cluster) { - List addrs = new ArrayList(); + List addrs = new ArrayList<>(); if (clusterAddrTable.containsKey(cluster)) { Set brokerNames = clusterAddrTable.get(cluster); for (String brokerName : brokerNames) { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeByWho.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeByWho.java index 7b20d760e6..d5682a40d5 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeByWho.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeByWho.java @@ -20,8 +20,8 @@ import java.util.HashSet; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ConsumeByWho extends RemotingSerializable { - private HashSet consumedGroup = new HashSet(); - private HashSet notConsumedGroup = new HashSet(); + private HashSet consumedGroup = new HashSet<>(); + private HashSet notConsumedGroup = new HashSet<>(); private String topic; private int queueId; private long offset; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsList.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsList.java index 7b35a8099d..7183e1872e 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsList.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsList.java @@ -23,7 +23,7 @@ import org.apache.rocketmq.common.admin.ConsumeStats; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ConsumeStatsList extends RemotingSerializable { - private List>> consumeStatsList = new ArrayList>>(); + private List>> consumeStatsList = new ArrayList<>(); private String brokerAddr; private long totalDiff; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerConnection.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerConnection.java index 3a0356c7cc..586821c7e1 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerConnection.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerConnection.java @@ -27,9 +27,9 @@ import org.apache.rocketmq.common.protocol.heartbeat.SubscriptionData; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ConsumerConnection extends RemotingSerializable { - private HashSet connectionSet = new HashSet(); + private HashSet connectionSet = new HashSet<>(); private ConcurrentMap subscriptionTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private ConsumeType consumeType; private MessageModel messageModel; private ConsumeFromWhere consumeFromWhere; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerOffsetSerializeWrapper.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerOffsetSerializeWrapper.java index 1317d548cd..5c1dac85b6 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerOffsetSerializeWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerOffsetSerializeWrapper.java @@ -24,7 +24,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ConsumerOffsetSerializeWrapper extends RemotingSerializable { private ConcurrentMap> offsetTable = - new ConcurrentHashMap>(512); + new ConcurrentHashMap<>(512); private DataVersion dataVersion; public ConcurrentMap> getOffsetTable() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfo.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfo.java index 79206727d1..b64e91f85a 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfo.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfo.java @@ -37,15 +37,15 @@ public class ConsumerRunningInfo extends RemotingSerializable { private Properties properties = new Properties(); - private TreeSet subscriptionSet = new TreeSet(); + private TreeSet subscriptionSet = new TreeSet<>(); - private TreeMap mqTable = new TreeMap(); + private TreeMap mqTable = new TreeMap<>(); - private TreeMap mqPopTable = new TreeMap(); + private TreeMap mqPopTable = new TreeMap<>(); - private TreeMap statusTable = new TreeMap(); + private TreeMap statusTable = new TreeMap<>(); - private TreeMap userConsumerInfo = new TreeMap(); + private TreeMap userConsumerInfo = new TreeMap<>(); private String jstack; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetConsumerStatusBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetConsumerStatusBody.java index 6234a774d4..18ef57e278 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetConsumerStatusBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetConsumerStatusBody.java @@ -24,9 +24,9 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; @Deprecated public class GetConsumerStatusBody extends RemotingSerializable { - private Map messageQueueTable = new HashMap(); + private Map messageQueueTable = new HashMap<>(); private Map> consumerTable = - new HashMap>(); + new HashMap<>(); public Map getMessageQueueTable() { return messageQueueTable; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetRemoteClientConfigBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetRemoteClientConfigBody.java index 38b3b482a8..d4dc36d134 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetRemoteClientConfigBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GetRemoteClientConfigBody.java @@ -22,7 +22,7 @@ import java.util.ArrayList; import java.util.List; public class GetRemoteClientConfigBody extends RemotingSerializable { - private List keys = new ArrayList(); + private List keys = new ArrayList<>(); public List getKeys() { return keys; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GroupList.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GroupList.java index 862a739ec6..fd6db14ceb 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/GroupList.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/GroupList.java @@ -20,7 +20,7 @@ import java.util.HashSet; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class GroupList extends RemotingSerializable { - private HashSet groupList = new HashSet(); + private HashSet groupList = new HashSet<>(); public HashSet getGroupList() { return groupList; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/HARuntimeInfo.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/HARuntimeInfo.java index 8994b51633..24a5d529d5 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/HARuntimeInfo.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/HARuntimeInfo.java @@ -27,7 +27,7 @@ public class HARuntimeInfo extends RemotingSerializable { private boolean master; private long masterCommitLogMaxOffset; private int inSyncSlaveNums; - private List haConnectionInfo = new ArrayList(); + private List haConnectionInfo = new ArrayList<>(); private HAClientRuntimeInfo haClientRuntimeInfo = new HAClientRuntimeInfo(); public boolean isMaster() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/KVTable.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/KVTable.java index 28aafc4578..6b40682871 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/KVTable.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/KVTable.java @@ -20,7 +20,7 @@ import java.util.HashMap; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class KVTable extends RemotingSerializable { - private HashMap table = new HashMap(); + private HashMap table = new HashMap<>(); public HashMap getTable() { return table; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchRequestBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchRequestBody.java index 92e4d4e48d..66f654749b 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchRequestBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchRequestBody.java @@ -26,7 +26,7 @@ public class LockBatchRequestBody extends RemotingSerializable { private String consumerGroup; private String clientId; private boolean onlyThisBroker = false; - private Set mqSet = new HashSet(); + private Set mqSet = new HashSet<>(); public String getConsumerGroup() { return consumerGroup; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchResponseBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchResponseBody.java index 5018f20314..c99b6f383c 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchResponseBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/LockBatchResponseBody.java @@ -24,7 +24,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class LockBatchResponseBody extends RemotingSerializable { - private Set lockOKMQSet = new HashSet(); + private Set lockOKMQSet = new HashSet<>(); public Set getLockOKMQSet() { return lockOKMQSet; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapper.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapper.java index 4271ebf4ed..f0804a5aed 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapper.java @@ -23,7 +23,7 @@ import java.util.concurrent.ConcurrentHashMap; public class MessageRequestModeSerializeWrapper extends RemotingSerializable { private ConcurrentHashMap> - messageRequestModeMap = new ConcurrentHashMap>(); + messageRequestModeMap = new ConcurrentHashMap<>(); public ConcurrentHashMap> getMessageRequestModeMap() { return messageRequestModeMap; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ProducerConnection.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ProducerConnection.java index 14d71104b2..dbba3c0a8f 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/ProducerConnection.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/ProducerConnection.java @@ -21,7 +21,7 @@ import java.util.HashSet; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class ProducerConnection extends RemotingSerializable { - private HashSet connectionSet = new HashSet(); + private HashSet connectionSet = new HashSet<>(); public HashSet getConnectionSet() { return connectionSet; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryConsumeTimeSpanBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryConsumeTimeSpanBody.java index cae21094bb..53fd454635 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryConsumeTimeSpanBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryConsumeTimeSpanBody.java @@ -22,7 +22,7 @@ import java.util.List; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class QueryConsumeTimeSpanBody extends RemotingSerializable { - List consumeTimeSpanSet = new ArrayList(); + List consumeTimeSpanSet = new ArrayList<>(); public List getConsumeTimeSpanSet() { return consumeTimeSpanSet; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBody.java index f7c866ac08..547f1def60 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBody.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class QueryCorrectionOffsetBody extends RemotingSerializable { - private Map correctionOffsets = new HashMap(); + private Map correctionOffsets = new HashMap<>(); public Map getCorrectionOffsets() { return correctionOffsets; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java index 1921727aa0..e07546c56c 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java @@ -43,7 +43,7 @@ public class RegisterBrokerBody extends RemotingSerializable { private static final InternalLogger LOGGER = InternalLoggerFactory.getLogger(LoggerName.COMMON_LOGGER_NAME); private TopicConfigAndMappingSerializeWrapper topicConfigSerializeWrapper = new TopicConfigAndMappingSerializeWrapper(); - private List filterServerList = new ArrayList(); + private List filterServerList = new ArrayList<>(); public byte[] encode(boolean compress) { @@ -87,7 +87,7 @@ public class RegisterBrokerBody extends RemotingSerializable { Map topicQueueMappingInfoMap = topicConfigSerializeWrapper.getTopicQueueMappingInfoMap(); if (topicQueueMappingInfoMap == null) { //as the place holder - topicQueueMappingInfoMap = new ConcurrentHashMap(); + topicQueueMappingInfoMap = new ConcurrentHashMap<>(); } outputStream.write(convertIntToByteArray(topicQueueMappingInfoMap.size())); for (TopicQueueMappingInfo info: topicQueueMappingInfoMap.values()) { @@ -141,7 +141,7 @@ public class RegisterBrokerBody extends RemotingSerializable { byte[] filterServerListBuffer = readBytes(inflaterInputStream, filterServerListJsonLength); String filterServerListJson = new String(filterServerListBuffer, MixAll.DEFAULT_CHARSET); - List filterServerList = new ArrayList(); + List filterServerList = new ArrayList<>(); try { filterServerList = JSON.parseArray(filterServerListJson, String.class); } catch (Exception e) { @@ -151,7 +151,7 @@ public class RegisterBrokerBody extends RemotingSerializable { registerBrokerBody.setFilterServerList(filterServerList); int topicQueueMappingNum = readInt(inflaterInputStream); - Map topicQueueMappingInfoMap = new ConcurrentHashMap(); + Map topicQueueMappingInfoMap = new ConcurrentHashMap<>(); for (int i = 0; i < topicQueueMappingNum; i++) { int mappingJsonLen = readInt(inflaterInputStream); byte[] buffer = readBytes(inflaterInputStream, mappingJsonLen); @@ -211,7 +211,7 @@ public class RegisterBrokerBody extends RemotingSerializable { public static ConcurrentMap cloneTopicConfigTable( ConcurrentMap topicConfigConcurrentMap) { - ConcurrentHashMap result = new ConcurrentHashMap(); + ConcurrentHashMap result = new ConcurrentHashMap<>(); if (topicConfigConcurrentMap != null) { for (Map.Entry entry : topicConfigConcurrentMap.entrySet()) { result.put(entry.getKey(), entry.getValue()); diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapper.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapper.java index e05f75961f..ed2b404c13 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapper.java @@ -25,7 +25,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class SubscriptionGroupWrapper extends RemotingSerializable { private ConcurrentMap subscriptionGroupTable = - new ConcurrentHashMap(1024); + new ConcurrentHashMap<>(1024); private DataVersion dataVersion = new DataVersion(); public ConcurrentMap getSubscriptionGroupTable() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigAndMappingSerializeWrapper.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigAndMappingSerializeWrapper.java index 830a8a43d9..a06d9640a2 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigAndMappingSerializeWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigAndMappingSerializeWrapper.java @@ -25,9 +25,9 @@ import java.util.Map; import java.util.concurrent.ConcurrentHashMap; public class TopicConfigAndMappingSerializeWrapper extends TopicConfigSerializeWrapper { - private Map topicQueueMappingInfoMap = new ConcurrentHashMap(); + private Map topicQueueMappingInfoMap = new ConcurrentHashMap<>(); - private Map topicQueueMappingDetailMap = new ConcurrentHashMap(); + private Map topicQueueMappingDetailMap = new ConcurrentHashMap<>(); private DataVersion mappingDataVersion = new DataVersion(); diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigSerializeWrapper.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigSerializeWrapper.java index ce123021d4..f8205a192e 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigSerializeWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/TopicConfigSerializeWrapper.java @@ -25,7 +25,7 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class TopicConfigSerializeWrapper extends RemotingSerializable { private ConcurrentMap topicConfigTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private DataVersion dataVersion = new DataVersion(); public ConcurrentMap getTopicConfigTable() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/body/UnlockBatchRequestBody.java b/common/src/main/java/org/apache/rocketmq/common/protocol/body/UnlockBatchRequestBody.java index f71dafb65b..0be8e6f2a1 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/body/UnlockBatchRequestBody.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/body/UnlockBatchRequestBody.java @@ -26,7 +26,7 @@ public class UnlockBatchRequestBody extends RemotingSerializable { private String consumerGroup; private String clientId; private boolean onlyThisBroker = false; - private Set mqSet = new HashSet(); + private Set mqSet = new HashSet<>(); public String getConsumerGroup() { return consumerGroup; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/header/ExtraInfoUtil.java b/common/src/main/java/org/apache/rocketmq/common/protocol/header/ExtraInfoUtil.java index 39cbe8b2aa..9a777208ac 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/header/ExtraInfoUtil.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/header/ExtraInfoUtil.java @@ -171,7 +171,7 @@ public class ExtraInfoUtil { return null; } - Map> msgOffsetMap = new HashMap>(4); + Map> msgOffsetMap = new HashMap<>(4); String[] array; if (msgOffsetInfo.indexOf(";") < 0) { array = new String[]{msgOffsetInfo}; @@ -188,7 +188,7 @@ public class ExtraInfoUtil { if (msgOffsetMap.containsKey(key)) { throw new IllegalArgumentException("parse msgOffsetMap error, duplicate, " + msgOffsetMap); } - msgOffsetMap.put(key, new ArrayList(8)); + msgOffsetMap.put(key, new ArrayList<>(8)); String[] msgOffsets = split[2].split(","); for (String msgOffset : msgOffsets) { msgOffsetMap.get(key).add(Long.valueOf(msgOffset)); @@ -202,7 +202,7 @@ public class ExtraInfoUtil { if (startOffsetInfo == null || startOffsetInfo.length() == 0) { return null; } - Map startOffsetMap = new HashMap(4); + Map startOffsetMap = new HashMap<>(4); String[] array; if (startOffsetInfo.indexOf(";") < 0) { array = new String[]{startOffsetInfo}; @@ -229,7 +229,7 @@ public class ExtraInfoUtil { if (orderCountInfo == null || orderCountInfo.length() == 0) { return null; } - Map startOffsetMap = new HashMap(4); + Map startOffsetMap = new HashMap<>(4); String[] array; if (orderCountInfo.indexOf(";") < 0) { array = new String[]{orderCountInfo}; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/ConsumerData.java b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/ConsumerData.java index d4605d069a..ad50503fa5 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/ConsumerData.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/ConsumerData.java @@ -29,7 +29,7 @@ public class ConsumerData { private ConsumeType consumeType; private MessageModel messageModel; private ConsumeFromWhere consumeFromWhere; - private Set subscriptionDataSet = new HashSet(); + private Set subscriptionDataSet = new HashSet<>(); private boolean unitMode; public String getGroupName() { diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/HeartbeatData.java b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/HeartbeatData.java index 47ae542a33..34bb46b70f 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/HeartbeatData.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/HeartbeatData.java @@ -26,8 +26,8 @@ import org.apache.rocketmq.remoting.protocol.RemotingSerializable; public class HeartbeatData extends RemotingSerializable { private String clientID; - private Set producerDataSet = new HashSet(); - private Set consumerDataSet = new HashSet(); + private Set producerDataSet = new HashSet<>(); + private Set consumerDataSet = new HashSet<>(); public String getClientID() { return clientID; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/SubscriptionData.java b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/SubscriptionData.java index 83e254f22e..19b16ac4e5 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/SubscriptionData.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/heartbeat/SubscriptionData.java @@ -31,8 +31,8 @@ public class SubscriptionData implements Comparable { private boolean classFilterMode = false; private String topic; private String subString; - private Set tagsSet = new HashSet(); - private Set codeSet = new HashSet(); + private Set tagsSet = new HashSet<>(); + private Set codeSet = new HashSet<>(); private long subVersion = System.currentTimeMillis(); private String expressionType = ExpressionType.TAG; diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java b/common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java index fa382296b7..e7a29eb515 100644 --- a/common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java +++ b/common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java @@ -40,15 +40,15 @@ public class TopicRouteData extends RemotingSerializable { private Map topicQueueMappingByBroker; public TopicRouteData() { - queueDatas = new ArrayList(); - brokerDatas = new ArrayList(); - filterServerTable = new HashMap>(); + queueDatas = new ArrayList<>(); + brokerDatas = new ArrayList<>(); + filterServerTable = new HashMap<>(); } public TopicRouteData(TopicRouteData topicRouteData) { - this.queueDatas = new ArrayList(); - this.brokerDatas = new ArrayList(); - this.filterServerTable = new HashMap>(); + this.queueDatas = new ArrayList<>(); + this.brokerDatas = new ArrayList<>(); + this.filterServerTable = new HashMap<>(); this.orderTopicConf = topicRouteData.orderTopicConf; if (topicRouteData.queueDatas != null) { @@ -64,7 +64,7 @@ public class TopicRouteData extends RemotingSerializable { } if (topicRouteData.topicQueueMappingByBroker != null) { - this.topicQueueMappingByBroker = new HashMap(topicRouteData.topicQueueMappingByBroker); + this.topicQueueMappingByBroker = new HashMap<>(topicRouteData.topicQueueMappingByBroker); } } @@ -100,7 +100,7 @@ public class TopicRouteData extends RemotingSerializable { for (final Map.Entry> listEntry : this.filterServerTable.entrySet()) { topicRouteData.getFilterServerTable().put(listEntry.getKey(), - new ArrayList(listEntry.getValue())); + new ArrayList<>(listEntry.getValue())); } if (this.topicQueueMappingByBroker != null) { Map cloneMap = new HashMap<>(this.topicQueueMappingByBroker.size()); @@ -108,7 +108,7 @@ public class TopicRouteData extends RemotingSerializable { TopicQueueMappingInfo topicQueueMappingInfo = new TopicQueueMappingInfo(entry.getValue().getTopic(), entry.getValue().getTotalQueues(), entry.getValue().getBname(), entry.getValue().getEpoch()); topicQueueMappingInfo.setDirty(entry.getValue().isDirty()); topicQueueMappingInfo.setScope(entry.getValue().getScope()); - ConcurrentMap concurrentMap = new ConcurrentHashMap(entry.getValue().getCurrIdMap()); + ConcurrentMap concurrentMap = new ConcurrentHashMap<>(entry.getValue().getCurrIdMap()); topicQueueMappingInfo.setCurrIdMap(concurrentMap); cloneMap.put(entry.getKey(), topicQueueMappingInfo); } diff --git a/common/src/main/java/org/apache/rocketmq/common/queue/ConcurrentTreeMap.java b/common/src/main/java/org/apache/rocketmq/common/queue/ConcurrentTreeMap.java index 791c72c18a..b5999a7061 100644 --- a/common/src/main/java/org/apache/rocketmq/common/queue/ConcurrentTreeMap.java +++ b/common/src/main/java/org/apache/rocketmq/common/queue/ConcurrentTreeMap.java @@ -35,8 +35,8 @@ public class ConcurrentTreeMap { private RoundQueue roundQueue; public ConcurrentTreeMap(int capacity, Comparator comparator) { - tree = new TreeMap(comparator); - roundQueue = new RoundQueue(capacity); + tree = new TreeMap<>(comparator); + roundQueue = new RoundQueue<>(capacity); lock = new ReentrantLock(true); } diff --git a/common/src/main/java/org/apache/rocketmq/common/queue/RoundQueue.java b/common/src/main/java/org/apache/rocketmq/common/queue/RoundQueue.java index a2bbe9dcd7..8fc5f68791 100644 --- a/common/src/main/java/org/apache/rocketmq/common/queue/RoundQueue.java +++ b/common/src/main/java/org/apache/rocketmq/common/queue/RoundQueue.java @@ -30,7 +30,7 @@ public class RoundQueue { public RoundQueue(int capacity) { this.capacity = capacity; - queue = new LinkedList(); + queue = new LinkedList<>(); } public boolean put(E e) { diff --git a/common/src/main/java/org/apache/rocketmq/common/rpc/ClientMetadata.java b/common/src/main/java/org/apache/rocketmq/common/rpc/ClientMetadata.java index 67ceed5204..8a8d6c4c70 100644 --- a/common/src/main/java/org/apache/rocketmq/common/rpc/ClientMetadata.java +++ b/common/src/main/java/org/apache/rocketmq/common/rpc/ClientMetadata.java @@ -39,12 +39,12 @@ import java.util.concurrent.ConcurrentMap; public class ClientMetadata { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.COMMON_LOGGER_NAME); - private final ConcurrentMap topicRouteTable = new ConcurrentHashMap(); - private final ConcurrentMap> topicEndPointsTable = new ConcurrentHashMap>(); + private final ConcurrentMap topicRouteTable = new ConcurrentHashMap<>(); + private final ConcurrentMap> topicEndPointsTable = new ConcurrentHashMap<>(); private final ConcurrentMap> brokerAddrTable = - new ConcurrentHashMap>(); + new ConcurrentHashMap<>(); private final ConcurrentMap> brokerVersionTable = - new ConcurrentHashMap>(); + new ConcurrentHashMap<>(); public void freshTopicRoute(String topic, TopicRouteData topicRouteData) { if (topic == null @@ -101,17 +101,17 @@ public class ClientMetadata { public static ConcurrentMap topicRouteData2EndpointsForStaticTopic(final String topic, final TopicRouteData route) { if (route.getTopicQueueMappingByBroker() == null || route.getTopicQueueMappingByBroker().isEmpty()) { - return new ConcurrentHashMap(); + return new ConcurrentHashMap<>(); } - ConcurrentMap mqEndPointsOfBroker = new ConcurrentHashMap(); + ConcurrentMap mqEndPointsOfBroker = new ConcurrentHashMap<>(); - Map> mappingInfosByScope = new HashMap>(); + Map> mappingInfosByScope = new HashMap<>(); for (Map.Entry entry : route.getTopicQueueMappingByBroker().entrySet()) { TopicQueueMappingInfo info = entry.getValue(); String scope = info.getScope(); if (scope != null) { if (!mappingInfosByScope.containsKey(scope)) { - mappingInfosByScope.put(scope, new HashMap()); + mappingInfosByScope.put(scope, new HashMap<>()); } mappingInfosByScope.get(scope).put(entry.getKey(), entry.getValue()); } @@ -120,8 +120,8 @@ public class ClientMetadata { for (Map.Entry> mapEntry : mappingInfosByScope.entrySet()) { String scope = mapEntry.getKey(); Map topicQueueMappingInfoMap = mapEntry.getValue(); - ConcurrentMap mqEndPoints = new ConcurrentHashMap(); - List> mappingInfos = new ArrayList>(topicQueueMappingInfoMap.entrySet()); + ConcurrentMap mqEndPoints = new ConcurrentHashMap<>(); + List> mappingInfos = new ArrayList<>(topicQueueMappingInfoMap.entrySet()); Collections.sort(mappingInfos, new Comparator>() { @Override public int compare(Map.Entry o1, Map.Entry o2) { diff --git a/common/src/main/java/org/apache/rocketmq/common/rpc/RequestBuilder.java b/common/src/main/java/org/apache/rocketmq/common/rpc/RequestBuilder.java index 9fec087be9..38b13bb879 100644 --- a/common/src/main/java/org/apache/rocketmq/common/rpc/RequestBuilder.java +++ b/common/src/main/java/org/apache/rocketmq/common/rpc/RequestBuilder.java @@ -25,7 +25,7 @@ import java.util.Map; public class RequestBuilder { - private static Map requestCodeMap = new HashMap(); + private static Map requestCodeMap = new HashMap<>(); static { requestCodeMap.put(RequestCode.PULL_MESSAGE, PullMessageRequestHeader.class); } diff --git a/common/src/main/java/org/apache/rocketmq/common/rpc/RpcClientImpl.java b/common/src/main/java/org/apache/rocketmq/common/rpc/RpcClientImpl.java index c5cbc740b4..237b201bdb 100644 --- a/common/src/main/java/org/apache/rocketmq/common/rpc/RpcClientImpl.java +++ b/common/src/main/java/org/apache/rocketmq/common/rpc/RpcClientImpl.java @@ -45,7 +45,7 @@ public class RpcClientImpl implements RpcClient { private RemotingClient remotingClient; - private List clientHookList = new ArrayList(); + private List clientHookList = new ArrayList<>(); public RpcClientImpl(ClientMetadata clientMetadata, RemotingClient remotingClient) { this.clientMetadata = clientMetadata; diff --git a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingDetail.java b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingDetail.java index 40e50f4b40..23bf1bd241 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingDetail.java +++ b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingDetail.java @@ -28,7 +28,7 @@ public class TopicQueueMappingDetail extends TopicQueueMappingInfo { // the mapping info in current broker, do not register to nameserver // make sure this value is not null - private ConcurrentMap> hostedQueues = new ConcurrentHashMap>(); + private ConcurrentMap> hostedQueues = new ConcurrentHashMap<>(); //make sure there is a default constructor public TopicQueueMappingDetail() { @@ -59,9 +59,9 @@ public class TopicQueueMappingDetail extends TopicQueueMappingInfo { assert level == LEVEL_0 ; if (mappingDetail.hostedQueues == null || mappingDetail.hostedQueues.isEmpty()) { - return new ConcurrentHashMap(); + return new ConcurrentHashMap<>(); } - ConcurrentMap tmpIdMap = new ConcurrentHashMap(); + ConcurrentMap tmpIdMap = new ConcurrentHashMap<>(); for (Map.Entry> entry: mappingDetail.hostedQueues.entrySet()) { Integer globalId = entry.getKey(); List items = entry.getValue(); diff --git a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingInfo.java b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingInfo.java index 784247d2da..b419c39b87 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingInfo.java +++ b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingInfo.java @@ -47,7 +47,7 @@ public class TopicQueueMappingInfo extends RemotingSerializable { long epoch; //important to fence the old dirty data boolean dirty; //indicate if the data is dirty //register to broker to construct the route - protected ConcurrentMap currIdMap = new ConcurrentHashMap(); + protected ConcurrentMap currIdMap = new ConcurrentHashMap<>(); public TopicQueueMappingInfo() { diff --git a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtils.java b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtils.java index bf02ccd457..c4812bd64d 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtils.java +++ b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtils.java @@ -39,13 +39,13 @@ public class TopicQueueMappingUtils { public static final int DEFAULT_BLOCK_SEQ_SIZE = 10000; public static class MappingAllocator { - Map brokerNumMap = new HashMap(); - Map idToBroker = new HashMap(); + Map brokerNumMap = new HashMap<>(); + Map idToBroker = new HashMap<>(); //used for remapping Map brokerNumMapBeforeRemapping = null; int currentIndex = 0; Random random = new Random(); - List leastBrokers = new ArrayList(); + List leastBrokers = new ArrayList<>(); private MappingAllocator(Map idToBroker, Map brokerNumMap, Map brokerNumMapBeforeRemapping) { this.idToBroker.putAll(idToBroker); this.brokerNumMap.putAll(brokerNumMap); @@ -134,11 +134,11 @@ public class TopicQueueMappingUtils { queueNum = mappingDetail.getTotalQueues(); } } - return new AbstractMap.SimpleImmutableEntry(epoch, queueNum); + return new AbstractMap.SimpleImmutableEntry<>(epoch, queueNum); } public static List getMappingDetailFromConfig(Collection configs) { - List detailList = new ArrayList(); + List detailList = new ArrayList<>(); for (TopicConfigAndQueueMapping configMapping : configs) { if (configMapping.getMappingDetail() != null) { detailList.add(configMapping.getMappingDetail()); @@ -198,7 +198,7 @@ public class TopicQueueMappingUtils { maxNum = mappingDetail.getTotalQueues(); } } - return new AbstractMap.SimpleEntry(maxEpoch, maxNum); + return new AbstractMap.SimpleEntry<>(maxEpoch, maxNum); } public static String getMockBrokerName(String scope) { @@ -295,7 +295,7 @@ public class TopicQueueMappingUtils { } public static void checkIfReusePhysicalQueue(Collection mappingOnes) { - Map physicalQueueIdMap = new HashMap(); + Map physicalQueueIdMap = new HashMap<>(); for (TopicQueueMappingOne mappingOne : mappingOnes) { for (LogicQueueMappingItem item: mappingOne.items) { String physicalQueueId = item.getBname() + "-" + item.getQueueId(); @@ -353,7 +353,7 @@ public class TopicQueueMappingUtils { }); int maxNum = 0; - Map globalIdMap = new HashMap(); + Map globalIdMap = new HashMap<>(); for (TopicQueueMappingDetail mappingDetail : mappingDetailList) { if (mappingDetail.totalQueues > maxNum) { maxNum = mappingDetail.totalQueues; @@ -444,11 +444,11 @@ public class TopicQueueMappingUtils { public static TopicRemappingDetailWrapper createTopicConfigMapping(String topic, int queueNum, Set targetBrokers, Map brokerConfigMap) { checkTargetBrokersComplete(targetBrokers, brokerConfigMap); - Map globalIdMap = new HashMap(); - Map.Entry maxEpochAndNum = new AbstractMap.SimpleImmutableEntry(System.currentTimeMillis(), queueNum); + Map globalIdMap = new HashMap<>(); + Map.Entry maxEpochAndNum = new AbstractMap.SimpleImmutableEntry<>(System.currentTimeMillis(), queueNum); if (!brokerConfigMap.isEmpty()) { maxEpochAndNum = TopicQueueMappingUtils.checkNameEpochNumConsistence(topic, brokerConfigMap); - globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); + globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList<>(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); checkIfReusePhysicalQueue(globalIdMap.values()); checkPhysicalQueueConsistence(brokerConfigMap); } @@ -461,11 +461,11 @@ public class TopicQueueMappingUtils { } //the check is ok, now do the mapping allocation - Map brokerNumMap = new HashMap(); + Map brokerNumMap = new HashMap<>(); for (String broker: targetBrokers) { brokerNumMap.put(broker, 0); } - final Map oldIdToBroker = new HashMap(); + final Map oldIdToBroker = new HashMap<>(); for (Map.Entry entry : globalIdMap.entrySet()) { String leaderbroker = entry.getValue().getBname(); oldIdToBroker.put(entry.getKey(), leaderbroker); @@ -500,7 +500,7 @@ public class TopicQueueMappingUtils { configMapping.setReadQueueNums(configMapping.getReadQueueNums() + 1); } LogicQueueMappingItem mappingItem = new LogicQueueMappingItem(0, configMapping.getWriteQueueNums() - 1, broker, 0, 0, -1, -1, -1); - TopicQueueMappingDetail.putMappingInfo(configMapping.getMappingDetail(), queueId, new ArrayList(Collections.singletonList(mappingItem))); + TopicQueueMappingDetail.putMappingInfo(configMapping.getMappingDetail(), queueId, new ArrayList<>(Collections.singletonList(mappingItem))); } // set the topic config @@ -516,7 +516,7 @@ public class TopicQueueMappingUtils { checkIfReusePhysicalQueue(globalIdMap.values()); checkPhysicalQueueConsistence(brokerConfigMap); } - return new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, newEpoch, brokerConfigMap, new HashSet(), new HashSet()); + return new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, newEpoch, brokerConfigMap, new HashSet<>(), new HashSet<>()); } @@ -529,11 +529,11 @@ public class TopicQueueMappingUtils { //the check is ok, now do the mapping allocation int maxNum = maxEpochAndNum.getValue(); - Map brokerNumMap = new HashMap(); + Map brokerNumMap = new HashMap<>(); for (String broker: targetBrokers) { brokerNumMap.put(broker, 0); } - Map brokerNumMapBeforeRemapping = new HashMap(); + Map brokerNumMapBeforeRemapping = new HashMap<>(); for (TopicQueueMappingOne mappingOne: globalIdMap.values()) { if (brokerNumMapBeforeRemapping.containsKey(mappingOne.bname)) { brokerNumMapBeforeRemapping.put(mappingOne.bname, brokerNumMapBeforeRemapping.get(mappingOne.bname) + 1); @@ -542,12 +542,12 @@ public class TopicQueueMappingUtils { } } - TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap(), brokerNumMap, brokerNumMapBeforeRemapping); + TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap<>(), brokerNumMap, brokerNumMapBeforeRemapping); allocator.upToNum(maxNum); Map expectedBrokerNumMap = allocator.getBrokerNumMap(); - Queue waitAssignQueues = new ArrayDeque(); + Queue waitAssignQueues = new ArrayDeque<>(); //cannot directly use the idBrokerMap from allocator, for the number of globalId maybe not in the natural order - Map expectedIdToBroker = new HashMap(); + Map expectedIdToBroker = new HashMap<>(); //the following logic will make sure that, for one broker, either "map in" or "map out" //It can't both, map in some queues but also map out some queues. for (Map.Entry entry : globalIdMap.entrySet()) { @@ -579,8 +579,8 @@ public class TopicQueueMappingUtils { long newEpoch = Math.max(maxEpochAndNum.getKey() + 1000, System.currentTimeMillis()); //Now construct the remapping info - Set brokersToMapOut = new HashSet(); - Set brokersToMapIn = new HashSet(); + Set brokersToMapOut = new HashSet<>(); + Set brokersToMapIn = new HashSet<>(); for (Map.Entry mapEntry : expectedIdToBroker.entrySet()) { Integer queueId = mapEntry.getKey(); String broker = mapEntry.getValue(); @@ -605,7 +605,7 @@ public class TopicQueueMappingUtils { mapInConfig.setWriteQueueNums(mapInConfig.getWriteQueueNums() + 1); mapInConfig.setReadQueueNums(mapInConfig.getReadQueueNums() + 1); - List items = new ArrayList(topicQueueMappingOne.getItems()); + List items = new ArrayList<>(topicQueueMappingOne.getItems()); LogicQueueMappingItem last = items.get(items.size() - 1); items.add(new LogicQueueMappingItem(last.getGen() + 1, mapInConfig.getWriteQueueNums() - 1, mapInBroker, -1, 0, -1, -1, -1)); diff --git a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicRemappingDetailWrapper.java b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicRemappingDetailWrapper.java index ce02a93d9c..f181811c33 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicRemappingDetailWrapper.java +++ b/common/src/main/java/org/apache/rocketmq/common/statictopic/TopicRemappingDetailWrapper.java @@ -35,11 +35,11 @@ public class TopicRemappingDetailWrapper extends RemotingSerializable { private String type; private long epoch; - private Map brokerConfigMap = new HashMap(); + private Map brokerConfigMap = new HashMap<>(); - private Set brokerToMapIn = new HashSet(); + private Set brokerToMapIn = new HashSet<>(); - private Set brokerToMapOut = new HashSet(); + private Set brokerToMapOut = new HashSet<>(); public TopicRemappingDetailWrapper() { diff --git a/common/src/main/java/org/apache/rocketmq/common/statistics/FutureHolder.java b/common/src/main/java/org/apache/rocketmq/common/statistics/FutureHolder.java index 6356101c92..1fcf0b8bf0 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statistics/FutureHolder.java +++ b/common/src/main/java/org/apache/rocketmq/common/statistics/FutureHolder.java @@ -23,12 +23,12 @@ import java.util.concurrent.Future; import java.util.concurrent.LinkedBlockingQueue; public class FutureHolder { - private ConcurrentMap> futureMap = new ConcurrentHashMap>(8); + private ConcurrentMap> futureMap = new ConcurrentHashMap<>(8); public void addFuture(T t, Future future) { BlockingQueue list = futureMap.get(t); if (list == null) { - list = new LinkedBlockingQueue(); + list = new LinkedBlockingQueue<>(); BlockingQueue old = futureMap.putIfAbsent(t, list); if (old != null) { list = old; diff --git a/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsItemScheduledIncrementPrinter.java b/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsItemScheduledIncrementPrinter.java index c0db6807d8..2890e6e15c 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsItemScheduledIncrementPrinter.java +++ b/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsItemScheduledIncrementPrinter.java @@ -33,10 +33,10 @@ public class StatisticsItemScheduledIncrementPrinter extends StatisticsItemSched * last snapshots of all scheduled items */ private final ConcurrentHashMap> lastItemSnapshots - = new ConcurrentHashMap>(); + = new ConcurrentHashMap<>(); private final ConcurrentHashMap> sampleBriefs - = new ConcurrentHashMap>(); + = new ConcurrentHashMap<>(); public StatisticsItemScheduledIncrementPrinter(String name, StatisticsItemPrinter printer, ScheduledExecutorService executor, InitialDelay initialDelay, @@ -140,7 +140,7 @@ public class StatisticsItemScheduledIncrementPrinter extends StatisticsItemSched String key = item.getStatObject(); ConcurrentHashMap itemMap = snapshots.get(kind); if (itemMap == null) { - itemMap = new ConcurrentHashMap(); + itemMap = new ConcurrentHashMap<>(); ConcurrentHashMap oldItemMap = snapshots.putIfAbsent(kind, itemMap); if (oldItemMap != null) { itemMap = oldItemMap; @@ -154,7 +154,7 @@ public class StatisticsItemScheduledIncrementPrinter extends StatisticsItemSched StatisticsItemSampleBrief brief) { ConcurrentHashMap itemMap = sampleBriefs.get(kind); if (itemMap == null) { - itemMap = new ConcurrentHashMap(); + itemMap = new ConcurrentHashMap<>(); ConcurrentHashMap oldItemMap = sampleBriefs.putIfAbsent(kind, itemMap); if (oldItemMap != null) { itemMap = oldItemMap; diff --git a/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsManager.java b/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsManager.java index b517b63159..8d6bdb73a5 100644 --- a/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsManager.java +++ b/common/src/main/java/org/apache/rocketmq/common/statistics/StatisticsManager.java @@ -42,7 +42,7 @@ public class StatisticsManager { * Statistics */ private final ConcurrentHashMap> statsTable - = new ConcurrentHashMap>(); + = new ConcurrentHashMap<>(); private static final int MAX_IDLE_TIME = 10 * 60 * 1000; private final ScheduledExecutorService executor = ThreadUtils.newSingleThreadScheduledExecutor( @@ -51,7 +51,7 @@ public class StatisticsManager { private StatisticsItemStateGetter statisticsItemStateGetter; public StatisticsManager() { - kindMetaMap = new HashMap(); + kindMetaMap = new HashMap<>(); start(); } @@ -62,7 +62,7 @@ public class StatisticsManager { public void addStatisticsKindMeta(StatisticsKindMeta kindMeta) { kindMetaMap.put(kindMeta.getName(), kindMeta); - statsTable.putIfAbsent(kindMeta.getName(), new ConcurrentHashMap(16)); + statsTable.putIfAbsent(kindMeta.getName(), new ConcurrentHashMap<>(16)); } public void setBriefMeta(Pair[] briefMetas) { @@ -85,7 +85,7 @@ public class StatisticsManager { continue; } - HashMap tmpItemMap = new HashMap(itemMap); + HashMap tmpItemMap = new HashMap<>(itemMap); for (StatisticsItem item : tmpItemMap.values()) { // remove when expired if (System.currentTimeMillis() - item.getLastTimeStamp().get() > MAX_IDLE_TIME diff --git a/common/src/main/java/org/apache/rocketmq/common/stats/MomentStatsItemSet.java b/common/src/main/java/org/apache/rocketmq/common/stats/MomentStatsItemSet.java index 4d2ce0cfcd..522130e36d 100644 --- a/common/src/main/java/org/apache/rocketmq/common/stats/MomentStatsItemSet.java +++ b/common/src/main/java/org/apache/rocketmq/common/stats/MomentStatsItemSet.java @@ -28,7 +28,7 @@ import org.apache.rocketmq.logging.InternalLogger; public class MomentStatsItemSet { private final ConcurrentMap statsItemTable = - new ConcurrentHashMap(128); + new ConcurrentHashMap<>(128); private final String statsName; private final ScheduledExecutorService scheduledExecutorService; private final InternalLogger log; diff --git a/common/src/main/java/org/apache/rocketmq/common/stats/StatsItem.java b/common/src/main/java/org/apache/rocketmq/common/stats/StatsItem.java index d016662afa..35e4da5b5c 100644 --- a/common/src/main/java/org/apache/rocketmq/common/stats/StatsItem.java +++ b/common/src/main/java/org/apache/rocketmq/common/stats/StatsItem.java @@ -31,11 +31,11 @@ public class StatsItem { private final LongAdder times = new LongAdder(); - private final LinkedList csListMinute = new LinkedList(); + private final LinkedList csListMinute = new LinkedList<>(); - private final LinkedList csListHour = new LinkedList(); + private final LinkedList csListHour = new LinkedList<>(); - private final LinkedList csListDay = new LinkedList(); + private final LinkedList csListDay = new LinkedList<>(); private final String statsName; private final String statsKey; diff --git a/common/src/main/java/org/apache/rocketmq/common/stats/StatsItemSet.java b/common/src/main/java/org/apache/rocketmq/common/stats/StatsItemSet.java index 8d5418ef6c..eb853847aa 100644 --- a/common/src/main/java/org/apache/rocketmq/common/stats/StatsItemSet.java +++ b/common/src/main/java/org/apache/rocketmq/common/stats/StatsItemSet.java @@ -28,7 +28,7 @@ import org.apache.rocketmq.logging.InternalLogger; public class StatsItemSet { private final ConcurrentMap statsItemTable = - new ConcurrentHashMap(128); + new ConcurrentHashMap<>(128); private final String statsName; private final ScheduledExecutorService scheduledExecutorService; diff --git a/common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java b/common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java index 540f53ad76..44e9ca1fe3 100644 --- a/common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java +++ b/common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java @@ -41,12 +41,12 @@ public class TopicValidator { public static final boolean[] VALID_CHAR_BIT_MAP = new boolean[128]; private static final int TOPIC_MAX_LENGTH = 127; - private static final Set SYSTEM_TOPIC_SET = new HashSet(); + private static final Set SYSTEM_TOPIC_SET = new HashSet<>(); /** * Topics'set which client can not send msg! */ - private static final Set NOT_ALLOWED_SEND_TOPIC_SET = new HashSet(); + private static final Set NOT_ALLOWED_SEND_TOPIC_SET = new HashSet<>(); static { SYSTEM_TOPIC_SET.add(AUTO_CREATE_TOPIC_KEY_TOPIC); diff --git a/common/src/main/java/org/apache/rocketmq/common/utils/IOTinyUtils.java b/common/src/main/java/org/apache/rocketmq/common/utils/IOTinyUtils.java index 5ed82ae6e6..5abcb21e69 100644 --- a/common/src/main/java/org/apache/rocketmq/common/utils/IOTinyUtils.java +++ b/common/src/main/java/org/apache/rocketmq/common/utils/IOTinyUtils.java @@ -58,7 +58,7 @@ public class IOTinyUtils { static public List readLines(Reader input) throws IOException { BufferedReader reader = toBufferedReader(input); - List list = new ArrayList(); + List list = new ArrayList<>(); String line; for (; ; ) { line = reader.readLine(); diff --git a/common/src/main/java/org/apache/rocketmq/common/utils/MessageUtils.java b/common/src/main/java/org/apache/rocketmq/common/utils/MessageUtils.java index 0e5ac7add9..4d6a150adc 100644 --- a/common/src/main/java/org/apache/rocketmq/common/utils/MessageUtils.java +++ b/common/src/main/java/org/apache/rocketmq/common/utils/MessageUtils.java @@ -41,7 +41,7 @@ public class MessageUtils { } public static Set getShardingKeyIndexes(Collection msgs, int indexSize) { - Set indexSet = new HashSet(indexSize); + Set indexSet = new HashSet<>(indexSize); for (MessageExt msg : msgs) { indexSet.add(getShardingKeyIndexByMsg(msg, indexSize)); } diff --git a/common/src/test/java/org/apache/rocketmq/common/MessageBatchTest.java b/common/src/test/java/org/apache/rocketmq/common/MessageBatchTest.java index f264420760..5876cbdd88 100644 --- a/common/src/test/java/org/apache/rocketmq/common/MessageBatchTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/MessageBatchTest.java @@ -26,7 +26,7 @@ import org.junit.Test; public class MessageBatchTest { public List generateMessages() { - List messages = new ArrayList(); + List messages = new ArrayList<>(); Message message1 = new Message("topic1", "body".getBytes()); Message message2 = new Message("topic1", "body".getBytes()); diff --git a/common/src/test/java/org/apache/rocketmq/common/MessageEncodeDecodeTest.java b/common/src/test/java/org/apache/rocketmq/common/MessageEncodeDecodeTest.java index 42d3909d99..7c73147e0c 100644 --- a/common/src/test/java/org/apache/rocketmq/common/MessageEncodeDecodeTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/MessageEncodeDecodeTest.java @@ -46,7 +46,7 @@ public class MessageEncodeDecodeTest { @Test public void testEncodeDecodeList() throws Exception { - List messages = new ArrayList(128); + List messages = new ArrayList<>(128); for (int i = 0; i < 100; i++) { Message message = new Message("topic", ("body" + i).getBytes()); message.setFlag(i); diff --git a/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java index 9001fc16c1..40e6286e25 100644 --- a/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/RegisterBrokerBodyTest.java @@ -33,7 +33,7 @@ public class RegisterBrokerBodyTest { TopicConfigAndMappingSerializeWrapper topicConfigSerializeWrapper = new TopicConfigAndMappingSerializeWrapper(); registerBrokerBody.setTopicConfigSerializeWrapper(topicConfigSerializeWrapper); - ConcurrentMap topicConfigTable = new ConcurrentHashMap(); + ConcurrentMap topicConfigTable = new ConcurrentHashMap<>(); for (int i = 0; i < 10000; i++) { topicConfigTable.put(String.valueOf(i), new TopicConfig(String.valueOf(i))); } diff --git a/common/src/test/java/org/apache/rocketmq/common/admin/TopicStatsTableTest.java b/common/src/test/java/org/apache/rocketmq/common/admin/TopicStatsTableTest.java index 22ea926af8..22e90c1a84 100644 --- a/common/src/test/java/org/apache/rocketmq/common/admin/TopicStatsTableTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/admin/TopicStatsTableTest.java @@ -44,7 +44,7 @@ public class TopicStatsTableTest { @Before public void buildTopicStatsTable() { - HashMap offsetTableMap = new HashMap(); + HashMap offsetTableMap = new HashMap<>(); MessageQueue messageQueue = new MessageQueue(TEST_TOPIC, TEST_BROKER, QUEUE_ID); diff --git a/common/src/test/java/org/apache/rocketmq/common/filter/FilterAPITest.java b/common/src/test/java/org/apache/rocketmq/common/filter/FilterAPITest.java index bf14207c30..7eb712bd6b 100644 --- a/common/src/test/java/org/apache/rocketmq/common/filter/FilterAPITest.java +++ b/common/src/test/java/org/apache/rocketmq/common/filter/FilterAPITest.java @@ -37,7 +37,7 @@ public class FilterAPITest { assertThat(subscriptionData.getTopic()).isEqualTo(topic); assertThat(subscriptionData.getSubString()).isEqualTo(subString); String[] tags = subString.split("\\|\\|"); - Set tagSet = new HashSet(); + Set tagSet = new HashSet<>(); for (String tag : tags) { tagSet.add(tag.trim()); } diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java index a67df50722..c74b77b7c9 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/ClusterInfoTest.java @@ -74,8 +74,8 @@ public class ClusterInfoTest { private ClusterInfo buildClusterInfo() throws Exception { ClusterInfo clusterInfo = new ClusterInfo(); - HashMap brokerAddrTable = new HashMap(); - HashMap> clusterAddrTable = new HashMap>(); + HashMap brokerAddrTable = new HashMap<>(); + HashMap> clusterAddrTable = new HashMap<>(); //build brokerData BrokerData brokerData = new BrokerData(); @@ -83,13 +83,13 @@ public class ClusterInfoTest { brokerData.setCluster("DEFAULT_CLUSTER"); //build brokerAddrs - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(MixAll.MASTER_ID, MixAll.getLocalhostByNetworkInterface()); brokerData.setBrokerAddrs(brokerAddrs); brokerAddrTable.put("master", brokerData); - Set brokerNames = new HashSet(); + Set brokerNames = new HashSet<>(); brokerNames.add("master"); clusterAddrTable.put("DEFAULT_CLUSTER", brokerNames); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java index f5f05a0444..0b9771b14e 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/GroupListTest.java @@ -45,7 +45,7 @@ public class GroupListTest { } private HashSet createUniqueNewSet() { - HashSet groups = new HashSet(); + HashSet groups = new HashSet<>(); groups.add(UUID.randomUUID().toString()); return groups; } diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java index 022f1b6e3c..5950128463 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/QueryConsumeTimeSpanBodyTest.java @@ -49,7 +49,7 @@ public class QueryConsumeTimeSpanBodyTest { @Test public void testFromJson() throws Exception { QueryConsumeTimeSpanBody qctsb = new QueryConsumeTimeSpanBody(); - List queueTimeSpans = new ArrayList(); + List queueTimeSpans = new ArrayList<>(); QueueTimeSpan queueTimeSpan = new QueueTimeSpan(); queueTimeSpan.setMinTimeStamp(1550825710000L); queueTimeSpan.setMaxTimeStamp(1550825790000L); @@ -100,7 +100,7 @@ public class QueryConsumeTimeSpanBodyTest { } private List newUniqueConsumeTimeSpanSet() { - List queueTimeSpans = new ArrayList(); + List queueTimeSpans = new ArrayList<>(); QueueTimeSpan queueTimeSpan = new QueueTimeSpan(); queueTimeSpan.setMinTimeStamp(System.currentTimeMillis()); queueTimeSpan.setMaxTimeStamp(UtilAll.computeNextHourTimeMillis()); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsListTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsListTest.java index 088ca05ee6..24e06d6f10 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsListTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumeStatsListTest.java @@ -33,11 +33,11 @@ public class ConsumeStatsListTest { @Test public void testFromJson() { ConsumeStats consumeStats = new ConsumeStats(); - ArrayList consumeStatsListValue = new ArrayList(); + ArrayList consumeStatsListValue = new ArrayList<>(); consumeStatsListValue.add(consumeStats); - HashMap> map = new HashMap>(); + HashMap> map = new HashMap<>(); map.put("subscriptionGroupName", consumeStatsListValue); - List>> consumeStatsListValue2 = new ArrayList>>(); + List>> consumeStatsListValue2 = new ArrayList<>(); consumeStatsListValue2.add(map); String brokerAddr = "brokerAddr"; diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerConnectionTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerConnectionTest.java index be1460ebca..016756e883 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerConnectionTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerConnectionTest.java @@ -35,11 +35,11 @@ public class ConsumerConnectionTest { @Test public void testFromJson() { ConsumerConnection consumerConnection = new ConsumerConnection(); - HashSet connections = new HashSet(); + HashSet connections = new HashSet<>(); Connection conn = new Connection(); connections.add(conn); - ConcurrentHashMap subscriptionTable = new ConcurrentHashMap(); + ConcurrentHashMap subscriptionTable = new ConcurrentHashMap<>(); SubscriptionData subscriptionData = new SubscriptionData(); subscriptionTable.put("topicA", subscriptionData); @@ -68,7 +68,7 @@ public class ConsumerConnectionTest { @Test public void testComputeMinVersion() { ConsumerConnection consumerConnection = new ConsumerConnection(); - HashSet connections = new HashSet(); + HashSet connections = new HashSet<>(); Connection conn1 = new Connection(); conn1.setVersion(1); connections.add(conn1); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java index 98d02853c4..4a6455d582 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ConsumerRunningInfoTest.java @@ -45,16 +45,16 @@ public class ConsumerRunningInfoTest { consumerRunningInfo = new ConsumerRunningInfo(); consumerRunningInfo.setJstack("test"); - TreeMap mqTable = new TreeMap(); + TreeMap mqTable = new TreeMap<>(); messageQueue = new MessageQueue("topicA","broker", 1); mqTable.put(messageQueue, new ProcessQueueInfo()); consumerRunningInfo.setMqTable(mqTable); - TreeMap statusTable = new TreeMap(); + TreeMap statusTable = new TreeMap<>(); statusTable.put("topicA", new ConsumeStatus()); consumerRunningInfo.setStatusTable(statusTable); - TreeSet subscriptionSet = new TreeSet(); + TreeSet subscriptionSet = new TreeSet<>(); subscriptionSet.add(new SubscriptionData()); consumerRunningInfo.setSubscriptionSet(subscriptionSet); @@ -63,7 +63,7 @@ public class ConsumerRunningInfoTest { properties.put(ConsumerRunningInfo.PROP_CONSUMER_START_TIMESTAMP, System.currentTimeMillis()); consumerRunningInfo.setProperties(properties); - criTable = new TreeMap(); + criTable = new TreeMap<>(); criTable.put("client_id", consumerRunningInfo); } diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/KVTableTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/KVTableTest.java index 6a39cee987..0d6e2558ef 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/KVTableTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/KVTableTest.java @@ -28,7 +28,7 @@ public class KVTableTest { @Test public void testFromJson() throws Exception { - HashMap table = new HashMap(); + HashMap table = new HashMap<>(); table.put("key1", "value1"); table.put("key2", "value2"); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java index a3b16587df..3588ce4a67 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/MessageRequestModeSerializeWrapperTest.java @@ -30,7 +30,7 @@ public class MessageRequestModeSerializeWrapperTest { public void testFromJson() { MessageRequestModeSerializeWrapper messageRequestModeSerializeWrapper = new MessageRequestModeSerializeWrapper(); ConcurrentHashMap> - messageRequestModeMap = new ConcurrentHashMap>(); + messageRequestModeMap = new ConcurrentHashMap<>(); String topic = "TopicTest"; String group = "Consumer"; MessageRequestMode requestMode = MessageRequestMode.POP; diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java index c4699705e3..db8f976276 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryConsumeQueueResponseBodyTest.java @@ -40,7 +40,7 @@ public class QueryConsumeQueueResponseBodyTest { data.setPhysicOffset(10L); data.setPhysicSize(1); data.setTagsCode(1L); - List list = new ArrayList(); + List list = new ArrayList<>(); list.add(data); body.setQueueData(list); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBodyTest.java index d0c4b5026c..171ae214e0 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBodyTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/QueryCorrectionOffsetBodyTest.java @@ -30,7 +30,7 @@ public class QueryCorrectionOffsetBodyTest { @Test public void testFromJson() throws Exception { QueryCorrectionOffsetBody qcob = new QueryCorrectionOffsetBody(); - Map offsetMap = new HashMap(); + Map offsetMap = new HashMap<>(); offsetMap.put(1, 100L); offsetMap.put(2, 200L); qcob.setCorrectionOffsets(offsetMap); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ResetOffsetBodyTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ResetOffsetBodyTest.java index f9559a92c1..54f9f35d9e 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/ResetOffsetBodyTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/ResetOffsetBodyTest.java @@ -31,7 +31,7 @@ public class ResetOffsetBodyTest { @Test public void testFromJson() throws Exception { ResetOffsetBody rob = new ResetOffsetBody(); - Map offsetMap = new HashMap(); + Map offsetMap = new HashMap<>(); MessageQueue queue = new MessageQueue(); queue.setQueueId(1); queue.setBrokerName("brokerName"); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java index 009c80d9f9..066e718c9a 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/body/SubscriptionGroupWrapperTest.java @@ -29,7 +29,7 @@ public class SubscriptionGroupWrapperTest { @Test public void testFromJson() { SubscriptionGroupWrapper subscriptionGroupWrapper = new SubscriptionGroupWrapper(); - ConcurrentHashMap subscriptions = new ConcurrentHashMap(); + ConcurrentHashMap subscriptions = new ConcurrentHashMap<>(); SubscriptionGroupConfig subscriptionGroupConfig = new SubscriptionGroupConfig(); subscriptionGroupConfig.setConsumeBroadcastEnable(true); subscriptionGroupConfig.setBrokerId(1234); diff --git a/common/src/test/java/org/apache/rocketmq/common/protocol/route/TopicRouteDataTest.java b/common/src/test/java/org/apache/rocketmq/common/protocol/route/TopicRouteDataTest.java index f72f8f488f..8508dbfa65 100644 --- a/common/src/test/java/org/apache/rocketmq/common/protocol/route/TopicRouteDataTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/protocol/route/TopicRouteDataTest.java @@ -40,10 +40,10 @@ public class TopicRouteDataTest { queueData.setWriteQueueNums(8); queueData.setTopicSysFlag(0); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); queueDataList.add(queueData); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "192.168.0.47:10911"); brokerAddrs.put(1L, "192.168.0.47:10921"); @@ -52,11 +52,11 @@ public class TopicRouteDataTest { brokerData.setBrokerName("broker-a"); brokerData.setCluster("TestCluster"); - List brokerDataList = new ArrayList(); + List brokerDataList = new ArrayList<>(); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - topicRouteData.setFilterServerTable(new HashMap>()); + topicRouteData.setFilterServerTable(new HashMap<>()); topicRouteData.setQueueDatas(queueDataList); assertThat(new TopicRouteData(topicRouteData)).isEqualTo(topicRouteData); @@ -75,10 +75,10 @@ public class TopicRouteDataTest { queueData.setWriteQueueNums(8); queueData.setTopicSysFlag(0); - List queueDataList = new ArrayList(); + List queueDataList = new ArrayList<>(); queueDataList.add(queueData); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(0L, "192.168.0.47:10911"); brokerAddrs.put(1L, "192.168.0.47:10921"); @@ -87,11 +87,11 @@ public class TopicRouteDataTest { brokerData.setBrokerName("broker-a"); brokerData.setCluster("TestCluster"); - List brokerDataList = new ArrayList(); + List brokerDataList = new ArrayList<>(); brokerDataList.add(brokerData); topicRouteData.setBrokerDatas(brokerDataList); - topicRouteData.setFilterServerTable(new HashMap>()); + topicRouteData.setFilterServerTable(new HashMap<>()); topicRouteData.setQueueDatas(queueDataList); String topicRouteDataJsonStr = RemotingSerializable.toJson(topicRouteData, true); diff --git a/common/src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtilsTest.java b/common/src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtilsTest.java index c9bd22e03f..08148e019f 100644 --- a/common/src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtilsTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtilsTest.java @@ -38,7 +38,7 @@ public class TopicQueueMappingUtilsTest { } private Set buildTargetBrokers(int num, String suffix) { - Set brokers = new HashSet(); + Set brokers = new HashSet<>(); for (int i = 0; i < num; i++) { brokers.add("broker" + suffix + i); } @@ -46,7 +46,7 @@ public class TopicQueueMappingUtilsTest { } private Map buildBrokerNumMap(int num) { - Map map = new HashMap(); + Map map = new HashMap<>(); for (int i = 0; i < num; i++) { map.put("broker" + i, 0); } @@ -54,7 +54,7 @@ public class TopicQueueMappingUtilsTest { } private Map buildBrokerNumMap(int num, int queues) { - Map map = new HashMap(); + Map map = new HashMap<>(); int random = new Random().nextInt(num); for (int i = 0; i < num; i++) { map.put("broker" + i, queues); @@ -66,7 +66,7 @@ public class TopicQueueMappingUtilsTest { } private void testIdToBroker(Map idToBroker, Map brokerNumMap) { - Map brokerNumOther = new HashMap(); + Map brokerNumOther = new HashMap<>(); for (int i = 0; i < idToBroker.size(); i++) { Assert.assertTrue(idToBroker.containsKey(i)); String broker = idToBroker.get(i); @@ -88,7 +88,7 @@ public class TopicQueueMappingUtilsTest { for (int i = 0; i < 10; i++) { int num = 3; Map brokerNumMap = buildBrokerNumMap(num); - TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap(), brokerNumMap, null); + TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap<>(), brokerNumMap, null); allocator.upToNum(num * 2); for (Map.Entry entry: allocator.getBrokerNumMap().entrySet()) { Assert.assertEquals(2L, entry.getValue().longValue()); @@ -113,7 +113,7 @@ public class TopicQueueMappingUtilsTest { int num = (i + 2) * 2; Map brokerNumMap = buildBrokerNumMap(num); Map brokerNumMapBeforeRemapping = buildBrokerNumMap(num, num); - TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap(), brokerNumMap, brokerNumMapBeforeRemapping); + TopicQueueMappingUtils.MappingAllocator allocator = TopicQueueMappingUtils.buildMappingAllocator(new HashMap<>(), brokerNumMap, brokerNumMapBeforeRemapping); allocator.upToNum(num * num + 1); Assert.assertEquals(brokerNumMapBeforeRemapping, allocator.getBrokerNumMap()); } @@ -125,11 +125,11 @@ public class TopicQueueMappingUtilsTest { String topic = "static"; String broker1 = "broker1"; String broker2 = "broker2"; - Set targetBrokers = new HashSet(); + Set targetBrokers = new HashSet<>(); targetBrokers.add(broker1); - Map brokerConfigMap = new HashMap(); + Map brokerConfigMap = new HashMap<>(); TopicQueueMappingDetail mappingDetail = new TopicQueueMappingDetail(topic, 0, broker2, 0); - mappingDetail.getHostedQueues().put(1, new ArrayList()); + mappingDetail.getHostedQueues().put(1, new ArrayList<>()); brokerConfigMap.put(broker2, new TopicConfigAndQueueMapping(new TopicConfig(topic, 0, 0), mappingDetail)); TopicQueueMappingUtils.checkTargetBrokersComplete(targetBrokers, brokerConfigMap); } @@ -140,7 +140,7 @@ public class TopicQueueMappingUtilsTest { public void testCreateStaticTopic() { String topic = "static"; int queueNum; - Map brokerConfigMap = new HashMap(); + Map brokerConfigMap = new HashMap<>(); for (int i = 1; i < 10; i++) { Set targetBrokers = buildTargetBrokers(2 * i); Set nonTargetBrokers = buildTargetBrokers(2 * i, "test"); @@ -152,7 +152,7 @@ public class TopicQueueMappingUtilsTest { //do the check manually Map.Entry maxEpochAndNum = TopicQueueMappingUtils.checkNameEpochNumConsistence(topic, brokerConfigMap); Assert.assertEquals(queueNum, maxEpochAndNum.getValue().longValue()); - Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); + Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList<>(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); TopicQueueMappingUtils.checkIfReusePhysicalQueue(globalIdMap.values()); TopicQueueMappingUtils.checkPhysicalQueueConsistence(brokerConfigMap); @@ -183,7 +183,7 @@ public class TopicQueueMappingUtilsTest { public void testRemappingStaticTopic() { String topic = "static"; int queueNum = 7; - Map brokerConfigMap = new HashMap(); + Map brokerConfigMap = new HashMap<>(); Set originalBrokers = buildTargetBrokers(2); TopicRemappingDetailWrapper wrapper = TopicQueueMappingUtils.createTopicConfigMapping(topic, queueNum, originalBrokers, brokerConfigMap); Assert.assertEquals(wrapper.getBrokerConfigMap(), brokerConfigMap); @@ -193,7 +193,7 @@ public class TopicQueueMappingUtilsTest { //do the check manually TopicQueueMappingUtils.checkNameEpochNumConsistence(topic, brokerConfigMap); TopicQueueMappingUtils.checkPhysicalQueueConsistence(brokerConfigMap); - Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); + Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList<>(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); TopicQueueMappingUtils.checkIfReusePhysicalQueue(globalIdMap.values()); } @@ -203,7 +203,7 @@ public class TopicQueueMappingUtilsTest { //do the check manually TopicQueueMappingUtils.checkNameEpochNumConsistence(topic, brokerConfigMap); TopicQueueMappingUtils.checkPhysicalQueueConsistence(brokerConfigMap); - Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); + Map globalIdMap = TopicQueueMappingUtils.checkAndBuildMappingItems(new ArrayList<>(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values())), false, true); TopicQueueMappingUtils.checkIfReusePhysicalQueue(globalIdMap.values()); TopicQueueMappingUtils.checkLeaderInTargetBrokers(globalIdMap.values(), targetBrokers); @@ -227,7 +227,7 @@ public class TopicQueueMappingUtilsTest { public void testRemappingStaticTopicStability() { String topic = "static"; int queueNum = 7; - Map brokerConfigMap = new HashMap(); + Map brokerConfigMap = new HashMap<>(); Set originalBrokers = buildTargetBrokers(2); { TopicRemappingDetailWrapper wrapper = TopicQueueMappingUtils.createTopicConfigMapping(topic, queueNum, originalBrokers, brokerConfigMap); @@ -249,7 +249,7 @@ public class TopicQueueMappingUtilsTest { public void testUtilsCheck() { String topic = "static"; int queueNum = 10; - Map brokerConfigMap = new HashMap(); + Map brokerConfigMap = new HashMap<>(); Set targetBrokers = buildTargetBrokers(2); TopicRemappingDetailWrapper wrapper = TopicQueueMappingUtils.createTopicConfigMapping(topic, queueNum, targetBrokers, brokerConfigMap); Assert.assertEquals(wrapper.getBrokerConfigMap(), brokerConfigMap); @@ -287,7 +287,7 @@ public class TopicQueueMappingUtilsTest { try { - configMapping.getMappingDetail().getHostedQueues().put(10000, new ArrayList(Collections.singletonList(new LogicQueueMappingItem(1, 1, targetBrokers.iterator().next(), 0, 0, -1, -1, -1)))); + configMapping.getMappingDetail().getHostedQueues().put(10000, new ArrayList<>(Collections.singletonList(new LogicQueueMappingItem(1, 1, targetBrokers.iterator().next(), 0, 0, -1, -1, -1)))); TopicQueueMappingUtils.checkAndBuildMappingItems(TopicQueueMappingUtils.getMappingDetailFromConfig(brokerConfigMap.values()), false, true); } catch (RuntimeException ignore) { exceptionNum++; diff --git a/common/src/test/java/org/apache/rocketmq/common/stats/StatsItemSetTest.java b/common/src/test/java/org/apache/rocketmq/common/stats/StatsItemSetTest.java index d834160d63..b02fb60ae4 100644 --- a/common/src/test/java/org/apache/rocketmq/common/stats/StatsItemSetTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/stats/StatsItemSetTest.java @@ -52,7 +52,7 @@ public class StatsItemSetTest { final String rtStatKey = "rtTest"; final StatsItemSet statsItemSet = new StatsItemSet(tpsStatKey, scheduler, null); executor = new ThreadPoolExecutor(10, 20, 10, TimeUnit.SECONDS, - new ArrayBlockingQueue(100), new ThreadFactoryImpl("testMultiThread")); + new ArrayBlockingQueue<>(100), new ThreadFactoryImpl("testMultiThread")); for (int i = 0; i < 10; i++) { executor.submit(new Runnable() { @Override @@ -100,7 +100,7 @@ public class StatsItemSetTest { private LongAdder test_unit() throws InterruptedException { final StatsItemSet statsItemSet = new StatsItemSet("topicTest", scheduler, null); executor = new ThreadPoolExecutor(10, 20, 10, TimeUnit.SECONDS, - new ArrayBlockingQueue(100), new ThreadFactoryImpl("testMultiThread")); + new ArrayBlockingQueue<>(100), new ThreadFactoryImpl("testMultiThread")); for (int i = 0; i < 10; i++) { executor.submit(new Runnable() { @Override @@ -121,7 +121,7 @@ public class StatsItemSetTest { private AtomicLong test_unit_moment() throws InterruptedException { final MomentStatsItemSet statsItemSet = new MomentStatsItemSet("topicTest", scheduler, null); executor = new ThreadPoolExecutor(10, 20, 10, TimeUnit.SECONDS, - new ArrayBlockingQueue(100), new ThreadFactoryImpl("testMultiThread")); + new ArrayBlockingQueue<>(100), new ThreadFactoryImpl("testMultiThread")); for (int i = 0; i < 10; i++) { executor.submit(new Runnable() { @Override diff --git a/controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java b/controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java index f8ae7eb4f2..aa3e856d6b 100644 --- a/controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java +++ b/controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java @@ -86,7 +86,7 @@ public class ControllerManager { new ThreadFactoryImpl("ControllerRequestExecutorThread_")) { @Override protected RunnableFuture newTaskFor(final Runnable runnable, final T value) { - return new FutureTaskExt(runnable, value); + return new FutureTaskExt<>(runnable, value); } }; this.heartbeatManager = new DefaultBrokerHeartbeatManager(this.controllerConfig); diff --git a/example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java b/example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java index 8476875171..ef7bd4dc65 100644 --- a/example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java +++ b/example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java @@ -82,7 +82,7 @@ public class Consumer { ScheduledExecutorService executorService = new ScheduledThreadPoolExecutor(1, new BasicThreadFactory.Builder().namingPattern("BenchmarkTimerThread-%d").daemon(true).build()); - final LinkedList snapshotList = new LinkedList(); + final LinkedList snapshotList = new LinkedList<>(); executorService.scheduleAtFixedRate(new TimerTask() { @Override diff --git a/example/src/main/java/org/apache/rocketmq/example/benchmark/Producer.java b/example/src/main/java/org/apache/rocketmq/example/benchmark/Producer.java index 245a209a4f..ac164a0819 100644 --- a/example/src/main/java/org/apache/rocketmq/example/benchmark/Producer.java +++ b/example/src/main/java/org/apache/rocketmq/example/benchmark/Producer.java @@ -100,7 +100,7 @@ public class Producer { ScheduledExecutorService executorService = new ScheduledThreadPoolExecutor(1, new BasicThreadFactory.Builder().namingPattern("BenchmarkTimerThread-%d").daemon(true).build()); - final LinkedList snapshotList = new LinkedList(); + final LinkedList snapshotList = new LinkedList<>(); final long[] msgNums = new long[threadCount]; diff --git a/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java b/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java index ababfc6700..f2ab6b5731 100644 --- a/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java +++ b/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java @@ -45,7 +45,7 @@ public class TimerConsumer { private final ScheduledExecutorService scheduledExecutor = new ScheduledThreadPoolExecutor(1, new ThreadFactoryImpl("ConsumerScheduleThread_")); private final StatsBenchmarkConsumer statsBenchmark = new StatsBenchmarkConsumer(); - private final LinkedList snapshotList = new LinkedList(); + private final LinkedList snapshotList = new LinkedList<>(); private final DefaultMQPushConsumer consumer; diff --git a/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerProducer.java b/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerProducer.java index da0270e990..e4b1d87cc5 100644 --- a/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerProducer.java +++ b/example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerProducer.java @@ -63,7 +63,7 @@ public class TimerProducer { private final ExecutorService sendThreadPool; private final StatsBenchmarkProducer statsBenchmark = new StatsBenchmarkProducer(); - private final LinkedList snapshotList = new LinkedList(); + private final LinkedList snapshotList = new LinkedList<>(); private final DefaultMQProducer producer; @@ -90,7 +90,7 @@ public class TimerProducer { threadCount, 0L, TimeUnit.MILLISECONDS, - new LinkedBlockingQueue(), + new LinkedBlockingQueue<>(), new ThreadFactoryImpl("ProducerSendMessageThread_")); producer = new DefaultMQProducer("benchmark_producer"); @@ -138,7 +138,7 @@ public class TimerProducer { public void start() throws MQClientException { producer.start(); System.out.printf("Start sending messages%n"); - List delayList = new ArrayList(); + List delayList = new ArrayList<>(); final long startDelayTime = System.currentTimeMillis() / precisionMs * precisionMs + 2 * 60 * 1000 + 10; for (int slotCnt = 0; slotCnt < slotsTotal; slotCnt++) { for (int msgCnt = 0; msgCnt < msgsTotalPerSlotThread; msgCnt++) { diff --git a/example/src/main/java/org/apache/rocketmq/example/simple/AclClient.java b/example/src/main/java/org/apache/rocketmq/example/simple/AclClient.java index c1f56ec9c2..15134a5210 100644 --- a/example/src/main/java/org/apache/rocketmq/example/simple/AclClient.java +++ b/example/src/main/java/org/apache/rocketmq/example/simple/AclClient.java @@ -44,7 +44,7 @@ import org.apache.rocketmq.remoting.common.RemotingHelper; public class AclClient { - private static final Map OFFSE_TABLE = new HashMap(); + private static final Map OFFSE_TABLE = new HashMap<>(); private static final String ACL_ACCESS_KEY = "RocketMQ"; diff --git a/example/src/main/java/org/apache/rocketmq/example/simple/CachedQueue.java b/example/src/main/java/org/apache/rocketmq/example/simple/CachedQueue.java index 9e6ab92c7d..41e28c5915 100644 --- a/example/src/main/java/org/apache/rocketmq/example/simple/CachedQueue.java +++ b/example/src/main/java/org/apache/rocketmq/example/simple/CachedQueue.java @@ -21,7 +21,7 @@ import java.util.TreeMap; import org.apache.rocketmq.common.message.MessageExt; public class CachedQueue { - private final TreeMap msgCachedTable = new TreeMap(); + private final TreeMap msgCachedTable = new TreeMap<>(); public TreeMap getMsgCachedTable() { return msgCachedTable; diff --git a/example/src/main/java/org/apache/rocketmq/example/simple/RandomAsyncCommit.java b/example/src/main/java/org/apache/rocketmq/example/simple/RandomAsyncCommit.java index 031cb15136..d4bd0ea6e4 100644 --- a/example/src/main/java/org/apache/rocketmq/example/simple/RandomAsyncCommit.java +++ b/example/src/main/java/org/apache/rocketmq/example/simple/RandomAsyncCommit.java @@ -24,7 +24,7 @@ import org.apache.rocketmq.common.message.MessageQueue; public class RandomAsyncCommit { private final ConcurrentHashMap mqCachedTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); public void putMessages(final MessageQueue mq, final List msgs) { CachedQueue cachedQueue = this.mqCachedTable.get(mq); diff --git a/filter/src/main/java/org/apache/rocketmq/filter/FilterFactory.java b/filter/src/main/java/org/apache/rocketmq/filter/FilterFactory.java index f1e1c7d73f..71a8b4d4bd 100644 --- a/filter/src/main/java/org/apache/rocketmq/filter/FilterFactory.java +++ b/filter/src/main/java/org/apache/rocketmq/filter/FilterFactory.java @@ -27,7 +27,7 @@ public class FilterFactory { public static final FilterFactory INSTANCE = new FilterFactory(); - protected static final Map FILTER_SPI_HOLDER = new HashMap(4); + protected static final Map FILTER_SPI_HOLDER = new HashMap<>(4); static { FilterFactory.INSTANCE.register(new SqlFilter()); diff --git a/filter/src/main/java/org/apache/rocketmq/filter/expression/ComparisonExpression.java b/filter/src/main/java/org/apache/rocketmq/filter/expression/ComparisonExpression.java index 9a919c4441..b793cdf976 100644 --- a/filter/src/main/java/org/apache/rocketmq/filter/expression/ComparisonExpression.java +++ b/filter/src/main/java/org/apache/rocketmq/filter/expression/ComparisonExpression.java @@ -32,7 +32,7 @@ import java.util.List; */ public abstract class ComparisonExpression extends BinaryExpression implements BooleanExpression { - public static final ThreadLocal CONVERT_STRING_EXPRESSIONS = new ThreadLocal(); + public static final ThreadLocal CONVERT_STRING_EXPRESSIONS = new ThreadLocal<>(); boolean convertStringExpressions = false; diff --git a/filter/src/main/java/org/apache/rocketmq/filter/expression/UnaryExpression.java b/filter/src/main/java/org/apache/rocketmq/filter/expression/UnaryExpression.java index 7f18ddd541..7a62624b51 100644 --- a/filter/src/main/java/org/apache/rocketmq/filter/expression/UnaryExpression.java +++ b/filter/src/main/java/org/apache/rocketmq/filter/expression/UnaryExpression.java @@ -82,7 +82,7 @@ public abstract class UnaryExpression implements Expression { } else if (elements.size() < 5) { t = elements; } else { - t = new HashSet(elements); + t = new HashSet<>(elements); } final Collection inList = t; diff --git a/filter/src/main/java/org/apache/rocketmq/filter/parser/SelectorParser.java b/filter/src/main/java/org/apache/rocketmq/filter/parser/SelectorParser.java index 73502d3c69..5658391fd5 100644 --- a/filter/src/main/java/org/apache/rocketmq/filter/parser/SelectorParser.java +++ b/filter/src/main/java/org/apache/rocketmq/filter/parser/SelectorParser.java @@ -1214,7 +1214,7 @@ public class SelectorParser implements SelectorParserConstants { return jjNtk = jjNt.kind; } - private java.util.List jjExpentries = new java.util.ArrayList(); + private java.util.List jjExpentries = new java.util.ArrayList<>(); private int[] jjExpentry; private int jjKind = -1; private int[] jjLasttokens = new int[100]; diff --git a/filter/src/test/java/org/apache/rocketmq/filter/ExpressionTest.java b/filter/src/test/java/org/apache/rocketmq/filter/ExpressionTest.java index 7fb606ac13..8b02a2627d 100644 --- a/filter/src/test/java/org/apache/rocketmq/filter/ExpressionTest.java +++ b/filter/src/test/java/org/apache/rocketmq/filter/ExpressionTest.java @@ -576,7 +576,7 @@ public class ExpressionTest { class PropertyContext implements EvaluationContext { - public Map properties = new HashMap(8); + public Map properties = new HashMap<>(8); @Override public Object get(final String name) { diff --git a/logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java b/logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java index d95245356e..114e068eaa 100644 --- a/logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java @@ -345,7 +345,7 @@ public class InnerLoggerFactory extends InternalLoggerFactory { private static void objectArrayAppend(StringBuilder sbuf, Object[] a, Map seenMap) { if (seenMap == null) { - seenMap = new HashMap(); + seenMap = new HashMap<>(); } sbuf.append('['); if (!seenMap.containsKey(a)) { diff --git a/logging/src/main/java/org/apache/rocketmq/logging/InternalLoggerFactory.java b/logging/src/main/java/org/apache/rocketmq/logging/InternalLoggerFactory.java index c71b108ba3..9c21f664b2 100644 --- a/logging/src/main/java/org/apache/rocketmq/logging/InternalLoggerFactory.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/InternalLoggerFactory.java @@ -38,9 +38,9 @@ public abstract class InternalLoggerFactory { private static String loggerType = null; - public static final ThreadLocal BROKER_IDENTITY = new ThreadLocal(); + public static final ThreadLocal BROKER_IDENTITY = new ThreadLocal<>(); - private static ConcurrentHashMap loggerFactoryCache = new ConcurrentHashMap(); + private static ConcurrentHashMap loggerFactoryCache = new ConcurrentHashMap<>(); public static InternalLogger getLogger(Class clazz) { return getLogger(clazz.getName()); diff --git a/logging/src/main/java/org/apache/rocketmq/logging/Slf4jLoggerFactory.java b/logging/src/main/java/org/apache/rocketmq/logging/Slf4jLoggerFactory.java index 5e1cd5b8b1..f1f727cc4c 100644 --- a/logging/src/main/java/org/apache/rocketmq/logging/Slf4jLoggerFactory.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/Slf4jLoggerFactory.java @@ -52,7 +52,7 @@ public class Slf4jLoggerFactory extends InternalLoggerFactory { private final String loggerSuffix; private final Logger defaultLogger; - private final Map loggerMap = new HashMap(); + private final Map loggerMap = new HashMap<>(); public Slf4jLogger(String loggerSuffix) { this.loggerSuffix = loggerSuffix; diff --git a/logging/src/main/java/org/apache/rocketmq/logging/inner/Appender.java b/logging/src/main/java/org/apache/rocketmq/logging/inner/Appender.java index c06156310f..d40d6cb313 100755 --- a/logging/src/main/java/org/apache/rocketmq/logging/inner/Appender.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/inner/Appender.java @@ -131,7 +131,7 @@ public abstract class Appender { } if (appenderList == null) { - appenderList = new Vector(1); + appenderList = new Vector<>(1); } if (!appenderList.contains(newAppender)) { appenderList.addElement(newAppender); diff --git a/logging/src/main/java/org/apache/rocketmq/logging/inner/Logger.java b/logging/src/main/java/org/apache/rocketmq/logging/inner/Logger.java index 470ed41daf..7584ea3172 100755 --- a/logging/src/main/java/org/apache/rocketmq/logging/inner/Logger.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/inner/Logger.java @@ -276,7 +276,7 @@ public class Logger implements Appender.AppenderPipeline { public static class DefaultLoggerRepository implements LoggerRepository { - final Hashtable ht = new Hashtable(); + final Hashtable ht = new Hashtable<>(); Logger root; int logLevelInt; @@ -348,7 +348,7 @@ public class Logger implements Appender.AppenderPipeline { } public Enumeration getCurrentLoggers() { - Vector loggers = new Vector(ht.size()); + Vector loggers = new Vector<>(ht.size()); Enumeration elems = ht.elements(); while (elems.hasMoreElements()) { diff --git a/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingBuilder.java b/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingBuilder.java index 50b72119c3..ea669cfcfb 100644 --- a/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingBuilder.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingBuilder.java @@ -145,9 +145,9 @@ public class LoggingBuilder { public static final int DEFAULT_BUFFER_SIZE = 128; - private final List buffer = new ArrayList(); + private final List buffer = new ArrayList<>(); - private final Map discardMap = new HashMap(); + private final Map discardMap = new HashMap<>(); private int bufferSize = DEFAULT_BUFFER_SIZE; diff --git a/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingEvent.java b/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingEvent.java index 44554e2b7e..06fa6aed9d 100644 --- a/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingEvent.java +++ b/logging/src/main/java/org/apache/rocketmq/logging/inner/LoggingEvent.java @@ -104,7 +104,7 @@ public class LoggingEvent implements java.io.Serializable { pw.flush(); LineNumberReader reader = new LineNumberReader( new StringReader(sw.toString())); - ArrayList lines = new ArrayList(); + ArrayList lines = new ArrayList<>(); try { String line = reader.readLine(); while (line != null) { diff --git a/namesrv/src/main/java/org/apache/rocketmq/namesrv/kvconfig/KVConfigManager.java b/namesrv/src/main/java/org/apache/rocketmq/namesrv/kvconfig/KVConfigManager.java index 0ea14c77a1..54c179e231 100644 --- a/namesrv/src/main/java/org/apache/rocketmq/namesrv/kvconfig/KVConfigManager.java +++ b/namesrv/src/main/java/org/apache/rocketmq/namesrv/kvconfig/KVConfigManager.java @@ -35,7 +35,7 @@ public class KVConfigManager { private final ReadWriteLock lock = new ReentrantReadWriteLock(); private final HashMap> configTable = - new HashMap>(); + new HashMap<>(); public KVConfigManager(NamesrvController namesrvController) { this.namesrvController = namesrvController; diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java index 512d6b3d69..87f8382277 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/RequestProcessorTest.java @@ -574,7 +574,7 @@ public class RequestProcessorTest { topicConfigSerializeWrapper.setTopicConfigTable(topicConfigConcurrentHashMap); Channel channel = mock(Channel.class); RegisterBrokerResult registerBrokerResult = routeInfoManager.registerBroker("default-cluster", "127.0.0.1:10911", "default-broker", 1234, "127.0.0.1:1001", "", - null, topicConfigSerializeWrapper, new ArrayList(), channel); + null, topicConfigSerializeWrapper, new ArrayList<>(), channel); } diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/GetRouteInfoBenchmark.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/GetRouteInfoBenchmark.java index 8dfb88e726..4d64b6c177 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/GetRouteInfoBenchmark.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/GetRouteInfoBenchmark.java @@ -117,7 +117,7 @@ public class GetRouteInfoBenchmark { Channel channel = mock(Channel.class); routeInfoManager.registerBroker(clusterName, brokerAddr, brokerName, 0, brokerAddr, "", - null, topicConfigSerializeWrapper, new ArrayList(), channel); + null, topicConfigSerializeWrapper, new ArrayList<>(), channel); } } }); diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RegisterBrokerBenchmark.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RegisterBrokerBenchmark.java index ba3e4530d3..ac063348d7 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RegisterBrokerBenchmark.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RegisterBrokerBenchmark.java @@ -147,7 +147,7 @@ public class RegisterBrokerBenchmark { "DefaultBroker" + index, 0, "127.0.0.1:400" + index, "", null, - topicConfigSerializeWrapper, new ArrayList(), channel); + topicConfigSerializeWrapper, new ArrayList<>(), channel); } @Benchmark @@ -170,7 +170,7 @@ public class RegisterBrokerBenchmark { "DefaultBroker" + index, 0, "127.0.0.1:400" + index, "", null, - topicConfigSerializeWrapper, new ArrayList(), channel); + topicConfigSerializeWrapper, new ArrayList<>(), channel); } public static void main(String[] args) throws Exception { diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java index b0d4cbac41..9fcdc9d822 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java @@ -707,7 +707,7 @@ public class RouteInfoManagerNewTest { "", null, brokerInfo.enableActingMaster, - topicConfigSerializeWrapper, new ArrayList(), channel); + topicConfigSerializeWrapper, new ArrayList<>(), channel); return registerBrokerResult; } diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerTest.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerTest.java index 9c397ab029..c44c4d1b22 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerTest.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerTest.java @@ -90,7 +90,7 @@ public class RouteInfoManagerTest { topicConfigSerializeWrapper.setTopicConfigTable(topicConfigConcurrentHashMap); Channel channel = mock(Channel.class); RegisterBrokerResult registerBrokerResult = routeInfoManager.registerBroker("default-cluster-1", "127.0.0.1:10911", "default-broker-1", 1234, "127.0.0.1:1001", "", - null, topicConfigSerializeWrapper, new ArrayList(), channel); + null, topicConfigSerializeWrapper, new ArrayList<>(), channel); assertThat(registerBrokerResult).isNotNull(); DataVersion dataVersion0 = routeInfoManager.queryBrokerTopicConfig("default-cluster", "127.0.0.1:10911"); @@ -130,7 +130,7 @@ public class RouteInfoManagerTest { topicConfigSerializeWrapper.setTopicConfigTable(topicConfigConcurrentHashMap); Channel channel = mock(Channel.class); RegisterBrokerResult registerBrokerResult = routeInfoManager.registerBroker("default-cluster", "127.0.0.1:10911", "default-broker", 1234, "127.0.0.1:1001", "", - null, topicConfigSerializeWrapper, new ArrayList(), channel); + null, topicConfigSerializeWrapper, new ArrayList<>(), channel); assertThat(registerBrokerResult).isNotNull(); } diff --git a/openmessaging/src/main/java/io/openmessaging/rocketmq/utils/BeanUtils.java b/openmessaging/src/main/java/io/openmessaging/rocketmq/utils/BeanUtils.java index d75d749c73..73a2113586 100644 --- a/openmessaging/src/main/java/io/openmessaging/rocketmq/utils/BeanUtils.java +++ b/openmessaging/src/main/java/io/openmessaging/rocketmq/utils/BeanUtils.java @@ -34,7 +34,7 @@ public final class BeanUtils { /** * Maps primitive {@code Class}es to their corresponding wrapper {@code Class}. */ - private static Map, Class> primitiveWrapperMap = new HashMap, Class>(); + private static Map, Class> primitiveWrapperMap = new HashMap<>(); static { primitiveWrapperMap.put(Boolean.TYPE, Boolean.class); @@ -48,7 +48,7 @@ public final class BeanUtils { primitiveWrapperMap.put(Void.TYPE, Void.TYPE); } - private static Map, Class> wrapperMap = new HashMap, Class>(); + private static Map, Class> wrapperMap = new HashMap<>(); static { for (Entry, Class> primitiveClass : primitiveWrapperMap.entrySet()) { diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingUtil.java b/remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingUtil.java index aed99fa37a..df8fb61c9e 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingUtil.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingUtil.java @@ -96,8 +96,8 @@ public class RemotingUtil { try { // Traversal Network interface to get the first non-loopback and non-private address Enumeration enumeration = NetworkInterface.getNetworkInterfaces(); - ArrayList ipv4Result = new ArrayList(); - ArrayList ipv6Result = new ArrayList(); + ArrayList ipv4Result = new ArrayList<>(); + ArrayList ipv6Result = new ArrayList<>(); while (enumeration.hasMoreElements()) { final NetworkInterface networkInterface = enumeration.nextElement(); if (isBridge(networkInterface)) { diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java index 0e3b903826..2d82fbe6cd 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java @@ -94,13 +94,13 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti private final Lock lockChannelTables = new ReentrantLock(); private final Map proxyMap = new HashMap<>(); private final ConcurrentHashMap bootstrapMap = new ConcurrentHashMap<>(); - private final ConcurrentMap channelTables = new ConcurrentHashMap(); + private final ConcurrentMap channelTables = new ConcurrentHashMap<>(); private final Timer timer = new Timer("ClientHouseKeepingService", true); - private final AtomicReference> namesrvAddrList = new AtomicReference>(); - private final ConcurrentMap availableNamesrvAddrMap = new ConcurrentHashMap(); - private final AtomicReference namesrvAddrChoosed = new AtomicReference(); + private final AtomicReference> namesrvAddrList = new AtomicReference<>(); + private final ConcurrentMap availableNamesrvAddrMap = new ConcurrentHashMap<>(); + private final AtomicReference namesrvAddrChoosed = new AtomicReference<>(); private final AtomicInteger namesrvIndex = new AtomicInteger(initValueIndex()); private final Lock namesrvChannelLock = new ReentrantLock(); @@ -148,7 +148,7 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti }); this.scanExecutor = new ThreadPoolExecutor(4, 10, 60, TimeUnit.SECONDS, - new ArrayBlockingQueue(32), new ThreadFactory() { + new ArrayBlockingQueue<>(32), new ThreadFactory() { private final AtomicInteger threadIndex = new AtomicInteger(0); @Override @@ -593,7 +593,7 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti } this.closeChannel(addr, cw.getChannel()); } - interruptPullRequests(new HashSet(addrList)); + interruptPullRequests(new HashSet<>(addrList)); } private void interruptPullRequests(Set brokerAddrSet) { @@ -797,7 +797,7 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti executorThis = this.publicExecutor; } - Pair pair = new Pair(processor, executorThis); + Pair pair = new Pair<>(processor, executorThis); this.processorTable.put(requestCode, pair); } @@ -817,7 +817,7 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti @Override public List getAvailableNameSrvList() { - return new ArrayList(this.availableNamesrvAddrMap.keySet()); + return new ArrayList<>(this.availableNamesrvAddrMap.keySet()); } @Override diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java index 10a51ed207..68ccdf69dd 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java @@ -48,11 +48,11 @@ public class RemotingCommand { private static final int RPC_TYPE = 0; // 0, REQUEST_COMMAND private static final int RPC_ONEWAY = 1; // 0, RPC private static final Map, Field[]> CLASS_HASH_MAP = - new HashMap, Field[]>(); - private static final Map CANONICAL_NAME_CACHE = new HashMap(); + new HashMap<>(); + private static final Map CANONICAL_NAME_CACHE = new HashMap<>(); // 1, Oneway // 1, RESPONSE_COMMAND - private static final Map NULLABLE_FIELD_CACHE = new HashMap(); + private static final Map NULLABLE_FIELD_CACHE = new HashMap<>(); private static final String STRING_CANONICAL_NAME = String.class.getCanonicalName(); private static final String DOUBLE_CANONICAL_NAME_1 = Double.class.getCanonicalName(); private static final String DOUBLE_CANONICAL_NAME_2 = double.class.getCanonicalName(); @@ -345,7 +345,7 @@ public class RemotingCommand { Field[] field = CLASS_HASH_MAP.get(classHeader); if (field == null) { - Set fieldList = new HashSet(); + Set fieldList = new HashSet<>(); for (Class className = classHeader; className != Object.class; className = className.getSuperclass()) { Field[] fields = className.getDeclaredFields(); fieldList.addAll(Arrays.asList(fields)); @@ -427,7 +427,7 @@ public class RemotingCommand { if (this.customHeader != null) { Field[] fields = getClazzFields(customHeader.getClass()); if (null == this.extFields) { - this.extFields = new HashMap(); + this.extFields = new HashMap<>(); } for (Field field : fields) { @@ -597,7 +597,7 @@ public class RemotingCommand { public void addExtField(String key, String value) { if (null == extFields) { - extFields = new HashMap(); + extFields = new HashMap<>(); } extFields.put(key, value); } diff --git a/srvutil/src/main/java/org/apache/rocketmq/util/cache/ExpiredLocalCache.java b/srvutil/src/main/java/org/apache/rocketmq/util/cache/ExpiredLocalCache.java index ab60f0fb5e..bfece5bbfc 100644 --- a/srvutil/src/main/java/org/apache/rocketmq/util/cache/ExpiredLocalCache.java +++ b/srvutil/src/main/java/org/apache/rocketmq/util/cache/ExpiredLocalCache.java @@ -49,7 +49,7 @@ public class ExpiredLocalCache { } public T put(K key, T v, long exp) { - CacheObject value = new CacheObject(exp, v); + CacheObject value = new CacheObject<>(exp, v); CacheObject old = cache.put(key, value); if (old == null) { return null; @@ -59,7 +59,7 @@ public class ExpiredLocalCache { } public T putIfAbsent(K key, T v, long exp) { - CacheObject value = new CacheObject(exp, v); + CacheObject value = new CacheObject<>(exp, v); CacheObject old = cache.putIfAbsent(key, value); if (old == null) { return null; diff --git a/srvutil/src/main/java/org/apache/rocketmq/util/cache/LockManager.java b/srvutil/src/main/java/org/apache/rocketmq/util/cache/LockManager.java index ae6906c544..bbb9ae8d5b 100644 --- a/srvutil/src/main/java/org/apache/rocketmq/util/cache/LockManager.java +++ b/srvutil/src/main/java/org/apache/rocketmq/util/cache/LockManager.java @@ -22,7 +22,7 @@ import org.apache.rocketmq.common.PopAckConstants; import org.apache.rocketmq.common.protocol.header.PopMessageRequestHeader; public class LockManager { - private static ExpiredLocalCache expiredLocalCache = new ExpiredLocalCache(100000); + private static ExpiredLocalCache expiredLocalCache = new ExpiredLocalCache<>(100000); public static boolean tryLock(String key, long lockTime) { AtomicBoolean v = expiredLocalCache.get(key); diff --git a/store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java b/store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java index 93ded625a5..94999997c3 100644 --- a/store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java +++ b/store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java @@ -40,9 +40,9 @@ public class AllocateMappedFileService extends ServiceThread { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.STORE_LOGGER_NAME); private static int waitTimeOut = 1000 * 5; private ConcurrentMap requestTable = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); private PriorityBlockingQueue requestQueue = - new PriorityBlockingQueue(); + new PriorityBlockingQueue<>(); private volatile boolean hasException = false; private DefaultMessageStore messageStore; diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java index d584167b90..c60303dcef 100644 --- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java +++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java @@ -1444,8 +1444,8 @@ public class CommitLog implements Swappable { * GroupCommit Service */ class GroupCommitService extends FlushCommitLogService { - private volatile LinkedList requestsWrite = new LinkedList(); - private volatile LinkedList requestsRead = new LinkedList(); + private volatile LinkedList requestsWrite = new LinkedList<>(); + private volatile LinkedList requestsRead = new LinkedList<>(); private final PutMessageSpinLock lock = new PutMessageSpinLock(); public void putRequest(final GroupCommitRequest request) { @@ -1543,8 +1543,8 @@ public class CommitLog implements Swappable { } class GroupCheckService extends FlushCommitLogService { - private volatile List requestsWrite = new ArrayList(); - private volatile List requestsRead = new ArrayList(); + private volatile List requestsWrite = new ArrayList<>(); + private volatile List requestsRead = new ArrayList<>(); public boolean isAsyncRequestsFull() { return requestsWrite.size() > CommitLog.this.defaultMessageStore.getMessageStoreConfig().getMaxAsyncPutMessageRequests() * 2; diff --git a/store/src/main/java/org/apache/rocketmq/store/ConsumeQueueExt.java b/store/src/main/java/org/apache/rocketmq/store/ConsumeQueueExt.java index f678e98d19..e39b51e8b4 100644 --- a/store/src/main/java/org/apache/rocketmq/store/ConsumeQueueExt.java +++ b/store/src/main/java/org/apache/rocketmq/store/ConsumeQueueExt.java @@ -326,7 +326,7 @@ public class ConsumeQueueExt { log.info("Truncate consume queue ext by min {}.", minAddress); - List willRemoveFiles = new ArrayList(); + List willRemoveFiles = new ArrayList<>(); List mappedFiles = this.mappedFileQueue.getMappedFiles(); final long realOffset = unDecorate(minAddress); diff --git a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java index 77914763be..1bc19b0193 100644 --- a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java +++ b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java @@ -167,7 +167,7 @@ public class DefaultMessageStore implements MessageStore { private SendMessageBackHook sendMessageBackHook; private final ConcurrentMap delayLevelTable = - new ConcurrentHashMap(32); + new ConcurrentHashMap<>(32); private int maxDelayLevel; @@ -227,7 +227,7 @@ public class DefaultMessageStore implements MessageStore { } public boolean parseDelayLevel() { - HashMap timeUnitTable = new HashMap(); + HashMap timeUnitTable = new HashMap<>(); timeUnitTable.put("s", 1000L); timeUnitTable.put("m", 1000L * 60); timeUnitTable.put("h", 1000L * 60 * 60); @@ -1276,7 +1276,7 @@ public class DefaultMessageStore implements MessageStore { public Map getMessageIds(final String topic, final int queueId, long minOffset, long maxOffset, SocketAddress storeHost) { - Map messageIds = new HashMap(); + Map messageIds = new HashMap<>(); if (this.shutdown) { return messageIds; } diff --git a/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java b/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java index 799df72885..995145fb18 100644 --- a/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java +++ b/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java @@ -44,7 +44,7 @@ public class MappedFileQueue implements Swappable { protected final int mappedFileSize; - protected final CopyOnWriteArrayList mappedFiles = new CopyOnWriteArrayList(); + protected final CopyOnWriteArrayList mappedFiles = new CopyOnWriteArrayList<>(); protected final AllocateMappedFileService allocateMappedFileService; @@ -107,7 +107,7 @@ public class MappedFileQueue implements Swappable { } public void truncateDirtyFiles(long offset) { - List willRemoveFiles = new ArrayList(); + List willRemoveFiles = new ArrayList<>(); for (MappedFile file : this.mappedFiles) { long fileTailOffset = file.getFileFromOffset() + this.mappedFileSize; @@ -354,7 +354,7 @@ public class MappedFileQueue implements Swappable { int mfsLength = mfs.length - 1; int deleteCount = 0; - List files = new ArrayList(); + List files = new ArrayList<>(); int skipFileNum = 0; if (null != mfs) { //do check before deleting @@ -399,7 +399,7 @@ public class MappedFileQueue implements Swappable { public int deleteExpiredFileByOffset(long offset, int unitSize) { Object[] mfs = this.copyMappedFiles(0); - List files = new ArrayList(); + List files = new ArrayList<>(); int deleteCount = 0; if (null != mfs) { @@ -442,7 +442,7 @@ public class MappedFileQueue implements Swappable { public int deleteExpiredFileByOffsetForTimerLog(long offset, int checkOffset, int unitSize) { Object[] mfs = this.copyMappedFiles(0); - List files = new ArrayList(); + List files = new ArrayList<>(); int deleteCount = 0; if (null != mfs) { @@ -621,7 +621,7 @@ public class MappedFileQueue implements Swappable { boolean result = mappedFile.destroy(intervalForcibly); if (result) { log.info("the mappedFile re delete OK, " + mappedFile.getFileName()); - List tmpFiles = new ArrayList(); + List tmpFiles = new ArrayList<>(); tmpFiles.add(mappedFile); this.deleteExpiredFile(tmpFiles); } else { diff --git a/store/src/main/java/org/apache/rocketmq/store/QueryMessageResult.java b/store/src/main/java/org/apache/rocketmq/store/QueryMessageResult.java index 2bda659460..fbcbc05acf 100644 --- a/store/src/main/java/org/apache/rocketmq/store/QueryMessageResult.java +++ b/store/src/main/java/org/apache/rocketmq/store/QueryMessageResult.java @@ -23,9 +23,9 @@ import java.util.List; public class QueryMessageResult { private final List messageMapedList = - new ArrayList(100); + new ArrayList<>(100); - private final List messageBufferList = new ArrayList(100); + private final List messageBufferList = new ArrayList<>(100); private long indexLastUpdateTimestamp; private long indexLastUpdatePhyoffset; diff --git a/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java b/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java index 916e1aa67b..ebceac59b6 100644 --- a/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java +++ b/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java @@ -62,11 +62,11 @@ public class StoreStatsService extends ServiceThread { private final LongAdder getMessageTimesTotalFound = new LongAdder(); private final LongAdder getMessageTransferredMsgCount = new LongAdder(); private final LongAdder getMessageTimesTotalMiss = new LongAdder(); - private final LinkedList putTimesList = new LinkedList(); + private final LinkedList putTimesList = new LinkedList<>(); - private final LinkedList getTimesFoundList = new LinkedList(); - private final LinkedList getTimesMissList = new LinkedList(); - private final LinkedList transferredMsgCountList = new LinkedList(); + private final LinkedList getTimesFoundList = new LinkedList<>(); + private final LinkedList getTimesMissList = new LinkedList<>(); + private final LinkedList transferredMsgCountList = new LinkedList<>(); private volatile LongAdder[] putMessageDistributeTime; private volatile LongAdder[] lastPutMessageDistributeTime; private long messageStoreBootTimestamp = System.currentTimeMillis(); @@ -495,7 +495,7 @@ public class StoreStatsService extends ServiceThread { } public HashMap getRuntimeInfo() { - HashMap result = new HashMap(64); + HashMap result = new HashMap<>(64); Long totalTimes = getPutMessageTimesTotal(); if (0 == totalTimes) { diff --git a/store/src/main/java/org/apache/rocketmq/store/ha/WaitNotifyObject.java b/store/src/main/java/org/apache/rocketmq/store/ha/WaitNotifyObject.java index 5adf372ca7..bff17f0e72 100644 --- a/store/src/main/java/org/apache/rocketmq/store/ha/WaitNotifyObject.java +++ b/store/src/main/java/org/apache/rocketmq/store/ha/WaitNotifyObject.java @@ -29,7 +29,7 @@ public class WaitNotifyObject { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.STORE_LOGGER_NAME); protected final ConcurrentHashMap waitingThreadTable = - new ConcurrentHashMap(16); + new ConcurrentHashMap<>(16); protected AtomicBoolean hasNotified = new AtomicBoolean(false); diff --git a/store/src/main/java/org/apache/rocketmq/store/index/IndexService.java b/store/src/main/java/org/apache/rocketmq/store/index/IndexService.java index ace825edb6..99b553527e 100644 --- a/store/src/main/java/org/apache/rocketmq/store/index/IndexService.java +++ b/store/src/main/java/org/apache/rocketmq/store/index/IndexService.java @@ -44,7 +44,7 @@ public class IndexService { private final int hashSlotNum; private final int indexNum; private final String storePath; - private final ArrayList indexFileList = new ArrayList(); + private final ArrayList indexFileList = new ArrayList<>(); private final ReadWriteLock readWriteLock = new ReentrantReadWriteLock(); public IndexService(final DefaultMessageStore store) { @@ -115,7 +115,7 @@ public class IndexService { } if (files != null) { - List fileList = new ArrayList(); + List fileList = new ArrayList<>(); for (int i = 0; i < (files.length - 1); i++) { IndexFile f = (IndexFile) files[i]; if (f.getEndPhyOffset() < offset) { @@ -164,7 +164,7 @@ public class IndexService { } public QueryOffsetResult queryOffset(String topic, String key, int maxNum, long begin, long end) { - List phyOffsets = new ArrayList(maxNum); + List phyOffsets = new ArrayList<>(maxNum); long indexLastUpdateTimestamp = 0; long indexLastUpdatePhyoffset = 0; diff --git a/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java b/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java index 7ec9477d70..7ceb005291 100644 --- a/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java +++ b/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java @@ -133,7 +133,7 @@ public class BrokerStatsManager { private ScheduledExecutorService commercialExecutor; private ScheduledExecutorService accountExecutor; - private final HashMap statsTable = new HashMap(); + private final HashMap statsTable = new HashMap<>(); private final String clusterName; private final boolean enableQueueStat; private MomentStatsItemSet momentStatsItemSetFallSize; diff --git a/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java b/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java index 92a7af8360..4f8e5ec5bd 100644 --- a/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java +++ b/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java @@ -201,13 +201,13 @@ public class TimerMessageStore { dequeuePutMessageServices[i] = new TimerDequeuePutMessageService(); } if (storeConfig.isTimerEnableDisruptor()) { - enqueuePutQueue = new DisruptorBlockingQueue(1024); - dequeueGetQueue = new DisruptorBlockingQueue>(1024); - dequeuePutQueue = new DisruptorBlockingQueue(1024); + enqueuePutQueue = new DisruptorBlockingQueue<>(1024); + dequeueGetQueue = new DisruptorBlockingQueue<>(1024); + dequeuePutQueue = new DisruptorBlockingQueue<>(1024); } else { - enqueuePutQueue = new LinkedBlockingDeque(1024); - dequeueGetQueue = new LinkedBlockingDeque>(1024); - dequeuePutQueue = new LinkedBlockingDeque(1024); + enqueuePutQueue = new LinkedBlockingDeque<>(1024); + dequeueGetQueue = new LinkedBlockingDeque<>(1024); + dequeuePutQueue = new LinkedBlockingDeque<>(1024); } this.brokerStatsManager = brokerStatsManager; } diff --git a/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java b/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java index be4b8623dc..ecb711473c 100644 --- a/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java +++ b/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java @@ -272,7 +272,7 @@ public class MappedFileQueueTest { ThreadPoolExecutor executor = new ThreadPoolExecutor(3, 3, 1000 * 60, TimeUnit.MILLISECONDS, - new LinkedBlockingQueue(), + new LinkedBlockingQueue<>(), new ThreadFactoryImpl("testThreadPool")); for (int i = 0; i < mappedFileSize; i++) { @@ -351,7 +351,7 @@ public class MappedFileQueueTest { ThreadPoolExecutor executor = new ThreadPoolExecutor(5, 5, 1000 * 60, TimeUnit.MILLISECONDS, - new LinkedBlockingQueue(), + new LinkedBlockingQueue<>(), new ThreadFactoryImpl("testThreadPool")); for (int i = 0; i < mappedFileSize; i++) { MappedFile mappedFile = mappedFileQueue.getLastMappedFile(0); diff --git a/store/src/test/java/org/apache/rocketmq/store/index/IndexFileTest.java b/store/src/test/java/org/apache/rocketmq/store/index/IndexFileTest.java index 99493724fe..7b35951b87 100644 --- a/store/src/test/java/org/apache/rocketmq/store/index/IndexFileTest.java +++ b/store/src/test/java/org/apache/rocketmq/store/index/IndexFileTest.java @@ -62,7 +62,7 @@ public class IndexFileTest { boolean putResult = indexFile.putKey(Long.toString(400), 400, System.currentTimeMillis()); assertThat(putResult).isFalse(); - final List phyOffsets = new ArrayList(); + final List phyOffsets = new ArrayList<>(); indexFile.selectPhyOffset(phyOffsets, "60", 10, 0, Long.MAX_VALUE); assertThat(phyOffsets).isNotEmpty(); assertThat(phyOffsets.size()).isEqualTo(1); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java b/tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java index dc69f516f1..06503962e2 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java @@ -119,7 +119,7 @@ import org.apache.rocketmq.tools.command.CommandUtil; public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { private static final String SOCKS_PROXY_JSON = "socksProxyJson"; - private static final Set SYSTEM_GROUP_SET = new HashSet(); + private static final Set SYSTEM_GROUP_SET = new HashSet<>(); static { SYSTEM_GROUP_SET.add(MixAll.DEFAULT_CONSUMER_GROUP); @@ -186,7 +186,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { int theadPoolCoreSize = Integer.parseInt(System.getProperty("rocketmq.admin.threadpool.coresize", "20")); - this.threadPoolExecutor = new ThreadPoolExecutor(theadPoolCoreSize, 100, 5, TimeUnit.MINUTES, new LinkedBlockingQueue(), new ThreadFactoryImpl("DefaultMQAdminExtImpl_")); + this.threadPoolExecutor = new ThreadPoolExecutor(theadPoolCoreSize, 100, 5, TimeUnit.MINUTES, new LinkedBlockingQueue<>(), new ThreadFactoryImpl("DefaultMQAdminExtImpl_")); break; case RUNNING: @@ -696,7 +696,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { Set brokerAddressSet = CommandUtil.fetchMasterAndSlaveAddrByClusterName(this.defaultMQAdminExt, clusterName); this.deleteTopicInBroker(brokerAddressSet, topicName); List nameServerList = this.getNameServerAddressList(); - Set nameServerSet = new HashSet(nameServerList); + Set nameServerSet = new HashSet<>(nameServerList); this.deleteTopicInNameServer(nameServerSet, topicName); for (String namespace : this.kvNamespaceToDeleteList) { this.deleteKvConfig(namespace, topicName); @@ -784,8 +784,8 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { public List resetOffsetByTimestampOld(String consumerGroup, String topic, long timestamp, boolean force) throws RemotingException, MQBrokerException, InterruptedException, MQClientException { TopicRouteData topicRouteData = this.examineTopicRouteInfo(topic); - List rollbackStatsList = new ArrayList(); - Map topicRouteMap = new HashMap(); + List rollbackStatsList = new ArrayList<>(); + Map topicRouteMap = new HashMap<>(); for (QueueData queueData : topicRouteData.getQueueDatas()) { topicRouteMap.put(queueData.getBrokerName(), queueData); } @@ -801,7 +801,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { private List resetOffsetByTimestampOld(String brokerAddr, QueueData queueData, String consumerGroup, String topic, long timestamp, boolean force) throws RemotingException, MQBrokerException, InterruptedException, MQClientException { - List rollbackStatsList = new ArrayList(); + List rollbackStatsList = new ArrayList<>(); ConsumeStats consumeStats = this.mqClientInstance.getMQClientAPIImpl().getConsumeStats(brokerAddr, consumerGroup, timeoutMillis); boolean hasConsumed = false; @@ -860,7 +860,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { if (topicRouteData == null || CollectionUtils.isEmpty(topicRouteData.getBrokerDatas())) { return AdminToolResult.failure(AdminToolsResultCodeEnum.TOPIC_ROUTE_INFO_NOT_EXIST, "topic router info not found"); } - final Map topicRouteMap = new HashMap(); + final Map topicRouteMap = new HashMap<>(); for (QueueData queueData : topicRouteData.getQueueDatas()) { topicRouteMap.put(queueData.getBrokerName(), queueData); } @@ -924,7 +924,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { boolean isC) throws RemotingException, MQBrokerException, InterruptedException, MQClientException { TopicRouteData topicRouteData = this.examineTopicRouteInfo(topic); List brokerDatas = topicRouteData.getBrokerDatas(); - Map allOffsetTable = new HashMap(); + Map allOffsetTable = new HashMap<>(); if (brokerDatas != null) { for (BrokerData brokerData : brokerDatas) { String addr = brokerData.selectBrokerAddr(); @@ -998,7 +998,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { e.printStackTrace(); } - Map orderConfMap = new HashMap(); + Map orderConfMap = new HashMap<>(); if (!UtilAll.isBlank(oldOrderConfs)) { String[] oldOrderConfArr = oldOrderConfs.split(";"); for (String oldOrderConf : oldOrderConfArr) { @@ -1107,7 +1107,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { @Override public List queryConsumeTimeSpan(final String topic, final String group) throws InterruptedException, MQBrokerException, RemotingException, MQClientException { - List spanSet = new ArrayList(); + List spanSet = new ArrayList<>(); TopicRouteData topicRouteData = this.examineTopicRouteInfo(topic); for (BrokerData bd : topicRouteData.getBrokerDatas()) { String addr = bd.selectBrokerAddr(); @@ -1316,7 +1316,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { @Override public List messageTrackDetail( MessageExt msg) throws RemotingException, MQClientException, InterruptedException, MQBrokerException { - List result = new ArrayList(); + List result = new ArrayList<>(); GroupList groupList = this.queryTopicConsumeByWho(msg.getTopic()); @@ -1403,7 +1403,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { @Override public List messageTrackDetailConcurrent( final MessageExt msg) throws RemotingException, MQClientException, InterruptedException, MQBrokerException { - final List result = new ArrayList(); + final List result = new ArrayList<>(); GroupList groupList = this.queryTopicConsumeByWho(msg.getTopic()); @@ -1590,7 +1590,7 @@ public class DefaultMQAdminExtImpl implements MQAdminExt, MQAdminExtInner { @Override public Set getTopicClusterList( final String topic) throws InterruptedException, MQBrokerException, MQClientException, RemotingException { - Set clusterSet = new HashSet(); + Set clusterSet = new HashSet<>(); ClusterInfo clusterInfo = examineBrokerClusterInfo(); TopicRouteData topicRouteData = examineTopicRouteInfo(topic); BrokerData brokerData = topicRouteData.getBrokerDatas().get(0); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/CommandUtil.java b/tools/src/main/java/org/apache/rocketmq/tools/command/CommandUtil.java index 272320c2d6..a6b612070c 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/CommandUtil.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/CommandUtil.java @@ -45,7 +45,7 @@ public class CommandUtil { throws InterruptedException, RemotingConnectException, RemotingTimeoutException, RemotingSendRequestException, MQBrokerException { - Map> masterAndSlaveMap = new HashMap>(4); + Map> masterAndSlaveMap = new HashMap<>(4); ClusterInfo clusterInfoSerializeWrapper = adminExt.examineBrokerClusterInfo(); Set brokerNameSet = clusterInfoSerializeWrapper.getClusterAddrTable().get(clusterName); @@ -67,7 +67,7 @@ public class CommandUtil { if (masterAddr == null) { masterAndSlaveMap.putIfAbsent(NO_MASTER_PLACEHOLDER, new ArrayList<>()); } else { - masterAndSlaveMap.put(masterAddr, new ArrayList()); + masterAndSlaveMap.put(masterAddr, new ArrayList<>()); } for (Entry brokerAddrEntry : brokerData.getBrokerAddrs().entrySet()) { @@ -89,7 +89,7 @@ public class CommandUtil { public static Set fetchMasterAddrByClusterName(final MQAdminExt adminExt, final String clusterName) throws InterruptedException, RemotingConnectException, RemotingTimeoutException, RemotingSendRequestException, MQBrokerException { - Set masterSet = new HashSet(); + Set masterSet = new HashSet<>(); ClusterInfo clusterInfoSerializeWrapper = adminExt.examineBrokerClusterInfo(); @@ -116,7 +116,7 @@ public class CommandUtil { public static Set fetchMasterAndSlaveAddrByClusterName(final MQAdminExt adminExt, final String clusterName) throws InterruptedException, RemotingConnectException, RemotingTimeoutException, RemotingSendRequestException, MQBrokerException { - Set brokerAddressSet = new HashSet(); + Set brokerAddressSet = new HashSet<>(); ClusterInfo clusterInfoSerializeWrapper = adminExt.examineBrokerClusterInfo(); Set brokerNameSet = clusterInfoSerializeWrapper.getClusterAddrTable().get(clusterName); if (brokerNameSet != null) { diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommand.java index c246b66d50..3be40daa17 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommand.java @@ -129,7 +129,7 @@ public class UpdateAccessConfigSubCommand implements SubCommand { // TopicPerms list value if (commandLine.hasOption('t')) { String[] topicPerms = commandLine.getOptionValue('t').trim().split(","); - List topicPermList = new ArrayList(); + List topicPermList = new ArrayList<>(); if (topicPerms != null) { for (String topicPerm : topicPerms) { topicPermList.add(topicPerm); @@ -141,7 +141,7 @@ public class UpdateAccessConfigSubCommand implements SubCommand { // GroupPerms list value if (commandLine.hasOption('g')) { String[] groupPerms = commandLine.getOptionValue('g').trim().split(","); - List groupPermList = new ArrayList(); + List groupPermList = new ArrayList<>(); if (groupPerms != null) { for (String groupPerm : groupPerms) { groupPermList.add(groupPerm); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommad.java b/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommad.java index f462b27818..6e7d8d53a1 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommad.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommad.java @@ -119,7 +119,7 @@ public class BrokerConsumeStatsSubCommad implements SubCommand { String group = entry.getKey(); List consumeStatsArray = entry.getValue(); for (ConsumeStats consumeStats : consumeStatsArray) { - List mqList = new LinkedList(); + List mqList = new LinkedList<>(); mqList.addAll(consumeStats.getOffsetTable().keySet()); Collections.sort(mqList); for (MessageQueue mq : mqList) { diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerStatusSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerStatusSubCommand.java index 789ba00f72..6d22c67c92 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerStatusSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/broker/BrokerStatusSubCommand.java @@ -95,7 +95,7 @@ public class BrokerStatusSubCommand implements SubCommand { final boolean printBroker) throws InterruptedException, MQBrokerException, RemotingTimeoutException, RemotingSendRequestException, RemotingConnectException { KVTable kvTable = defaultMQAdminExt.fetchBrokerRuntimeStats(brokerAddr); - TreeMap tmp = new TreeMap(); + TreeMap tmp = new TreeMap<>(); tmp.putAll(kvTable.getTable()); Iterator> it = tmp.entrySet().iterator(); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/CLusterSendMsgRTCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/CLusterSendMsgRTCommand.java index 259e8425cd..f5ca7f3e8b 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/CLusterSendMsgRTCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/CLusterSendMsgRTCommand.java @@ -113,7 +113,7 @@ public class CLusterSendMsgRTCommand implements SubCommand { .getOptionValue('m').trim(); if (commandLine.hasOption('c')) { - clusterNames = new TreeSet(); + clusterNames = new TreeSet<>(); clusterNames.add(commandLine.getOptionValue('c').trim()); } else { clusterNames = clusterAddr.keySet(); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java index 1629190420..ac43f8bd06 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java @@ -109,7 +109,7 @@ public class ClusterListSubCommand implements SubCommand { if (StringUtils.isEmpty(clusterName)) { return clusterInfo.getClusterAddrTable().keySet(); } else { - Set clusterNames = new TreeSet(); + Set clusterNames = new TreeSet<>(); clusterNames.add(clusterName); return clusterNames; } @@ -128,7 +128,7 @@ public class ClusterListSubCommand implements SubCommand { ); for (String clusterName : clusterNames) { - TreeSet brokerNameTreeSet = new TreeSet(); + TreeSet brokerNameTreeSet = new TreeSet<>(); Set brokerNameSet = clusterInfo.getClusterAddrTable().get(clusterName); if (brokerNameSet != null && !brokerNameSet.isEmpty()) { brokerNameTreeSet.addAll(brokerNameSet); @@ -196,7 +196,7 @@ public class ClusterListSubCommand implements SubCommand { ); for (String clusterName : clusterNames) { - TreeSet brokerNameTreeSet = new TreeSet(); + TreeSet brokerNameTreeSet = new TreeSet<>(); Set brokerNameSet = clusterInfo.getClusterAddrTable().get(clusterName); if (brokerNameSet != null && !brokerNameSet.isEmpty()) { brokerNameTreeSet.addAll(brokerNameSet); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommand.java index 523f41191b..7e0f7d25a5 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommand.java @@ -118,7 +118,7 @@ public class ConsumerProgressSubCommand implements SubCommand { } else { consumeStats = defaultMQAdminExt.examineConsumeStats(consumerGroup, topicName); } - List mqList = new LinkedList(); + List mqList = new LinkedList<>(); mqList.addAll(consumeStats.getOffsetTable().keySet()); Collections.sort(mqList); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommand.java index fbd5f732f8..38d623ff55 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommand.java @@ -91,7 +91,7 @@ public class ConsumerStatusSubCommand implements SubCommand { if (!commandLine.hasOption('i')) { int i = 1; long now = System.currentTimeMillis(); - final TreeMap criTable = new TreeMap(); + final TreeMap criTable = new TreeMap<>(); System.out.printf("%-10s %-40s %-20s %s%n", "#Index", "#ClientId", diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerSubCommand.java index f3b1fccf32..9de9d46e35 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerSubCommand.java @@ -80,7 +80,7 @@ public class ConsumerSubCommand implements SubCommand { int i = 1; long now = System.currentTimeMillis(); final TreeMap criTable = - new TreeMap(); + new TreeMap<>(); for (Connection conn : cc.getConnectionSet()) { try { ConsumerRunningInfo consumerRunningInfo = diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java index 88f1b74762..654560167f 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java @@ -74,7 +74,7 @@ public class PrintMessageByQueueCommand implements SubCommand { if (!calByTag) return; - List list = new ArrayList(); + List list = new ArrayList<>(); for (Map.Entry entry : tagCalmap.entrySet()) { TagCountBean tagBean = new TagCountBean(entry.getKey(), entry.getValue()); list.add(tagBean); @@ -193,7 +193,7 @@ public class PrintMessageByQueueCommand implements SubCommand { maxOffset = consumer.searchOffset(mq, timeValue); } - final Map tagCalmap = new HashMap(); + final Map tagCalmap = new HashMap<>(); READQ: for (long offset = minOffset; offset < maxOffset; ) { try { diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/AllocateMQSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/AllocateMQSubCommand.java index a9b9ab0347..d9d366ac18 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/AllocateMQSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/AllocateMQSubCommand.java @@ -67,7 +67,7 @@ public class AllocateMQSubCommand implements SubCommand { String topic = commandLine.getOptionValue('t').trim(); String ips = commandLine.getOptionValue('i').trim(); final String[] split = ips.split(","); - final List ipList = new LinkedList(); + final List ipList = new LinkedList<>(); for (String ip : split) { ipList.add(ip); } @@ -80,7 +80,7 @@ public class AllocateMQSubCommand implements SubCommand { RebalanceResult rr = new RebalanceResult(); for (String i : ipList) { - final List mqResult = averagely.allocate("aa", i, new ArrayList(mqs), ipList); + final List mqResult = averagely.allocate("aa", i, new ArrayList<>(mqs), ipList); rr.getResult().put(i, mqResult); } diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RebalanceResult.java b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RebalanceResult.java index 21a5cf46a2..730d520c2a 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RebalanceResult.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RebalanceResult.java @@ -23,7 +23,7 @@ import java.util.Map; import org.apache.rocketmq.common.message.MessageQueue; public class RebalanceResult { - private Map> result = new HashMap>(); + private Map> result = new HashMap<>(); public Map> getResult() { return result; diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RemappingStaticTopicSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RemappingStaticTopicSubCommand.java index 484428e685..0192d5c25f 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RemappingStaticTopicSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/RemappingStaticTopicSubCommand.java @@ -181,7 +181,7 @@ public class RemappingStaticTopicSubCommand implements SubCommand { } Map.Entry maxEpochAndNum = TopicQueueMappingUtils.checkNameEpochNumConsistence(topic, brokerConfigMap); { - TopicRemappingDetailWrapper oldWrapper = new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, maxEpochAndNum.getKey(), brokerConfigMap, new HashSet(), new HashSet()); + TopicRemappingDetailWrapper oldWrapper = new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, maxEpochAndNum.getKey(), brokerConfigMap, new HashSet<>(), new HashSet<>()); String oldMappingDataFile = TopicQueueMappingUtils.writeToTemp(oldWrapper, false); System.out.printf("The old mapping data is written to file " + oldMappingDataFile + "\n"); } diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicStatusSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicStatusSubCommand.java index 55440821b0..9896b52e04 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicStatusSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicStatusSubCommand.java @@ -63,7 +63,7 @@ public class TopicStatusSubCommand implements SubCommand { String topic = commandLine.getOptionValue('t').trim(); TopicStatsTable topicStatsTable = defaultMQAdminExt.examineTopicStats(topic); - List mqList = new LinkedList(); + List mqList = new LinkedList<>(); mqList.addAll(topicStatsTable.getOffsetTable().keySet()); Collections.sort(mqList); diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateStaticTopicSubCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateStaticTopicSubCommand.java index c0d0fbe46f..f09eff18eb 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateStaticTopicSubCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateStaticTopicSubCommand.java @@ -184,7 +184,7 @@ public class UpdateStaticTopicSubCommand implements SubCommand { } { - TopicRemappingDetailWrapper oldWrapper = new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, maxEpochAndNum.getKey(), brokerConfigMap, new HashSet(), new HashSet()); + TopicRemappingDetailWrapper oldWrapper = new TopicRemappingDetailWrapper(topic, TopicRemappingDetailWrapper.TYPE_CREATE_OR_UPDATE, maxEpochAndNum.getKey(), brokerConfigMap, new HashSet<>(), new HashSet<>()); String oldMappingDataFile = TopicQueueMappingUtils.writeToTemp(oldWrapper, false); System.out.printf("The old mapping data is written to file " + oldMappingDataFile + "\n"); } diff --git a/tools/src/main/java/org/apache/rocketmq/tools/monitor/MonitorService.java b/tools/src/main/java/org/apache/rocketmq/tools/monitor/MonitorService.java index 3269ae126a..789a09d952 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/monitor/MonitorService.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/monitor/MonitorService.java @@ -209,7 +209,7 @@ public class MonitorService { if (cs != null) { - HashMap csByTopic = new HashMap(); + HashMap csByTopic = new HashMap<>(); { Iterator> it = cs.getOffsetTable().entrySet().iterator(); while (it.hasNext()) { @@ -244,7 +244,7 @@ public class MonitorService { public void reportConsumerRunningInfo(final String consumerGroup) throws InterruptedException, MQBrokerException, RemotingException, MQClientException { ConsumerConnection cc = defaultMQAdminExt.examineConsumerConnectionInfo(consumerGroup); - TreeMap infoMap = new TreeMap(); + TreeMap infoMap = new TreeMap<>(); for (Connection c : cc.getConnectionSet()) { String clientId = c.getClientId(); diff --git a/tools/src/test/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtTest.java b/tools/src/test/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtTest.java index 026ce5ae30..02d280f827 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtTest.java @@ -38,7 +38,6 @@ import org.apache.rocketmq.client.impl.factory.MQClientInstance; import org.apache.rocketmq.common.MixAll; import org.apache.rocketmq.common.TopicConfig; import org.apache.rocketmq.common.admin.ConsumeStats; -import org.apache.rocketmq.common.admin.TopicOffset; import org.apache.rocketmq.common.admin.TopicStatsTable; import org.apache.rocketmq.common.consumer.ConsumeFromWhere; import org.apache.rocketmq.common.message.MessageExt; @@ -48,12 +47,10 @@ import org.apache.rocketmq.common.protocol.ResponseCode; import org.apache.rocketmq.common.protocol.body.ClusterInfo; import org.apache.rocketmq.common.protocol.body.Connection; import org.apache.rocketmq.common.protocol.body.ConsumeStatsList; -import org.apache.rocketmq.common.protocol.body.ConsumeStatus; import org.apache.rocketmq.common.protocol.body.ConsumerConnection; import org.apache.rocketmq.common.protocol.body.ConsumerRunningInfo; import org.apache.rocketmq.common.protocol.body.GroupList; import org.apache.rocketmq.common.protocol.body.KVTable; -import org.apache.rocketmq.common.protocol.body.ProcessQueueInfo; import org.apache.rocketmq.common.protocol.body.ProducerConnection; import org.apache.rocketmq.common.protocol.body.ProducerInfo; import org.apache.rocketmq.common.protocol.body.ProducerTableInfo; @@ -63,9 +60,7 @@ import org.apache.rocketmq.common.protocol.body.TopicConfigSerializeWrapper; import org.apache.rocketmq.common.protocol.body.TopicList; import org.apache.rocketmq.common.protocol.heartbeat.ConsumeType; import org.apache.rocketmq.common.protocol.heartbeat.MessageModel; -import org.apache.rocketmq.common.protocol.heartbeat.SubscriptionData; import org.apache.rocketmq.common.protocol.route.BrokerData; -import org.apache.rocketmq.common.protocol.route.QueueData; import org.apache.rocketmq.common.protocol.route.TopicRouteData; import org.apache.rocketmq.common.statictopic.TopicConfigAndQueueMapping; import org.apache.rocketmq.common.subscription.SubscriptionGroupConfig; @@ -150,8 +145,8 @@ public class DefaultMQAdminExtTest { brokerDatas.add(brokerData); brokerDatas.add(new BrokerData(CLUSTER, BROKER2_NAME, (HashMap) Maps.newHashMap(MixAll.MASTER_ID, BROKER2_ADDR))); topicRouteData.setBrokerDatas(brokerDatas); - topicRouteData.setQueueDatas(new ArrayList()); - topicRouteData.setFilterServerTable(new HashMap>()); + topicRouteData.setQueueDatas(new ArrayList<>()); + topicRouteData.setFilterServerTable(new HashMap<>()); when(mQClientAPIImpl.getTopicRouteInfoFromNameServer(anyString(), anyLong())).thenReturn(topicRouteData); HashMap result = new HashMap<>(); @@ -164,7 +159,7 @@ public class DefaultMQAdminExtTest { brokerAddrTable.put(BROKER1_NAME, brokerData); brokerAddrTable.put(BROKER2_NAME, new BrokerData()); clusterInfo.setBrokerAddrTable(brokerAddrTable); - clusterInfo.setClusterAddrTable(new HashMap>()); + clusterInfo.setClusterAddrTable(new HashMap<>()); when(mQClientAPIImpl.getBrokerClusterInfo(anyLong())).thenReturn(clusterInfo); when(mQClientAPIImpl.cleanExpiredConsumeQueue(anyString(), anyLong())).thenReturn(true); @@ -216,7 +211,7 @@ public class DefaultMQAdminExtTest { HashSet connections = new HashSet<>(); connections.add(new Connection()); consumerConnection.setConnectionSet(connections); - consumerConnection.setSubscriptionTable(new ConcurrentHashMap()); + consumerConnection.setSubscriptionTable(new ConcurrentHashMap<>()); consumerConnection.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET); when(mQClientAPIImpl.getConsumerConnectionList(anyString(), anyString(), anyLong())).thenReturn(consumerConnection); @@ -224,7 +219,7 @@ public class DefaultMQAdminExtTest { Connection connection = new Connection(); connection.setClientAddr("127.0.0.1:9898"); connection.setClientId("PID_12345"); - HashSet connectionSet = new HashSet(); + HashSet connectionSet = new HashSet<>(); connectionSet.add(connection); producerConnection.setConnectionSet(connectionSet); when(mQClientAPIImpl.getProducerConnectionList(anyString(), anyString(), anyLong())).thenReturn(producerConnection); @@ -244,7 +239,7 @@ public class DefaultMQAdminExtTest { when(mQClientAPIImpl.addWritePermOfBroker(anyString(), anyString(), anyLong())).thenReturn(7); TopicStatsTable topicStatsTable = new TopicStatsTable(); - topicStatsTable.setOffsetTable(new HashMap()); + topicStatsTable.setOffsetTable(new HashMap<>()); Map> consumerStatus = new HashMap<>(); when(mQClientAPIImpl.invokeBrokerToGetConsumerStatus(anyString(), anyString(), anyString(), anyString(), anyLong())).thenReturn(consumerStatus); @@ -254,9 +249,9 @@ public class DefaultMQAdminExtTest { ConsumerRunningInfo consumerRunningInfo = new ConsumerRunningInfo(); consumerRunningInfo.setJstack("test"); - consumerRunningInfo.setMqTable(new TreeMap()); - consumerRunningInfo.setStatusTable(new TreeMap()); - consumerRunningInfo.setSubscriptionSet(new TreeSet()); + consumerRunningInfo.setMqTable(new TreeMap<>()); + consumerRunningInfo.setStatusTable(new TreeMap<>()); + consumerRunningInfo.setSubscriptionSet(new TreeSet<>()); when(mQClientAPIImpl.getConsumerRunningInfo(anyString(), anyString(), anyString(), anyBoolean(), anyLong())).thenReturn(consumerRunningInfo); TopicConfigSerializeWrapper topicConfigSerializeWrapper = new TopicConfigSerializeWrapper(); diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommandTest.java index 602a27aac6..ae4eca4356 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommandTest.java @@ -16,9 +16,9 @@ */ package org.apache.rocketmq.tools.command.acl; +import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; -import org.apache.commons.cli.CommandLine; import org.apache.rocketmq.srvutil.ServerUtil; import org.junit.Test; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java index 5e3f903524..cff02d2180 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java @@ -72,7 +72,7 @@ public class UpdateAccessConfigSubCommandTest { // groupPerms list value if (commandLine.hasOption('g')) { String[] groupPerms = commandLine.getOptionValue('g').trim().split(";"); - List groupPermList = new ArrayList(); + List groupPermList = new ArrayList<>(); Collections.addAll(groupPermList, groupPerms); accessConfig.setGroupPerms(groupPermList); } diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommadTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommadTest.java index 44a275828d..6b4833f5d2 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommadTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/broker/BrokerConsumeStatsSubCommadTest.java @@ -18,8 +18,6 @@ package org.apache.rocketmq.tools.command.broker; import java.lang.reflect.Field; import java.util.ArrayList; -import java.util.List; -import java.util.Map; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -28,7 +26,6 @@ import org.apache.rocketmq.client.exception.MQClientException; import org.apache.rocketmq.client.impl.MQClientAPIImpl; import org.apache.rocketmq.client.impl.MQClientManager; import org.apache.rocketmq.client.impl.factory.MQClientInstance; -import org.apache.rocketmq.common.admin.ConsumeStats; import org.apache.rocketmq.common.protocol.body.ConsumeStatsList; import org.apache.rocketmq.remoting.exception.RemotingConnectException; import org.apache.rocketmq.remoting.exception.RemotingSendRequestException; @@ -74,7 +71,7 @@ public class BrokerConsumeStatsSubCommadTest { ConsumeStatsList consumeStatsList = new ConsumeStatsList(); consumeStatsList.setBrokerAddr("127.0l.0.1:10911"); - consumeStatsList.setConsumeStatsList(new ArrayList>>()); + consumeStatsList.setConsumeStatsList(new ArrayList<>()); consumeStatsList.setTotalDiff(123); when(mQClientAPIImpl.fetchConsumeStatsInBroker(anyString(), anyBoolean(), anyLong())).thenReturn(consumeStatsList); } diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommandTest.java index 9b44e4c114..7d76dafa01 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommandTest.java @@ -16,6 +16,8 @@ */ package org.apache.rocketmq.tools.command.broker; +import java.io.UnsupportedEncodingException; +import java.util.Properties; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -25,9 +27,6 @@ import org.apache.rocketmq.tools.command.SubCommandException; import org.apache.rocketmq.tools.command.server.ServerResponseMocker; import org.junit.Test; -import java.io.UnsupportedEncodingException; -import java.util.Properties; - public class GetBrokerConfigCommandTest extends ServerResponseMocker { @Override diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java index 7773eac9f8..6214dba55c 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.connection; +import java.util.HashSet; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -29,8 +30,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashSet; - import static org.mockito.Mockito.mock; public class ConsumerConnectionSubCommandTest { diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ProducerConnectionSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ProducerConnectionSubCommandTest.java index 001148148e..d915ccd820 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ProducerConnectionSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/connection/ProducerConnectionSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.connection; +import java.util.HashSet; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -29,8 +30,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashSet; - import static org.mockito.Mockito.mock; public class ProducerConnectionSubCommandTest { diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommandTest.java index efa8d05bab..d3f5fe3a4c 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.consumer; +import java.util.HashMap; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -31,8 +32,6 @@ import org.junit.Before; import org.junit.Ignore; import org.junit.Test; -import java.util.HashMap; - public class ConsumerProgressSubCommandTest { private ServerResponseMocker brokerMocker; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommandTest.java index bcd4477f6c..5175d1e73e 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/ConsumerStatusSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.consumer; +import java.util.HashSet; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -29,8 +30,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashSet; - import static org.mockito.Mockito.mock; public class ConsumerStatusSubCommandTest { diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/GetConsumerConfigSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/GetConsumerConfigSubCommandTest.java index fccb120999..784d1e89bc 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/GetConsumerConfigSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/consumer/GetConsumerConfigSubCommandTest.java @@ -16,6 +16,9 @@ */ package org.apache.rocketmq.tools.command.consumer; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Set; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -30,10 +33,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashMap; -import java.util.HashSet; -import java.util.Set; - import static org.mockito.Mockito.mock; public class GetConsumerConfigSubCommandTest { diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgByUniqueKeySubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgByUniqueKeySubCommandTest.java index c47a39f99d..ea7403824f 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgByUniqueKeySubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgByUniqueKeySubCommandTest.java @@ -16,6 +16,13 @@ */ package org.apache.rocketmq.tools.command.message; +import java.lang.reflect.Field; +import java.net.InetSocketAddress; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Set; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -33,11 +40,11 @@ import org.apache.rocketmq.common.admin.OffsetWrapper; import org.apache.rocketmq.common.message.MessageExt; import org.apache.rocketmq.common.message.MessageQueue; import org.apache.rocketmq.common.protocol.body.CMResult; -import org.apache.rocketmq.common.protocol.body.GroupList; import org.apache.rocketmq.common.protocol.body.ClusterInfo; import org.apache.rocketmq.common.protocol.body.Connection; -import org.apache.rocketmq.common.protocol.body.ConsumerConnection; import org.apache.rocketmq.common.protocol.body.ConsumeMessageDirectlyResult; +import org.apache.rocketmq.common.protocol.body.ConsumerConnection; +import org.apache.rocketmq.common.protocol.body.GroupList; import org.apache.rocketmq.common.protocol.heartbeat.ConsumeType; import org.apache.rocketmq.common.protocol.route.BrokerData; import org.apache.rocketmq.common.protocol.route.TopicRouteData; @@ -54,19 +61,10 @@ import org.assertj.core.util.Lists; import org.junit.Before; import org.junit.Test; -import java.lang.reflect.Field; -import java.net.InetSocketAddress; -import java.util.Set; -import java.util.List; -import java.util.HashMap; -import java.util.HashSet; -import java.util.ArrayList; - - -import static org.mockito.ArgumentMatchers.isNull; import static org.mockito.ArgumentMatchers.anyInt; import static org.mockito.ArgumentMatchers.anyLong; import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.ArgumentMatchers.isNull; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; @@ -132,9 +130,9 @@ public class QueryMsgByUniqueKeySubCommandTest { when(defaultMQAdminExtImpl.queryMessageByUniqKey(anyString(), anyString(), anyInt(), anyLong(), anyLong())).thenReturn(queryResult); TopicRouteData topicRouteData = new TopicRouteData(); - List brokerDataList = new ArrayList(); + List brokerDataList = new ArrayList<>(); BrokerData brokerData = new BrokerData(); - HashMap brokerAddrs = new HashMap(); + HashMap brokerAddrs = new HashMap<>(); brokerAddrs.put(MixAll.MASTER_ID, "127.0.0.1:9876"); brokerData.setBrokerAddrs(brokerAddrs); brokerDataList.add(brokerData); @@ -142,14 +140,14 @@ public class QueryMsgByUniqueKeySubCommandTest { when(mQClientAPIImpl.getTopicRouteInfoFromNameServer(anyString(), anyLong())).thenReturn(topicRouteData); GroupList groupList = new GroupList(); - HashSet groupSets = new HashSet(); + HashSet groupSets = new HashSet<>(); groupSets.add("testGroup"); groupList.setGroupList(groupSets); when(mQClientAPIImpl.queryTopicConsumeByWho(anyString(), anyString(), anyLong())).thenReturn(groupList); ConsumeStats consumeStats = new ConsumeStats(); consumeStats.setConsumeTps(100 * 10000); - HashMap offsetTable = new HashMap(); + HashMap offsetTable = new HashMap<>(); MessageQueue messageQueue = new MessageQueue(); messageQueue.setBrokerName("messageQueue BrokerName testing"); messageQueue.setTopic("messageQueue topic"); @@ -163,11 +161,11 @@ public class QueryMsgByUniqueKeySubCommandTest { when(mQClientAPIImpl.getConsumeStats(anyString(), anyString(), (String) isNull(), anyLong())).thenReturn(consumeStats); ClusterInfo clusterInfo = new ClusterInfo(); - HashMap brokerAddrTable = new HashMap(); + HashMap brokerAddrTable = new HashMap<>(); brokerAddrTable.put("key", brokerData); clusterInfo.setBrokerAddrTable(brokerAddrTable); - HashMap> clusterAddrTable = new HashMap>(); - Set addrSet = new HashSet(); + HashMap> clusterAddrTable = new HashMap<>(); + Set addrSet = new HashSet<>(); addrSet.add("127.0.0.1:9876"); clusterAddrTable.put("key", addrSet); clusterInfo.setClusterAddrTable(clusterAddrTable); diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgTraceByIdSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgTraceByIdSubCommandTest.java index e300ed357e..97e0236135 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgTraceByIdSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/message/QueryMsgTraceByIdSubCommandTest.java @@ -16,6 +16,11 @@ */ package org.apache.rocketmq.tools.command.message; +import java.net.InetAddress; +import java.net.InetSocketAddress; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -32,12 +37,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.net.InetAddress; -import java.net.InetSocketAddress; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; - public class QueryMsgTraceByIdSubCommandTest { private ServerResponseMocker brokerMocker; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/message/SendMessageCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/message/SendMessageCommandTest.java index ada3132df5..6f750d530b 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/message/SendMessageCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/message/SendMessageCommandTest.java @@ -17,6 +17,9 @@ package org.apache.rocketmq.tools.command.message; +import java.io.ByteArrayOutputStream; +import java.io.PrintStream; +import java.lang.reflect.Field; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -35,10 +38,6 @@ import org.junit.Assert; import org.junit.BeforeClass; import org.junit.Test; -import java.io.ByteArrayOutputStream; -import java.io.PrintStream; -import java.lang.reflect.Field; - import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/AddWritePermSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/AddWritePermSubCommandTest.java index 5de41a2483..fdf6c00f03 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/AddWritePermSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/AddWritePermSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.namesrv; +import java.util.HashMap; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -28,8 +29,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashMap; - public class AddWritePermSubCommandTest { private ServerResponseMocker brokerMocker; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/WipeWritePermSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/WipeWritePermSubCommandTest.java index 2a70f540fd..b0f91268d3 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/WipeWritePermSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/namesrv/WipeWritePermSubCommandTest.java @@ -16,6 +16,7 @@ */ package org.apache.rocketmq.tools.command.namesrv; +import java.util.HashMap; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -27,8 +28,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashMap; - public class WipeWritePermSubCommandTest { private ServerResponseMocker brokerMocker; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/producer/ProducerSubCommandTest.java b/tools/src/test/java/org/apache/rocketmq/tools/command/producer/ProducerSubCommandTest.java index 13290911b4..1ca08146fb 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/producer/ProducerSubCommandTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/producer/ProducerSubCommandTest.java @@ -17,6 +17,7 @@ package org.apache.rocketmq.tools.command.producer; +import java.util.HashMap; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.Options; @@ -31,8 +32,6 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; -import java.util.HashMap; - public class ProducerSubCommandTest { private ServerResponseMocker brokerMocker; diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/server/NameServerMocker.java b/tools/src/test/java/org/apache/rocketmq/tools/command/server/NameServerMocker.java index 5f0d2d5449..6dc83dbb83 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/server/NameServerMocker.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/server/NameServerMocker.java @@ -16,12 +16,11 @@ */ package org.apache.rocketmq.tools.command.server; -import org.apache.rocketmq.common.protocol.route.BrokerData; -import org.apache.rocketmq.common.protocol.route.TopicRouteData; - import java.util.ArrayList; import java.util.HashMap; import java.util.List; +import org.apache.rocketmq.common.protocol.route.BrokerData; +import org.apache.rocketmq.common.protocol.route.TopicRouteData; /** * tools class diff --git a/tools/src/test/java/org/apache/rocketmq/tools/command/server/ServerResponseMocker.java b/tools/src/test/java/org/apache/rocketmq/tools/command/server/ServerResponseMocker.java index 01cc5a233f..8e043ce4bc 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/command/server/ServerResponseMocker.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/command/server/ServerResponseMocker.java @@ -29,6 +29,9 @@ import io.netty.channel.socket.SocketChannel; import io.netty.channel.socket.nio.NioServerSocketChannel; import io.netty.handler.timeout.IdleStateHandler; import io.netty.util.concurrent.Future; +import java.net.InetSocketAddress; +import java.util.HashMap; +import java.util.concurrent.ExecutionException; import org.apache.rocketmq.client.log.ClientLogger; import org.apache.rocketmq.remoting.netty.NettyDecoder; import org.apache.rocketmq.remoting.netty.NettyEncoder; @@ -36,10 +39,6 @@ import org.apache.rocketmq.remoting.protocol.RemotingCommand; import org.apache.rocketmq.remoting.protocol.RemotingSysResponseCode; import org.junit.After; import org.junit.Before; - -import java.net.InetSocketAddress; -import java.util.HashMap; -import java.util.concurrent.ExecutionException; import org.junit.BeforeClass; /** diff --git a/tools/src/test/java/org/apache/rocketmq/tools/monitor/DefaultMonitorListenerTest.java b/tools/src/test/java/org/apache/rocketmq/tools/monitor/DefaultMonitorListenerTest.java index f6f8794813..e527e6d4a3 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/monitor/DefaultMonitorListenerTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/monitor/DefaultMonitorListenerTest.java @@ -19,11 +19,7 @@ package org.apache.rocketmq.tools.monitor; import java.util.Properties; import java.util.TreeMap; import java.util.TreeSet; -import org.apache.rocketmq.common.message.MessageQueue; -import org.apache.rocketmq.common.protocol.body.ConsumeStatus; import org.apache.rocketmq.common.protocol.body.ConsumerRunningInfo; -import org.apache.rocketmq.common.protocol.body.ProcessQueueInfo; -import org.apache.rocketmq.common.protocol.heartbeat.SubscriptionData; import org.apache.rocketmq.common.protocol.topic.OffsetMovedEvent; import org.junit.Before; import org.junit.Test; @@ -75,10 +71,10 @@ public class DefaultMonitorListenerTest { public void testReportConsumerRunningInfo() { TreeMap criTable = new TreeMap<>(); ConsumerRunningInfo consumerRunningInfo = new ConsumerRunningInfo(); - consumerRunningInfo.setSubscriptionSet(new TreeSet()); - consumerRunningInfo.setStatusTable(new TreeMap()); - consumerRunningInfo.setSubscriptionSet(new TreeSet()); - consumerRunningInfo.setMqTable(new TreeMap()); + consumerRunningInfo.setSubscriptionSet(new TreeSet<>()); + consumerRunningInfo.setStatusTable(new TreeMap<>()); + consumerRunningInfo.setSubscriptionSet(new TreeSet<>()); + consumerRunningInfo.setMqTable(new TreeMap<>()); consumerRunningInfo.setProperties(new Properties()); criTable.put("test", consumerRunningInfo); defaultMonitorListener.reportConsumerRunningInfo(criTable); diff --git a/tools/src/test/java/org/apache/rocketmq/tools/monitor/MonitorServiceTest.java b/tools/src/test/java/org/apache/rocketmq/tools/monitor/MonitorServiceTest.java index 89bb16576f..0781afe049 100644 --- a/tools/src/test/java/org/apache/rocketmq/tools/monitor/MonitorServiceTest.java +++ b/tools/src/test/java/org/apache/rocketmq/tools/monitor/MonitorServiceTest.java @@ -40,16 +40,12 @@ import org.apache.rocketmq.common.admin.OffsetWrapper; import org.apache.rocketmq.common.consumer.ConsumeFromWhere; import org.apache.rocketmq.common.message.MessageQueue; import org.apache.rocketmq.common.protocol.body.Connection; -import org.apache.rocketmq.common.protocol.body.ConsumeStatus; import org.apache.rocketmq.common.protocol.body.ConsumerConnection; import org.apache.rocketmq.common.protocol.body.ConsumerRunningInfo; -import org.apache.rocketmq.common.protocol.body.ProcessQueueInfo; import org.apache.rocketmq.common.protocol.body.TopicList; import org.apache.rocketmq.common.protocol.heartbeat.ConsumeType; import org.apache.rocketmq.common.protocol.heartbeat.MessageModel; -import org.apache.rocketmq.common.protocol.heartbeat.SubscriptionData; import org.apache.rocketmq.common.protocol.route.BrokerData; -import org.apache.rocketmq.common.protocol.route.QueueData; import org.apache.rocketmq.common.protocol.route.TopicRouteData; import org.apache.rocketmq.remoting.exception.RemotingException; import org.apache.rocketmq.remoting.protocol.LanguageCode; @@ -125,8 +121,8 @@ public class MonitorServiceTest { brokerData.setBrokerAddrs(brokerAddrs); brokerDatas.add(brokerData); topicRouteData.setBrokerDatas(brokerDatas); - topicRouteData.setQueueDatas(new ArrayList()); - topicRouteData.setFilterServerTable(new HashMap>()); + topicRouteData.setQueueDatas(new ArrayList<>()); + topicRouteData.setFilterServerTable(new HashMap<>()); when(mQClientAPIImpl.getTopicRouteInfoFromNameServer(anyString(), anyLong())).thenReturn(topicRouteData); ConsumeStats consumeStats = new ConsumeStats(); @@ -149,15 +145,15 @@ public class MonitorServiceTest { connection.setVersion(MQVersion.Version.V4_0_0_SNAPSHOT.ordinal()); connections.add(connection); consumerConnection.setConnectionSet(connections); - consumerConnection.setSubscriptionTable(new ConcurrentHashMap()); + consumerConnection.setSubscriptionTable(new ConcurrentHashMap<>()); consumerConnection.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET); when(mQClientAPIImpl.getConsumerConnectionList(anyString(), anyString(), anyLong())).thenReturn(consumerConnection); ConsumerRunningInfo consumerRunningInfo = new ConsumerRunningInfo(); consumerRunningInfo.setJstack("test"); - consumerRunningInfo.setMqTable(new TreeMap()); - consumerRunningInfo.setStatusTable(new TreeMap()); - consumerRunningInfo.setSubscriptionSet(new TreeSet()); + consumerRunningInfo.setMqTable(new TreeMap<>()); + consumerRunningInfo.setStatusTable(new TreeMap<>()); + consumerRunningInfo.setSubscriptionSet(new TreeSet<>()); Properties properties = new Properties(); properties.put(ConsumerRunningInfo.PROP_CONSUME_TYPE, CONSUME_ACTIVELY); properties.put(ConsumerRunningInfo.PROP_CONSUMER_START_TIMESTAMP, System.currentTimeMillis());