From c121565c3eb59d536edc54512624e420136d30e5 Mon Sep 17 00:00:00 2001 From: hjl11 <52824850+hjl11@users.noreply.github.com> Date: Mon, 28 Mar 2022 10:15:43 +0800 Subject: [PATCH] [ISSUE #4040] Unnecessary toString methods deleted (#4041) --- .../broker/processor/AbstractSendMessageProcessor.java | 2 +- .../impl/consumer/ConsumeMessageConcurrentlyService.java | 2 +- .../rocketmq/client/impl/producer/DefaultMQProducerImpl.java | 2 +- .../java/org/apache/rocketmq/filter/util/BloomFilter.java | 4 ++-- .../apache/rocketmq/remoting/netty/NettyRemotingClient.java | 2 +- .../org/apache/rocketmq/test/util/DuplicateMessageInfo.java | 4 ++-- .../tools/command/message/PrintMessageByQueueCommand.java | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java index 3303d70e4a..f0925a7d6c 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java @@ -221,7 +221,7 @@ public abstract class AbstractSendMessageProcessor extends AsyncNettyRequestProc if (queueIdInt >= idValid) { String errorInfo = String.format("request queueId[%d] is illegal, %s Producer: %s", queueIdInt, - topicConfig.toString(), + topicConfig, RemotingHelper.parseChannelRemoteAddr(ctx.channel())); log.warn(errorInfo); diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java index a1e4eedd15..c3626c38b4 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java @@ -314,7 +314,7 @@ public class ConsumeMessageConcurrentlyService implements ConsumeMessageService this.defaultMQPushConsumerImpl.sendMessageBack(msg, delayLevel, context.getMessageQueue().getBrokerName()); return true; } catch (Exception e) { - log.error("sendMessageBack exception, group: " + this.consumerGroup + " msg: " + msg.toString(), e); + log.error("sendMessageBack exception, group: " + this.consumerGroup + " msg: " + msg, e); } return false; diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java index ea80478604..73569368f9 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java @@ -399,7 +399,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { if (info != null && topic != null) { TopicPublishInfo prev = this.topicPublishInfoTable.put(topic, info); if (prev != null) { - log.info("updateTopicPublishInfo prev is not null, " + prev.toString()); + log.info("updateTopicPublishInfo prev is not null, " + prev); } } } diff --git a/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java b/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java index 9a3de6016b..a1cbd24b07 100644 --- a/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java +++ b/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java @@ -145,7 +145,7 @@ public class BloomFilter { if (!isValid(filterData)) { throw new IllegalArgumentException( String.format("Bloom filter data may not belong to this filter! %s, %s", - filterData, this.toString()) + filterData, this) ); } hashTo(filterData.getBitPos(), bits); @@ -183,7 +183,7 @@ public class BloomFilter { if (!isValid(filterData)) { throw new IllegalArgumentException( String.format("Bloom filter data may not belong to this filter! %s, %s", - filterData, this.toString()) + filterData, this) ); } return isHit(filterData.getBitPos(), bits); diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java index 5ced3b7eb4..8576b23b09 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java @@ -513,7 +513,7 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti log.info("createChannel: connect remote host[{}] success, {}", addr, channelFuture.toString()); return cw.getChannel(); } else { - log.warn("createChannel: connect remote host[" + addr + "] failed, " + channelFuture.toString(), channelFuture.cause()); + log.warn("createChannel: connect remote host[" + addr + "] failed, " + channelFuture, channelFuture.cause()); } } else { log.warn("createChannel: connect remote host[{}] timeout {}ms, {}", addr, this.nettyClientConfig.getConnectTimeoutMillis(), diff --git a/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java b/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java index 8bd93b677e..c90c5c9bf9 100644 --- a/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java +++ b/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java @@ -90,7 +90,7 @@ public class DuplicateMessageInfo { getFloatNumString(msgQueueInnerDupRate) + "%\r\n"); } - System.out.print(strBuilder.toString()); + System.out.print(strBuilder); String titleString = "queue\tdupQueue\tdupMsg\r\n"; System.out.print(titleString); @@ -104,7 +104,7 @@ public class DuplicateMessageInfo { String strToWrite; byte[] byteToWrite; - strToWrite = strBuilder.toString() + titleString; + strToWrite = strBuilder + titleString; for (int i = 0; i < msgListSize; i++) strToWrite += strBQueue.get(i).toString() + "\r\n"; diff --git a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java index 46c5f74735..88f1b74762 100644 --- a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java +++ b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java @@ -93,7 +93,7 @@ public class PrintMessageByQueueCommand implements SubCommand { for (MessageExt msg : msgs) { try { - System.out.printf("MSGID: %s %s BODY: %s%n", msg.getMsgId(), msg.toString(), + System.out.printf("MSGID: %s %s BODY: %s%n", msg.getMsgId(), msg, printBody ? new String(msg.getBody(), charsetName) : "NOT PRINT BODY"); } catch (UnsupportedEncodingException e) { e.printStackTrace();