From 83f64a8b4dbb22909815488dcc3163a1a937733a Mon Sep 17 00:00:00 2001 From: mxsm Date: Thu, 4 Aug 2022 08:49:44 +0800 Subject: [PATCH] [ISSUE #4751] Optimize NettyRemotingAbstract#processRequestCommand code --- .../rocketmq/remoting/netty/NettyRemotingAbstract.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java index 272d4a6871..7e0e21d327 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java @@ -110,7 +110,7 @@ public abstract class NettyRemotingAbstract { * Constructor, specifying capacity of one-way and asynchronous semaphores. * * @param permitsOneway Number of permits for one-way requests. - * @param permitsAsync Number of permits for asynchronous requests. + * @param permitsAsync Number of permits for asynchronous requests. */ public NettyRemotingAbstract(final int permitsOneway, final int permitsAsync) { this.semaphoreOneway = new Semaphore(permitsOneway, true); @@ -210,8 +210,7 @@ public abstract class NettyRemotingAbstract { if (exception == null) { response = pair.getObject1().processRequest(ctx, cmd); } else { - response = RemotingCommand.createResponseCommand(null); - response.setCode(RemotingSysResponseCode.SYSTEM_ERROR); + response = RemotingCommand.createResponseCommand(RemotingSysResponseCode.SYSTEM_ERROR, null); } try {