From 61c4ba5009a9fe1fa2d68135e2349e85d556db3a Mon Sep 17 00:00:00 2001 From: Lei Zhiyuan Date: Wed, 8 Mar 2023 16:06:28 +0800 Subject: [PATCH] [ISSUE #6213] fix: when subscriptionGroupConfig is null ,we do not register consumer --- .../processor/ClientManageProcessor.java | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java index 556c951b83..c9c051a421 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java @@ -115,21 +115,21 @@ public class ClientManageProcessor implements NettyRequestProcessor { subscriptionGroupConfig.getRetryQueueNums(), PermName.PERM_WRITE | PermName.PERM_READ, hasOrderTopicSub, topicSysFlag); } - - boolean changed = this.brokerController.getConsumerManager().registerConsumer( - consumerData.getGroupName(), - clientChannelInfo, - consumerData.getConsumeType(), - consumerData.getMessageModel(), - consumerData.getConsumeFromWhere(), - consumerData.getSubscriptionDataSet(), - isNotifyConsumerIdsChangedEnable - ); - - if (changed) { - LOGGER.info( - "ClientManageProcessor: registerConsumer info changed, SDK address={}, consumerData={}", - RemotingHelper.parseChannelRemoteAddr(ctx.channel()), consumerData.toString()); + if (null != subscriptionGroupConfig) { + boolean changed = this.brokerController.getConsumerManager().registerConsumer( + consumerData.getGroupName(), + clientChannelInfo, + consumerData.getConsumeType(), + consumerData.getMessageModel(), + consumerData.getConsumeFromWhere(), + consumerData.getSubscriptionDataSet(), + isNotifyConsumerIdsChangedEnable + ); + if (changed) { + LOGGER.info( + "ClientManageProcessor: registerConsumer info changed, SDK address={}, consumerData={}", + RemotingHelper.parseChannelRemoteAddr(ctx.channel()), consumerData.toString()); + } } }