From 405f5aad83ed8d0ae6ffb803cb33536a4eb09530 Mon Sep 17 00:00:00 2001 From: "kaiyi.lk" Date: Wed, 1 Jun 2022 13:03:25 +0800 Subject: [PATCH] [ISSUE #3949] add log when write rejected response --- .../apache/rocketmq/acl/common/AuthorizationHeader.java | 1 - .../rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java | 9 ++++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java b/acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java index 24eb6de8db..aa40b6fd33 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java @@ -18,7 +18,6 @@ package org.apache.rocketmq.acl.common; import com.google.common.base.MoreObjects; -import java.util.Arrays; import org.apache.commons.codec.DecoderException; import org.apache.commons.codec.binary.Base64; import org.apache.commons.codec.binary.Hex; diff --git a/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java b/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java index 3538fd2b94..806504d683 100644 --- a/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java +++ b/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java @@ -349,7 +349,6 @@ public class GrpcMessagingApplication extends MessagingServiceGrpc.MessagingServ @Override public void onError(Throwable t) { - log.error("telemetry onError", t); responseTelemetryCommand.onError(t); } @@ -400,8 +399,12 @@ public class GrpcMessagingApplication extends MessagingServiceGrpc.MessagingServ @Override public void rejectedExecution(Runnable r, ThreadPoolExecutor executor) { if (r instanceof GrpcTask) { - GrpcTask grpcTask = (GrpcTask) r; - ResponseWriter.write(grpcTask.streamObserver, grpcTask.executeRejectResponse); + try { + GrpcTask grpcTask = (GrpcTask) r; + ResponseWriter.write(grpcTask.streamObserver, grpcTask.executeRejectResponse); + } catch (Throwable t) { + log.warn("write rejected error response failed", t); + } } } }