Files
panel/pkg/db/postgres.go
T
耗子andClaude Opus 5 e0588a1468 refactor: 把 context 打通到数据库、对象存储与容器 API
上一轮打通 shell 路径时留下三处接口本身不带 ctx,导致底下的
context.Background() 无法消除。这三处 contextcheck 都不报(接口方法没有
ctx 形参,静态分析认为合理),属于 lint 发现不了的死角:

- pkg/db.Operator 的 17 个方法加 ctx,MySQL/Postgres/ClickHouse/SQLite/
  MongoDB/Elasticsearch 实现同步改。其中 Elasticsearch 的 resty 请求原先
  根本没挂 ctx,不只是传了 Background
- pkg/storage.Storage 的 6 个方法加 ctx,local/s3/sftp/webdav 四个实现与
  s3sdk 子包同步改;sftp 连接改用 net.Dialer.DialContext,连接阶段可取消
- internal/data/container*.go 的 moby client 调用,Container/Image/Network/
  Volume 四个 Repo 共 26 个方法加 ctx

非测试代码的 context.Background() 从 71 处降到 14 处,剩下的是应用根 ctx、
有意的独立超时,以及几个瞬时本机操作的叶子函数。双平台 lint 保持 0 issues。

新增 23 处 context.WithoutCancel,其中两处的理由值得记:

备份上传断开取消链,是因为 ClearStorageExpired 按 mtime 保留最新 N 份,
上传被取消留下的截断文件会被当成最新的有效备份,把真正完好的旧备份挤出
保留窗口——静默的数据丢失。而 Put 失败路径没有任何远端清理逻辑,本地侧
反而有(任务队列独享 TMPDIR + defer RemoveAll),两边不对称。

Postgres.UserDrop 是 REASSIGN OWNED → DROP OWNED → DROP USER 三步,中途
取消会留下丢了所有权却没被删掉的用户;MySQL 权限变更后的 FLUSH 被跳过则
新授权根本不生效。

ImagePull 经核实不需要断开:moby 的 LayerDownloadManager 把未完成的层写在
临时文件里并在取消时删除,层只有完整校验后才注册进 layer store,取消不会
留下悬空层。

顺带删掉 8 处 //nolint:contextcheck,它们当初就是因为 Operator 接口没有
ctx 才挂上的。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-15 01:17:02 +08:00

294 lines
8.3 KiB
Go

package db
import (
"context"
"database/sql"
"fmt"
"slices"
"strings"
_ "github.com/lib/pq"
)
type Postgres struct {
db *sql.DB
username string
password string
address string
port uint
}
func NewPostgres(ctx context.Context, username, password, address string, port uint, database ...string) (Operator, error) {
username = strings.ReplaceAll(username, `'`, `\'`)
password = strings.ReplaceAll(password, `'`, `\'`)
dbname := "postgres"
if len(database) > 0 && database[0] != "" {
dbname = strings.ReplaceAll(database[0], `'`, `\'`)
}
// connect_timeout 限制建连耗时,避免不可达地址阻塞调用方
dsn := fmt.Sprintf(`host=%s port=%d user='%s' password='%s' dbname='%s' sslmode=disable connect_timeout=5`, address, port, username, password, dbname)
if password == "" {
if username == "" {
username = "postgres"
}
dsn = fmt.Sprintf(`host=%s port=%d user='%s' dbname='%s' sslmode=disable connect_timeout=5`, address, port, username, dbname)
}
db, err := sql.Open("postgres", dsn)
if err != nil {
return nil, fmt.Errorf("init postgres connection failed: %w", err)
}
if err = db.PingContext(ctx); err != nil {
_ = db.Close()
return nil, fmt.Errorf("connect to postgres failed: %w", err)
}
return &Postgres{
db: db,
username: username,
password: password,
address: address,
port: port,
}, nil
}
func (r *Postgres) Close() {
_ = r.db.Close()
}
func (r *Postgres) Ping(ctx context.Context) error {
return r.db.PingContext(ctx)
}
func (r *Postgres) Query(ctx context.Context, query string, args ...any) (*sql.Rows, error) {
return r.db.QueryContext(ctx, query, args...)
}
func (r *Postgres) QueryRow(ctx context.Context, query string, args ...any) *sql.Row {
return r.db.QueryRowContext(ctx, query, args...)
}
func (r *Postgres) Exec(ctx context.Context, query string, args ...any) (sql.Result, error) {
return r.db.ExecContext(ctx, query, args...)
}
func (r *Postgres) Prepare(ctx context.Context, query string) (*sql.Stmt, error) {
return r.db.PrepareContext(ctx, query)
}
func (r *Postgres) DatabaseCreate(ctx context.Context, name string) error {
// postgres 不支持 CREATE DATABASE IF NOT EXISTS,但是为了保持与 MySQL 一致,先检查数据库是否存在
exist, err := r.DatabaseExists(ctx, name)
if err != nil {
return err
}
if exist {
return nil
}
name = strings.ReplaceAll(name, `"`, `""`)
_, err = r.Exec(ctx, fmt.Sprintf(`CREATE DATABASE "%s"`, name))
return err
}
func (r *Postgres) DatabaseDrop(ctx context.Context, name string) error {
name = strings.ReplaceAll(name, `"`, `""`)
_, err := r.Exec(ctx, fmt.Sprintf(`DROP DATABASE IF EXISTS "%s"`, name))
return err
}
func (r *Postgres) DatabaseExists(ctx context.Context, name string) (bool, error) {
var count int
if err := r.QueryRow(ctx, "SELECT COUNT(*) FROM pg_database WHERE datname = $1", name).Scan(&count); err != nil {
return false, err
}
return count > 0, nil
}
func (r *Postgres) DatabaseSize(ctx context.Context, name string) (int64, error) {
var size int64
if err := r.QueryRow(ctx, "SELECT pg_database_size($1)", name).Scan(&size); err != nil {
return 0, err
}
return size, nil
}
func (r *Postgres) DatabaseComment(ctx context.Context, name, comment string) error {
name = strings.ReplaceAll(name, `"`, `""`)
_, err := r.Exec(ctx, fmt.Sprintf(`COMMENT ON DATABASE "%s" IS '%s'`, name, comment))
return err
}
func (r *Postgres) UserCreate(ctx context.Context, user, password string, host ...string) error {
user = strings.ReplaceAll(user, `"`, `""`)
_, err := r.Exec(ctx, fmt.Sprintf(`CREATE USER "%s" WITH PASSWORD '%s'`, user, password))
if err != nil {
return err
}
return nil
}
func (r *Postgres) UserDrop(ctx context.Context, user string, host ...string) error {
// PostgreSQL 中,如果用户拥有数据库对象或权限,直接 DROP USER 会失败
// 必须先转移所有权并撤销权限
// 三步是一个整体,中途取消会留下丢了所有权却没被删掉的用户
ctx = context.WithoutCancel(ctx)
user = strings.ReplaceAll(user, `"`, `""`)
username := strings.ReplaceAll(r.username, `"`, `""`)
if _, err := r.Exec(ctx, fmt.Sprintf(`REASSIGN OWNED BY "%s" TO "%s"`, user, username)); err != nil {
return err
}
if _, err := r.Exec(ctx, fmt.Sprintf(`DROP OWNED BY "%s"`, user)); err != nil {
return err
}
_, err := r.Exec(ctx, fmt.Sprintf(`DROP USER IF EXISTS "%s"`, user))
if err != nil {
return err
}
return nil
}
func (r *Postgres) UserPassword(ctx context.Context, user, password string, host ...string) error {
user = strings.ReplaceAll(user, `"`, `""`)
_, err := r.Exec(ctx, fmt.Sprintf(`ALTER USER "%s" WITH PASSWORD '%s'`, user, password))
return err
}
func (r *Postgres) UserPrivileges(ctx context.Context, user string, host ...string) ([]string, error) {
query := `
SELECT d.datname
FROM pg_catalog.pg_database d
JOIN pg_catalog.pg_roles r ON d.datdba = r.oid
WHERE r.rolname = $1
AND d.datistemplate = false
AND d.datname NOT IN ('template0', 'template1', 'postgres')
ORDER BY d.datname;
`
rows, err := r.Query(ctx, query, user)
if err != nil {
return nil, err
}
defer func(rows *sql.Rows) { _ = rows.Close() }(rows)
var databases []string
for rows.Next() {
var dbName string
if err = rows.Scan(&dbName); err != nil {
return nil, err
}
databases = append(databases, dbName)
}
if err = rows.Err(); err != nil {
return nil, err
}
return databases, nil
}
func (r *Postgres) PrivilegesGrant(ctx context.Context, user, database string, host ...string) error {
// 改属主和授权是一个整体,中途取消会留下换了属主却没有权限的库
ctx = context.WithoutCancel(ctx)
user = strings.ReplaceAll(user, `"`, `""`)
database = strings.ReplaceAll(database, `"`, `""`)
if _, err := r.Exec(ctx, fmt.Sprintf(`ALTER DATABASE "%s" OWNER TO "%s"`, database, user)); err != nil {
return err
}
if _, err := r.Exec(ctx, fmt.Sprintf(`GRANT ALL PRIVILEGES ON DATABASE "%s" TO "%s"`, database, user)); err != nil {
return err
}
return nil
}
func (r *Postgres) PrivilegesRevoke(ctx context.Context, user, database string, host ...string) error {
user = strings.ReplaceAll(user, `"`, `""`)
database = strings.ReplaceAll(database, `"`, `""`)
_, err := r.Exec(ctx, fmt.Sprintf(`REVOKE ALL PRIVILEGES ON DATABASE "%s" FROM "%s"`, database, user))
return err
}
func (r *Postgres) Users(ctx context.Context) ([]User, error) {
query := `
SELECT rolname,
rolsuper,
rolcreaterole,
rolcreatedb,
rolreplication,
rolbypassrls
FROM pg_roles
WHERE rolcanlogin = true;
`
rows, err := r.Query(ctx, query)
if err != nil {
return nil, err
}
defer func(rows *sql.Rows) { _ = rows.Close() }(rows)
var users []User
for rows.Next() {
var user User
var super, canCreateRole, canCreateDb, replication, bypassRls bool
if err = rows.Scan(&user.User, &super, &canCreateRole, &canCreateDb, &replication, &bypassRls); err != nil {
return nil, err
}
permissions := map[string]bool{
"Super": super,
"CreateRole": canCreateRole,
"CreateDB": canCreateDb,
"Replication": replication,
"BypassRLS": bypassRls,
}
for perm, enabled := range permissions {
if enabled {
user.Grants = append(user.Grants, perm)
}
}
if len(user.Grants) == 0 {
user.Grants = append(user.Grants, "None")
}
users = append(users, user)
}
if err = rows.Err(); err != nil {
return nil, err
}
return users, nil
}
func (r *Postgres) Databases(ctx context.Context) ([]Database, error) {
query := `
SELECT
d.datname,
pg_catalog.pg_get_userbyid(d.datdba),
pg_catalog.pg_encoding_to_char(d.encoding),
COALESCE(pg_catalog.shobj_description(d.oid, 'pg_database'), '')
FROM pg_catalog.pg_database d
WHERE datistemplate = false;
`
rows, err := r.Query(ctx, query)
if err != nil {
return nil, err
}
defer func(rows *sql.Rows) { _ = rows.Close() }(rows)
var databases []Database
for rows.Next() {
var db Database
if err := rows.Scan(&db.Name, &db.Owner, &db.CharSet, &db.Comment); err != nil {
return nil, err
}
if slices.Contains([]string{"template0", "template1", "postgres"}, db.Name) {
continue
}
databases = append(databases, db)
}
return databases, rows.Err()
}