From a8020b37be022ce97d50828bb8f5f9b9bc943ef4 Mon Sep 17 00:00:00 2001
From: Richard Stanway <r1ch@r1ch.net>
Date: Wed, 28 Sep 2016 15:21:07 -0700
Subject: [PATCH] obs-ffmpeg: Fix possible NVENC crash

If the codec hasn't even been fully initialized, calling these functions
in the shutdown code could cause a crash.
---
 plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c b/plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c
index 4b693c02c..520c6e80d 100644
--- a/plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c
+++ b/plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c
@@ -54,6 +54,7 @@ struct nvenc_encoder {
 
 	int                            height;
 	bool                           first_packet;
+	bool                           initialized;
 };
 
 static const char *nvenc_getname(void *unused)
@@ -113,6 +114,8 @@ static bool nvenc_init_codec(struct nvenc_encoder *enc)
 		return false;
 	}
 
+	enc->initialized = true;
+
 	*((AVPicture*)enc->vframe) = enc->dst_picture;
 	return true;
 }
@@ -233,15 +236,19 @@ static bool nvenc_update(void *data, obs_data_t *settings)
 static void nvenc_destroy(void *data)
 {
 	struct nvenc_encoder *enc = data;
-	AVPacket pkt = {0};
-	int r_pkt = 1;
 
-	while (r_pkt) {
-		if (avcodec_encode_video2(enc->context, &pkt, NULL, &r_pkt) < 0)
-			break;
+	if (enc->initialized) {
+		AVPacket pkt = {0};
+		int r_pkt = 1;
 
-		if (r_pkt)
-			av_free_packet(&pkt);
+		while (r_pkt) {
+			if (avcodec_encode_video2(enc->context, &pkt, NULL,
+						&r_pkt) < 0)
+				break;
+
+			if (r_pkt)
+				av_free_packet(&pkt);
+		}
 	}
 
 	avcodec_close(enc->context);