From 7d25a8061020bd3a1a4a22f91e08765a6d80603b Mon Sep 17 00:00:00 2001 From: CrackThrough Date: Wed, 31 Jan 2024 15:15:57 +0900 Subject: [PATCH] UI: Fix null pointer dereference strcmp(obs_get_encoder_codec(option), "opus") causes the application to segfault while loading service if find_encoder(id) returns NULL. Add a null pointer check to prevent that from occurring. --- UI/window-basic-main.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UI/window-basic-main.cpp b/UI/window-basic-main.cpp index c1911f8d2..c7aea6301 100644 --- a/UI/window-basic-main.cpp +++ b/UI/window-basic-main.cpp @@ -1431,7 +1431,9 @@ bool OBSBasic::LoadService() option = config_get_string(basicConfig, "AdvOut", "AudioEncoder"); - if (strcmp(obs_get_encoder_codec(option), "opus") != 0) + + const char *encoder_codec = obs_get_encoder_codec(option); + if (!encoder_codec || strcmp(encoder_codec, "opus") != 0) config_set_string(basicConfig, "AdvOut", "AudioEncoder", "ffmpeg_opus"); }