mirror of
https://github.com/obsproject/obs-studio.git
synced 2026-09-24 23:31:36 +08:00
UI: Add recording presets to simple output
So certain high-profile individuals were complaining that it was difficult to configure recording settings for quality in OBS. So, I decided to add a very easy-to-use auto-configuration for high quality encoding -- including lossless encoding. This feature will automatically configure ideal recording settings based upon a specified quality level. Recording quality presets added to simple output: - Same as stream: Copies the encoded streaming data with no extra usage hit. - High quality: uses a higher CRF value (starting at 23) if using x264. - Indistinguishable quality: uses a low CRF value (starting at 16) if using x264. - Lossless will spawn an FFmpeg output that uses huffyuv encoding. If a user tries to select lossless, they will be warned both via a dialog prompt and a warning message in the settings window to ensure they understand that it requires tremendous amounts of free space. It will always use the AVI file format. Extra Notes: - When High/Indistinguishable quality is set, it will allow you to select the recording encoder. Currently, it just allows you to select x264 (at either veryfast or ultrafast). Later on, it'll be useful to be able to set up pre-configured presets for hardware encoders once more are implemented and tested. - I decided to allow the use of x264 at both veryfast or ultrafast presets. The reasoning is two-fold: 1.) ultrafast is perfectly viable even for near indistinguishable quality as long as it has the appropriate CRF value. It's nice if you want to record but would like to or need to reduce the impact of encoding on the CPU. It will automatically compensate for the preset at the cost of larger file size. 2.) It was suggested to just always use ultrafast, but ultrafast requires 2-4x as much disk space for the same CRF (most likely due to x264 compensating for the preset). Providing veryfast is important if you really want to reduce file size and/or reduce blocking at lower quality levels. - When a recording preset is used, a secondary audio encoder is also spawned at 192 bitrate to ensure high quality audio. I chose 192 because that's the limit of the media foundation aac encoder on windows, which I want to make sure is used if available due to its high performance. - The CRF calculation is based upon resolution, quality, and whether it's set to ultrafast. First, quality sets the base CRF, 23 for "good" quality, 16 for "very high" quality. If set to ultrafast, it'll subtract 2 points from the CRF value to help compensate. Lower resolutions will also lower the CRF value to help improve higher details with a smaller pixel ratio.
This commit is contained in:
jp9000
@@ -104,18 +104,36 @@ static bool CreateAACEncoder(OBSEncoder &res, string &id, int bitrate,
|
||||
/* ------------------------------------------------------------------------ */
|
||||
|
||||
struct SimpleOutput : BasicOutputHandler {
|
||||
OBSEncoder aac;
|
||||
OBSEncoder h264;
|
||||
OBSEncoder aacStreaming;
|
||||
OBSEncoder h264Streaming;
|
||||
OBSEncoder aacRecording;
|
||||
OBSEncoder h264Recording;
|
||||
|
||||
string aacEncoderID;
|
||||
string aacRecEncID;
|
||||
string aacStreamEncID;
|
||||
|
||||
string videoEncoder;
|
||||
string videoQuality;
|
||||
bool usingRecordingPreset = false;
|
||||
bool ffmpegOutput = false;
|
||||
bool lowCPUx264 = false;
|
||||
|
||||
SimpleOutput(OBSBasic *main_);
|
||||
|
||||
int CalcCRF(int crf);
|
||||
|
||||
void UpdateRecordingSettings_x264_crf(int crf);
|
||||
void UpdateRecordingSettings();
|
||||
void UpdateRecordingAudioSettings();
|
||||
virtual void Update() override;
|
||||
|
||||
void SetupOutputs();
|
||||
int GetAudioBitrate() const;
|
||||
|
||||
void LoadRecordingPreset_x264();
|
||||
void LoadRecordingPreset_Lossless();
|
||||
void LoadRecordingPreset();
|
||||
|
||||
virtual bool StartStreaming(obs_service_t *service) override;
|
||||
virtual bool StartRecording() override;
|
||||
virtual void StopStreaming() override;
|
||||
@@ -125,6 +143,68 @@ struct SimpleOutput : BasicOutputHandler {
|
||||
virtual bool RecordingActive() const override;
|
||||
};
|
||||
|
||||
void SimpleOutput::LoadRecordingPreset_Lossless()
|
||||
{
|
||||
fileOutput = obs_output_create("ffmpeg_output",
|
||||
"simple_ffmpeg_output", nullptr, nullptr);
|
||||
if (!fileOutput)
|
||||
throw "Failed to create recording FFmpeg output "
|
||||
"(simple output)";
|
||||
obs_output_release(fileOutput);
|
||||
|
||||
obs_data_t *settings = obs_data_create();
|
||||
obs_data_set_string(settings, "format_name", "avi");
|
||||
obs_data_set_string(settings, "video_encoder", "huffyuv");
|
||||
obs_data_set_int(settings, "audio_bitrate", 512);
|
||||
obs_data_set_string(settings, "audio_encoder", "ac3");
|
||||
|
||||
obs_output_update(fileOutput, settings);
|
||||
obs_data_release(settings);
|
||||
}
|
||||
|
||||
void SimpleOutput::LoadRecordingPreset_x264()
|
||||
{
|
||||
h264Recording = obs_video_encoder_create("obs_x264",
|
||||
"simple_h264_recording", nullptr, nullptr);
|
||||
if (!h264Recording)
|
||||
throw "Failed to create h264 recording encoder (simple output)";
|
||||
obs_encoder_release(h264Recording);
|
||||
|
||||
if (!CreateAACEncoder(aacRecording, aacRecEncID, 192,
|
||||
"simple_aac_recording", 0))
|
||||
throw "Failed to create aac recording encoder (simple output)";
|
||||
}
|
||||
|
||||
void SimpleOutput::LoadRecordingPreset()
|
||||
{
|
||||
const char *quality = config_get_string(main->Config(), "SimpleOutput",
|
||||
"RecQuality");
|
||||
const char *encoder = config_get_string(main->Config(), "SimpleOutput",
|
||||
"RecEncoder");
|
||||
|
||||
videoEncoder = encoder;
|
||||
videoQuality = quality;
|
||||
ffmpegOutput = false;
|
||||
|
||||
if (strcmp(quality, "Stream") == 0) {
|
||||
h264Recording = h264Streaming;
|
||||
aacRecording = aacStreaming;
|
||||
usingRecordingPreset = false;
|
||||
return;
|
||||
|
||||
} else if (strcmp(quality, "Lossless") == 0) {
|
||||
LoadRecordingPreset_Lossless();
|
||||
usingRecordingPreset = true;
|
||||
ffmpegOutput = true;
|
||||
return;
|
||||
|
||||
} else {
|
||||
lowCPUx264 = strcmp(encoder, SIMPLE_ENCODER_X264_LOWCPU) == 0;
|
||||
LoadRecordingPreset_x264();
|
||||
usingRecordingPreset = true;
|
||||
}
|
||||
}
|
||||
|
||||
SimpleOutput::SimpleOutput(OBSBasic *main_) : BasicOutputHandler(main_)
|
||||
{
|
||||
streamOutput = obs_output_create("rtmp_output", "simple_stream",
|
||||
@@ -133,21 +213,15 @@ SimpleOutput::SimpleOutput(OBSBasic *main_) : BasicOutputHandler(main_)
|
||||
throw "Failed to create stream output (simple output)";
|
||||
obs_output_release(streamOutput);
|
||||
|
||||
fileOutput = obs_output_create("ffmpeg_muxer", "simple_file_output",
|
||||
nullptr, nullptr);
|
||||
if (!fileOutput)
|
||||
throw "Failed to create recording output (simple output)";
|
||||
obs_output_release(fileOutput);
|
||||
h264Streaming = obs_video_encoder_create("obs_x264",
|
||||
"simple_h264_stream", nullptr, nullptr);
|
||||
if (!h264Streaming)
|
||||
throw "Failed to create h264 streaming encoder (simple output)";
|
||||
obs_encoder_release(h264Streaming);
|
||||
|
||||
h264 = obs_video_encoder_create("obs_x264", "simple_h264", nullptr,
|
||||
nullptr);
|
||||
if (!h264)
|
||||
throw "Failed to create h264 encoder (simple output)";
|
||||
obs_encoder_release(h264);
|
||||
|
||||
if (!CreateAACEncoder(aac, aacEncoderID, GetAudioBitrate(),
|
||||
if (!CreateAACEncoder(aacStreaming, aacStreamEncID, GetAudioBitrate(),
|
||||
"simple_aac", 0))
|
||||
throw "Failed to create audio encoder (simple output)";
|
||||
throw "Failed to create aac streaming encoder (simple output)";
|
||||
|
||||
streamDelayStarting.Connect(obs_output_get_signal_handler(streamOutput),
|
||||
"starting", OBSStreamStarting, this);
|
||||
@@ -159,6 +233,17 @@ SimpleOutput::SimpleOutput(OBSBasic *main_) : BasicOutputHandler(main_)
|
||||
stopStreaming.Connect(obs_output_get_signal_handler(streamOutput),
|
||||
"stop", OBSStopStreaming, this);
|
||||
|
||||
LoadRecordingPreset();
|
||||
|
||||
if (!ffmpegOutput) {
|
||||
fileOutput = obs_output_create("ffmpeg_muxer",
|
||||
"simple_file_output", nullptr, nullptr);
|
||||
if (!fileOutput)
|
||||
throw "Failed to create recording output "
|
||||
"(simple output)";
|
||||
obs_output_release(fileOutput);
|
||||
}
|
||||
|
||||
startRecording.Connect(obs_output_get_signal_handler(fileOutput),
|
||||
"start", OBSStartRecording, this);
|
||||
stopRecording.Connect(obs_output_get_signal_handler(fileOutput),
|
||||
@@ -202,20 +287,89 @@ void SimpleOutput::Update()
|
||||
enum video_format format = video_output_get_format(video);
|
||||
|
||||
if (format != VIDEO_FORMAT_NV12 && format != VIDEO_FORMAT_I420)
|
||||
obs_encoder_set_preferred_video_format(h264, VIDEO_FORMAT_NV12);
|
||||
obs_encoder_set_preferred_video_format(h264Streaming,
|
||||
VIDEO_FORMAT_NV12);
|
||||
|
||||
obs_encoder_update(h264, h264Settings);
|
||||
obs_encoder_update(aac, aacSettings);
|
||||
obs_encoder_update(h264Streaming, h264Settings);
|
||||
obs_encoder_update(aacStreaming, aacSettings);
|
||||
|
||||
obs_data_release(h264Settings);
|
||||
obs_data_release(aacSettings);
|
||||
}
|
||||
|
||||
void SimpleOutput::UpdateRecordingAudioSettings()
|
||||
{
|
||||
obs_data_t *settings = obs_data_create();
|
||||
obs_data_set_int(settings, "bitrate", 192);
|
||||
obs_data_set_bool(settings, "cbr", true);
|
||||
|
||||
obs_encoder_update(aacRecording, settings);
|
||||
|
||||
obs_data_release(settings);
|
||||
}
|
||||
|
||||
#define CROSS_DIST_CUTOFF 2000.0
|
||||
|
||||
int SimpleOutput::CalcCRF(int crf)
|
||||
{
|
||||
int cx = config_get_uint(main->Config(), "Video", "OutputCX");
|
||||
int cy = config_get_uint(main->Config(), "Video", "OutputCY");
|
||||
double fCX = double(cx);
|
||||
double fCY = double(cy);
|
||||
|
||||
if (lowCPUx264)
|
||||
crf -= 2;
|
||||
|
||||
double crossDist = sqrt(fCX * fCX + fCY * fCY);
|
||||
double crfResReduction =
|
||||
fmin(CROSS_DIST_CUTOFF, crossDist) / CROSS_DIST_CUTOFF;
|
||||
crfResReduction = (1.0 - crfResReduction) * 10.0;
|
||||
|
||||
return crf - int(crfResReduction);
|
||||
}
|
||||
|
||||
void SimpleOutput::UpdateRecordingSettings_x264_crf(int crf)
|
||||
{
|
||||
obs_data_t *settings = obs_data_create();
|
||||
obs_data_set_int(settings, "bitrate", 1000);
|
||||
obs_data_set_int(settings, "buffer_size", 0);
|
||||
obs_data_set_int(settings, "crf", crf);
|
||||
obs_data_set_bool(settings, "use_bufsize", true);
|
||||
obs_data_set_bool(settings, "cbr", false);
|
||||
obs_data_set_string(settings, "profile", "high");
|
||||
obs_data_set_string(settings, "preset",
|
||||
lowCPUx264 ? "ultrafast" : "veryfast");
|
||||
|
||||
obs_encoder_update(h264Recording, settings);
|
||||
|
||||
obs_data_release(settings);
|
||||
}
|
||||
|
||||
void SimpleOutput::UpdateRecordingSettings()
|
||||
{
|
||||
if (astrcmp_n(videoEncoder.c_str(), "x264", 4) == 0) {
|
||||
if (videoQuality == "Small")
|
||||
UpdateRecordingSettings_x264_crf(CalcCRF(23));
|
||||
else if (videoQuality == "HQ")
|
||||
UpdateRecordingSettings_x264_crf(CalcCRF(16));
|
||||
}
|
||||
}
|
||||
|
||||
inline void SimpleOutput::SetupOutputs()
|
||||
{
|
||||
SimpleOutput::Update();
|
||||
obs_encoder_set_video(h264, obs_get_video());
|
||||
obs_encoder_set_audio(aac, obs_get_audio());
|
||||
obs_encoder_set_video(h264Streaming, obs_get_video());
|
||||
obs_encoder_set_audio(aacStreaming, obs_get_audio());
|
||||
|
||||
if (usingRecordingPreset) {
|
||||
if (ffmpegOutput) {
|
||||
obs_output_set_media(fileOutput, obs_get_video(),
|
||||
obs_get_audio());
|
||||
} else {
|
||||
obs_encoder_set_video(h264Recording, obs_get_video());
|
||||
obs_encoder_set_audio(aacRecording, obs_get_audio());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
bool SimpleOutput::StartStreaming(obs_service_t *service)
|
||||
@@ -223,8 +377,8 @@ bool SimpleOutput::StartStreaming(obs_service_t *service)
|
||||
if (!Active())
|
||||
SetupOutputs();
|
||||
|
||||
obs_output_set_video_encoder(streamOutput, h264);
|
||||
obs_output_set_audio_encoder(streamOutput, aac, 0);
|
||||
obs_output_set_video_encoder(streamOutput, h264Streaming);
|
||||
obs_output_set_audio_encoder(streamOutput, aacStreaming, 0);
|
||||
obs_output_set_service(streamOutput, service);
|
||||
|
||||
bool reconnect = config_get_bool(main->Config(), "Output",
|
||||
@@ -257,6 +411,13 @@ bool SimpleOutput::StartStreaming(obs_service_t *service)
|
||||
|
||||
bool SimpleOutput::StartRecording()
|
||||
{
|
||||
if (usingRecordingPreset) {
|
||||
if (!ffmpegOutput)
|
||||
UpdateRecordingSettings();
|
||||
} else if (!obs_output_active(streamOutput)) {
|
||||
Update();
|
||||
}
|
||||
|
||||
if (!Active())
|
||||
SetupOutputs();
|
||||
|
||||
@@ -283,15 +444,18 @@ bool SimpleOutput::StartRecording()
|
||||
if (lastChar != '/' && lastChar != '\\')
|
||||
strPath += "/";
|
||||
|
||||
strPath += GenerateTimeDateFilename(format);
|
||||
strPath += GenerateTimeDateFilename(ffmpegOutput ? "avi" : format);
|
||||
|
||||
SetupOutputs();
|
||||
|
||||
obs_output_set_video_encoder(fileOutput, h264);
|
||||
obs_output_set_audio_encoder(fileOutput, aac, 0);
|
||||
if (!ffmpegOutput) {
|
||||
obs_output_set_video_encoder(fileOutput, h264Recording);
|
||||
obs_output_set_audio_encoder(fileOutput, aacRecording, 0);
|
||||
}
|
||||
|
||||
obs_data_t *settings = obs_data_create();
|
||||
obs_data_set_string(settings, "path", strPath.c_str());
|
||||
obs_data_set_string(settings, ffmpegOutput ? "url" : "path",
|
||||
strPath.c_str());
|
||||
|
||||
obs_output_update(fileOutput, settings);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user