From 4f8b17d61229f5cf745e3d320767323d2e383fb0 Mon Sep 17 00:00:00 2001 From: gxalpha Date: Thu, 10 Aug 2023 19:53:18 +0200 Subject: [PATCH] UI: Use QGroupBox::toggled signal for group changes The QGroupBox::clicked is specifically for mouse clicks. This means that it's not emitted if the "checked" property is modified through other means than the mouse, for example programatically or through accessibility software like VoiceOver. However, we do want to catch such events, so the QGroupBox::toggle signal (which as per the Qt documentation is the notified signal for the "checked" property) is the appropriate one to use. --- UI/window-basic-settings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/window-basic-settings.cpp b/UI/window-basic-settings.cpp index 46015d2f7..94416340b 100644 --- a/UI/window-basic-settings.cpp +++ b/UI/window-basic-settings.cpp @@ -334,7 +334,7 @@ void RestrictResetBitrates(initializer_list boxes, int maxbitrate); #define EDIT_CHANGED &QLineEdit::textChanged #define CBEDIT_CHANGED &QComboBox::editTextChanged #define CHECK_CHANGED &QCheckBox::clicked -#define GROUP_CHANGED &QGroupBox::clicked +#define GROUP_CHANGED &QGroupBox::toggled #define SCROLL_CHANGED &QSpinBox::valueChanged #define DSCROLL_CHANGED &QDoubleSpinBox::valueChanged