From cce5401ed29df9ada99be29b4a67892c389b8dab Mon Sep 17 00:00:00 2001 From: Rob Hough Date: Tue, 11 Aug 2026 11:22:36 +0100 Subject: [PATCH] fix(editor): Remove misleading reset zoom control (#35843) --- .../workflows/canvas/components/Canvas.vue | 1 - .../buttons/CanvasControlButtons.test.ts | 20 ------------------ .../elements/buttons/CanvasControlButtons.vue | 21 ------------------- .../CanvasControlButtons.test.ts.snap | 1 - .../testing/playwright/pages/CanvasPage.ts | 4 ---- .../editor/canvas/canvas-zoom.spec.ts | 8 ++----- 6 files changed, 2 insertions(+), 53 deletions(-) diff --git a/packages/frontend/editor-ui/src/features/workflows/canvas/components/Canvas.vue b/packages/frontend/editor-ui/src/features/workflows/canvas/components/Canvas.vue index 9320632441f..be64afcd327 100644 --- a/packages/frontend/editor-ui/src/features/workflows/canvas/components/Canvas.vue +++ b/packages/frontend/editor-ui/src/features/workflows/canvas/components/Canvas.vue @@ -1926,7 +1926,6 @@ defineExpose({ @zoom-to-fit="onFitView" @zoom-in="onZoomIn" @zoom-out="onZoomOut" - @reset-zoom="onResetZoom" @tidy-up="onTidyUp({ source: 'canvas-button' })" @toggle-zoom-mode="onToggleZoomMode" /> diff --git a/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.test.ts b/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.test.ts index 94a6fa9cec5..009ed40f474 100644 --- a/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.test.ts +++ b/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.test.ts @@ -28,26 +28,6 @@ describe('CanvasControlButtons', () => { expect(wrapper.html()).toMatchSnapshot(); }); - it('should show reset zoom button when zoom is not equal to 1', () => { - const wrapper = renderComponent({ - props: { - zoom: 1.5, - }, - }); - - expect(wrapper.getByTestId('reset-zoom-button')).toBeVisible(); - }); - - it('should hide the reset zoom button when zoom is equal to 1', () => { - const wrapper = renderComponent({ - props: { - zoom: 1, - }, - }); - - expect(wrapper.queryByTestId('reset-zoom-button')).not.toBeInTheDocument(); - }); - it('should hide the tidy up button when canvas is read-only', () => { const wrapper = renderComponent({ props: { diff --git a/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.vue b/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.vue index bf4809c44ad..44113b62331 100644 --- a/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.vue +++ b/packages/frontend/editor-ui/src/features/workflows/canvas/components/elements/buttons/CanvasControlButtons.vue @@ -20,7 +20,6 @@ const props = withDefaults( ); const emit = defineEmits<{ - 'reset-zoom': []; 'zoom-in': []; 'zoom-out': []; 'zoom-to-fit': []; @@ -38,12 +37,6 @@ const isExperimentalNdvActive = computed(() => experimentalNdvStore.isActive(pro const isToggleZoomVisible = computed(() => experimentalNdvStore.isZoomedViewEnabled); -const isResetZoomVisible = computed(() => !isToggleZoomVisible.value && props.zoom !== 1); - -function onResetZoom() { - emit('reset-zoom'); -} - function onZoomIn() { emit('zoom-in'); } @@ -129,20 +122,6 @@ function handleClickCollapseAll() { @click="emit('toggle-zoom-mode')" /> - - - should render correctly 1`] = ` - diff --git a/packages/testing/playwright/pages/CanvasPage.ts b/packages/testing/playwright/pages/CanvasPage.ts index 4c7b1e3cffc..e84f32015b8 100644 --- a/packages/testing/playwright/pages/CanvasPage.ts +++ b/packages/testing/playwright/pages/CanvasPage.ts @@ -896,10 +896,6 @@ export class CanvasPage extends BasePage { return this.page.getByTestId('zoom-in-button'); } - getResetZoomButton(): Locator { - return this.page.getByTestId('reset-zoom-button'); - } - async clickZoomInButton(): Promise { await this.clickByTestId('zoom-in-button'); } diff --git a/packages/testing/playwright/tests/e2e/workflows/editor/canvas/canvas-zoom.spec.ts b/packages/testing/playwright/tests/e2e/workflows/editor/canvas/canvas-zoom.spec.ts index 6101ac3889d..60f1d79d926 100644 --- a/packages/testing/playwright/tests/e2e/workflows/editor/canvas/canvas-zoom.spec.ts +++ b/packages/testing/playwright/tests/e2e/workflows/editor/canvas/canvas-zoom.spec.ts @@ -55,13 +55,9 @@ test.describe( expect(finalZoom).toBeLessThanOrEqual(ZOOM_OUT_X2_FACTOR + ZOOM_TOLERANCE); }); - test('should reset zoom', async ({ n8n }) => { - await expect(n8n.canvas.getResetZoomButton()).not.toBeAttached(); - + test('should reset zoom on keyboard shortcut', async ({ n8n }) => { await n8n.canvas.clickZoomInButton(); - - await expect(n8n.canvas.getResetZoomButton()).toBeVisible(); - await n8n.canvas.getResetZoomButton().click(); + await n8n.page.keyboard.press('0'); await expectZoomLevel(n8n, DEFAULT_ZOOM_FACTOR); });