From b45be8aa4ca00e47c581b9cd704a1586f956ffa3 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Fri, 24 Oct 2025 12:09:54 +0300 Subject: [PATCH] refactor(editor): Extract `NodeSettings` code into features/ndv (no-changelog) (#21093) --- .../editor-ui/src/components/FocusPanel.vue | 4 ++-- .../editor-ui/src/components/ParameterInput.vue | 4 ++-- .../src/components/ParameterInputList.vue | 4 ++-- .../editor-ui/src/components/ParameterOptions.vue | 2 +- .../features/ndv/components/runData/RunData.vue | 2 +- .../ndv/components/settings}/NodeSettings.vue | 14 +++++++------- .../components/settings}/NodeSettingsHeader.vue | 2 +- .../ndv/components/settings}/NodeSettingsHint.vue | 0 .../NodeSettingsInvalidNodeWarning.test.ts | 0 .../settings}/NodeSettingsInvalidNodeWarning.vue | 2 +- .../components/settings}/NodeSettingsTabs.test.ts | 2 +- .../ndv/components/settings}/NodeSettingsTabs.vue | 0 .../ndv/components/settings}/NodeWebhooks.vue | 0 .../composables/useNodeSettingsParameters.test.ts | 2 +- .../ndv}/composables/useNodeSettingsParameters.ts | 14 +++++++------- .../ndv/ndv.utils.test.ts} | 2 +- .../ndv/ndv.utils.ts} | 4 ++-- .../src/features/ndv/views/NodeDetailsView.vue | 2 +- .../src/features/ndv/views/NodeDetailsViewV2.vue | 2 +- .../components/ExperimentalCanvasNodeSettings.vue | 2 +- .../components/ExperimentalEmbeddedNdvHeader.vue | 2 +- 21 files changed, 33 insertions(+), 33 deletions(-) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettings.vue (98%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsHeader.vue (96%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsHint.vue (100%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsInvalidNodeWarning.test.ts (100%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsInvalidNodeWarning.vue (98%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsTabs.test.ts (97%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeSettingsTabs.vue (100%) rename packages/frontend/editor-ui/src/{components => features/ndv/components/settings}/NodeWebhooks.vue (100%) rename packages/frontend/editor-ui/src/{ => features/ndv}/composables/useNodeSettingsParameters.test.ts (99%) rename packages/frontend/editor-ui/src/{ => features/ndv}/composables/useNodeSettingsParameters.ts (94%) rename packages/frontend/editor-ui/src/{utils/nodeSettingsUtils.test.ts => features/ndv/ndv.utils.test.ts} (99%) rename packages/frontend/editor-ui/src/{utils/nodeSettingsUtils.ts => features/ndv/ndv.utils.ts} (99%) diff --git a/packages/frontend/editor-ui/src/components/FocusPanel.vue b/packages/frontend/editor-ui/src/components/FocusPanel.vue index d8c665cc504..3e40920428f 100644 --- a/packages/frontend/editor-ui/src/components/FocusPanel.vue +++ b/packages/frontend/editor-ui/src/components/FocusPanel.vue @@ -17,10 +17,10 @@ import { getParameterTypeOption, isValidParameterOption, parseFromExpression, -} from '@/utils/nodeSettingsUtils'; +} from '@/features/ndv/ndv.utils'; import { isValueExpression } from '@/utils/nodeTypesUtils'; import { useNodeHelpers } from '@/composables/useNodeHelpers'; -import { useNodeSettingsParameters } from '@/composables/useNodeSettingsParameters'; +import { useNodeSettingsParameters } from '@/features/ndv/composables/useNodeSettingsParameters'; import { useResolvedExpression } from '@/composables/useResolvedExpression'; import { useDeviceSupport } from '@n8n/composables/useDeviceSupport'; import { diff --git a/packages/frontend/editor-ui/src/components/ParameterInput.vue b/packages/frontend/editor-ui/src/components/ParameterInput.vue index 58e26ef63f2..32dde624986 100644 --- a/packages/frontend/editor-ui/src/components/ParameterInput.vue +++ b/packages/frontend/editor-ui/src/components/ParameterInput.vue @@ -49,7 +49,7 @@ import { isValidParameterOption, parseFromExpression, shouldSkipParamValidation, -} from '@/utils/nodeSettingsUtils'; +} from '@/features/ndv/ndv.utils'; import { hasExpressionMapping, isValueExpression } from '@/utils/nodeTypesUtils'; import { @@ -68,7 +68,7 @@ import { useI18n } from '@n8n/i18n'; import { useNodeHelpers } from '@/composables/useNodeHelpers'; import { useTelemetry } from '@/composables/useTelemetry'; import { useWorkflowHelpers } from '@/composables/useWorkflowHelpers'; -import { useNodeSettingsParameters } from '@/composables/useNodeSettingsParameters'; +import { useNodeSettingsParameters } from '@/features/ndv/composables/useNodeSettingsParameters'; import { htmlEditorEventBus } from '@/event-bus'; import { useCredentialsStore } from '@/features/credentials/credentials.store'; import { useNDVStore } from '@/features/ndv/ndv.store'; diff --git a/packages/frontend/editor-ui/src/components/ParameterInputList.vue b/packages/frontend/editor-ui/src/components/ParameterInputList.vue index f707d8ffb13..19ec68c0877 100644 --- a/packages/frontend/editor-ui/src/components/ParameterInputList.vue +++ b/packages/frontend/editor-ui/src/components/ParameterInputList.vue @@ -23,7 +23,7 @@ import MultipleParameter from '@/components/MultipleParameter.vue'; import ParameterInputFull from '@/components/ParameterInputFull.vue'; import ResourceMapper from '@/components/ResourceMapper/ResourceMapper.vue'; import { useI18n } from '@n8n/i18n'; -import { useNodeSettingsParameters } from '@/composables/useNodeSettingsParameters'; +import { useNodeSettingsParameters } from '@/features/ndv/composables/useNodeSettingsParameters'; import { useWorkflowHelpers } from '@/composables/useWorkflowHelpers'; import { useMessage } from '@/composables/useMessage'; import { @@ -41,7 +41,7 @@ import { computedWithControl } from '@vueuse/core'; import get from 'lodash/get'; import { storeToRefs } from 'pinia'; import { useCalloutHelpers } from '@/composables/useCalloutHelpers'; -import { getParameterTypeOption } from '@/utils/nodeSettingsUtils'; +import { getParameterTypeOption } from '@/features/ndv/ndv.utils'; import { useWorkflowsStore } from '@/stores/workflows.store'; import type { IconName } from '@n8n/design-system/components/N8nIcon/icons'; diff --git a/packages/frontend/editor-ui/src/components/ParameterOptions.vue b/packages/frontend/editor-ui/src/components/ParameterOptions.vue index 354f97bd3d9..a222c03aec6 100644 --- a/packages/frontend/editor-ui/src/components/ParameterOptions.vue +++ b/packages/frontend/editor-ui/src/components/ParameterOptions.vue @@ -9,7 +9,7 @@ import { isValueExpression } from '@/utils/nodeTypesUtils'; import { computed } from 'vue'; import { useNDVStore } from '@/features/ndv/ndv.store'; import { AI_TRANSFORM_NODE_TYPE } from '@/constants'; -import { getParameterTypeOption } from '@/utils/nodeSettingsUtils'; +import { getParameterTypeOption } from '@/features/ndv/ndv.utils'; import { useIsInExperimentalNdv } from '@/features/workflows/canvas/experimental/composables/useIsInExperimentalNdv'; import { useExperimentalNdvStore } from '@/features/workflows/canvas/experimental/experimentalNdv.store'; diff --git a/packages/frontend/editor-ui/src/features/ndv/components/runData/RunData.vue b/packages/frontend/editor-ui/src/features/ndv/components/runData/RunData.vue index ec3185817c1..ba745d75220 100644 --- a/packages/frontend/editor-ui/src/features/ndv/components/runData/RunData.vue +++ b/packages/frontend/editor-ui/src/features/ndv/components/runData/RunData.vue @@ -1,7 +1,7 @@