From 5dda3b2142b752722efb6ef4691ca74b618ae33d Mon Sep 17 00:00:00 2001 From: Bernhard Wittmann Date: Fri, 24 Apr 2026 17:39:44 +0200 Subject: [PATCH] fix(GitHub Node): Return pagination token as string in resource locators (#29099) Co-authored-by: RomanDavydchuk --- packages/nodes-base/nodes/Github/SearchFunctions.ts | 11 +++++++---- .../nodes/Github/__tests__/SearchFunctions.test.ts | 8 ++++---- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/packages/nodes-base/nodes/Github/SearchFunctions.ts b/packages/nodes-base/nodes/Github/SearchFunctions.ts index be85c2fb73e..c8dfb261462 100644 --- a/packages/nodes-base/nodes/Github/SearchFunctions.ts +++ b/packages/nodes-base/nodes/Github/SearchFunctions.ts @@ -61,7 +61,8 @@ export async function getUsers( url: item.html_url, })); - const nextPaginationToken = page * per_page < responseData.total_count ? page + 1 : undefined; + const nextPaginationToken = + page * per_page < responseData.total_count ? String(page + 1) : undefined; return { results, paginationToken: nextPaginationToken }; } @@ -97,7 +98,8 @@ export async function getRepositories( url: item.html_url, })); - const nextPaginationToken = page * per_page < responseData.total_count ? page + 1 : undefined; + const nextPaginationToken = + page * per_page < responseData.total_count ? String(page + 1) : undefined; return { results, paginationToken: nextPaginationToken }; } @@ -126,7 +128,8 @@ export async function getWorkflows( value: workflow.id, })); - const nextPaginationToken = page * per_page < responseData.total_count ? page + 1 : undefined; + const nextPaginationToken = + page * per_page < responseData.total_count ? String(page + 1) : undefined; return { results, paginationToken: nextPaginationToken }; } @@ -177,6 +180,6 @@ export async function getRefs( ); return { results: filteredRefs }; } - const nextPaginationToken = responseData.length === per_page ? page + 1 : undefined; + const nextPaginationToken = responseData.length === per_page ? String(page + 1) : undefined; return { results: refs, paginationToken: nextPaginationToken }; } diff --git a/packages/nodes-base/nodes/Github/__tests__/SearchFunctions.test.ts b/packages/nodes-base/nodes/Github/__tests__/SearchFunctions.test.ts index 9e218f84455..a50f88660c2 100644 --- a/packages/nodes-base/nodes/Github/__tests__/SearchFunctions.test.ts +++ b/packages/nodes-base/nodes/Github/__tests__/SearchFunctions.test.ts @@ -73,7 +73,7 @@ describe('Search Functions', () => { { name: 'test-user-1', value: 'test-user-1', url: 'https://github.com/test-user-1' }, { name: 'test-user-2', value: 'test-user-2', url: 'https://github.com/test-user-2' }, ], - paginationToken: 2, + paginationToken: '2', }); }); @@ -303,7 +303,7 @@ describe('Search Functions', () => { { name: 'workflow-1', value: '1' }, { name: 'workflow-2', value: '2' }, ], - paginationToken: 2, + paginationToken: '2', }); }); @@ -333,7 +333,7 @@ describe('Search Functions', () => { { name: 'workflow-3', value: '3' }, { name: 'workflow-4', value: '4' }, ], - paginationToken: 2, + paginationToken: '2', }); expect(mockLoadOptionsFunctions.helpers.requestWithAuthentication).toHaveBeenCalledWith( @@ -492,7 +492,7 @@ describe('Search Functions', () => { const result = await getRefs.call(mockLoadOptionsFunctions); - expect(result.paginationToken).toBe(2); + expect(result.paginationToken).toBe('2'); expect(result.results.length).toBe(100); }); });