Ben SchumacherandClaude Sonnet 4.6 93ab9a4ccc [MM-68351] Fix nil pointer panic in mmctl websocket command on connection failure (#36138) ...

* fix(mmctl): prevent nil pointer panic in websocket command on connection failure

When the WebSocket connection fails immediately, Listen() closes EventChannel
via defer. Reading from a closed channel with a plain receive returns nil,
causing a panic in ToJSON(). Switch to range so the loop exits cleanly,
add a nil guard, and surface ListenError to the caller.

Fixes MM-68351

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(mmctl): add unit tests for websocket nil event and ListenError handling

Extracts the event-processing loop into processWebSocketEvents to enable
unit testing, and adds tests covering the nil-event skip and error surfacing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(mmctl): add happy-path subtest for processWebSocketEvents

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-04-23 15:32:34 +02:00

..

mattermost

ci: enable fullyparallel mode for server tests (#35816)

2026-04-08 20:48:36 -04:00

mmctl

[MM-68351] Fix nil pointer panic in mmctl websocket command on connection failure (#36138)

2026-04-23 15:32:34 +02:00