mirror of
https://github.com/mattermost/mattermost.git
synced 2026-08-28 18:19:38 +08:00
Ben Schumacher
a3e171f730
* Migrate property field reads to request context Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Preserve nil property service request context behavior Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Use explicit session attributes system context Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Use non-nil property contexts for internal calls Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Thread request context through content flagging lookups Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Update content flagging helper tests for request context Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Thread request context through content flagging values Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> * Fix build: remove unused context imports left after request.CTX migration Migrating PropertyFieldStore to request.CTX removed the last context.Context usage from the store.go interface, leaving an unused "context" import in store.go and in the generated retrylayer/timerlayer files (regenerated via `make store-layers`, with layer_generators now stripping the context import when it's unused). Also drop the same now-unused import in localcachelayer/main_test.go. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Remove context import directly from store layer templates Store no longer has any context.Context methods after the request.CTX migration, so drop the hardcoded "context" import from the retry/timer layer templates instead of stripping it at generation time. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Remove deprecated store.WithMaster/sqlstore.WithMaster helpers request.CTX is now used everywhere, so the deprecated context.Context-based WithMaster helpers and their wrapper in sqlstore have no remaining callers; inline the logic into RequestContextWithMaster instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix TestDoSetupSessionAttributesProperties nil-context panic Two subtests still constructed the pre-seed field state via UpdatePropertyFields(nil, ...), which was the old system-caller sentinel. isSystemCaller now requires an explicit SystemCallerContext marker, so a bare nil rctx falls through into validateUpdate and panics in RequestContextWithMaster. Use SystemCallerContext(th.Context) like the rest of the suite already does. * ci trigger * ci trigger --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>