mirror of
https://github.com/mattermost/mattermost.git
synced 2026-08-29 02:28:16 +08:00
Alejandro García Montoro
87c84ef177
* Remove ElasticsearchSettings.BulkIndexingTimeWindowSeconds Marked to remove in v8.0; drop the now-unneeded nil-check workaround in the test-connection handler along with the field itself. * Remove ClusterSettings.EnableExperimentalGossipEncryption Marked to remove in v8.0; EnableGossipEncryption is the replacement and no longer needs the fallback-from-deprecated-field logic. * Remove ExperimentalSettings.ClientSideCertEnable Always false since certificate-based authentication was removed (#33751); the server has failed to start if it were ever enabled. * Remove TeamSettings.ExperimentalViewArchivedChannels Always true since hiding archived channels was removed (#32162); the validation already rejected any attempt to disable it. * Remove CloudSettings.CWSMock Never read anywhere. * Remove PluginSettings.ChimeraOAuthProxyURL Unused since v8.0. * Remove DataRetentionSettings.EnableBoardsDeletion Deprecated in #24231. * Remove DataRetentionSettings.BoardsRetentionDays Deprecated in #24231. * Remove SqlSettings.AtRestEncryptKey Generated, length-validated, and sanitized, but never actually used to encrypt or decrypt anything. * Remove NativeAppSettings.EnableIntuneMAM Never read anywhere; fully superseded by IntuneSettings.Enable, which is what the server and the System Console actually use. * Remove GuestAccountsSettings.AllowEmailAccounts Only ever written by tests; no production code reads it. * Add test for unknown config keys on load and save There was no test encoding the assumption behind removing dead config fields safely: that a stale/unrecognized key left over in config.json from a past release is silently ignored on load, and gets dropped from the file the next time it's saved. Add TestFileStoreUnknownConfigKeys with both cases, using the ElasticsearchSettings.BulkIndexingTimeWindowSeconds field just removed as one of the injected unknown keys. This exercises upgrades with major version changes that remove fields from the configuration. * Make linter happy --------- Co-authored-by: Mattermost Build <build@mattermost.com>