opensource/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-09-24 16:05:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Changed require.Nil to require.NoError when error type is used (#16900)

Browse Source
This commit is contained in:
Jesús Espino
2021-02-10 09:30:36 +01:00
committed by GitHub
parent 7dd4d4859b
commit 5f043b0a08
12 changed files with 116 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/httpservice/client_test.go
+5 -5
View File
@@ -105,11 +105,11 @@ func TestHTTPClientWithProxy(t *testing.T) {
c.Transport.(*MattermostTransport).Transport.(*http.Transport).Proxy = http.ProxyURL(purl)
resp, err := c.Get("http://acme.com")
require.Nil(t, err)
require.NoError(t, err)
defer resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
require.Nil(t, err)
require.NoError(t, err)
require.Equal(t, "proxy", string(body))
}
@@ -150,10 +150,10 @@ func TestDialContextFilter(t *testing.T) {
_, err := filter(context.Background(), "", tc.Addr)
if tc.IsValid {
require.Nil(t, err)
require.NoError(t, err)
require.True(t, didDial)
} else {
require.NotNil(t, err)
require.Error(t, err)
require.Equal(t, err, AddressForbidden)
require.False(t, didDial)
}
@@ -172,7 +172,7 @@ func TestUserAgentIsSet(t *testing.T) {
client := NewHTTPClient(NewTransport(true, nil, nil))
req, err := http.NewRequest("GET", ts.URL, nil)
require.Nil(t, err, "NewRequest failed", err)
require.NoError(t, err, "NewRequest failed", err)
client.Do(req)
}