mirror of
https://github.com/mattermost/mattermost.git
synced 2026-09-01 15:00:08 +08:00
Address PR feedback: remove unnecessary SAML color removal test case
Per reviewer feedback, drop the GenerateClientConfig test case that asserted the removed SAML login button color props are absent. There is no value in perpetually testing that a deleted feature stays deleted.
This commit is contained in:
@@ -849,26 +849,6 @@ func TestGetClientConfig(t *testing.T) {
|
||||
},
|
||||
nil,
|
||||
},
|
||||
{
|
||||
"SAML login button text exposed with license, button colors removed",
|
||||
&model.Config{
|
||||
SamlSettings: model.SamlSettings{
|
||||
Enable: new(true),
|
||||
LoginButtonText: new("With SAML"),
|
||||
},
|
||||
},
|
||||
"",
|
||||
&model.License{
|
||||
Features: &model.Features{
|
||||
SAML: new(true),
|
||||
},
|
||||
},
|
||||
map[string]string{
|
||||
"EnableSaml": "true",
|
||||
"SamlLoginButtonText": "With SAML",
|
||||
},
|
||||
[]string{"SamlLoginButtonColor", "SamlLoginButtonBorderColor", "SamlLoginButtonTextColor"},
|
||||
},
|
||||
}
|
||||
|
||||
for _, testCase := range testCases {
|
||||
|
||||
Reference in New Issue
Block a user