From 25121055f41959629fa80c6677c18a786d2eff5b Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Wed, 10 Dec 2025 16:49:33 +0700 Subject: [PATCH 1/5] remove unused cli option --- src/main/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/index.ts b/src/main/index.ts index 45137e81..5f0f42b6 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -233,7 +233,7 @@ function parseCliArgs(rawArgv = process.argv) { const argsWithoutAppName = rawArgv.length > ignoreFirstArgs ? rawArgv.slice(ignoreFirstArgs) : []; return yargsParser(argsWithoutAppName, { - boolean: ['allow-multiple-instances', 'disable-networking'], + boolean: ['disable-networking'], string: ['settings-json', 'config-dir', 'lossy-mode'], }); } From 25121069f9e0c972ee7006f979142123244d26c5 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Wed, 10 Dec 2025 16:51:49 +0700 Subject: [PATCH 2/5] improve todo --- src/main/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/index.ts b/src/main/index.ts index 5f0f42b6..1a0877e0 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -251,7 +251,7 @@ if (argv['localesPath'] != null) i18nCommon.setCustomLocalesPath(argv['localesPa function safeRequestSingleInstanceLock(additionalData: Record) { - if (process.mas) return true; // todo remove when fixed https://github.com/electron/electron/issues/35540 + if (process.mas) return true; // todo remove when dropping support for MacOS 13 https://github.com/electron/electron/issues/35540#issuecomment-2173130321 // using additionalData because the built in "argv" passing is a bit broken: // https://github.com/electron/electron/issues/20322 From 2512108210aa3ac04bee2534cdd0de3d9bf3eb05 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Wed, 10 Dec 2025 16:52:22 +0700 Subject: [PATCH 3/5] don't open file when clicking on X in batch list --- src/renderer/src/components/BatchFile.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/components/BatchFile.tsx b/src/renderer/src/components/BatchFile.tsx index c03f9c4f..d5fac44f 100644 --- a/src/renderer/src/components/BatchFile.tsx +++ b/src/renderer/src/components/BatchFile.tsx @@ -59,6 +59,12 @@ function BatchFile({ path, index, isOpen, isSelected, name, onSelect, onDelete, e.currentTarget.blur(); }, [onSelect, path]); + const handleDeleteClick = useCallback>((e) => { + e.stopPropagation(); + onDelete?.(path); + e.currentTarget.blur(); + }, [onDelete, path]); + return (
{name}
- {onDelete && onDelete(path)} />} + {onDelete && }
); } From 2512150c897b8aad23ce343b448c9b560d418ce0 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Mon, 15 Dec 2025 17:24:15 +0700 Subject: [PATCH 4/5] remove flatpak again #2393 https://github.com/flathub/no.mifi.losslesscut/issues/84#issuecomment-3654854957 --- .github/workflows/build.yml | 8 -------- package.json | 20 -------------------- 2 files changed, 28 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b58b9eb1..e624ce0a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -70,13 +70,6 @@ jobs: uses: samuelmeuli/action-snapcraft@v2 if: startsWith(matrix.os, 'ubuntu') - - name: (Linux) Setup flatpak - if: startsWith(matrix.os, 'ubuntu') - run: | - sudo apt-get update - sudo apt-get install -y flatpak flatpak-builder - flatpak --user remote-add --if-not-exists flathub https://dl.flathub.org/repo/flathub.flatpakrepo - - name: Save provisioning profile if: startsWith(matrix.os, 'macos') env: @@ -176,6 +169,5 @@ jobs: dist/LosslessCut-linux-arm64.tar.bz2 dist/LosslessCut-linux-armv7l.tar.bz2 dist/LosslessCut-linux-x64.tar.bz2 - dist/LosslessCut-linux-x86_64.flatpak screenshot.jpeg diff --git a/package.json b/package.json index b4213796..24e34443 100644 --- a/package.json +++ b/package.json @@ -452,10 +452,6 @@ "arch": "x64", "target": "snap" }, - { - "arch": "x64", - "target": "flatpak" - }, { "arch": "arm64", "target": "tar.bz2" @@ -471,22 +467,6 @@ "default", "removable-media" ] - }, - "flatpak": { - "runtime": "org.freedesktop.Platform", - "runtimeVersion": "23.08", - "sdk": "org.freedesktop.Sdk", - "base": "org.electronjs.Electron2.BaseApp", - "baseVersion": "23.08", - "finishArgs": [ - "--share=network", - "--socket=x11", - "--socket=wayland", - "--device=dri", - "--socket=pulseaudio", - "--filesystem=home", - "--talk-name=org.freedesktop.Notifications" - ] } }, "packageManager": "yarn@4.11.0" From 251215e5a991a54cdb1675b3fd389670031a335b Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Mon, 15 Dec 2025 17:24:49 +0700 Subject: [PATCH 5/5] add theo videos --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 54a91aa2..2ad4733a 100644 --- a/README.md +++ b/README.md @@ -161,6 +161,7 @@ LosslessCut uses the Chromium browser's HTML5 video player, and not all formats/ - Hacker News [2024](https://news.ycombinator.com/item?id=40829494) [2022](https://news.ycombinator.com/item?id=33969490) [2020-10](https://news.ycombinator.com/item?id=24883030) [2020-01](https://news.ycombinator.com/item?id=22026412) [2016](https://news.ycombinator.com/item?id=12885585) - [Wikipedia](https://en.m.wikipedia.org/wiki/LosslessCut) - Your link here? +- theo (YouTube) [1](https://youtu.be/FI5ba4RRE8U?t=246) [2](https://youtu.be/uaCypXEJjes?t=381) Star History Chart