mirror of
https://github.com/Kilo-Org/kilocode.git
synced 2026-08-28 19:11:03 +08:00
Marius
732cc14012
* fix(agent-manager): resolve macOS shell PATH for GUI-launched VS Code * fix: address PR review — concurrent callers, fallback detection, multiline parsing - Use shared promise so concurrent ENOENT callers wait on one resolution instead of rejecting prematurely - Compare resolved PATH against original before marking fix as succeeded, so fallback-to-process.env doesn't permanently block retries - Parse env output with proper KEY= regex to handle multiline values (BASH_FUNC_*, certs) without corrupting other entries
77 lines
2.6 KiB
TypeScript
77 lines
2.6 KiB
TypeScript
import { afterEach, describe, expect, it } from "bun:test"
|
|
import { getShellEnvironment, execWithShellEnv, clearShellEnvCache } from "../../src/agent-manager/shell-env"
|
|
|
|
afterEach(() => {
|
|
clearShellEnvCache()
|
|
})
|
|
|
|
describe("getShellEnvironment", () => {
|
|
it("returns an object with PATH", async () => {
|
|
const env = await getShellEnvironment()
|
|
expect(env).toBeDefined()
|
|
expect(typeof env.PATH).toBe("string")
|
|
expect(env.PATH!.length).toBeGreaterThan(0)
|
|
})
|
|
|
|
it("returns HOME", async () => {
|
|
const env = await getShellEnvironment()
|
|
expect(typeof env.HOME).toBe("string")
|
|
})
|
|
|
|
it("caches results across calls", async () => {
|
|
const first = await getShellEnvironment()
|
|
const second = await getShellEnvironment()
|
|
expect(first.PATH).toBe(second.PATH)
|
|
})
|
|
|
|
it("returns a copy (mutations don't corrupt cache)", async () => {
|
|
const first = await getShellEnvironment()
|
|
first.PATH = "/mutated"
|
|
const second = await getShellEnvironment()
|
|
expect(second.PATH).not.toBe("/mutated")
|
|
})
|
|
|
|
it("handles multiline env values without corrupting PATH", async () => {
|
|
// PATH should never contain newlines — verify it parses correctly
|
|
// even if other env vars have multiline values (e.g. BASH_FUNC_*)
|
|
const env = await getShellEnvironment()
|
|
expect(env.PATH).toBeDefined()
|
|
expect(env.PATH).not.toContain("\n")
|
|
})
|
|
})
|
|
|
|
describe("execWithShellEnv", () => {
|
|
it("executes a simple command", async () => {
|
|
const { stdout } = await execWithShellEnv("echo", ["hello"])
|
|
expect(stdout.trim()).toBe("hello")
|
|
})
|
|
|
|
it("passes cwd option through", async () => {
|
|
const { stdout } = await execWithShellEnv("pwd", [], { cwd: "/tmp" })
|
|
// /tmp may resolve to /private/tmp on macOS
|
|
expect(stdout.trim()).toMatch(/\/tmp$/)
|
|
})
|
|
|
|
it("throws on non-ENOENT errors", async () => {
|
|
await expect(execWithShellEnv("ls", ["--nonexistent-flag-that-fails"])).rejects.toThrow()
|
|
})
|
|
|
|
it("concurrent calls don't reject prematurely", async () => {
|
|
// Both calls should succeed — neither should throw due to a race
|
|
const [a, b] = await Promise.all([execWithShellEnv("echo", ["first"]), execWithShellEnv("echo", ["second"])])
|
|
expect(a.stdout.trim()).toBe("first")
|
|
expect(b.stdout.trim()).toBe("second")
|
|
})
|
|
})
|
|
|
|
describe("clearShellEnvCache", () => {
|
|
it("forces fresh resolution on next call", async () => {
|
|
const first = await getShellEnvironment()
|
|
clearShellEnvCache()
|
|
const second = await getShellEnvironment()
|
|
// Both should succeed and contain PATH
|
|
expect(first.PATH).toBeDefined()
|
|
expect(second.PATH).toBeDefined()
|
|
})
|
|
})
|