mirror of
https://github.com/Kilo-Org/kilocode.git
synced 2026-08-30 17:14:40 +08:00
a1ad65e522
* fix(cli): stabilize Windows CI tests and rebalance slow shards Three Windows-only instabilities in the CLI unit suite: 1. httpapi-instance-route-auth.test.ts failed with an uncaught "Invalid handle" error. The test's ConfigProvider.layer( fromUnknown(...)) replaced the ambient config provider, blinding KILO_EXPERIMENTAL_DISABLE_FILEWATCHER=true that CI/preload sets. With the flag hidden, the @parcel/watcher Windows backend subscribed on the temp repo's .git; the tmpdir fixture then deleted that directory while the never-disposed per-test runtime still held the subscription, and CreateFileW failed with the hardcoded "Invalid handle" (napi rejection with no JS stack). Add the disable-filewatcher flag to every test config map that boots instances via the HttpApi app (instance-route-auth, cors, ui, exercise backend, kilo-edit, memory). 2. config-overlay.test.ts intermittently returned HTTP 500 on Windows. Filesystem.write's atomic temp-file+rename had no retry for Windows transient locked-file errors (EPERM/EACCES/EBUSY) from Defender/indexer and the detached background plugin install racing the rename in the same tmpdir. Mirror the proven cleanup.ts locked-error retry pattern with a short backoff, Windows-only. 3. Windows shards were badly imbalanced: the sharder weighted files by byte size, which concentrated every slow spawn/FS/lock-heavy file (snapshot, prompt, provider, run-process, instance-bootstrap, httpapi-session) into one shard (~612s vs ~356s siblings), and the resulting contention forced whole-file retries that doubled cost. Add TestShard.timedWeight and a committed test-timings.json seeded from CI junit data so shards balance by measured runtime (spread collapses from ~200s to ~18s) and contention-prone files spread across shards. Platforms without manifest entries fall back to size weighting. * fix(cli): skip stale manifest entries in timed shard weighting Bun.file().size returns 0 (never throws) for missing paths, so the try/catch in timedWeight was dead code and stale/renamed manifest entries added their time to the scale numerator with zero size, inflating the size-to-time ratio that estimates unknown files. Skip entries with a non-positive on-disk size instead of catching a throw that never happens. * revert(cli): drop hardcoded test-timings manifest The committed test-timings.json (482 entries) was a maintenance burden: it goes stale as tests are added/renamed and no size-based heuristic can replace it (slow subprocess outliers like run-process.test.ts are 7kb but 112s, 10x the runtime-per-byte of other files). Revert the timing-weighted sharding to the prior size-based LPT. The Windows reliability fixes (ConfigProvider filewatcher flag + Filesystem.write locked-file retry) remain and are what eliminate the failures and the ~360s of retry overhead that dominated the 12m50s shard. A maintainable runtime-based rebalance (self-updating CI cache fed from the junit artifacts CI already uploads) is a separate follow-up.
87 lines
3.4 KiB
TypeScript
87 lines
3.4 KiB
TypeScript
import { afterEach, describe, expect, test } from "bun:test"
|
|
import { ConfigProvider, Layer } from "effect"
|
|
import { HttpRouter } from "effect/unstable/http"
|
|
import { EventPaths } from "../../src/server/routes/instance/httpapi/groups/event"
|
|
import { PtyPaths } from "../../src/server/routes/instance/httpapi/groups/pty"
|
|
import { HttpApiApp } from "../../src/server/routes/instance/httpapi/server"
|
|
import { ServerAuth } from "../../src/server/auth"
|
|
import { PtyID } from "@opencode-ai/core/pty/schema"
|
|
import { resetDatabase } from "../fixture/db"
|
|
import { disposeAllInstances, tmpdir } from "../fixture/fixture"
|
|
|
|
function app(input: { password?: string; username?: string }) {
|
|
const handler = HttpRouter.toWebHandler(
|
|
HttpApiApp.routes.pipe(
|
|
Layer.provide(
|
|
ConfigProvider.layer(
|
|
// kilocode_change start - keep the filewatcher-disable flag visible so the
|
|
// @parcel/watcher Windows backend does not subscribe on temp dirs that
|
|
// the tmpdir fixture deletes mid-test (throws "Invalid handle").
|
|
ConfigProvider.fromUnknown({
|
|
KILO_SERVER_PASSWORD: input.password,
|
|
KILO_SERVER_USERNAME: input.username,
|
|
KILO_EXPERIMENTAL_DISABLE_FILEWATCHER: process.env.KILO_EXPERIMENTAL_DISABLE_FILEWATCHER ?? "true",
|
|
}),
|
|
// kilocode_change end
|
|
),
|
|
),
|
|
),
|
|
{ disableLogger: true },
|
|
).handler
|
|
|
|
return {
|
|
fetch: (request: Request) => handler(request, HttpApiApp.context),
|
|
request(input: string | URL | Request, init?: RequestInit) {
|
|
return this.fetch(input instanceof Request ? input : new Request(new URL(input, "http://localhost"), init))
|
|
},
|
|
}
|
|
}
|
|
|
|
function basic(username: string, password: string) {
|
|
return ServerAuth.header({ username, password }) ?? ""
|
|
}
|
|
|
|
async function cancelBody(response: Response) {
|
|
await response.body?.cancel().catch(() => {})
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await disposeAllInstances()
|
|
await resetDatabase()
|
|
})
|
|
|
|
describe("HttpApi instance route authorization", () => {
|
|
test("requires configured auth before opening the instance event stream", async () => {
|
|
await using tmp = await tmpdir({ git: true, config: { formatter: false, lsp: false } })
|
|
const server = app({ password: "secret" })
|
|
const headers = { "x-kilo-directory": tmp.path }
|
|
|
|
const missing = await server.request(EventPaths.event, { headers })
|
|
await cancelBody(missing)
|
|
expect(missing.status).toBe(401)
|
|
|
|
const authed = await server.request(EventPaths.event, {
|
|
headers: { ...headers, authorization: basic("kilo", "secret") }, // kilocode_change - Kilo username default
|
|
})
|
|
await cancelBody(authed)
|
|
expect(authed.status).toBe(200)
|
|
})
|
|
|
|
test("requires configured auth before resolving the PTY websocket route", async () => {
|
|
await using tmp = await tmpdir({ git: true, config: { formatter: false, lsp: false } })
|
|
const server = app({ password: "secret" })
|
|
const route = PtyPaths.connect.replace(":ptyID", PtyID.ascending())
|
|
const headers = { "x-kilo-directory": tmp.path }
|
|
|
|
const missing = await server.request(route, { headers })
|
|
await cancelBody(missing)
|
|
expect(missing.status).toBe(401)
|
|
|
|
const authed = await server.request(route, {
|
|
headers: { ...headers, authorization: basic("kilo", "secret") }, // kilocode_change - Kilo username default
|
|
})
|
|
await cancelBody(authed)
|
|
expect(authed.status).toBe(404)
|
|
})
|
|
})
|