From f4610dc99bf0ff66cefd10f4b5f4f1dce115d011 Mon Sep 17 00:00:00 2001 From: Mark IJbema Date: Wed, 25 Feb 2026 09:04:57 +0100 Subject: [PATCH] docs(vscode): remove file-permission-dialogs.md (considered done) --- .../file-permission-dialogs.md | 24 ------------------- .../kilo-vscode/docs/implementation-status.md | 5 ++-- .../docs/opencode-migration-plan.md | 1 - 3 files changed, 2 insertions(+), 28 deletions(-) delete mode 100644 packages/kilo-vscode/docs/chat-ui-features/file-permission-dialogs.md diff --git a/packages/kilo-vscode/docs/chat-ui-features/file-permission-dialogs.md b/packages/kilo-vscode/docs/chat-ui-features/file-permission-dialogs.md deleted file mode 100644 index ec4680fed8c..00000000000 --- a/packages/kilo-vscode/docs/chat-ui-features/file-permission-dialogs.md +++ /dev/null @@ -1,24 +0,0 @@ -# File Permission Dialogs - -**Priority:** P1 -**Status:** 🔨 Partial - -## What Exists - -- Single permission requests render inline above prompt input with Deny / Allow Always / Allow Once buttons -- Tool-level inline permissions appear inside tool cards in `message-part.tsx` -- Permission queue (`permission-queue.ts`) handles upsert/remove, processes one at a time - -## Remaining Work - -- Batch file read approval (approve multiple pending file reads at once) -- Per-file granularity in batch approvals -- Render permissions inline in the prompt dock area instead of the current modal `Dialog` wrapper — match the pattern used by the desktop app (`packages/app/`) where permissions replace the text input while pending - -## TODO: Inline Permission Rendering - -Both the desktop app and the old extension render permission prompts inline in the prompt area. The current rebuild uses a modal `Dialog` wrapper. Change to: - -- Render `BasicTool` + `permission-prompt` block in the prompt dock area, conditionally replacing the input when `permissions().length > 0` -- Remove the `Dialog` / `useDialog()` wrapper -- This naturally blocks user input while permissions are pending, matching the app's `blocked()` memo pattern diff --git a/packages/kilo-vscode/docs/implementation-status.md b/packages/kilo-vscode/docs/implementation-status.md index 51249cc30d9..79386130e7c 100644 --- a/packages/kilo-vscode/docs/implementation-status.md +++ b/packages/kilo-vscode/docs/implementation-status.md @@ -18,7 +18,6 @@ Fully implemented features have been removed from the plans (docs deleted). This | `browser-session-controls.md` | Partially implemented | In-chat browser controls, action replay, screenshot viewing | | `checkpoint-task-management.md` | Not implemented | Checkpoint restore, navigation, "See New Changes" diff buttons | | `connection-state-ui.md` | Partially implemented | Loading spinner overlay, error panel with retry, reconnecting indicator | -| `file-permission-dialogs.md` | Partially implemented | Batch approval, per-file granularity, inline rendering instead of modal | | `follow-up-questions.md` | Not implemented | Suggestion chips, click-to-submit, auto-approval countdown | | `mermaid-diagram-features.md` | Not implemented | Mermaid rendering, "Fix with AI", copy, open-as-PNG | | `message-editing-management.md` | Not implemented | Inline editing, deletion, timestamps, up-arrow redo | @@ -71,7 +70,7 @@ Fully implemented features have been removed from the plans (docs deleted). This | Category | Partially | Not | | ----------------------- | --------- | ------ | -| Chat UI Features (8) | 4 | 4 | +| Chat UI Features (7) | 3 | 4 | | Non-Agent Features (23) | 10 | 13 | | Infrastructure (4) | 2 | 2 | -| **Total (35)** | **16** | **19** | +| **Total (34)** | **15** | **19** | diff --git a/packages/kilo-vscode/docs/opencode-migration-plan.md b/packages/kilo-vscode/docs/opencode-migration-plan.md index fa746c8c7e8..46063d63f22 100644 --- a/packages/kilo-vscode/docs/opencode-migration-plan.md +++ b/packages/kilo-vscode/docs/opencode-migration-plan.md @@ -15,7 +15,6 @@ This document tracks remaining work needed for feature parity with the old exten | [Browser Session Controls](chat-ui-features/browser-session-controls.md) | 🔨 Partial | In-chat browser controls, action replay, screenshot viewing | CLI-side (if browser tool exists) + webview | P3 | | [Checkpoint & Task Management](chat-ui-features/checkpoint-task-management.md) | ❌ Not started | Checkpoint restore, navigation, "See New Changes" diff buttons | CLI session undo/redo/fork + extension git integration | P1 | | [Connection State UI](chat-ui-features/connection-state-ui.md) | 🔨 Partial | Loading spinner overlay, error panel with retry, reconnecting indicator | Webview-only (consumes connection state) | P0 | -| [File Permission Dialogs](chat-ui-features/file-permission-dialogs.md) | 🔨 Partial | Batch file read approval, per-file granularity, inline rendering instead of modal | CLI permission model; webview UI | P1 | | [Follow-Up Questions](chat-ui-features/follow-up-questions.md) | ❌ Not started | Suggested reply chips, click-to-submit, auto-approval countdown, mode indicators | Likely extension-side generation | P2 | | [Mermaid Diagram Features](chat-ui-features/mermaid-diagram-features.md) | ❌ Not started | Mermaid rendering, "Fix with AI" button, copy, open-as-PNG | Webview-only (rendering); CLI for "Fix with AI" | P2 | | [Message Editing & Management](chat-ui-features/message-editing-management.md) | ❌ Not started | Inline editing, deletion, timestamp display, redo-previous-message (up-arrow) | CLI session fork/undo for edit semantics | P1 |