From bf2ddafc331feb29f8d53c687fb134c7f7597567 Mon Sep 17 00:00:00 2001 From: marius-kilocode Date: Wed, 5 Aug 2026 11:05:39 +0200 Subject: [PATCH] refactor(vscode): remove unused Agent Manager refresh --- .../src/agent-manager/AgentManagerProvider.ts | 2 +- .../kilo-vscode/src/agent-manager/GitStatsPoller.ts | 8 +------- .../src/agent-manager/orchestration-bridge.ts | 2 +- .../unit/agent-manager-orchestration-bridge.test.ts | 11 +++++------ 4 files changed, 8 insertions(+), 15 deletions(-) diff --git a/packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts b/packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts index 069783c53fc..a8207ee5f35 100644 --- a/packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts +++ b/packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts @@ -240,7 +240,7 @@ export class AgentManagerProvider implements Disposable { await this.stateReady return this.state }, - stats: (refresh) => this.statsPoller.snapshot(refresh), + stats: () => this.statsPoller.snapshot(), prs: () => this.prBridge.snapshot(), push: () => this.pushState(), managed: (id) => this.panelSessions.has(id) || !!this.state?.getSession(id), diff --git a/packages/kilo-vscode/src/agent-manager/GitStatsPoller.ts b/packages/kilo-vscode/src/agent-manager/GitStatsPoller.ts index 9b5fd45ef5a..add3f852c30 100644 --- a/packages/kilo-vscode/src/agent-manager/GitStatsPoller.ts +++ b/packages/kilo-vscode/src/agent-manager/GitStatsPoller.ts @@ -131,13 +131,7 @@ export class GitStatsPoller { this.lastStats = {} } - async snapshot(refresh = false): Promise<{ worktrees: WorktreeStats[]; local?: LocalStats }> { - if (refresh && !this.busy) { - this.busy = true - await Promise.all([this.fetchWorktreeStats(true), this.fetchLocalStats()]).finally(() => { - this.busy = false - }) - } + async snapshot(): Promise<{ worktrees: WorktreeStats[]; local?: LocalStats }> { return { worktrees: Object.values(this.lastStats), ...(this.lastLocalStats ? { local: this.lastLocalStats } : {}), diff --git a/packages/kilo-vscode/src/agent-manager/orchestration-bridge.ts b/packages/kilo-vscode/src/agent-manager/orchestration-bridge.ts index 0ad1e60b014..e36948c449a 100644 --- a/packages/kilo-vscode/src/agent-manager/orchestration-bridge.ts +++ b/packages/kilo-vscode/src/agent-manager/orchestration-bridge.ts @@ -44,7 +44,7 @@ interface Options { root(): string | undefined ready(): Promise state(): WorktreeStateManager | undefined - stats(refresh?: boolean): Promise<{ worktrees: WorktreeStats[]; local?: LocalStats }> + stats(): Promise<{ worktrees: WorktreeStats[]; local?: LocalStats }> prs(): Map push(): void managed(sessionID: string): boolean diff --git a/packages/kilo-vscode/tests/unit/agent-manager-orchestration-bridge.test.ts b/packages/kilo-vscode/tests/unit/agent-manager-orchestration-bridge.test.ts index 2b8b4203a0d..dded9b2ed5d 100644 --- a/packages/kilo-vscode/tests/unit/agent-manager-orchestration-bridge.test.ts +++ b/packages/kilo-vscode/tests/unit/agent-manager-orchestration-bridge.test.ts @@ -37,7 +37,7 @@ describe("AgentManagerOrchestrationBridge", () => { const replies: unknown[] = [] const rejections: unknown[] = [] const lists = new Map() - const statsCalls: Array = [] + const statsCalls: number[] = [] const handlers: { event?: (event: SSEPayload, directory?: string) => void state?: (state: "connecting" | "connected" | "disconnected" | "error") => void @@ -103,9 +103,8 @@ describe("AgentManagerOrchestrationBridge", () => { root: () => root, ready: async () => state, state: () => state, - stats: async (refresh) => { - statsCalls.push(refresh) - if (refresh) return new Promise(() => undefined) + stats: async () => { + statsCalls.push(1) return { worktrees: [] } }, prs: () => new Map(), @@ -258,7 +257,7 @@ describe("AgentManagerOrchestrationBridge", () => { test.bridge.dispose() }) - it("returns an overview without waiting for a forced git refresh", async () => { + it("returns an overview with cached git stats", async () => { const test = harness() test.request({ id: "amr_overview", @@ -267,7 +266,7 @@ describe("AgentManagerOrchestrationBridge", () => { }) await waitFor(() => test.replies.length === 1) - expect(test.statsCalls).toEqual([undefined]) + expect(test.statsCalls).toEqual([1]) expect(test.replies[0]).toEqual({ requestID: "amr_overview", directory: root,