From 2d7b71f118f303018bd43e540a69b21da059fc5b Mon Sep 17 00:00:00 2001
From: cmanu <cmanughian@anaconda.com>
Date: Fri, 31 Jul 2026 07:32:39 -0700
Subject: [PATCH] fix(charts): bot suggestion applied for cleanup

---
 packages/kilo-ui/src/components/chart.tsx | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/packages/kilo-ui/src/components/chart.tsx b/packages/kilo-ui/src/components/chart.tsx
index 2e299fbaf0e..40979900861 100644
--- a/packages/kilo-ui/src/components/chart.tsx
+++ b/packages/kilo-ui/src/components/chart.tsx
@@ -59,7 +59,13 @@ export function ChartTool(props: ToolProps) {
       return
     }
 
-    rendered = true
+    let chart: Chart | undefined
+    onCleanup(() => {
+      chart?.destroy()
+      rendered = false
+    })
+
+    if (!el.isConnected) return
 
     const colors = getThemeColors()
     const isPolar = config.type === "pie" || config.type === "doughnut" || config.type === "polarArea"
@@ -81,11 +87,6 @@ export function ChartTool(props: ToolProps) {
       }
     })
 
-    let chart: Chart | undefined
-    onCleanup(() => chart?.destroy())
-
-    if (!el.isConnected) return
-
     try {
       chart = new Chart(el, {
         type: config.type as any,
@@ -113,6 +114,7 @@ export function ChartTool(props: ToolProps) {
           ...config.options,
         },
       })
+      rendered = true
     } catch (e) {
       setError(e instanceof Error ? e.message : "Failed to render chart")
     }