From 13245cd048e04833d34f569efff82c36897dba14 Mon Sep 17 00:00:00 2001 From: Mir Arif Hasan Date: Mon, 11 May 2026 22:16:12 +0600 Subject: [PATCH] fix: class validator decorator usages (#6293) * fix: class validator decorator usages * fix: feedback --- packages/hoppscotch-backend/src/auth/dto/signin-magic.dto.ts | 2 +- packages/hoppscotch-backend/src/infra-config/input-args.ts | 2 +- .../hoppscotch-backend/src/infra-token/request-response.dto.ts | 1 - .../hoppscotch-backend/src/published-docs/input-type.args.ts | 1 - .../src/published-docs/published-docs.service.spec.ts | 1 - packages/hoppscotch-backend/src/types/input-types.args.ts | 2 +- .../hoppscotch-backend/src/user-request/input-type.args.ts | 3 ++- 7 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/hoppscotch-backend/src/auth/dto/signin-magic.dto.ts b/packages/hoppscotch-backend/src/auth/dto/signin-magic.dto.ts index 22f074249..e6ddc1469 100644 --- a/packages/hoppscotch-backend/src/auth/dto/signin-magic.dto.ts +++ b/packages/hoppscotch-backend/src/auth/dto/signin-magic.dto.ts @@ -1,4 +1,4 @@ -import { IsEmail, IsNotEmpty } from 'class-validator'; +import { IsEmail } from 'class-validator'; // Inputs to initiate Magic-Link auth flow export class SignInMagicDto { diff --git a/packages/hoppscotch-backend/src/infra-config/input-args.ts b/packages/hoppscotch-backend/src/infra-config/input-args.ts index aadcfa04d..0f0941860 100644 --- a/packages/hoppscotch-backend/src/infra-config/input-args.ts +++ b/packages/hoppscotch-backend/src/infra-config/input-args.ts @@ -2,7 +2,7 @@ import { Field, InputType } from '@nestjs/graphql'; import { InfraConfigEnum } from 'src/types/InfraConfig'; import { ServiceStatus } from './helper'; import { AuthProvider } from 'src/auth/helper'; -import { IsEnum, IsNotEmpty, IsString } from 'class-validator'; +import { IsEnum, IsString } from 'class-validator'; @InputType() export class InfraConfigArgs { diff --git a/packages/hoppscotch-backend/src/infra-token/request-response.dto.ts b/packages/hoppscotch-backend/src/infra-token/request-response.dto.ts index 91f013936..814933462 100644 --- a/packages/hoppscotch-backend/src/infra-token/request-response.dto.ts +++ b/packages/hoppscotch-backend/src/infra-token/request-response.dto.ts @@ -5,7 +5,6 @@ import { IsArray, IsBoolean, IsEmail, - IsNotEmpty, IsOptional, IsString, MinLength, diff --git a/packages/hoppscotch-backend/src/published-docs/input-type.args.ts b/packages/hoppscotch-backend/src/published-docs/input-type.args.ts index b326011b6..f0bd316e3 100644 --- a/packages/hoppscotch-backend/src/published-docs/input-type.args.ts +++ b/packages/hoppscotch-backend/src/published-docs/input-type.args.ts @@ -67,7 +67,6 @@ export class CreatePublishedDocsArgs { workspaceType: WorkspaceType; @IsString() - @IsNotEmpty() @Field({ name: 'workspaceID', description: 'ID of the workspace', diff --git a/packages/hoppscotch-backend/src/published-docs/published-docs.service.spec.ts b/packages/hoppscotch-backend/src/published-docs/published-docs.service.spec.ts index c3b3aa0bb..1b1680235 100644 --- a/packages/hoppscotch-backend/src/published-docs/published-docs.service.spec.ts +++ b/packages/hoppscotch-backend/src/published-docs/published-docs.service.spec.ts @@ -4,7 +4,6 @@ import { PUBLISHED_DOCS_CREATION_FAILED, PUBLISHED_DOCS_DELETION_FAILED, PUBLISHED_DOCS_INVALID_COLLECTION, - PUBLISHED_DOCS_FORBIDDEN_ENVIRONMENT_ACCESS, PUBLISHED_DOCS_NOT_FOUND, PUBLISHED_DOCS_UPDATE_FAILED, TEAM_ENVIRONMENT_NOT_FOUND, diff --git a/packages/hoppscotch-backend/src/types/input-types.args.ts b/packages/hoppscotch-backend/src/types/input-types.args.ts index ae088058e..226694a0c 100644 --- a/packages/hoppscotch-backend/src/types/input-types.args.ts +++ b/packages/hoppscotch-backend/src/types/input-types.args.ts @@ -1,7 +1,7 @@ import { ArgsType, Field, ID, InputType } from '@nestjs/graphql'; import { ApiPropertyOptional } from '@nestjs/swagger'; import { Type } from 'class-transformer'; -import { IsInt, IsNotEmpty, IsOptional, IsString, Min } from 'class-validator'; +import { IsInt, IsOptional, IsString, Min } from 'class-validator'; @ArgsType() @InputType() diff --git a/packages/hoppscotch-backend/src/user-request/input-type.args.ts b/packages/hoppscotch-backend/src/user-request/input-type.args.ts index 2e6692cb8..1c2f17b99 100644 --- a/packages/hoppscotch-backend/src/user-request/input-type.args.ts +++ b/packages/hoppscotch-backend/src/user-request/input-type.args.ts @@ -67,7 +67,8 @@ export class CreateUserRequestArgs { @IsNotEmpty() request: string; - type: ReqType; + @IsOptional() + type?: ReqType; } @ArgsType()