Files
galaxy/test/integration/test_users.py
T
mvdbeek 778dd5de52 Fix admin resend-activation email missing hostname
In a FastAPI request, UrlBuilder's NoMatchFound fallback called
web.url_for without the popped qualified flag, and routes.url_for has
no host available in an ASGI context. The admin resend-activation
endpoint hits this path (since /user/activate is a WSGI-only
@web.expose route) and produced links like http:///user/activate?... .

Latent in the FastAPI endpoint since 72d5cceda8 ("Add mail activation
operation to api"); surfaced for users after c9b849d934 bumped
fastapi 0.135.3 -> 0.136.0.

Qualify the fallback URL with request.base_url when qualified=True.

Integration test posts to /api/users/{user_id}/send_activation_email as
admin with mock SMTP capture, then asserts the captured email body
contains a fully-qualified activation link with a non-empty host. Would
have caught the regression that produced http:///user/activate?... .
2026-04-27 10:15:55 +02:00

125 lines
4.8 KiB
Python

import json
import os
import re
from typing import (
ClassVar,
)
from galaxy_test.driver import integration_util
USER_SUMMARY_KEYS: set[str] = {"model_class", "id", "email", "username", "deleted", "active", "last_password_change"}
class UsersIntegrationCase(integration_util.IntegrationTestCase):
expose_user_name: ClassVar[bool]
expose_user_email: ClassVar[bool]
expected_regular_user_list_count: ClassVar[int]
expected_limited_user_keys: ClassVar[set[str]]
@classmethod
def handle_galaxy_config_kwds(cls, config):
super().handle_galaxy_config_kwds(config)
config["expose_user_name"] = cls.expose_user_name
config["expose_user_email"] = cls.expose_user_email
def setUp(self):
super().setUp()
self._setup_users()
def _setup_users(self):
self.user = self._get("users/current").json()
self.user2 = self._setup_user("user02@test.gx")
self.user3 = self._setup_user("user03@test.gx")
def test_admin_index(self):
all_users_response = self._get("users", admin=True)
self._assert_status_code_is(all_users_response, 200)
all_users = all_users_response.json()
assert len(all_users) == 3
for user in all_users:
self._assert_has_keys(user, *USER_SUMMARY_KEYS)
def test_user_index(self):
requesting_user_id = self.user["id"]
all_users_response = self._get("users")
self._assert_status_code_is(all_users_response, 200)
all_users = all_users_response.json()
assert len(all_users) == self.expected_regular_user_list_count
unexpected_user_keys = USER_SUMMARY_KEYS - self.expected_limited_user_keys
for user in all_users:
if user["id"] == requesting_user_id:
# Requesting users should be able to see their own information.
self._assert_has_keys(user, *USER_SUMMARY_KEYS)
continue
# The user should be able to see other users information depending on the configuration.
self._assert_has_keys(user, *self.expected_limited_user_keys)
self._assert_not_has_keys(user, *unexpected_user_keys)
class TestExposeUsersIntegration(UsersIntegrationCase):
expose_user_name = True
expose_user_email = True
# Since we allow to expose user information, all users are returned.
expected_limited_user_keys = {"id", "username", "email"}
expected_regular_user_list_count = 3
class TestExposeOnlyUserNameIntegration(UsersIntegrationCase):
expose_user_name = True
expose_user_email = False
# When only username is exposed, only that field is returned in the user list.
# Since we are exposing user information, all users are returned.
expected_limited_user_keys = {"id", "username"}
expected_regular_user_list_count = 3
class TestExposeOnlyUserEmailIntegration(UsersIntegrationCase):
expose_user_name = False
expose_user_email = True
# When only email is exposed, only that field is returned in the user list.
# Since we are exposing user information, all users are returned.
expected_limited_user_keys = {"id", "email"}
expected_regular_user_list_count = 3
class TestUnexposedUsersIntegration(UsersIntegrationCase):
expose_user_name = False
expose_user_email = False
# Since no user information is exposed, only the current user should be returned.
# And the current user has all fields, so no limited fields.
expected_limited_user_keys = set()
expected_regular_user_list_count = 1
class TestAdminResendActivationEmail(integration_util.IntegrationTestCase):
email_directory: ClassVar[str]
@classmethod
def handle_galaxy_config_kwds(cls, config):
super().handle_galaxy_config_kwds(config)
cls.email_directory = cls._test_driver.mkdtemp()
config["user_activation_on"] = True
config["activation_grace_period"] = 3
config["email_from"] = "galaxy-noreply@example.com"
config["smtp_server"] = f"mock_emails_to_path://{cls.email_directory}/email.json"
def test_resend_activation_includes_qualified_link(self):
user = self._setup_user("resend-activation@test.gx")
response = self._post(f"users/{user['id']}/send_activation_email", admin=True)
self._assert_status_code_is_ok(response)
with open(os.path.join(self.email_directory, "email.json")) as f:
email = json.loads(f.read())
assert email["to"] == "resend-activation@test.gx"
assert email["subject"] == "Galaxy Account Activation"
match = re.search(r"(https?://[^/\s]+/user/activate\?[^\s]+)", email["body"])
assert match, f"No qualified activation link found in email body:\n{email['body']}"
link = match.group(1)
assert "activation_token=" in link
assert "email=" in link