mirror of https://github.com/galaxyproject/galaxy.git synced 2026-11-05 16:07:52 +08:00

Files

T

mvdbeek 47104e4dfa Drop min/max from user-defined-tool data parameters

`min`/`max` on a data parameter bound the number of *selected datasets* and are
only meaningful for a `multiple` input (the runtime DataToolParameter rejects
them on a single one, and enforces them at submission only for multiple). In
practice authors and the tool-generating agent reach for `min: 1` to mean
"required" -- which a data input already is -- and the tool then fails at build
time.

Remove the fields from the YAML authoring surface (YamlDataParameter). With
extra="forbid", a tool that sets `min`/`max` on a data input now gets a clear
authoring-time error instead of a build-time crash. The internal model and XML
tools keep min/max.

Regenerate ToolSourceSchema.json (via rebuild.py) and the api-client / tool_shed
TypeScript schemas; the latter also pick up the discover_via default removal
from the previous commit.

2026-06-19 10:37:42 +02:00

api-client

Drop min/max from user-defined-tool data parameters

2026-06-19 10:37:42 +02:00

README.md

Document the workspace-packages layout

2026-05-21 10:11:43 +02:00

README.md

client/packages/

Workspace packages consumed by the main client as workspace:* deps. The main client (client/package.json, client/src/) is the workspace root.

Package	Published	Purpose
`api-client/`	Yes (`@galaxyproject/galaxy-api-client`)	OpenAPI schema types, typed fetch client, error utilities.

Criteria for adding a package

A package boundary has real cost. Adding one needs:

Zero Galaxy-specific coupling (no stores, session, routing, auth).
No existing npm substitute (don't republish @vueuse/core or lodash equivalents).
Either a real external consumer or a real internal architectural case -- a migration target, an enforced dependency-direction boundary. See the decomposition issue (#13336) before extracting.

How it works

client/pnpm-workspace.yaml declares packages/* as members; single client/pnpm-lock.yaml.
A postinstall on client/package.json builds each workspace package so dist/ is present for vue-tsc and production vite build.
client/vite.config.mjs has a conditional resolve.alias that maps @galaxyproject/* imports directly to package source during vite serve -- edits HMR without a rebuild. Production builds use dist/.

Published vs internal

Published packages have a Galaxy-release-tied version and ship via publish_artifacts.yaml. Internal packages ("private": true) exist for the architectural boundary only; flip to published by removing "private": true and adding a publish step.

Common ops (from `client/`)

pnpm install                                                  # workspace + postinstall builds
pnpm --filter @galaxyproject/galaxy-api-client test           # scoped command
pnpm --filter @galaxyproject/galaxy-api-client run build
make update-client-api-schema                                 # from galaxy root

README.md

client/packages/

Criteria for adding a package

How it works

Published vs internal

Common ops (from client/)

Common ops (from `client/`)