mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-08-29 02:26:59 +08:00
Dannon Baker
35194beb12
Self-review turned up three problems in the guidance I just added. The mapped array idiom joined paths unquoted. shell_command is the one branch that doesn't shlex.quote its result (unlike base_command/arguments right above it in _build_command_line), so a path with a space split into two arguments. Switched to the per-element quoted form our own test tool cat_multiple_user_defined.yml uses, which renders cat '/d/s 1.fq' '/d/b.fq'. "There is no [] indexing syntax" was too strong and simply wrong -- expressions are JavaScript with InlineJavascriptRequirement always on, so inputs.some_repeat[0].x is fine and the validator's own comment cites that form. Only the empty [] is a syntax error. Narrowed the claim to that. And scoping `value` to the types that have one: select and data forbid it and fail with extra_forbidden, so telling the model to give every optional parameter a `value` traded one validation failure for another. Select defaults are selected: true on an option. Same correction on the critic side, where asking for a field that can't exist would have set needs_full_refine and burned an extra generation pass. Also dropped the critic's unconditional claim that a dedicated step resolves the container, which has the same off-by-default problem as the producer prompt.