mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
John Chilton
01eb5f04e6
I don't get why when we click submit the user does not actually get logged in, but based on the last round of improved error messages this seems to be the case. You might think there is some callback in the login form that doesn't get registered by the time Selenium clicks the submit button - but this doesn't seem to be the case - I don't see any jquery magic happening in login.mako. Should fix failures like this: https://jenkins.galaxyproject.org/job/selenium/482/testReport/junit/selenium_tests.test_saved_histories/SavedHistoriesTestCase/test_history_publish/ I'd say at this point this is the most common problem in the Selenium tests. This also introduces a framework for taking state snapshots of the Galaxy interface during tests that will only get written out if the tests fail. We now take screenshots before and after submitting the login form but this is a general purpose debugging mechanism that could be used other places.
132 lines
5.3 KiB
Python
132 lines
5.3 KiB
Python
from .framework import SeleniumTestCase
|
|
from .framework import selenium_test
|
|
|
|
# Remove hack when submit_login works more consistently.
|
|
VALID_LOGIN_RETRIES = 3
|
|
|
|
|
|
class HistorySharingTestCase(SeleniumTestCase):
|
|
|
|
@selenium_test
|
|
def test_sharing_valid(self):
|
|
user1_email, user2_email, history_id = self.setup_two_users_with_one_shared_history()
|
|
self.submit_login(user2_email, retries=VALID_LOGIN_RETRIES)
|
|
response = self.api_get("histories/%s" % history_id, raw=True)
|
|
assert response.status_code == 200, response.json()
|
|
|
|
@selenium_test
|
|
def test_sharing_valid_by_id(self):
|
|
user1_email, user2_email, history_id = self.setup_two_users_with_one_shared_history(share_by_id=True)
|
|
self.submit_login(user2_email, retries=VALID_LOGIN_RETRIES)
|
|
response = self.api_get("histories/%s" % history_id, raw=True)
|
|
assert response.status_code == 200, response.json()
|
|
|
|
@selenium_test
|
|
def test_unsharing(self):
|
|
user1_email, user2_email, history_id = self.setup_two_users_with_one_shared_history()
|
|
self.submit_login(user1_email, retries=VALID_LOGIN_RETRIES)
|
|
self.navigate_to_history_share_page()
|
|
|
|
with self.main_panel():
|
|
first_user_element = self.wait_for_selector("#user-0-popup")
|
|
first_user_element.click()
|
|
|
|
unshare_link = self.wait_for_selector('a[href^="/history/sharing?unshare_user"]')
|
|
unshare_link.click()
|
|
|
|
self.navigate_to_history_share_page()
|
|
with self.main_panel():
|
|
self.assert_selector_absent("#user-0-popup")
|
|
|
|
self.logout_if_needed()
|
|
self.submit_login(user2_email, retries=VALID_LOGIN_RETRIES)
|
|
response = self.api_get("histories/%s" % history_id, raw=True)
|
|
assert response.status_code == 403
|
|
|
|
@selenium_test
|
|
def test_unshared_history_inaccessible(self):
|
|
# Here for completeness for now - but probably should have an explict API test case.
|
|
user1_email = self._get_random_email()
|
|
user2_email = self._get_random_email()
|
|
|
|
self.register(user1_email)
|
|
history_id = self.current_history_id()
|
|
self.logout_if_needed()
|
|
|
|
self.register(user2_email)
|
|
response = self.api_get("histories/%s" % history_id, raw=True)
|
|
assert response.status_code == 403
|
|
|
|
@selenium_test
|
|
def test_sharing_with_invalid_user(self):
|
|
user1_email = self._get_random_email()
|
|
self.register(user1_email)
|
|
self.share_history_with_user(user_email="invalid_user@test.com")
|
|
with self.main_panel():
|
|
self.assert_error_message(contains='is not a valid Galaxy user')
|
|
|
|
@selenium_test
|
|
def test_sharing_with_self(self):
|
|
user1_email = self._get_random_email()
|
|
self.register(user1_email)
|
|
self.share_history_with_user(user_email=user1_email)
|
|
with self.main_panel():
|
|
self.assert_error_message(contains='You cannot send histories to yourself')
|
|
|
|
def setup_two_users_with_one_shared_history(self, share_by_id=False):
|
|
user1_email = self._get_random_email()
|
|
user2_email = self._get_random_email()
|
|
|
|
self.register(user1_email)
|
|
self.logout_if_needed()
|
|
self.register(user2_email)
|
|
user2_id = self.api_get("users")[0]["id"]
|
|
self.logout_if_needed()
|
|
|
|
self.submit_login(user1_email, retries=VALID_LOGIN_RETRIES)
|
|
# Can't share an empty history...
|
|
self.perform_upload(self.get_filename("1.txt"))
|
|
self.wait_for_history()
|
|
|
|
history_id = self.current_history_id()
|
|
if share_by_id:
|
|
self.share_history_with_user(user_email=user2_email, assert_valid=True)
|
|
else:
|
|
self.share_history_with_user(user_id=user2_id, user_email=user2_email, assert_valid=True)
|
|
self.logout_if_needed()
|
|
|
|
return user1_email, user2_email, history_id
|
|
|
|
def navigate_to_history_share_page(self):
|
|
self.home()
|
|
self.click_history_option("Share or Publish")
|
|
|
|
def navigate_to_history_user_share_page(self):
|
|
self.navigate_to_history_share_page()
|
|
with self.main_panel():
|
|
user_share_link_selector = 'a[href^="/history/share?"]'
|
|
self.wait_for_and_click_selector(user_share_link_selector)
|
|
|
|
def share_history_with_user(self, user_id=None, user_email=None, assert_valid=False):
|
|
"""Share the current history with a target user by ID or email.
|
|
|
|
``user_email`` will be used to enter in the share form unless ``user_id``
|
|
is also specified. The ``user_email`` however is always used to check
|
|
the result if ``assert_valid`` is True.
|
|
"""
|
|
self.navigate_to_history_user_share_page()
|
|
with self.main_panel():
|
|
form_selector = "form#share"
|
|
form = self.wait_for_selector(form_selector)
|
|
# If expose_user_info is on would fill form out with this
|
|
# line, in future dispatch on actual select2 div present or not.
|
|
# self.select2_set_value(form_selector, email)
|
|
self.fill(form, {"email": user_id or user_email})
|
|
self.click_submit(form)
|
|
if assert_valid:
|
|
with self.main_panel():
|
|
self.assert_no_error_message()
|
|
|
|
xpath = '//div[contains(text(), "%s")]' % user_email
|
|
self.wait_for_xpath_visible(xpath)
|