mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
John Chilton
f52028f400
- Incorrect parsing of default auto sniff flag value. - Not respecting flag value when adding to dict of compressed sniffers. - Not checking the right value when checking for compressed datatype instances to add to sniff order. - Not filtering out the sniffers from being automatically added during the default stage of sniffer handling where all types with sniff are added at the end. This last point is the most complicated. I added a hack with #6091 so that the compressed sniffers would only return True if in validation mode or explicitly enabled. I'm not convinced that approached worked and I'm definitely convinced it was a bad approach. The better, cleaner approach is to just always let the sniffer return its truth regardless of validation mode or not and instead only add it to the list of sniffers if it should be enabled. This is what I was assuming would happen but I found this method append_to_sniff_order that was adding sniffers back in that I didn't want added.