mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
Nicola Soranzo
20a4bcd519
Fix the following errors reported by flake8-bugbear 21.4.3: B017 assertRaises(Exception): should be considered evil. It can lead to your test passing even if the code being tested is never executed due to a typo. Either assert for a more specific exception (builtin or custom), use assertRaisesRegex, or use the context manager form of assertRaises.
56 lines
2.0 KiB
Python
56 lines
2.0 KiB
Python
import shutil
|
|
import tempfile
|
|
import unittest
|
|
|
|
from galaxy.util.compression_utils import (
|
|
CompressedFile,
|
|
get_fileobj_raw
|
|
)
|
|
|
|
|
|
class CompressionUtilTestCase(unittest.TestCase):
|
|
|
|
def test_compression_safety(self):
|
|
self.assert_safety("test-data/unsafe.tar", False)
|
|
self.assert_safety("test-data/unsafe_relative_symlink.tar", False)
|
|
self.assert_safety("test-data/unsafe.zip", False)
|
|
self.assert_safety("test-data/4.bed.zip", True)
|
|
self.assert_safety("test-data/testdir.tar", True)
|
|
self.assert_safety("test-data/safetar_with_symlink.tar", True)
|
|
self.assert_safety("test-data/safe_relative_symlink.tar", True)
|
|
|
|
def test_get_fileobj_raw(self):
|
|
self.assert_format_detected("test-data/4.bed.zip", "zip")
|
|
self.assert_format_detected(
|
|
"test-data/4.bed.zip", None, ["bz2", "gzip"]
|
|
)
|
|
self.assert_format_detected("test-data/4.bed.gz", "gzip")
|
|
self.assert_format_detected(
|
|
"test-data/4.bed.gz", None, ["bz2", "zip"]
|
|
)
|
|
self.assert_format_detected("test-data/4.bed.bz2", "bz2")
|
|
self.assert_format_detected(
|
|
"test-data/4.bed.bz2", None, ["gzip", "zip"]
|
|
)
|
|
|
|
def assert_safety(self, path, expected_to_be_safe):
|
|
temp_dir = tempfile.mkdtemp()
|
|
try:
|
|
if expected_to_be_safe:
|
|
CompressedFile(path).extract(temp_dir)
|
|
else:
|
|
with self.assertRaisesRegex(Exception, "is blocked"):
|
|
CompressedFile(path).extract(temp_dir)
|
|
finally:
|
|
shutil.rmtree(temp_dir, ignore_errors=True)
|
|
|
|
def assert_format_detected(self, path, expected_fmt, allowed_fmts=None):
|
|
for mode in ['r', 'rb', 'rt', 'U']:
|
|
if 'b' in mode:
|
|
expected_type = bytes
|
|
else:
|
|
expected_type = str
|
|
fmt, fh = get_fileobj_raw(path, mode, allowed_fmts)
|
|
assert fmt == expected_fmt
|
|
assert isinstance(fh.read(0), expected_type)
|