galaxy/packages/tool_util/test-requirements.txt at 35c35faa436ccd7b952292dfee46739dc559bb24 - galaxy - Gitea: Git with a cup of tea

opensource/galaxy

mirror of https://github.com/galaxyproject/galaxy.git synced 2026-10-25 00:12:08 +08:00

Files

T

mvdbeek 40a7cd8f3c Don't attempt to use docker cli if it is not available

This fixes https://github.com/galaxyproject/galaxy/issues/11125, which
became a problem with https://github.com/galaxyproject/galaxy/pull/10814
and the recent removal of the docker runtime from kubernetes.

This is the quick fix, but I don't like the guessing and disabling
that we do if docker is not available or not functional.

I'm hesitating between adding a config option for the resolver
(`docker_cli_available` or `docker_list_images` + `docker_pull_images`)
and adding a `KubernetesContainerResolver` / `RemoteContainerResolver`
class that doesn't assume docker is available for listing and pulling
iages.

Not wanting to list/pull images on the Galaxy node is probably a
reasonable thing outside of kubernetes as well, so I tend to
go with a `RemoteContainerResolver` class in dev ?

2021-01-14 17:43:25 +01:00

3 lines

19 B

Plaintext

Raw Blame History

	`pytest`
	`pytest-mock`