mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-10-25 10:24:38 +08:00
mvdbeek
857a14e292
Which is caught in https://github.com/galaxyproject/galaxy/blob/44782a44c14885df2d9d1bcb91698245bfb3aed8/lib/galaxy/managers/base.py#L1121-L1124 Fixes https://sentry.galaxyproject.org/share/issue/16a3342631224d8292ef792298175dea/: ``` KeyError: "Could not find key nul in object store keys [None, 'scratch']" File "starlette/applications.py", line 123, in __call__ await self.middleware_stack(scope, receive, send) File "starlette/middleware/errors.py", line 186, in __call__ raise exc File "starlette/middleware/errors.py", line 164, in __call__ await self.app(scope, receive, _send) File "starlette_context/middleware/raw_middleware.py", line 92, in __call__ await self.app(scope, receive, send_wrapper) File "starlette/middleware/base.py", line 189, in __call__ with collapse_excgroups(): File "contextlib.py", line 155, in __exit__ self.gen.throw(typ, value, traceback) File "starlette/_utils.py", line 93, in collapse_excgroups raise exc File "starlette/middleware/base.py", line 191, in __call__ response = await self.dispatch_func(request, call_next) File "galaxy/webapps/galaxy/fast_app.py", line 108, in add_x_frame_options response = await call_next(request) File "starlette/middleware/base.py", line 165, in call_next raise app_exc File "starlette/middleware/base.py", line 151, in coro await self.app(scope, receive_or_disconnect, send_no_error) File "starlette/middleware/exceptions.py", line 62, in __call__ await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send) File "starlette/_exception_handler.py", line 64, in wrapped_app raise exc File "starlette/_exception_handler.py", line 53, in wrapped_app await app(scope, receive, sender) File "starlette/routing.py", line 758, in __call__ await self.middleware_stack(scope, receive, send) File "starlette/routing.py", line 778, in app await route.handle(scope, receive, send) File "starlette/routing.py", line 299, in handle await self.app(scope, receive, send) File "starlette/routing.py", line 79, in app await wrap_app_handling_exceptions(app, request)(scope, receive, send) File "starlette/_exception_handler.py", line 64, in wrapped_app raise exc File "starlette/_exception_handler.py", line 53, in wrapped_app await app(scope, receive, sender) File "starlette/routing.py", line 74, in app response = await func(request) File "fastapi/routing.py", line 278, in app raw_response = await run_endpoint_function( File "fastapi/routing.py", line 193, in run_endpoint_function return await run_in_threadpool(dependant.call, **values) File "starlette/concurrency.py", line 42, in run_in_threadpool return await anyio.to_thread.run_sync(func, *args) File "anyio/to_thread.py", line 56, in run_sync return await get_async_backend().run_sync_in_worker_thread( File "anyio/_backends/_asyncio.py", line 2144, in run_sync_in_worker_thread return await future File "anyio/_backends/_asyncio.py", line 851, in run result = context.run(func, *args) File "galaxy/webapps/galaxy/api/history_contents.py", line 465, in index items = self.service.index( File "galaxy/webapps/galaxy/services/history_contents.py", line 312, in index return self.__index_v2(trans, history_id, params, serialization_params, filter_query_params, accept) File "galaxy/webapps/galaxy/services/history_contents.py", line 972, in __index_v2 filters = self.history_contents_filters.parse_query_filters_with_relations(filter_query_params, history_id) File "galaxy/managers/history_contents.py", line 525, in parse_query_filters_with_relations return super().parse_query_filters(query_filters) File "galaxy/managers/base.py", line 1087, in parse_query_filters return self.parse_filters(filter_params) File "galaxy/managers/base.py", line 1096, in parse_filters filter_ = self.parse_filter(attr, op, val) File "galaxy/managers/base.py", line 1116, in parse_filter orm_filter = self._parse_orm_filter(attr, op, val) File "galaxy/managers/history_contents.py", line 601, in _parse_orm_filter if (column_filter := get_filter(attr, op, val)) is not None: File "galaxy/managers/history_contents.py", line 595, in get_filter raise KeyError(f"Could not find key {val} in object store keys {list(ids.keys())}") ```
233 lines
8.9 KiB
Python
233 lines
8.9 KiB
Python
from galaxy_test.base.populators import DatasetPopulator
|
|
from galaxy_test.driver import integration_util
|
|
|
|
|
|
class TestQuotaIntegration(integration_util.IntegrationTestCase):
|
|
dataset_populator: DatasetPopulator
|
|
require_admin_user = True
|
|
|
|
@classmethod
|
|
def handle_galaxy_config_kwds(cls, config):
|
|
super().handle_galaxy_config_kwds(config)
|
|
config["enable_quotas"] = True
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.dataset_populator = DatasetPopulator(self.galaxy_interactor)
|
|
|
|
def test_create(self):
|
|
self._create_quota_with_name("test-create-quota")
|
|
|
|
def test_index(self):
|
|
self._create_quota_with_name("test-index-quota")
|
|
index_response = self._get("quotas")
|
|
index_response.raise_for_status()
|
|
json_response = index_response.json()
|
|
assert len(json_response) > 0
|
|
|
|
def test_index_returns_encoded_ids(self):
|
|
quota = self._create_quota_with_name("test-index-encoded-quota")
|
|
created_quota_id = quota["id"]
|
|
index_response = self._get("quotas")
|
|
index_response.raise_for_status()
|
|
json_response = index_response.json()
|
|
assert len(json_response) > 0
|
|
quota_ids = [quota["id"] for quota in json_response]
|
|
for quota_id in quota_ids:
|
|
assert isinstance(quota_id, str)
|
|
assert created_quota_id in quota_ids
|
|
|
|
def test_index_deleted(self):
|
|
quota = self._create_quota_with_name("test-index-deleted-quota")
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete(f"quotas/{quota_id}")
|
|
delete_response.raise_for_status()
|
|
index_response = self._get("quotas/deleted")
|
|
index_response.raise_for_status()
|
|
json_response = index_response.json()
|
|
assert len(json_response) > 0
|
|
|
|
def test_show(self):
|
|
quota_name = "test-show-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
show_response = self._get(f"quotas/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert json_response["name"] == quota["name"]
|
|
|
|
def test_show_deleted(self):
|
|
quota_name = "test-show-deleted-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete(f"quotas/{quota_id}")
|
|
delete_response.raise_for_status()
|
|
show_response = self._get(f"quotas/deleted/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert json_response["name"] == quota["name"]
|
|
|
|
def test_update(self):
|
|
quota_name = "test-update-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
|
|
new_quota_name = "updated-quota-name"
|
|
update_payload = {
|
|
"name": new_quota_name,
|
|
}
|
|
put_response = self._put(f"quotas/{quota_id}", data=update_payload, json=True)
|
|
put_response.raise_for_status()
|
|
assert "has been renamed to" in put_response.text
|
|
|
|
show_response = self._get(f"quotas/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert json_response["name"] == new_quota_name
|
|
|
|
def test_delete(self):
|
|
quota_name = "test-delete-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete(f"quotas/{quota_id}")
|
|
delete_response.raise_for_status()
|
|
self._assert_quota_is_deleted(quota_id)
|
|
|
|
def test_delete_and_purge(self):
|
|
quota_name = "test-delete-purge-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete_and_purge(quota_id)
|
|
delete_response.raise_for_status()
|
|
self._assert_quota_is_deleted(quota_id)
|
|
|
|
def test_delete_and_purge_with_user(self):
|
|
user_email = "test@galaxy.test"
|
|
self.galaxy_interactor.ensure_user_with_email(user_email)
|
|
|
|
quota_name = "test-delete-purge-quota-user"
|
|
payload = self._build_quota_payload_with_name(quota_name)
|
|
payload["in_users"].append(user_email)
|
|
create_response = self._post("quotas", data=payload, json=True)
|
|
create_response.raise_for_status()
|
|
quota = create_response.json()
|
|
quota_id = quota["id"]
|
|
|
|
show_response = self._get(f"quotas/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert user_email in str(json_response["users"])
|
|
|
|
delete_response = self._delete_and_purge(quota_id)
|
|
delete_response.raise_for_status()
|
|
show_response = self._get(f"quotas/deleted/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert user_email not in str(json_response["users"])
|
|
|
|
def test_undelete(self):
|
|
quota_name = "test-undelete-quota"
|
|
quota = self._create_quota_with_name(quota_name)
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete(f"quotas/{quota_id}")
|
|
delete_response.raise_for_status()
|
|
self._assert_quota_is_deleted(quota_id)
|
|
|
|
undelete_response = self._post(f"quotas/deleted/{quota_id}/undelete")
|
|
undelete_response.raise_for_status()
|
|
|
|
show_response = self._get(f"quotas/{quota_id}")
|
|
show_response.raise_for_status()
|
|
|
|
show_response = self._get(f"quotas/deleted/{quota_id}")
|
|
self._assert_status_code_is(show_response, 400)
|
|
|
|
def test_400_when_delete_default(self):
|
|
quota_name = "test-delete-default-quota"
|
|
quota = self._create_quota_with_name(quota_name, is_default=True)
|
|
quota_id = quota["id"]
|
|
delete_response = self._delete(f"quotas/{quota_id}")
|
|
self._assert_status_code_is(delete_response, 400)
|
|
|
|
def test_400_when_quota_name_already_exists(self):
|
|
quota_name = "test-duplicated-quota"
|
|
self._create_quota_with_name(quota_name)
|
|
payload = self._build_quota_payload_with_name(quota_name)
|
|
create_response = self._post("quotas", data=payload, json=True)
|
|
self._assert_status_code_is(create_response, 400)
|
|
|
|
def test_400_when_show_unknown_quota(self):
|
|
quota_id = "unknown-id"
|
|
show_response = self._get(f"quotas/{quota_id}")
|
|
self._assert_status_code_is(show_response, 400)
|
|
|
|
def test_400_when_invalid_amount(self):
|
|
invalid_amount = ""
|
|
quota_name = "invalid-amount-id"
|
|
payload = {
|
|
"name": quota_name,
|
|
"description": f"Quota {quota_name} description",
|
|
"amount": invalid_amount,
|
|
"operation": "=",
|
|
"default": "no",
|
|
"in_users": [],
|
|
"in_groups": [],
|
|
}
|
|
create_response = self._post("quotas", data=payload, json=True)
|
|
self._assert_status_code_is(create_response, 400)
|
|
|
|
def test_quota_source_label_basics(self):
|
|
quotas = self.dataset_populator.get_quotas()
|
|
prior_quotas_len = len(quotas)
|
|
|
|
payload = {
|
|
"name": "defaultmylabeledquota1",
|
|
"description": "first default quota that is labeled",
|
|
"amount": "120MB",
|
|
"operation": "=",
|
|
"default": "registered",
|
|
"quota_source_label": "mylabel",
|
|
}
|
|
self.dataset_populator.create_quota(payload)
|
|
|
|
quotas = self.dataset_populator.get_quotas()
|
|
assert len(quotas) == prior_quotas_len + 1
|
|
|
|
labels = [q["quota_source_label"] for q in quotas]
|
|
assert "mylabel" in labels
|
|
|
|
with self.dataset_populator.test_history() as history_id:
|
|
response = self.dataset_populator._get_contents_request(
|
|
history_id, data={"q": "quota_source_label-eq", "qv": "invalid", "v": "dev"}
|
|
)
|
|
assert response.status_code == 400
|
|
assert "unparsable value for filter" in response.json()["err_msg"]
|
|
|
|
def _create_quota_with_name(self, quota_name: str, is_default: bool = False):
|
|
payload = self._build_quota_payload_with_name(quota_name, is_default)
|
|
create_response = self._post("quotas", data=payload, json=True)
|
|
create_response.raise_for_status()
|
|
return create_response.json()
|
|
|
|
def _build_quota_payload_with_name(self, quota_name: str, is_default: bool = False):
|
|
default = "registered" if is_default else "no"
|
|
return {
|
|
"name": quota_name,
|
|
"description": f"Quota {quota_name} description",
|
|
"amount": "100MB",
|
|
"operation": "=",
|
|
"default": default,
|
|
"in_users": [],
|
|
"in_groups": [],
|
|
}
|
|
|
|
def _delete_and_purge(self, quota_id):
|
|
data = {"purge": "true"}
|
|
return self._delete(f"quotas/{quota_id}", data=data, admin=True, json=True)
|
|
|
|
def _assert_quota_is_deleted(self, quota_id: str):
|
|
show_response = self._get(f"quotas/deleted/{quota_id}")
|
|
show_response.raise_for_status()
|
|
json_response = show_response.json()
|
|
assert json_response["id"] == quota_id
|