mvdbeek
f67ca01a99
Fix post job action getting lost when node is made active
...
And many more reactivity fixes.
The core of the issue was that the FormElement would emit a onUpdate
event, which triggers a request to `api/workflows/build_module`.
The FormSection that controls the post job action data is not ready at
this point, so when the data comes back in we have to break the
connection because the post job action that sets the datatype is
missing.
We really don't need to call `build_module` though when change post job
actions, they don't require the backend at all, we just need to bubble
them up to the Index component, which can set the postJobAction on the
active node (let's ignore that we should manipulate the data, not the vue instance
...).
In order for that to be properly reactive I had to remove the majority
of the getNode hacks.
We do still rely on this in the Terminals and Connectors, so those can
get out of sync still, but it fixes an annoying issue where connections
are dropped without notice.
2022-08-30 17:14:34 +02:00
mvdbeek
685ac29018
Fix qunit tests
2022-08-18 10:18:46 +02:00
mvdbeek
7195a161a0
Pass correct canvasManager into Connector
...
Should fix https://github.com/galaxyproject/galaxy/issues/14468
2022-08-18 10:18:46 +02:00
mvdbeek
d86b3554bc
Replace jQuery usage in connector.js
2022-08-18 10:18:46 +02:00
mvdbeek
18e4c007ef
Remove force_datatype getter
...
One place less that is calling out into the Node vue component
2022-08-18 10:18:46 +02:00
mvdbeek
e35b82aef1
Selenium test for changing datatype
...
In subworkflows and outside. All asserts terminal label.
2022-08-18 10:18:10 +02:00
mvdbeek
b0727be9e0
Fix change_datatype not reflected in tool and workflow output terminals
2022-08-16 15:46:11 +02:00
mvdbeek
1a14633417
Fix console errors when stored workflow id hasn't been fetched yet
2022-08-12 16:01:53 +02:00
Marius van den Beek
13162852dd
Merge pull request #14424 from dannon/fix-workflow-step-insertion
...
[22.05] Fix workflow direct step insertion in workflow editor
2022-08-10 10:33:53 +02:00
Dannon Baker
fbd52b9266
Drop test for delegation -- this is part of the component (for now).
2022-08-09 20:18:03 -04:00
Dannon Baker
566e00dc37
Fix vue-attributes-order
2022-08-09 20:12:13 -04:00
Dannon Baker
3c1d6f2ca4
Eliminate SaveAs old modal usage in the workflow editor, swapping to b-modal. needs refactoring, modal should probably be split out, but this is mvp
2022-08-09 20:09:31 -04:00
Dannon Baker
58597e1c3c
Swap back to 10 nodes as the threshold for confirmation; cleanup.
2022-08-09 16:34:11 -04:00
Dannon Baker
ccc781f586
Use standard bootstrap modal for copyIntoWorkflow; yagni w/ utilities -- keep action with component. Separation wasn't remotely clean anyway, with it taking the component instance as the first argument to operate on.
2022-08-09 16:31:37 -04:00
Dannon
858c57da7e
Merge pull request #14343 from dannon/fix-oldstyle-dataset-display
...
[22.05] Fix oldstyle dataset display
2022-08-09 11:27:15 -04:00
Dannon Baker
31c38260cc
Raise threshold for workflow insertion confirmation to 10 steps
2022-08-09 10:50:40 -04:00
Dannon Baker
f19e19c8f2
In workflow step insertion from saved workflow, swap to browser standard (jquery-free, whew) confirmation for now, as a bugfix -- we eventually want this to be a proper vue-confirm modal.
2022-08-09 10:49:43 -04:00
Dannon Baker
55bb5e0f6f
Fix number of jobs submitted display in tool success.
2022-08-09 08:54:27 -04:00
davelopez
9c63cb6ad7
Avoid possible empty IDs in expanded datasets
...
In some unknown situations, the expanded items IDs contains just blank spaces and provoke a Bad Request.
2022-08-09 12:05:04 +02:00
Dannon
1238d29de0
Merge pull request #14403 from dannon/backport-fix-dataset-links
...
[22.05] Fix dataset list operation to switch between histories
2022-08-05 16:48:52 -04:00
guerler
f2742831e3
Fix dataset list operation to switch between histories
2022-08-04 14:59:18 -04:00
David López
954012abb4
Merge pull request #14402 from dannon/copy-datasets-always-available
...
[22.05] Always allow 'copy datasets' action in history, even when empty.
2022-08-04 19:13:01 +02:00
Dannon Baker
0c6c93949f
Allow 'Copy Datasets' action in history even when the current history is empty. This action can be used to copy datasets *into* the history as well, so is appropriate.
2022-08-04 09:21:25 -04:00
davelopez
d66bbe23de
Avoid requesting details for invalid item IDs
...
In some circumstances the item ID might be undefined or empty and the request will fail with a rather cryptic validation error.
```
Aug 03 10:44:54 sn06.galaxyproject.eu gunicorn[2458098]: pydantic.error_wrappers.ValidationError: 2 validation errors for HistoryContentsIndexParams
Aug 03 10:44:54 sn06.galaxyproject.eu gunicorn[2458098]: dataset_details -> 1
Aug 03 10:44:54 sn06.galaxyproject.eu gunicorn[2458098]: Invalid characters in encoded ID (type=value_error)
Aug 03 10:44:54 sn06.galaxyproject.eu gunicorn[2458098]: dataset_details
Aug 03 10:44:54 sn06.galaxyproject.eu gunicorn[2458098]: unhashable type: 'set' (type=type_error)
```
2022-08-04 11:29:42 +02:00
Dannon
38b820736a
Merge pull request #14375 from davelopez/history_contents_detailed_only_for_expanded
...
[22.05] Optimize History watcher to request detailed information only for expanded items
2022-07-28 21:59:12 -04:00
Nicola Soranzo
e383e593e0
Merge branch 'release_22.01' into release_22.05
2022-07-27 15:38:19 +01:00
Dannon Baker
c0b80f3cf2
Fix incorrect history swapping / see more in #14173
2022-07-26 11:07:33 -04:00
davelopez
fc940e11f7
Optimize history watcher for detailed contents
...
This will requests the detailed view only for those items that are currently expanded in the history panel instead of all of them.
2022-07-26 13:57:14 +02:00
davelopez
9b3bfe02f0
Refactor history watcher to use axios params
2022-07-26 13:53:47 +02:00
davelopez
8ec4fa4bf4
Allow to optionally set axios params in urlData
2022-07-26 13:48:18 +02:00
Marius van den Beek
1b5ba6045b
Merge pull request #14325 from davelopez/22.05_allow_dataset_actions_in_new_tab
...
[22.05] Add HREF links to some history item actions
2022-07-24 11:19:16 -05:00
davelopez
f2bdee41f6
Display correct description in Manage Information
2022-07-22 18:11:14 +02:00
davelopez
b004c32ccb
Display Manage Cloud Auth user preferences always
2022-07-22 18:10:19 +02:00
davelopez
e775648d03
Disable only specific inputs in user information
2022-07-22 18:09:23 +02:00
davelopez
eb604cabb6
Keep current history details on list update
...
The incoming list of histories contains only summary information for all of them and the current history has additional details that we need.
Since the current history gets updated regularly, there is no harm in skipping the update from the incoming list.
2022-07-21 12:14:46 +02:00
davelopez
398f77317b
Add mixin to reuse extended history properties
...
The computed properties in the mixin avoid console errors when the history properties haven't been loaded yet.
2022-07-19 18:34:35 +02:00
davelopez
c88e1a15b6
Load only summary view for all histories
...
The extended (and potentially expensive) properties will be requested only for particular histories, like the current history.
2022-07-19 18:34:35 +02:00
davelopez
5695e75e4f
Reload histories when the user 'really' changes
...
The user prop watcher may trigger more times than the actual user changes.
2022-07-19 17:56:24 +02:00
Dannon Baker
9a8d1bb332
Update jest test for using ol parent container
2022-07-18 16:44:37 -04:00
Dannon Baker
498e63f81f
... chaining doesn't work in templates (yet)
2022-07-18 12:51:23 -04:00
Dannon Baker
ae22a83400
Include old style display app links in new viz list for datasets
2022-07-18 12:50:00 -04:00
Nicola Soranzo
edd05bab4b
Update yarn.lock file
...
Some changes were missing in commit 651221510a
2022-07-15 12:43:37 +01:00
davelopez
95c2efb83b
Fix prefix duplication in absPath function
...
Also enhance code documentation a bit
2022-07-15 13:22:35 +02:00
davelopez
23f190bd24
Fix history item action URLs with prefix
...
Declare relative URLs only and then prefix the root when necessary.
2022-07-15 13:18:38 +02:00
davelopez
9feebb88cb
Fix tours selectors
...
The buttons are now considered links so better use the class to select them since it will be less prone to change than the title.
2022-07-14 17:07:18 +02:00
davelopez
1638dc0210
Add HREF to dataset download
2022-07-14 11:58:51 +02:00
Dannon
46e41ba381
Merge pull request #14328 from mvdbeek/use_client_build_epoch_for_cache_busting
...
[22.05] Attempt to use epoch of client build time for cache busting
2022-07-13 21:48:59 -04:00
Dannon Baker
057b877f1c
Use same Date object for internal and external timestamps (was probably close enough, but...)
2022-07-13 15:19:53 -04:00
mvdbeek
651221510a
Attempt to use epoch of client build time for cache busting
...
Store webpack build hash in meta.json file, and use that to setup
the cache busting.
This should prevent clients from unnecessarily reloading client bundles
when the server restarts and/or when individual workers finish booting
at staggered intervals.
This became more important with usegalaxy.org not forking off workers
from a preloaded master (so all workers would have the same starttime).
2022-07-13 22:16:14 +03:00
davelopez
7d93f386d7
Add href links to some history item actions
...
This will allow to right click and open the action in a new tab or window.
2022-07-13 13:05:12 +02:00
mvdbeek